)]}'
{"openstackclient/network/v2/l3_conntrack_helper.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1fd99355f31b9d740f2a7833f2498acda9c6973d","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            required\u003dTrue,"},{"line_number":73,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"},{"line_number":74,"context_line":"            help\u003d_(\u0027The network port for the netfilter conntrack target rule\u0027)"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return parser"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"46dc9379_4fd1f863","line":75,"updated":"2021-05-27 12:02:14.000000000","message":"According to the API ref [1], \"port\" is an integer field.\nIt would be nice to add \"type\u003dint\" (as we do for security group rule icmp_type/code).\n\n[1] https://docs.openstack.org/api-ref/network/v2/index.html?expanded\u003dcreate-conntrack-helper-detail#create-conntrack-helper","commit_id":"0dd17f17c3fca0f51fb2529ddf567adbbe73cf57"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7d4f1222995cb34255fb2475657941b20cc44191","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            required\u003dTrue,"},{"line_number":73,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"},{"line_number":74,"context_line":"            help\u003d_(\u0027The network port for the netfilter conntrack target rule\u0027)"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return parser"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f4475865_7fa1aed4","line":75,"in_reply_to":"46dc9379_4fd1f863","updated":"2021-06-04 09:11:32.000000000","message":"Done","commit_id":"0dd17f17c3fca0f51fb2529ddf567adbbe73cf57"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1fd99355f31b9d740f2a7833f2498acda9c6973d","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        parser.add_argument("},{"line_number":212,"context_line":"            \u0027--port\u0027,"},{"line_number":213,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"},{"line_number":214,"context_line":"            help\u003d_(\u0027The network port for the netfilter conntrack target rule\u0027)"},{"line_number":215,"context_line":"        )"},{"line_number":216,"context_line":"        return parser"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5817c619_b44e2f65","line":214,"updated":"2021-05-27 12:02:14.000000000","message":"Same comment for CreateConntrackHelper.","commit_id":"0dd17f17c3fca0f51fb2529ddf567adbbe73cf57"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7d4f1222995cb34255fb2475657941b20cc44191","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        parser.add_argument("},{"line_number":212,"context_line":"            \u0027--port\u0027,"},{"line_number":213,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"},{"line_number":214,"context_line":"            help\u003d_(\u0027The network port for the netfilter conntrack target rule\u0027)"},{"line_number":215,"context_line":"        )"},{"line_number":216,"context_line":"        return parser"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d93ba36d_1bb81397","line":214,"in_reply_to":"5817c619_b44e2f65","updated":"2021-06-04 09:11:32.000000000","message":"Done","commit_id":"0dd17f17c3fca0f51fb2529ddf567adbbe73cf57"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"017b2da6f1325702b49e9bd59ea42f33a8cc097b","unresolved":true,"context_lines":[{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":"        parser.add_argument("},{"line_number":102,"context_line":"            \u0027conntrack_helper_ids\u0027,"},{"line_number":103,"context_line":"            metavar\u003d\u0027\u003cconntrack-helper-ids\u003e\u0027,"},{"line_number":104,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":105,"context_line":"            help\u003d_(\u0027The ID of the conntrack helper(s) to delete\u0027)"},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"d664b0fa_4eab4c08","line":103,"range":{"start_line":103,"start_character":22,"end_line":103,"end_character":42},"updated":"2021-06-08 06:34:05.000000000","message":"After approving the patch, I noticed it needs to be a singular form.\notherwise, we will see:\n\n openstack network l3 conntrack helper delete\n    \u003crouter\u003e\n    \u003cconntrack-helper-ids\u003e\n    [\u003cconntrack-helper-ids\u003e ...]\n\nI will send a fix.","commit_id":"fa8c8d26a7696d169b0b9d5aaf6b723d8feee08a"}],"openstackclient/tests/unit/network/v2/fakes.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"51257057d2d4f8596f0d81c56c659124b9cdbdce","unresolved":true,"context_lines":[{"line_number":2019,"context_line":"              The number of L3 Conntrack helper rule to fake"},{"line_number":2020,"context_line":"          :return:"},{"line_number":2021,"context_line":"              A list of FakeResource objects faking the Conntrack helpers"},{"line_number":2022,"context_line":"          \"\"\""},{"line_number":2023,"context_line":"        ct_helpers \u003d []"},{"line_number":2024,"context_line":"        for i in range(0, count):"},{"line_number":2025,"context_line":"            ct_helpers.append("}],"source_content_type":"text/x-python","patch_set":4,"id":"994fd990_c613492f","line":2022,"range":{"start_line":2022,"start_character":8,"end_line":2022,"end_character":10},"updated":"2021-06-07 11:59:06.000000000","message":"nit, indentation not consistent with other docstrings.","commit_id":"d6f317430fbb21ff7a07cfee36fbd898aae33354"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8b39a5c5aadde8d0f2350a11c34ec2bb199f851f","unresolved":false,"context_lines":[{"line_number":2019,"context_line":"              The number of L3 Conntrack helper rule to fake"},{"line_number":2020,"context_line":"          :return:"},{"line_number":2021,"context_line":"              A list of FakeResource objects faking the Conntrack helpers"},{"line_number":2022,"context_line":"          \"\"\""},{"line_number":2023,"context_line":"        ct_helpers \u003d []"},{"line_number":2024,"context_line":"        for i in range(0, count):"},{"line_number":2025,"context_line":"            ct_helpers.append("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f350bd4_43473bfc","line":2022,"range":{"start_line":2022,"start_character":8,"end_line":2022,"end_character":10},"in_reply_to":"994fd990_c613492f","updated":"2021-06-07 12:27:52.000000000","message":"Done","commit_id":"d6f317430fbb21ff7a07cfee36fbd898aae33354"}],"openstackclient/tests/unit/network/v2/test_l3_conntrack_helper.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1fd99355f31b9d740f2a7833f2498acda9c6973d","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def setUp(self):"},{"line_number":160,"context_line":"        super(TestListL3ConntrackHelper, self).setUp()"},{"line_number":161,"context_line":"        attrs \u003d {"},{"line_number":162,"context_line":"            \u0027router_id\u0027: self.router.id}"},{"line_number":163,"context_line":"        ct_helpers \u003d ("},{"line_number":164,"context_line":"            network_fakes.FakeL3ConntrackHelper.create_l3_conntrack_helpers("},{"line_number":165,"context_line":"                attrs, count\u003d3))"}],"source_content_type":"text/x-python","patch_set":3,"id":"20e010d6_77f5ac16","line":162,"range":{"start_line":161,"start_character":16,"end_line":162,"end_character":40},"updated":"2021-05-27 12:02:14.000000000","message":"nit: For consistency with others, consider\n\n  {\u0027router_id\u0027: self.router_id}\n\nor\n\n  {\n      \u0027router_id\u0027: self.router_id\n  }","commit_id":"0dd17f17c3fca0f51fb2529ddf567adbbe73cf57"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7d4f1222995cb34255fb2475657941b20cc44191","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def setUp(self):"},{"line_number":160,"context_line":"        super(TestListL3ConntrackHelper, self).setUp()"},{"line_number":161,"context_line":"        attrs \u003d {"},{"line_number":162,"context_line":"            \u0027router_id\u0027: self.router.id}"},{"line_number":163,"context_line":"        ct_helpers \u003d ("},{"line_number":164,"context_line":"            network_fakes.FakeL3ConntrackHelper.create_l3_conntrack_helpers("},{"line_number":165,"context_line":"                attrs, count\u003d3))"}],"source_content_type":"text/x-python","patch_set":3,"id":"6bddb53a_e017f99c","line":162,"range":{"start_line":161,"start_character":16,"end_line":162,"end_character":40},"in_reply_to":"20e010d6_77f5ac16","updated":"2021-06-04 09:11:32.000000000","message":"Done","commit_id":"0dd17f17c3fca0f51fb2529ddf567adbbe73cf57"}]}