)]}'
{"openstackclient/shell.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3e50d4a4f3ba18d4ef300d6d22e7ec437026b623","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            try:"},{"line_number":475,"context_line":"                self.authenticate_user()"},{"line_number":476,"context_line":"                self.restapi.set_auth(self.client_manager.identity.auth_token)"},{"line_number":477,"context_line":"            except Exception as e:"},{"line_number":478,"context_line":"                pass"},{"line_number":479,"context_line":"        else:"},{"line_number":480,"context_line":"            self.authenticate_user()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FTsU%3D","line":477,"updated":"2014-03-06 22:38:00.000000000","message":"e is never used, just write:\n\nexcept Exception:\n\nthough it\u0027s not really best practice to use Exception, I think it\u0027s okay in this scenario.","commit_id":"2f4bf8d8689b47ca1a6e358ed3d2ed571201e426"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0f015f868790f8c4cb852fd7431ce64987f7d58a","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if not cmd.auth_required:"},{"line_number":472,"context_line":"            return"},{"line_number":473,"context_line":"        if cmd.best_effort:"},{"line_number":474,"context_line":"            try:"},{"line_number":475,"context_line":"                self.authenticate_user()"},{"line_number":476,"context_line":"                self.restapi.set_auth(self.client_manager.identity.auth_token)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2FRl4%3D","line":473,"updated":"2014-04-15 16:16:11.000000000","message":"The duplication of the auth calls could be removed by turning this inside-out; always run the try block and do the best_effort test in the exception handler","commit_id":"211cd31d7ac2c7768cc871ac7c9228f7713b8dfc"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"a83035b82b14cd8889adf7c88c2634c999598397","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if not cmd.auth_required:"},{"line_number":472,"context_line":"            return"},{"line_number":473,"context_line":"        if cmd.best_effort:"},{"line_number":474,"context_line":"            try:"},{"line_number":475,"context_line":"                self.authenticate_user()"},{"line_number":476,"context_line":"                self.restapi.set_auth(self.client_manager.identity.auth_token)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F5kY%3D","line":473,"in_reply_to":"AAAAW3%2F%2FRl4%3D","updated":"2014-04-16 15:56:01.000000000","message":"This was done intentionally to preserve the stack trace of the authentication error.  The alternative is something like:\n\n        except Exception, e:\n            self.exc_info \u003d sys.exc_info()\n            raise self.exc_info[1], None, self.exc_info[2]","commit_id":"211cd31d7ac2c7768cc871ac7c9228f7713b8dfc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"03babea5668f26facb0797b69b8ced5a08903383","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if not cmd.auth_required:"},{"line_number":472,"context_line":"            return"},{"line_number":473,"context_line":"        if cmd.best_effort:"},{"line_number":474,"context_line":"            try:"},{"line_number":475,"context_line":"                self.authenticate_user()"},{"line_number":476,"context_line":"                self.restapi.set_auth(self.client_manager.identity.auth_token)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F38E%3D","line":473,"in_reply_to":"AAAAXH%2F%2F5kY%3D","updated":"2014-04-16 19:02:58.000000000","message":"roger","commit_id":"211cd31d7ac2c7768cc871ac7c9228f7713b8dfc"}]}