)]}'
{"openstackclient/volume/client.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8af0ba3461d8f99127c2c9b4dd9f3e5c2da704ea","unresolved":true,"context_lines":[{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Save the microversion if in use"},{"line_number":36,"context_line":"_volume_api_version \u003d None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def make_client(instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"562a1567_13b23166","line":36,"updated":"2021-05-26 15:13:17.000000000","message":"I see the compute\u0027s client does use their version of this variable as a global, but in this patch the variable is only used locally  in check_api_version().","commit_id":"7c73a4520f2ab75baa486f9084cbae43af2c0cca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9bdd55dcb05bd58b702bec0f7b1cf4fcc591765a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Save the microversion if in use"},{"line_number":36,"context_line":"_volume_api_version \u003d None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def make_client(instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"f476b135_4140224a","line":36,"in_reply_to":"562a1567_13b23166","updated":"2021-06-02 14:31:56.000000000","message":"Done","commit_id":"7c73a4520f2ab75baa486f9084cbae43af2c0cca"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8af0ba3461d8f99127c2c9b4dd9f3e5c2da704ea","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    # Defer client imports until we actually need them"},{"line_number":123,"context_line":"    from cinderclient import api_versions"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    global _volume_api_version"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Copy some logic from novaclient 3.3.0 for basic version detection"},{"line_number":128,"context_line":"    # NOTE(dtroyer): This is only enough to resume operations using API"}],"source_content_type":"text/x-python","patch_set":2,"id":"a03a3d22_8f29d0be","line":125,"updated":"2021-05-26 15:13:17.000000000","message":"As noted above, this doesn\u0027t need to be global.","commit_id":"7c73a4520f2ab75baa486f9084cbae43af2c0cca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9bdd55dcb05bd58b702bec0f7b1cf4fcc591765a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    # Defer client imports until we actually need them"},{"line_number":123,"context_line":"    from cinderclient import api_versions"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    global _volume_api_version"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Copy some logic from novaclient 3.3.0 for basic version detection"},{"line_number":128,"context_line":"    # NOTE(dtroyer): This is only enough to resume operations using API"}],"source_content_type":"text/x-python","patch_set":2,"id":"51be9074_28158e03","line":125,"in_reply_to":"a03a3d22_8f29d0be","updated":"2021-06-02 14:31:56.000000000","message":"I ended up copying the caching of version in \u0027make_client\u0027 from nova so this stays global now","commit_id":"7c73a4520f2ab75baa486f9084cbae43af2c0cca"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8af0ba3461d8f99127c2c9b4dd9f3e5c2da704ea","unresolved":true,"context_lines":[{"line_number":141,"context_line":"                    \"max\": api_versions.MAX_VERSION,"},{"line_number":142,"context_line":"                }"},{"line_number":143,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":144,"context_line":"    return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ece11452_e8e687a3","line":144,"updated":"2021-05-26 15:13:17.000000000","message":"-1: I think you only want to return True if the conditional at L134 is True. Otherwise, you bypass the standard/legacy validation code that uses API_VERSIONS[]. For example, \"2.666\" would pass this test, but clearly it isn\u0027t a valid version.","commit_id":"7c73a4520f2ab75baa486f9084cbae43af2c0cca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9bdd55dcb05bd58b702bec0f7b1cf4fcc591765a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                    \"max\": api_versions.MAX_VERSION,"},{"line_number":142,"context_line":"                }"},{"line_number":143,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":144,"context_line":"    return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"e38169ac_28c4770d","line":144,"in_reply_to":"ece11452_e8e687a3","updated":"2021-06-02 14:31:56.000000000","message":"Done","commit_id":"7c73a4520f2ab75baa486f9084cbae43af2c0cca"}]}