)]}'
{"id":"openstack%2Fpython-openstackclient~799662","triplet_id":"openstack%2Fpython-openstackclient~stable%2Ftrain~I2ea2def607ec5be112e42d53a1e660fef0cdd69c","project":"openstack/python-openstackclient","branch":"stable/train","topic":"fix_rbac_regression-stable/train","hashtags":[],"change_id":"I2ea2def607ec5be112e42d53a1e660fef0cdd69c","subject":"Fix reverted osc-lib interface change","status":"MERGED","created":"2021-07-06 12:43:33.000000000","updated":"2021-07-13 12:42:20.000000000","submitted":"2021-07-13 12:38:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"799662-fix_rbac_regression-stable/train","meta_rev_id":"f1aff396601c1cc97eb9ea35dd8a3fa1f1db8a33","_number":799662,"virtual_id_number":799662,"owner":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-13 12:38:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"recommended":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2021-07-13 12:42:20.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":1,"date":"2021-07-13 12:42:20.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-07-13 10:22:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-07-13 10:22:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"}],"reviewers":{"REVIEWER":[{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-06 12:43:33.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"state":"REVIEWER"},{"updated":"2021-07-06 14:04:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-06 16:23:24.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-07-09 07:55:54.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2021-07-13 10:22:41.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"ac54770b6a39c876f8770086d3531e50a7417706","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2021-07-06 12:43:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1415c68bf5726f7f5f3262bc6fabf61c50b3d6b0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-06 14:04:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d70be81dd8eb4ceb9cb4b92143d87d5e : SUCCESS in 5m 25s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d2784b6d550a4befb7de769ff9d0f62a : FAILURE in 4m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7b0e3cf23adf46ceba4a483360b23024 : SUCCESS in 4m 42s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6a2d2c18024a46c5acd586fca72ed3ca : FAILURE in 3m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/36163247767741fda7cb89650e4acc9e : SUCCESS in 4m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/82c15bc1973e40c7b4017c4bc76f802a : SUCCESS in 5m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/071064afa6924d29b6f8bf3a21667e04 : SUCCESS in 5m 22s\n- tempest-full https://zuul.opendev.org/t/openstack/build/deb2d430a9af4a21a7d728833ff8de2e : SUCCESS in 1h 19m 48s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4d2c0b24941e4403bc263222931e6b15 : SUCCESS in 1h 09m 23s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/78a95f06b44d4b408ec59e5c0bef3da2 : SUCCESS in 53m 32s","accounts_in_message":[],"_revision_number":1},{"id":"de162859a03d1799f3936068a23fbdfd105136fc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-07-06 16:22:12.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"d2771981a6bfcd84d1ee1983aa0924375f7b3b74","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-07-06 16:23:24.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"019c60f9a877b331cbe37e6c88ccadbe874bae26","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-06 18:14:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9c0ed25697294afa9bbe9c43911c6d4a : SUCCESS in 9m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a20fa0b52eec468eb55b5985cb11d922 : SUCCESS in 5m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4e622d78c8cb40ccac1832a3d8a8c773 : SUCCESS in 4m 55s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/741295cd5a1540ea8f82df8cf866e07f : SUCCESS in 4m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6c040f3e62ac4cbeb48472fd745bab57 : SUCCESS in 4m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/88020c9d58a047efb4c0b987e21ec9d8 : SUCCESS in 5m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ec7e7d9a9ca0411b9eb494e79b98fbee : SUCCESS in 5m 32s\n- tempest-full https://zuul.opendev.org/t/openstack/build/d7589898b3104296b78b14b2b4df6e58 : SUCCESS in 1h 45m 24s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a23b3a04324f47feb113f465db679920 : SUCCESS in 1h 26m 55s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/26a6014c124045039b4f7a79031c3738 : SUCCESS in 55m 45s","accounts_in_message":[],"_revision_number":2},{"id":"2a345573bd81bad9fa17690f58048908dc515d34","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-07-09 07:55:54.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6c33180fdc97159ff914e96e129bdd76f81c454e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-07-12 14:47:07.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"62b066decb9ca6908c05bc2bd751e1e5d20afe4f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-12 16:36:46.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/168007d22eb74f81a0f24f98e8cc9e22 : SUCCESS in 5m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e1a0f8a5edf5424daee7cd032b9772c3 : SUCCESS in 5m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/84e28fc2c46e464a8289ae54ad8eeaae : SUCCESS in 4m 57s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/72db0a93db284a31833ebd1e987e57a0 : SUCCESS in 4m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1929dedde2524d2989ea43e95247e0db : SUCCESS in 4m 51s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e03202a744da44d5b7bf196762c50ec6 : SUCCESS in 5m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81231c9ee4174a42b45ae90293eb2978 : SUCCESS in 5m 23s\n- tempest-full https://zuul.opendev.org/t/openstack/build/bdb41eddc6de45649feb14e6a05ba6e8 : SUCCESS in 1h 43m 54s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4b05bf72f5be4c5fab9cecad64f9816a : SUCCESS in 1h 21m 24s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/9d501cfe0f164b9e86e10853f91b08a6 : SUCCESS in 51m 53s","accounts_in_message":[],"_revision_number":3},{"id":"a9799d11056635bd607c5fd6bbe819c2c5b02547","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-07-13 10:22:41.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"7f1dcf45abdbaa9685e0a19a2bdc2dbe27cf11ce","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 10:23:03.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"87a657002fc770ba81cef8825483ec929c350b0b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 12:38:45.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2189b16a936743b59a3499ced1fcf9cf : SUCCESS in 5m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7dd0110e656c4023b4e02b49fa441ede : SUCCESS in 5m 18s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6d6619491f3a4adb962f959222755146 : SUCCESS in 4m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/63b137dae3994db1b64a1217039e604f : SUCCESS in 4m 32s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/541a3029564e46a3aaff8d52f7e47db1 : SUCCESS in 5m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/763d6a3930a14c14b9f505e5b42635c5 : SUCCESS in 5m 51s\n- tempest-full https://zuul.opendev.org/t/openstack/build/55ce66e34e4946e195b4d5a353739366 : SUCCESS in 1h 27m 07s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/86c28be87da34efdb3b902719bfa59c8 : SUCCESS in 1h 16m 23s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/b5091c8404aa4c2aa1ed626035419303 : SUCCESS in 51m 33s","accounts_in_message":[],"_revision_number":3},{"id":"bd894fc6fa85a0e5e4694a9b4516225c401c2629","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 12:38:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"795119ad5455a30be3052095a77ee632be5a194c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 12:42:20.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5ad001728d2846acb5af78433743b8b0 : SUCCESS in 57s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"de0be9db05ac2fe955b014b05f2e03411e684494","revisions":{"c88a57bfd3132977aca029ef39a35869ad8e3012":{"kind":"REWORK","_number":1,"created":"2021-07-06 12:43:33.000000000","uploader":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"ref":"refs/changes/62/799662/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/62/799662/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/1"}}},"commit":{"parents":[{"commit":"54bf2c054d7b8287de5cb20dfbf03af0383c29c9","subject":"Merge \"Bypass user and group verification in RemoveRole\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/54bf2c054d7b8287de5cb20dfbf03af0383c29c9"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2020-07-23 11:20:09.000000000","tz":120},"committer":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2021-07-06 12:40:56.000000000","tz":120},"subject":"Fix reverted osc-lib interface change","message":"Fix reverted osc-lib interface change\n\nThe patch https://review.opendev.org/#/c/673389/ introduced a regression\nby changing the osc-lib interface.\n\nTwo conflicting attempts to fix the regression were launched:\n\n1) Reverting the patch.\n\n2) The patch https://review.opendev.org/683119 changes the exception\n   from the generic CommandError back to a specific Forbidden exception.\n\n   The patch https://review.opendev.org/683118 catches this exception\n   and passes on, i.e. re-implements the same behavior as before.\n\nThe first idea was implemented, the initial patch reverted. The second\nidea was partially implemented. The change in python-openstackclient\n(683118) was merged. The change in osc-lib was approved but failed to\nmerge because the initial change had been reverted.\n\nNow we have again a situation where the exception produced in osc-lib\ndoes not match the exception expected by the caller.\n\nIt is unclear if the osc-lib interface will ever get a rebased version\nof https://review.opendev.org/683119 merged, so the safest way to\naddress the issue is to also catch the exception that used to be\nthrown before the inital change and is again thrown after the inital\nchange has been reverted.\n\nConflicts:\n    openstackclient/identity/common.py\n\nChange-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c\n(cherry picked from commit 0a8753dc3eaeda25554ccd769350de1e9792a62b)\n(cherry picked from commit 0a8d855764c049be983ece4aaad02eea866da09e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c88a57bfd3132977aca029ef39a35869ad8e3012"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c88a57bfd3132977aca029ef39a35869ad8e3012"}]},"branch":"refs/heads/stable/train"},"4ba53852b010526b663191dc0f0f12c4d7caf147":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-07-06 16:22:12.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/62/799662/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/62/799662/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/2"}}},"commit":{"parents":[{"commit":"a34311a74944ad70c989350e7d3e1621833d2b05","subject":"[stable-only] Cap bandit to 1.6.2, bump lower-constraints","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a34311a74944ad70c989350e7d3e1621833d2b05"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2020-07-23 11:20:09.000000000","tz":120},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-07-06 16:22:12.000000000","tz":0},"subject":"Fix reverted osc-lib interface change","message":"Fix reverted osc-lib interface change\n\nThe patch https://review.opendev.org/#/c/673389/ introduced a regression\nby changing the osc-lib interface.\n\nTwo conflicting attempts to fix the regression were launched:\n\n1) Reverting the patch.\n\n2) The patch https://review.opendev.org/683119 changes the exception\n   from the generic CommandError back to a specific Forbidden exception.\n\n   The patch https://review.opendev.org/683118 catches this exception\n   and passes on, i.e. re-implements the same behavior as before.\n\nThe first idea was implemented, the initial patch reverted. The second\nidea was partially implemented. The change in python-openstackclient\n(683118) was merged. The change in osc-lib was approved but failed to\nmerge because the initial change had been reverted.\n\nNow we have again a situation where the exception produced in osc-lib\ndoes not match the exception expected by the caller.\n\nIt is unclear if the osc-lib interface will ever get a rebased version\nof https://review.opendev.org/683119 merged, so the safest way to\naddress the issue is to also catch the exception that used to be\nthrown before the inital change and is again thrown after the inital\nchange has been reverted.\n\nConflicts:\n    openstackclient/identity/common.py\n\nChange-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c\n(cherry picked from commit 0a8753dc3eaeda25554ccd769350de1e9792a62b)\n(cherry picked from commit 0a8d855764c049be983ece4aaad02eea866da09e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4ba53852b010526b663191dc0f0f12c4d7caf147"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4ba53852b010526b663191dc0f0f12c4d7caf147"}]},"branch":"refs/heads/stable/train","description":"Rebase"},"de0be9db05ac2fe955b014b05f2e03411e684494":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-07-12 14:47:07.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/62/799662/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/62/799662/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/62/799662/3"}}},"commit":{"parents":[{"commit":"a69cc3ddae6af46841042f440ff0d52db515c1e4","subject":"[stable-only] Cap bandit to 1.6.2, bump lower-constraints","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a69cc3ddae6af46841042f440ff0d52db515c1e4"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2020-07-23 11:20:09.000000000","tz":120},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-07-12 14:46:59.000000000","tz":60},"subject":"Fix reverted osc-lib interface change","message":"Fix reverted osc-lib interface change\n\nThe patch https://review.opendev.org/#/c/673389/ introduced a regression\nby changing the osc-lib interface.\n\nTwo conflicting attempts to fix the regression were launched:\n\n1) Reverting the patch.\n\n2) The patch https://review.opendev.org/683119 changes the exception\n   from the generic CommandError back to a specific Forbidden exception.\n\n   The patch https://review.opendev.org/683118 catches this exception\n   and passes on, i.e. re-implements the same behavior as before.\n\nThe first idea was implemented, the initial patch reverted. The second\nidea was partially implemented. The change in python-openstackclient\n(683118) was merged. The change in osc-lib was approved but failed to\nmerge because the initial change had been reverted.\n\nNow we have again a situation where the exception produced in osc-lib\ndoes not match the exception expected by the caller.\n\nIt is unclear if the osc-lib interface will ever get a rebased version\nof https://review.opendev.org/683119 merged, so the safest way to\naddress the issue is to also catch the exception that used to be\nthrown before the inital change and is again thrown after the inital\nchange has been reverted.\n\nConflicts:\n    openstackclient/identity/common.py\n\nChange-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c\n(cherry picked from commit 0a8753dc3eaeda25554ccd769350de1e9792a62b)\n(cherry picked from commit 0a8d855764c049be983ece4aaad02eea866da09e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de0be9db05ac2fe955b014b05f2e03411e684494"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de0be9db05ac2fe955b014b05f2e03411e684494"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}