)]}'
{"id":"openstack%2Fpython-openstackclient~802421","triplet_id":"openstack%2Fpython-openstackclient~master~I2c97e9f64790b5e978e4d04230d45b8e343b53d4","project":"openstack/python-openstackclient","branch":"master","topic":"story/2009079","hashtags":[],"change_id":"I2c97e9f64790b5e978e4d04230d45b8e343b53d4","subject":"Fix TestListMigrationV223 test class MIGRATION_COLUMNS","status":"MERGED","created":"2021-07-27 02:21:10.000000000","updated":"2021-07-27 09:44:10.000000000","submitted":"2021-07-27 09:42:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"802421-story/2009079","meta_rev_id":"633bf018b9359f092cb8fe030881116c3040f5a0","_number":802421,"virtual_id_number":802421,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-27 09:42:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-07-27 08:53:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-07-27 08:53:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-27 03:28:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-27 08:53:41.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"125d52d5fbc62e19623b240192f7dddf5f16cd20","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-27 02:21:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"43a261462934d60717d9417a4b40f70e8feb0518","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-27 02:22:27.000000000","message":"Topic fix-list-migrations-unit-test removed","accounts_in_message":[],"_revision_number":1},{"id":"aa048de7d9dd01a00a51f0cbc05a133f7436429f","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-27 02:22:32.000000000","message":"Topic set to story/2009079","accounts_in_message":[],"_revision_number":1},{"id":"d0c64e6670f72b88a30cd0017c7856b53db39713","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 03:28:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/178774c6cf71492cb1e033dd18b51bd6 : SUCCESS in 6m 06s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/8446539efda04f788616749fcbb20852 : SUCCESS in 5m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a7d31ac7c5e14e95b7c346be0d77d55f : SUCCESS in 5m 16s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/75f04a68609745e8bd9d593ca5a32e50 : SUCCESS in 5m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2b56a4ee5f1c4c819f656fedb0629e83 : SUCCESS in 4m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7047fb7e424d4d628708e7e8d76465be : SUCCESS in 4m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2df1f40e13b8476ea841f5f18b8f7e43 : SUCCESS in 4m 32s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f338f8a609264e0e9f24e8f32123f509 : SUCCESS in 4m 42s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81b8444a6a9b48caa6ee53739b306a49 : SUCCESS in 7m 20s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/88439aeaee2d4762ab1b0981c78873a0 : SUCCESS in 7m 17s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/988cae590bc84d7db95fce699393c842 : SUCCESS in 59m 47s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/84c4915094e9475f83976986d2d47278 : SUCCESS in 48m 34s","accounts_in_message":[],"_revision_number":1},{"id":"2058769634d1963faa316beaaf6344d526aeed51","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-07-27 08:53:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5d7c279040ba7f3c765b70491a62ca2db93a3dc0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 08:54:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9ebe73d494c95fcfe994751557e897f9597ecce5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 09:42:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/770055c462af4cdba23762f2199d188c : SUCCESS in 5m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ba55161c388b4430b7ad6268f1ebda77 : SUCCESS in 7m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/536f4ed7939d4c91a5775f4632fc2bd8 : SUCCESS in 4m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/eec394234e0f4dde883c2af1a515f6bc : SUCCESS in 5m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/70cb9e57ba154a8298f6ea2296faa1f6 : SUCCESS in 5m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/86415edf89234309814c3289401c9b87 : SUCCESS in 7m 12s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/18b13c4923ca497c857c823eb202d250 : SUCCESS in 7m 28s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/8e7d1bedfb4d4aedb8e8015aad55a3fb : SUCCESS in 47m 13s","accounts_in_message":[],"_revision_number":1},{"id":"0b33297043ca1bfcb0cbaad792173b17ffbd5263","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 09:42:20.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"633bf018b9359f092cb8fe030881116c3040f5a0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-27 09:44:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/23bfa007069d4d01a47a7304c41f4c24 : SUCCESS in 1m 31s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/7f9d5ec91b524e5cb636d2b121450964 : SUCCESS in 56s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4f6fe1c0fd0ee5be3cc78961fd334aac0bacd57b","revisions":{"4f6fe1c0fd0ee5be3cc78961fd334aac0bacd57b":{"kind":"REWORK","_number":1,"created":"2021-07-27 02:21:10.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/21/802421/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/21/802421/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/21/802421/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/21/802421/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/21/802421/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/21/802421/1"}}},"commit":{"parents":[{"commit":"c1209601b4f4b81690a186e51aa819c783367fae","subject":"tests: Handle removal of block-storage v2 API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c1209601b4f4b81690a186e51aa819c783367fae"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-27 02:10:20.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-27 02:20:39.000000000","tz":0},"subject":"Fix TestListMigrationV223 test class MIGRATION_COLUMNS","message":"Fix TestListMigrationV223 test class MIGRATION_COLUMNS\n\nCurrently only the test_server_migration_list adds the \u0027Id\u0027 and \u0027Type\u0027\ncolumns to the expected output, so if the\ntest_server_migration_list_no_options test is run by itself, it fails\nas the actual response contains \u0027Id\u0027 and \u0027Type\u0027 but the reference does\nnot. This example run fails:\n\n  tox -epy38 test_server_migration_list_no_options\n\nThe reason the tests pass in the gate is because\ntest_server_migration_list (which adds the \u0027Id\u0027 and \u0027Type\u0027 columns to\nself.MIGRATION_COLUMNS) appears to always run before\ntest_server_migration_list_no_options, so the latter test gets the\nbenefit of the former test\u0027s column additions.\n\nThis changes the test class to just include the \u0027Id\u0027 and \u0027Type\u0027 columns\nall the time as they are always returned in microversion 2.23 anyway.\n\nStory: 2009079\nTask: 42891\n\nChange-Id: I2c97e9f64790b5e978e4d04230d45b8e343b53d4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4f6fe1c0fd0ee5be3cc78961fd334aac0bacd57b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4f6fe1c0fd0ee5be3cc78961fd334aac0bacd57b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
