)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c16e5160c3ab435fd5c3398c21f513c3add6fa5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Take advantage of the common pagination helpers introduced in change"},{"line_number":16,"context_line":"I551bb4c3ff0568c6df5244a1d0f0669497bee58f to expose this functionality"},{"line_number":17,"context_line":"to end users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idea9c995ad412efdc11ecb64baaece6ab35cbb48"},{"line_number":20,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":21,"context_line":"Story: #2009064"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8999fe0f_26ff8333","line":18,"updated":"2021-07-27 11:50:36.000000000","message":"Missing link:\n\n  [1] https://docs.openstack.org/api-ref/network/v2/#pagination","commit_id":"c1bd33f19445cdc29b17e6c6acfeb55755448e55"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c5af18923c0571daa5549f15bca3c486d5b948d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Take advantage of the common pagination helpers introduced in change"},{"line_number":16,"context_line":"I551bb4c3ff0568c6df5244a1d0f0669497bee58f to expose this functionality"},{"line_number":17,"context_line":"to end users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idea9c995ad412efdc11ecb64baaece6ab35cbb48"},{"line_number":20,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":21,"context_line":"Story: #2009064"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"045949d3_5d846038","line":18,"in_reply_to":"8999fe0f_26ff8333","updated":"2023-11-13 18:06:01.000000000","message":"Done","commit_id":"c1bd33f19445cdc29b17e6c6acfeb55755448e55"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93b7a3283ad7e7206e8a2d7797ab3004bde87574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f30c4164_69341676","updated":"2023-11-15 11:40:17.000000000","message":"I need to respin this. Should figure out the two TODOs first though","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a9f0fd0f0ef9bd85bbce1d11b305c5e6c8717b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7fc92f48_f1dfe43b","updated":"2023-11-15 01:15:17.000000000","message":"Mostly nits, not sure if i noticed a bug in there","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"79aa381fd831ce506ee5120e56c114274155cc4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"73cfd134_136db15a","updated":"2023-11-14 08:49:39.000000000","message":"thanks for taking care. If there\u0027s such items and you have no time for it just ring on Neutron IRC, or add the topic to the meeting","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"}],"openstackclient/network/v2/floating_ip_pool.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a9f0fd0f0ef9bd85bbce1d11b305c5e6c8717b3","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    def take_action_compute(self, client, parsed_args):"},{"line_number":35,"context_line":"        columns \u003d (\u0027Name\u0027,)"},{"line_number":36,"context_line":"        filters \u003d {}"},{"line_number":37,"context_line":"        data \u003d client.api.floating_ip_pool_list(**filters)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return ("},{"line_number":40,"context_line":"            columns,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ca591a4_7ae2ba6a","line":37,"updated":"2023-11-15 01:15:17.000000000","message":"Is this related to this change? or was the pagination filter code not added?","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33feae5946854927ce369451bbb8ae171dd5548b","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    def take_action_compute(self, client, parsed_args):"},{"line_number":35,"context_line":"        columns \u003d (\u0027Name\u0027,)"},{"line_number":36,"context_line":"        filters \u003d {}"},{"line_number":37,"context_line":"        data \u003d client.api.floating_ip_pool_list(**filters)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return ("},{"line_number":40,"context_line":"            columns,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1c0777b9_a2f902ec","line":37,"in_reply_to":"9ca591a4_7ae2ba6a","updated":"2023-11-15 11:40:05.000000000","message":"I\u0027ve forgotten the rationale behind this. I suspect there was initially pagination options here but I discovered this wasn\u0027t supported? I need to look into this again.","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a9f0fd0f0ef9bd85bbce1d11b305c5e6c8717b3","unresolved":true,"context_lines":[{"line_number":577,"context_line":"                \u0027ID\u0027,"},{"line_number":578,"context_line":"                \u0027Name\u0027,"},{"line_number":579,"context_line":"                \u0027Subnets\u0027,"},{"line_number":580,"context_line":"            )"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        if parsed_args.agent_id:"},{"line_number":583,"context_line":"            columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027subnet_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"05b964bb_e69fbaf0","line":580,"updated":"2023-11-15 01:15:17.000000000","message":"Is this related to this change?","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33feae5946854927ce369451bbb8ae171dd5548b","unresolved":true,"context_lines":[{"line_number":577,"context_line":"                \u0027ID\u0027,"},{"line_number":578,"context_line":"                \u0027Name\u0027,"},{"line_number":579,"context_line":"                \u0027Subnets\u0027,"},{"line_number":580,"context_line":"            )"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        if parsed_args.agent_id:"},{"line_number":583,"context_line":"            columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027subnet_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c52148a_a37abf11","line":580,"in_reply_to":"05b964bb_e69fbaf0","updated":"2023-11-15 11:40:05.000000000","message":"Nope, but it\u0027s a bugfix. As things stand, passing `--long` and `--agent` will cause the latter to be ignored. This reverses that behavior (which seems more sensible, since the former is really only formatting related). I should drag this out to a separate change though...","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a9f0fd0f0ef9bd85bbce1d11b305c5e6c8717b3","unresolved":true,"context_lines":[{"line_number":585,"context_line":"                \u0027ID\u0027,"},{"line_number":586,"context_line":"                \u0027Name\u0027,"},{"line_number":587,"context_line":"                \u0027Subnets\u0027,"},{"line_number":588,"context_line":"            )"},{"line_number":589,"context_line":"            client \u003d self.app.client_manager.network"},{"line_number":590,"context_line":"            dhcp_agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":591,"context_line":"            data \u003d client.dhcp_agent_hosting_networks(dhcp_agent)"}],"source_content_type":"text/x-python","patch_set":4,"id":"36f4841f_2d2d90c1","line":588,"updated":"2023-11-15 01:15:17.000000000","message":"Shouldn\u0027t this section go away? it will overwrite the column name if --long was give otherwise, right?","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33feae5946854927ce369451bbb8ae171dd5548b","unresolved":true,"context_lines":[{"line_number":585,"context_line":"                \u0027ID\u0027,"},{"line_number":586,"context_line":"                \u0027Name\u0027,"},{"line_number":587,"context_line":"                \u0027Subnets\u0027,"},{"line_number":588,"context_line":"            )"},{"line_number":589,"context_line":"            client \u003d self.app.client_manager.network"},{"line_number":590,"context_line":"            dhcp_agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":591,"context_line":"            data \u003d client.dhcp_agent_hosting_networks(dhcp_agent)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b39f7f0a_bc123476","line":588,"in_reply_to":"36f4841f_2d2d90c1","updated":"2023-11-15 11:40:05.000000000","message":"That was the previous behaviour. I don\u0027t get it either but I was _guessing_ that these are the only columns returned by the call to `dhcp_agent_hosting_networks`?","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a9f0fd0f0ef9bd85bbce1d11b305c5e6c8717b3","unresolved":true,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":"        if parsed_args.device_owner is not None:"},{"line_number":812,"context_line":"            filters[\u0027device_owner\u0027] \u003d parsed_args.device_owner"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"        if parsed_args.device_id is not None:"},{"line_number":815,"context_line":"            filters[\u0027device_id\u0027] \u003d parsed_args.device_id"},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4b38a77f_4d491100","line":813,"updated":"2023-11-15 01:15:17.000000000","message":"Some extra lines added in this file","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a9f0fd0f0ef9bd85bbce1d11b305c5e6c8717b3","unresolved":true,"context_lines":[{"line_number":563,"context_line":"    def take_action(self, parsed_args):"},{"line_number":564,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":565,"context_line":"        network_client \u003d self.app.client_manager.network"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        filters \u003d {}"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        if parsed_args.ip_version:"}],"source_content_type":"text/x-python","patch_set":4,"id":"b2bdf157_eb6d12f0","line":566,"updated":"2023-11-15 01:15:17.000000000","message":"Some extra lines added in this file as well","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"}],"openstackclient/network/v2/subnet_pool.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a9f0fd0f0ef9bd85bbce1d11b305c5e6c8717b3","unresolved":true,"context_lines":[{"line_number":329,"context_line":"    def take_action(self, parsed_args):"},{"line_number":330,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":331,"context_line":"        network_client \u003d self.app.client_manager.network"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        filters \u003d {}"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        if parsed_args.share:"}],"source_content_type":"text/x-python","patch_set":4,"id":"6f650cd0_05341fa5","line":332,"updated":"2023-11-15 01:15:17.000000000","message":"And here","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"}],"openstackclient/tests/unit/network/v2/test_floating_ip_port_forwarding.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a9f0fd0f0ef9bd85bbce1d11b305c5e6c8717b3","unresolved":true,"context_lines":[{"line_number":153,"context_line":"                \u0027internal_port_id\u0027: self.new_port_forwarding_with_ranges.internal_port_id,  # noqa: E501"},{"line_number":154,"context_line":"                \u0027protocol\u0027: self.new_port_forwarding_with_ranges.protocol,"},{"line_number":155,"context_line":"                \u0027description\u0027: self.new_port_forwarding_with_ranges.description,  # noqa: E501"},{"line_number":156,"context_line":"            },"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":159,"context_line":"        self.assertEqual(self.data, data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9714d459_cc263c1c","line":156,"updated":"2023-11-15 01:15:17.000000000","message":"Were the trailing commas necessary in this file?","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33feae5946854927ce369451bbb8ae171dd5548b","unresolved":true,"context_lines":[{"line_number":153,"context_line":"                \u0027internal_port_id\u0027: self.new_port_forwarding_with_ranges.internal_port_id,  # noqa: E501"},{"line_number":154,"context_line":"                \u0027protocol\u0027: self.new_port_forwarding_with_ranges.protocol,"},{"line_number":155,"context_line":"                \u0027description\u0027: self.new_port_forwarding_with_ranges.description,  # noqa: E501"},{"line_number":156,"context_line":"            },"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":159,"context_line":"        self.assertEqual(self.data, data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"356b0e47_19566226","line":156,"in_reply_to":"9714d459_cc263c1c","updated":"2023-11-15 11:40:05.000000000","message":"Nope, that was just old me being pedantic I suspect.","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"}],"openstackclient/tests/unit/network/v2/test_network_service_provider.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33feae5946854927ce369451bbb8ae171dd5548b","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":73,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # TODO(stephenfin): Does this API actually support pagination?"},{"line_number":76,"context_line":"    def test_network_server_provider_list_pagination(self):"},{"line_number":77,"context_line":"        arglist \u003d ["},{"line_number":78,"context_line":"            \u0027--marker\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a044daad_fcd4d2fa","line":75,"updated":"2023-11-15 11:40:05.000000000","message":"This TODO is still open. I have yet to evaluate this.","commit_id":"8b3bda2b94b3ee6b072d064be112edee951b44d4"}]}