)]}'
{"id":"openstack%2Fpython-openstackclient~802650","triplet_id":"openstack%2Fpython-openstackclient~master~I8aab60619e0225047f6a1c31e44917ca8fcc799e","project":"openstack/python-openstackclient","branch":"master","topic":"story/2009078","hashtags":[],"change_id":"I8aab60619e0225047f6a1c31e44917ca8fcc799e","subject":"Correct REST API response fields for /os-migrations API","status":"MERGED","created":"2021-07-28 03:35:59.000000000","updated":"2021-07-28 18:14:39.000000000","submitted":"2021-07-28 18:10:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"802650-story/2009078","meta_rev_id":"4319de9ff21109af8a164f243f58ed95cf1f7c80","_number":802650,"virtual_id_number":802650,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-28 18:10:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-07-28 17:15:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-07-28 17:15:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-28 04:25:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-28 10:22:47.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"593fab5a587e79c0a7e1d6c87f4e89d0be0906e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-28 03:35:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b4b2480e8a240eea2b054831d16cc4f77aebeafb","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-28 03:39:43.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"abd5e38cc5971898c660dff0ce1db12303f602b8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-28 04:25:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/10188064cb6c42d78a413bc18a7edb45 : SUCCESS in 11m 58s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/9cf9a3da2dca4be3b37ccb1a931a7f4e : SUCCESS in 7m 13s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/699092ffeecd4a089c635ad1cab2539a : SUCCESS in 5m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2ef9b71f10bb487bafa18d41bd34065f : SUCCESS in 4m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7ac35d6f51514da694b57ae226bfbebe : SUCCESS in 4m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/267486ded42b4a55b35db32e9f3d82e5 : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/764f7861981441e18b06ade2f793b9bf : SUCCESS in 3m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0d7f253634b049d6b31b7c7d9a9ab0b7 : SUCCESS in 4m 47s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/141520a996da484088ffa34d320ae9c4 : SUCCESS in 6m 46s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/61766f1db9b14dc5a39909feb6c492b2 : SUCCESS in 7m 19s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/030cbda57f0445eb8add717a510ecf04 : SUCCESS in 43m 21s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/f7cb27317b0e4e8d8d0c77c459929b42 : SUCCESS in 47m 48s","accounts_in_message":[],"_revision_number":1},{"id":"18d64ae3925e13738e94c38de1d22986c992ec19","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-07-28 10:22:47.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nsoftest of -1s. I could probably be talked around if you don\u0027t want to make the changes 😊","accounts_in_message":[],"_revision_number":1},{"id":"61f619d63c45e959f9892ac18fd0890644ca61e2","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-28 15:09:35.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nSure, no problem. Will respin.","accounts_in_message":[],"_revision_number":1},{"id":"f04b0f29d46ebe26f11b00fee609ef8c01c4c971","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-28 15:28:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5c8e461b98b462cff2dd517daf704a47371a253e","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-28 15:46:36.000000000","message":"Topic migration-server-uuid removed","accounts_in_message":[],"_revision_number":2},{"id":"cb803dd34285993037bc0c89d2d77c1e516d1b15","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-28 15:46:39.000000000","message":"Topic set to story/2009078","accounts_in_message":[],"_revision_number":2},{"id":"abf65bd794379d677afd6ea111a782ee6f60b5a7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-28 16:22:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/5817110b97834119b7d0ac5338ca818b : SUCCESS in 6m 28s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/e9cc19b8144d4a32ac0a0c4aa7254d8f : SUCCESS in 6m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2c4d438912ed42a29037af5f4b88ac62 : SUCCESS in 5m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f89bfd013ddd42528cd30a4d9852c359 : SUCCESS in 5m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3840368463624ed7a7c283eb0a5f9035 : SUCCESS in 5m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d89a4b5f15764f1382d8f3f51a29b5e6 : SUCCESS in 4m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/485ddf3544d04021b0f31873a11620b9 : SUCCESS in 4m 32s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f997fd2957e54e9e9caf04829c6fc45f : SUCCESS in 4m 58s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b37b445bd9d24fba8c62de55181bf88e : SUCCESS in 6m 39s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/47d5c17a15f54667a24cd4e7938e91c7 : SUCCESS in 7m 01s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/c316d2fab9dc46099a33766d530a0657 : SUCCESS in 48m 38s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/a03dedb8df3a4fe580b9f085d65db189 : SUCCESS in 49m 51s","accounts_in_message":[],"_revision_number":2},{"id":"093f60cfd6cdd6811702ee0ffa857372f1373a3a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-07-28 17:15:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e391667f8036bde1e5ab44a52920beaaca94db87","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-28 17:19:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"f6e7b8b9126d4b0839acc10b0f66efa21e6f7ee7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-28 18:10:42.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/fb45b786b9c74d73b16c525399c63915 : SUCCESS in 7m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fa84cf6e894f454a9f495364b7c2687b : SUCCESS in 5m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ab1fa174bb8c4cc19c4fb3bef86e1216 : SUCCESS in 4m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c90ed43c13e84a50b3147451f176e737 : SUCCESS in 5m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2cc9850174234b9a83278b1976e935af : SUCCESS in 4m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4435075f300e47c7a1fc094b951be8e6 : SUCCESS in 6m 50s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/d1be252a0267462badae7ce3dfbf3406 : SUCCESS in 9m 15s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/14c886cc8df5483da9bbc1e638190538 : SUCCESS in 47m 53s","accounts_in_message":[],"_revision_number":2},{"id":"6e7e0090ff6e538bf601e41844c80805db29a279","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-28 18:10:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"4319de9ff21109af8a164f243f58ed95cf1f7c80","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-28 18:14:39.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c990672567134250947a04acc2bfd1d4 : SUCCESS in 1m 04s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/d77d7044b1ec44bea3b1f92875008855 : SUCCESS in 59s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ed87f7949ef1ef580ed71b9820e16823c0466472","revisions":{"a6c4965c3c449107f2877d89530db21a9808c700":{"kind":"REWORK","_number":1,"created":"2021-07-28 03:35:59.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/50/802650/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/50/802650/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/802650/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/802650/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/802650/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/50/802650/1"}}},"commit":{"parents":[{"commit":"59256becc93d7953f983e0fbbdef098fefba73ff","subject":"Merge \"compute: Note that \u0027--password\u0027 is deployment-specific\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/59256becc93d7953f983e0fbbdef098fefba73ff"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-26 22:13:55.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-28 03:31:15.000000000","tz":0},"subject":"Correct REST API response fields for /os-migrations API","message":"Correct REST API response fields for /os-migrations API\n\nThe compute APIs are unfortunately inconsistent with regard to the\nresponse parameters for migrations.\n\n* GET /servers/{server_id}/migrations returns server_uuid\n* GET /os-migrations returns instance_uuid\n\nBecause the \u0027Server UUID\u0027 column is being specified for parsing the\nresponse from GET /os-migrations, it is always showing as an empty\nstring to users.\n\nThere are a few other mismatches between the column names and the REST\nAPI response fields:\n\n* \u0027Old Flavor\u0027 vs \u0027old_instance_type_id\u0027\n* \u0027New Flavor\u0027 vs \u0027new_instance_type_id\u0027\n* \u0027Type\u0027 vs \u0027migration_type\u0027\n\nThis adds a new list containing the REST API response field names to\npass to utils.get_item_properties so that the responses are correctly\nparsed and the client output contains the response data instead of\nempty strings.\n\nStory: 2009078\nTask: 42890\n\nChange-Id: I8aab60619e0225047f6a1c31e44917ca8fcc799e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a6c4965c3c449107f2877d89530db21a9808c700"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a6c4965c3c449107f2877d89530db21a9808c700"}]},"branch":"refs/heads/master"},"ed87f7949ef1ef580ed71b9820e16823c0466472":{"kind":"REWORK","_number":2,"created":"2021-07-28 15:28:25.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/50/802650/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/50/802650/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/802650/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/802650/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/802650/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/50/802650/2"}}},"commit":{"parents":[{"commit":"59256becc93d7953f983e0fbbdef098fefba73ff","subject":"Merge \"compute: Note that \u0027--password\u0027 is deployment-specific\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/59256becc93d7953f983e0fbbdef098fefba73ff"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-26 22:13:55.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-28 15:25:06.000000000","tz":0},"subject":"Correct REST API response fields for /os-migrations API","message":"Correct REST API response fields for /os-migrations API\n\nThe compute APIs are unfortunately inconsistent with regard to the\nresponse parameters for migrations.\n\n* GET /servers/{server_id}/migrations returns server_uuid\n* GET /os-migrations returns instance_uuid\n\nBecause the \u0027Server UUID\u0027 column is being specified for parsing the\nresponse from GET /os-migrations, it is always showing as an empty\nstring to users.\n\nThere are a few other mismatches between the column names and the REST\nAPI response fields [1]:\n\n* \u0027Old Flavor\u0027 vs \u0027old_instance_type_id\u0027\n* \u0027New Flavor\u0027 vs \u0027new_instance_type_id\u0027\n* \u0027Type\u0027 vs \u0027migration_type\u0027\n\nThis adds a new list containing the REST API response field names to\npass to utils.get_item_properties so that the responses are correctly\nparsed and the client output contains the response data instead of\nempty strings.\n\nStory: 2009078\nTask: 42890\n\n[1] https://docs.openstack.org/api-ref/compute/?expanded\u003dlist-migrations-detail#list-migrations\n\nChange-Id: I8aab60619e0225047f6a1c31e44917ca8fcc799e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ed87f7949ef1ef580ed71b9820e16823c0466472"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ed87f7949ef1ef580ed71b9820e16823c0466472"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}