)]}'
{"id":"openstack%2Fpython-openstackclient~812661","triplet_id":"openstack%2Fpython-openstackclient~master~Iae44770a784732991962cd38472095f76ab2543f","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"Iae44770a784732991962cd38472095f76ab2543f","subject":"Remove non-working code after method return.","status":"MERGED","created":"2021-10-06 10:54:45.000000000","updated":"2021-10-07 07:33:51.000000000","submitted":"2021-10-07 07:31:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"812661","meta_rev_id":"6e9ce8bd57b95edd0d86688ee1f5b218c0f6ba7e","_number":812661,"virtual_id_number":812661,"owner":{"_account_id":33836,"name":"Seunghyun LIm","display_name":"lsmman","email":"lsmman07@gmail.com","username":"lsmman"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-10-07 07:31:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-10-06 11:11:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-10-06 11:11:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-06 11:11:32.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-10-06 12:07:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"77181e7a7256610650dc6a383393ce5dfce19a8a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33836,"name":"Seunghyun LIm","display_name":"lsmman","email":"lsmman07@gmail.com","username":"lsmman"},"date":"2021-10-06 10:54:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a81cc1a4641ad654128a1ead3bea240962723e8","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-10-06 11:11:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0879e3bff8fb78738bb148f952940356132fe003","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-06 12:07:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/441d83e112b0445c8a7e376c189d1705 : SUCCESS in 6m 52s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/c9945b2f7fa84f5ea18b3bd84d06a897 : SUCCESS in 6m 49s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fff560898f014b8faef08335f9bf408c : SUCCESS in 8m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c6b817c3960d4cba9f025fe1dec86e07 : SUCCESS in 7m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/081df86a9d654525b2f187b7bb14fbba : SUCCESS in 5m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f5ba540b7a6946819f6f5789abb6e542 : SUCCESS in 5m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a2177c5b805e4c279f410af397163edf : SUCCESS in 4m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/865781c5627145c6a7d0937cede4d5e6 : SUCCESS in 5m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/72c363e5d0294f6880f6c0c5b1b3af25 : SUCCESS in 8m 27s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/9b2eeaa00d9a48ff98e891b2b84dcd54 : SUCCESS in 8m 46s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/8d0b2d13ed4d475690a784bc5ebc65e9 : SUCCESS in 58m 16s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/94eb001fc6324a5985d7737d3521c02c : FAILURE in 31m 33s","accounts_in_message":[],"_revision_number":1},{"id":"0b68cb687602c3cbcec3997d066f19e5ce524e39","author":{"_account_id":33836,"name":"Seunghyun LIm","display_name":"lsmman","email":"lsmman07@gmail.com","username":"lsmman"},"date":"2021-10-06 15:15:47.000000000","message":"Patch Set 1:\n\nRECHECK","accounts_in_message":[],"_revision_number":1},{"id":"2278c938f5cc4aa9157516508e1b6dd079b7bedf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-06 16:21:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/9a0162e717bf4462aa631494574cba6e : SUCCESS in 7m 00s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/c2ebece9e425440785fe642f7a4f7b20 : SUCCESS in 5m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/96c2f78759654e5b99fd3d72dca005d1 : SUCCESS in 5m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/588ea4afbb434adf9f9c07e63b76b646 : SUCCESS in 5m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dd0aa7dd02b64ab88821aa01e2a4317f : SUCCESS in 4m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7ba1fa8ccebd4115a09256f178fb6c7a : SUCCESS in 5m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ffffb8ad9e4f478184aeb0dd06ca9ac9 : SUCCESS in 5m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/65f1c310e89049de9df4c4313082b029 : SUCCESS in 5m 17s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c0da4ca3aefa4d56b028bb3224481a88 : SUCCESS in 7m 34s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/b18f54e841ff45d0ae15aab4fd345da9 : SUCCESS in 7m 03s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/f5dbefe4a94946dbaa2e7b78c6e976d4 : SUCCESS in 59m 36s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c664eeb1ba06471eb5bd5bfe936a0a28 : SUCCESS in 53m 03s","accounts_in_message":[],"_revision_number":1},{"id":"6d4cab5d81fe1c6dc08b04f65326800d1ba7e2eb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-06 16:23:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"79d35d35cde90140679bcf2eeaccba368b1655f9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-06 22:14:39.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/5c7743238a6c4407ad9fd518a83e60be : SUCCESS in 6m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/44080c1d66a94d48a6c73c78e3b65397 : SUCCESS in 7m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ff45a7e9ef164b3b8cce0b1fd806fc80 : SUCCESS in 4m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e1ec7a2184e744b1adba520c24691e7f : SUCCESS in 5m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c539d428e7a74c1ea75b543ad6de2a16 : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/58659265c3534f688f849233406a9be9 : SUCCESS in 7m 26s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/09686bf6bb6046ba8955bec2f03ac287 : SUCCESS in 7m 49s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/7833f6a128524e5d928839613aef889d : FAILURE in 43m 24s","accounts_in_message":[],"_revision_number":1},{"id":"7c3e923b2624c1249d22f3d885b70e838e8b3789","author":{"_account_id":33836,"name":"Seunghyun LIm","display_name":"lsmman","email":"lsmman07@gmail.com","username":"lsmman"},"date":"2021-10-07 05:33:23.000000000","message":"Patch Set 1:\n\nRECHECK","accounts_in_message":[],"_revision_number":1},{"id":"7bfd9942161f4943f88b9077ff254b8d53d9236f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-07 06:33:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/e636bef7da6b43a09e20c38ea89b8df3 : SUCCESS in 5m 52s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/9ca6dfd2b4414ea0a1e466ee968f41e7 : SUCCESS in 5m 29s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2b0239eda4ed4a51ac549f3104a4a436 : SUCCESS in 5m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6a091eb9ef7d4f6495a1926e44fd4d3c : SUCCESS in 4m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef0f865724504d809b9eaefd995dd92e : SUCCESS in 3m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2da48dfc09ef453a86adb3e86f58dc1f : SUCCESS in 4m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/02b1de24bd494cd1aff83b24f50a43a3 : SUCCESS in 4m 21s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/749e9bca88f74add8094958a1c22dc0e : SUCCESS in 4m 25s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6cf7263e6a3a429d8050722d69c2eac7 : SUCCESS in 6m 31s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/4c3a26716bb948c9bba222ab6c983d5e : SUCCESS in 6m 20s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/15341df2e9f2468d9153575de86c1a02 : SUCCESS in 54m 24s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c1ea78ff004b4abe92d9e40c4587592f : SUCCESS in 54m 19s","accounts_in_message":[],"_revision_number":1},{"id":"2658c56b1bc2d6773a9135645a870a3e6552d03b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-07 06:34:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ac8488c43563c75ecfb20172a86b38a7e9a8b737","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-07 07:31:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/a9561e9bce9544abafc16882af36b819 : SUCCESS in 9m 04s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/49e77ff1792b4884970bf3e8c1bb31e4 : SUCCESS in 6m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ad330628f29649719c9be17d2e9af741 : SUCCESS in 5m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/36535da50f744aee819a0d9e78218aa3 : SUCCESS in 6m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a66862b88d8a46119b93eaf6f6295107 : SUCCESS in 6m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d5d68a8a664a4803a3c324ad233df839 : SUCCESS in 9m 28s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/f859be0bac7846c5b0b72b55e96b0c9f : SUCCESS in 9m 04s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/0d621227b2ab451d90c3bce7db651d14 : SUCCESS in 51m 10s","accounts_in_message":[],"_revision_number":1},{"id":"feb016c7151d70ff9a95db8ac12fc1b1750dca76","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-07 07:31:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"6e9ce8bd57b95edd0d86688ee1f5b218c0f6ba7e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-07 07:33:51.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/31c7d7f186a544ff9de1b78ed623fcdb : SUCCESS in 1m 12s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/06d53b61be75486b9d677dd90882121f : SUCCESS in 1m 01s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"abed9f20f5d9c1af3345456ec82d726e49db9f68","revisions":{"abed9f20f5d9c1af3345456ec82d726e49db9f68":{"kind":"REWORK","_number":1,"created":"2021-10-06 10:54:45.000000000","uploader":{"_account_id":33836,"name":"Seunghyun LIm","display_name":"lsmman","email":"lsmman07@gmail.com","username":"lsmman"},"ref":"refs/changes/61/812661/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/61/812661/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/812661/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/812661/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/812661/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/61/812661/1"}}},"commit":{"parents":[{"commit":"ff372ffdfbfe036993f84be20cd18262599b37de","subject":"Add Python3 yoga unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ff372ffdfbfe036993f84be20cd18262599b37de"}]}],"author":{"name":"lsmman","email":"lsmman07@gmail.com","date":"2021-10-06 10:21:51.000000000","tz":540},"committer":{"name":"lsmman","email":"lsmman07@gmail.com","date":"2021-10-06 10:21:51.000000000","tz":540},"subject":"Remove non-working code after method return.","message":"Remove non-working code after method return.\n\nDelete duplicate return code.\n\nWhile adding return of a new Member type, the existing return code part is not deleted.\n\nNote the code in fakes.py in the below commit where these codes were added.\n- Project: python-openstackclient\n- The commit: 60e7c51df4cf061ebbb435a959ad63c7d3a296bf\n\nChange-Id: Iae44770a784732991962cd38472095f76ab2543f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/abed9f20f5d9c1af3345456ec82d726e49db9f68"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/abed9f20f5d9c1af3345456ec82d726e49db9f68"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}