)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"c162a5fe68e55db501d78906d7b65e7e71cdea03","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-18 01:23:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch server backup to sdk."},{"line_number":8,"context_line":"Unit tests are modified and can pass."},{"line_number":9,"context_line":"It seems that there is no functional test perticularly for server backup."},{"line_number":10,"context_line":"Module compute.v2.fakes.FakeServer is modified so that other 172 tests related to server fail."},{"line_number":11,"context_line":"This code change is hence more like a practice, and may need to wait till all commands related to server are completed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4d7e1df7_aa3c7752","line":8,"updated":"2021-10-18 15:59:55.000000000","message":"you need to have linebreak between commit \"summary\" and \"details\"","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13a28d245050a2b2117f17f000777e01cbef45c2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-18 01:23:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch server backup to sdk."},{"line_number":8,"context_line":"Unit tests are modified and can pass."},{"line_number":9,"context_line":"It seems that there is no functional test perticularly for server backup."},{"line_number":10,"context_line":"Module compute.v2.fakes.FakeServer is modified so that other 172 tests related to server fail."},{"line_number":11,"context_line":"This code change is hence more like a practice, and may need to wait till all commands related to server are completed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d89d4f3f_ffcd53b8","line":8,"in_reply_to":"10701db4_2e2b48cc","updated":"2021-10-26 11:06:37.000000000","message":"This information isn\u0027t part of the commit *message*: it\u0027s part of the commit. This information is included automatically. The author fields indicate who \"authored\" the commit initially, while the the commit fields indicate who made the last changes (i.e. a rebase or amend operation). You can reset the authorship information using e.g. \u0027git commit --amend --reset-author\u0027.\n\nAs I said, this information is set automatically based on your local git config (i.e. \u0027git config user.name\u0027 and \u0027git config user.email\u0027): the author info is added when you create a commit and the commit info is added when you make a change. You don\u0027t need to/can\u0027t set this information manually. Gerrit just surfaces that information so it\u0027s visible.","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-18 01:23:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch server backup to sdk."},{"line_number":8,"context_line":"Unit tests are modified and can pass."},{"line_number":9,"context_line":"It seems that there is no functional test perticularly for server backup."},{"line_number":10,"context_line":"Module compute.v2.fakes.FakeServer is modified so that other 172 tests related to server fail."},{"line_number":11,"context_line":"This code change is hence more like a practice, and may need to wait till all commands related to server are completed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"10701db4_2e2b48cc","line":8,"in_reply_to":"4d7e1df7_aa3c7752","updated":"2021-10-26 00:38:27.000000000","message":"I added a linebreak. Then I noticed there are these information in one of your commit:\nParent:     ff372ffd (Add Python3 yoga unit tests)\nAuthor:     Artem Goncharov \u003cArtem.goncharov@gmail.com\u003e\nAuthorDate: 2020-11-19 18:15:55 +0100\nCommit:     Artem Goncharov \u003cArtem.goncharov@gmail.com\u003e\nCommitDate: 2021-10-08 11:56:05 +0200\nCould you teach me how to get this information into our commits in the future.","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-18 01:23:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch server backup to sdk."},{"line_number":8,"context_line":"Unit tests are modified and can pass."},{"line_number":9,"context_line":"It seems that there is no functional test perticularly for server backup."},{"line_number":10,"context_line":"Module compute.v2.fakes.FakeServer is modified so that other 172 tests related to server fail."},{"line_number":11,"context_line":"This code change is hence more like a practice, and may need to wait till all commands related to server are completed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a32f10e5_13dc82db","line":8,"in_reply_to":"d89d4f3f_ffcd53b8","updated":"2021-10-26 14:51:04.000000000","message":"Noted, thank you.","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ed2a1e6827e79165750e18cc163c0f0258f368f","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"----------------third commit----------------------------------------"},{"line_number":21,"context_line":"fix python style problem"},{"line_number":22,"context_line":"tox passed locally"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: If476fb1614a64320ed071bbda35e941bf3290a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dd716f7c_2355640c","line":22,"updated":"2021-10-21 10:50:55.000000000","message":"You don\u0027t need to track this information in the commit message: we have the history in Gerrit. Instead, try to write from the perspective of someone looking at git log many years later, trying to figure out what you did. Something like this, perhaps:\n\n  Switch the \u0027server backup\u0027 command to SDK\n\n  Switch this command from novaclient to SDK. As this is the first server-related\n  command that we are migrating, we need to extend our test fakes to support fake\n  Server resources.","commit_id":"445a7e81b77138f346cf98a458a4c8acf8e1b2e6"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"----------------third commit----------------------------------------"},{"line_number":21,"context_line":"fix python style problem"},{"line_number":22,"context_line":"tox passed locally"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: If476fb1614a64320ed071bbda35e941bf3290a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f1486e5c_38305c3b","line":22,"in_reply_to":"dd716f7c_2355640c","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"445a7e81b77138f346cf98a458a4c8acf8e1b2e6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch server backup to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Switch this command from novaclient to SDK. As this is the first server-telated"},{"line_number":10,"context_line":"  command that we are migrating, we need to extend our test fakes to support fake"},{"line_number":11,"context_line":"  Server resources. The extended fakes will replace the old ones once all command"},{"line_number":12,"context_line":"  -s related to server are switched."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"132e7a91_e699e9ad","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":2},"updated":"2021-10-21 17:06:46.000000000","message":"nit: You don\u0027t need this indentation","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch server backup to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Switch this command from novaclient to SDK. As this is the first server-telated"},{"line_number":10,"context_line":"  command that we are migrating, we need to extend our test fakes to support fake"},{"line_number":11,"context_line":"  Server resources. The extended fakes will replace the old ones once all command"},{"line_number":12,"context_line":"  -s related to server are switched."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"6c12dcfe_6973425e","line":9,"range":{"start_line":9,"start_character":74,"end_line":9,"end_character":81},"updated":"2021-10-21 17:06:46.000000000","message":"nit: related","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch server backup to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Switch this command from novaclient to SDK. As this is the first server-telated"},{"line_number":10,"context_line":"  command that we are migrating, we need to extend our test fakes to support fake"},{"line_number":11,"context_line":"  Server resources. The extended fakes will replace the old ones once all command"},{"line_number":12,"context_line":"  -s related to server are switched."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d4c620b8_4423d5e1","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":2},"in_reply_to":"132e7a91_e699e9ad","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch server backup to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Switch this command from novaclient to SDK. As this is the first server-telated"},{"line_number":10,"context_line":"  command that we are migrating, we need to extend our test fakes to support fake"},{"line_number":11,"context_line":"  Server resources. The extended fakes will replace the old ones once all command"},{"line_number":12,"context_line":"  -s related to server are switched."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"75feb53f_a7101cfc","line":9,"range":{"start_line":9,"start_character":74,"end_line":9,"end_character":81},"in_reply_to":"6c12dcfe_6973425e","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Switch this command from novaclient to SDK. As this is the first server-telated"},{"line_number":10,"context_line":"  command that we are migrating, we need to extend our test fakes to support fake"},{"line_number":11,"context_line":"  Server resources. The extended fakes will replace the old ones once all command"},{"line_number":12,"context_line":"  -s related to server are switched."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If476fb1614a64320ed071bbda35e941bf3290a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fd9648d_1a62e0bb","line":11,"updated":"2021-10-21 17:06:46.000000000","message":"nit: Can you wrap this text at \u003c\u003d 72 characters?","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Switch this command from novaclient to SDK. As this is the first server-telated"},{"line_number":10,"context_line":"  command that we are migrating, we need to extend our test fakes to support fake"},{"line_number":11,"context_line":"  Server resources. The extended fakes will replace the old ones once all command"},{"line_number":12,"context_line":"  -s related to server are switched."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If476fb1614a64320ed071bbda35e941bf3290a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9d0ade20_a17125d4","line":11,"in_reply_to":"9fd9648d_1a62e0bb","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  Switch this command from novaclient to SDK. As this is the first server-telated"},{"line_number":10,"context_line":"  command that we are migrating, we need to extend our test fakes to support fake"},{"line_number":11,"context_line":"  Server resources. The extended fakes will replace the old ones once all command"},{"line_number":12,"context_line":"  -s related to server are switched."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If476fb1614a64320ed071bbda35e941bf3290a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d6826028_63335296","line":12,"updated":"2021-10-21 17:06:46.000000000","message":"nit: don\u0027t do manually wrapping like this. Just drag the word to the next line:\n\nno:\n\n  command\n  -s\n\nyes:\n\n  commands","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  Switch this command from novaclient to SDK. As this is the first server-telated"},{"line_number":10,"context_line":"  command that we are migrating, we need to extend our test fakes to support fake"},{"line_number":11,"context_line":"  Server resources. The extended fakes will replace the old ones once all command"},{"line_number":12,"context_line":"  -s related to server are switched."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If476fb1614a64320ed071bbda35e941bf3290a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"13b9d7c3_e966d754","line":12,"in_reply_to":"d6826028_63335296","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"4c15f25b19f37724f62107e0bd8675e8d0963a9a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7fe8c7a0_5b8cbcc0","updated":"2021-10-18 01:36:31.000000000","message":"First code review of our team. It\u0027s more like a practice. \nPlease have a look and give us some comments and suggestions. Thank you so much.","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"c162a5fe68e55db501d78906d7b65e7e71cdea03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a2b4258_081eca24","updated":"2021-10-18 15:59:55.000000000","message":"Once first major issue is addressed review can be proceed","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"eca28b9d53d1d5bba5c574650029b7231cfa2662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a1d649c_ee025364","in_reply_to":"7fe8c7a0_5b8cbcc0","updated":"2021-10-28 23:47:10.000000000","message":"Done","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ed2a1e6827e79165750e18cc163c0f0258f368f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be3dbb5a_4bfe5aba","updated":"2021-10-21 10:50:55.000000000","message":"This looks pretty good. Couple of comments inline. Let me know if anything is unclear","commit_id":"445a7e81b77138f346cf98a458a4c8acf8e1b2e6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"61a03824_376e171a","updated":"2021-10-21 17:06:46.000000000","message":"Soooo close. There\u0027s still some nits on the commit message and some commented out code that should be removed. Can you address these, please?","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b360a4abf79a9099d5516d2353474ae43a277401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4e16d731_896ab078","updated":"2021-10-26 11:14:45.000000000","message":"Still needs some comments addressed from last time.\n\nCan you add a release note also? You can create one of these using the \u0027reno\u0027 tool. Either install reno locally like so:\n\n  $ pip install --user reno\n  $ reno new migrate-server-backup-to-sdk\n\nor use the \u0027venv\u0027 tox environment:\n \n  $ tox -e venv -- reno new migrate-server-backup-to-sdk\n\nThe former is probably faster if you\u0027re using reno regularly, but the latter is \"cleaner\" since you\u0027re not installing anything system wide. Your call. You could also create a virtualenv locally and install in there.\n\nOne additional question: how are you reworking these commits? I suspect you\u0027re doing it in the web UI, which is fine, but it can be faster to pull things down and work on them locally. For example, to correct an issue in the commit message:\n\n  git review -d 814332\n  git commit --amend\n  # make changes\n  git review -f\n\nNote that the \u0027-f\u0027 flag passed to git review means \"delete\" my local branch - you don\u0027t really need to keep local branches around once they\u0027re under review, since you can always pull the latest version from Gerrit if/when you need to rework something.","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ef1a514a_d631f109","in_reply_to":"4e16d731_896ab078","updated":"2021-10-26 14:51:04.000000000","message":"Thank you Stephen. I added the release note.","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cb68107516cb3aa3d9bf1048d343af531eff1744","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a4d48883_2d2c880d","updated":"2021-10-27 09:11:16.000000000","message":"I\u0027m just going to fix release note real quick and then I\u0027m +2","commit_id":"4b5849e2c44a088bba7330147eb20df2d5711af3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6cb2d30cbb35a619e04c7aa4ecc29be8b32a6b00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b0cd95af_61102348","updated":"2021-10-27 09:11:38.000000000","message":"Thank you!","commit_id":"57aad01886fe9d98210496a92d517aa067c049a1"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"609c8c55c3f39c868a5d2979d735fecae2daec95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"69d913a8_af50a53c","updated":"2021-10-27 12:45:59.000000000","message":"recheck","commit_id":"57aad01886fe9d98210496a92d517aa067c049a1"}],"openstackclient/tests/unit/compute/v2/fakes.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"c162a5fe68e55db501d78906d7b65e7e71cdea03","unresolved":true,"context_lines":[{"line_number":619,"context_line":"                                    loaded\u003dTrue)"},{"line_number":620,"context_line":"        return server"},{"line_number":621,"context_line":"        \"\"\""},{"line_number":622,"context_line":"        return server.Server(**server_info)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @staticmethod"},{"line_number":625,"context_line":"    def create_servers(attrs\u003dNone, methods\u003dNone, count\u003d2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"00f1e444_c6e5e9b2","line":622,"updated":"2021-10-18 15:59:55.000000000","message":"this would be great, but at the moment it breaks all other tests","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":619,"context_line":"                                    loaded\u003dTrue)"},{"line_number":620,"context_line":"        return server"},{"line_number":621,"context_line":"        \"\"\""},{"line_number":622,"context_line":"        return server.Server(**server_info)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @staticmethod"},{"line_number":625,"context_line":"    def create_servers(attrs\u003dNone, methods\u003dNone, count\u003d2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4fcfdb6b_607b87fd","line":622,"in_reply_to":"00f1e444_c6e5e9b2","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"d930cdfd945420fa178322d4fd4f55cddaaf6893"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        # Overwrite default attributes."},{"line_number":614,"context_line":"        server_info.update(attrs)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        server \u003d fakes.FakeResource(info\u003dcopy.deepcopy(server_info),"},{"line_number":617,"context_line":"                                    methods\u003dmethods,"},{"line_number":618,"context_line":"                                    loaded\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"d349c9b0_78095429","side":"PARENT","line":615,"updated":"2021-10-21 17:06:46.000000000","message":"nit: unrelated change","commit_id":"53debe7fe1978f661768a27430f646a288948ecc"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        # Overwrite default attributes."},{"line_number":614,"context_line":"        server_info.update(attrs)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        server \u003d fakes.FakeResource(info\u003dcopy.deepcopy(server_info),"},{"line_number":617,"context_line":"                                    methods\u003dmethods,"},{"line_number":618,"context_line":"                                    loaded\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"98494400_8446ea11","side":"PARENT","line":615,"in_reply_to":"d349c9b0_78095429","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"53debe7fe1978f661768a27430f646a288948ecc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b360a4abf79a9099d5516d2353474ae43a277401","unresolved":true,"context_lines":[{"line_number":642,"context_line":"    def create_one_sdk_server(attrs\u003dNone, methods\u003dNone):"},{"line_number":643,"context_line":"        \"\"\"Create a fake server for testing migration to sdk"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        :param Dictionary attrs:"},{"line_number":646,"context_line":"            A dictionary with all attributes"},{"line_number":647,"context_line":"        :param Dictionary methods:"},{"line_number":648,"context_line":"            A dictionary with all methods"}],"source_content_type":"text/x-python","patch_set":16,"id":"3357a6fd_379a648a","line":645,"range":{"start_line":645,"start_character":15,"end_line":645,"end_character":25},"updated":"2021-10-26 11:14:45.000000000","message":"nit:\n\n  dict\n\nthat\u0027s the Python name for these, as you can see in real code, e.g.\n\n  \u003e\u003e\u003e dict(a\u003d1)\n  {\u0027a\u0027: 1}\n  \u003e\u003e\u003e help(dict)\n  Help on class dict in module builtins:\n\n  ...","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":642,"context_line":"    def create_one_sdk_server(attrs\u003dNone, methods\u003dNone):"},{"line_number":643,"context_line":"        \"\"\"Create a fake server for testing migration to sdk"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        :param Dictionary attrs:"},{"line_number":646,"context_line":"            A dictionary with all attributes"},{"line_number":647,"context_line":"        :param Dictionary methods:"},{"line_number":648,"context_line":"            A dictionary with all methods"}],"source_content_type":"text/x-python","patch_set":16,"id":"3425d2d8_4513bdb5","line":645,"range":{"start_line":645,"start_character":15,"end_line":645,"end_character":25},"in_reply_to":"3357a6fd_379a648a","updated":"2021-10-26 14:51:04.000000000","message":"Done. I replaced all Dictionary in this file with dict.","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cb68107516cb3aa3d9bf1048d343af531eff1744","unresolved":false,"context_lines":[{"line_number":642,"context_line":"    def create_one_sdk_server(attrs\u003dNone, methods\u003dNone):"},{"line_number":643,"context_line":"        \"\"\"Create a fake server for testing migration to sdk"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        :param Dictionary attrs:"},{"line_number":646,"context_line":"            A dictionary with all attributes"},{"line_number":647,"context_line":"        :param Dictionary methods:"},{"line_number":648,"context_line":"            A dictionary with all methods"}],"source_content_type":"text/x-python","patch_set":16,"id":"acca2995_f79f677f","line":645,"range":{"start_line":645,"start_character":15,"end_line":645,"end_character":25},"in_reply_to":"3425d2d8_4513bdb5","updated":"2021-10-27 09:11:16.000000000","message":"Oh, apologies, I didn\u0027t realize you had copy-pasted it. Thanks for fixing the other mistakes!","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b360a4abf79a9099d5516d2353474ae43a277401","unresolved":true,"context_lines":[{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        :param Dictionary attrs:"},{"line_number":646,"context_line":"            A dictionary with all attributes"},{"line_number":647,"context_line":"        :param Dictionary methods:"},{"line_number":648,"context_line":"            A dictionary with all methods"},{"line_number":649,"context_line":"        :return:"},{"line_number":650,"context_line":"            A openstack.compute.v2.server.Server object,"}],"source_content_type":"text/x-python","patch_set":16,"id":"75ac8a7b_a35f5a04","line":647,"range":{"start_line":647,"start_character":15,"end_line":647,"end_character":25},"updated":"2021-10-26 11:14:45.000000000","message":"dict","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        :param Dictionary attrs:"},{"line_number":646,"context_line":"            A dictionary with all attributes"},{"line_number":647,"context_line":"        :param Dictionary methods:"},{"line_number":648,"context_line":"            A dictionary with all methods"},{"line_number":649,"context_line":"        :return:"},{"line_number":650,"context_line":"            A openstack.compute.v2.server.Server object,"}],"source_content_type":"text/x-python","patch_set":16,"id":"4c86adf5_894592f5","line":647,"range":{"start_line":647,"start_character":15,"end_line":647,"end_character":25},"in_reply_to":"75ac8a7b_a35f5a04","updated":"2021-10-26 14:51:04.000000000","message":"Done","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"}],"openstackclient/tests/unit/compute/v2/test_server_backup.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ed2a1e6827e79165750e18cc163c0f0258f368f","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        self.sdk_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # self.servers_mock \u003d self.app.client_manager.compute.servers"},{"line_number":36,"context_line":"        # self.servers_mock.reset_mock()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Get a shortcut to the image client ImageManager Mock"},{"line_number":39,"context_line":"        self.app.client_manager.sdk_connection.image \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"2917677d_4aa7ae15","line":36,"updated":"2021-10-21 10:50:55.000000000","message":"If this is no longer needed, can you remove it? It\u0027s in git history if we ever need it again. If you think you will need it again in the near future, please add a comment explaining why","commit_id":"445a7e81b77138f346cf98a458a4c8acf8e1b2e6"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.sdk_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # self.servers_mock \u003d self.app.client_manager.compute.servers"},{"line_number":36,"context_line":"        # self.servers_mock.reset_mock()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Get a shortcut to the image client ImageManager Mock"},{"line_number":39,"context_line":"        self.app.client_manager.sdk_connection.image \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7c5ffb4_91cc6264","line":36,"in_reply_to":"2917677d_4aa7ae15","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"445a7e81b77138f346cf98a458a4c8acf8e1b2e6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ed2a1e6827e79165750e18cc163c0f0258f368f","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        # self.servers_mock.get \u003d compute_fakes.FakeServer.get_servers("},{"line_number":59,"context_line":"        #     servers,"},{"line_number":60,"context_line":"        #     0,"},{"line_number":61,"context_line":"        # )"},{"line_number":62,"context_line":"        self.sdk_client.find_server \u003d compute_fakes.FakeServer.get_servers("},{"line_number":63,"context_line":"            servers,"},{"line_number":64,"context_line":"            0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"30429d8e_5fa18ce2","line":61,"updated":"2021-10-21 10:50:55.000000000","message":"Ditto. If this is no longer needed, you can remove it.","commit_id":"445a7e81b77138f346cf98a458a4c8acf8e1b2e6"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # self.servers_mock.get \u003d compute_fakes.FakeServer.get_servers("},{"line_number":59,"context_line":"        #     servers,"},{"line_number":60,"context_line":"        #     0,"},{"line_number":61,"context_line":"        # )"},{"line_number":62,"context_line":"        self.sdk_client.find_server \u003d compute_fakes.FakeServer.get_servers("},{"line_number":63,"context_line":"            servers,"},{"line_number":64,"context_line":"            0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6bae6e62_f41ee9a4","line":61,"in_reply_to":"30429d8e_5fa18ce2","updated":"2021-10-26 00:38:27.000000000","message":"Done","commit_id":"445a7e81b77138f346cf98a458a4c8acf8e1b2e6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # compute_client.backup_server("},{"line_number":136,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":137,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":138,"context_line":"            servers[0].id,"},{"line_number":139,"context_line":"            servers[0].name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"4212be04_a0dc384b","line":136,"updated":"2021-10-21 17:06:46.000000000","message":"Is this dead code now? Can you remove it?","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"934f8bf2f690bb52c8d2f0c13ded179f553f1409","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # compute_client.backup_server("},{"line_number":136,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":137,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":138,"context_line":"            servers[0].id,"},{"line_number":139,"context_line":"            servers[0].name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ea10d982_58d8c6f5","line":136,"in_reply_to":"4212be04_a0dc384b","updated":"2021-10-26 00:38:27.000000000","message":"Hi Stephen, thanks for the comments.\nAbout this one and the following ones, I think it\u0027s a reminder of which method is being called. It was there before. It\u0027s ServerManager.backup() before and compute_client.backup_server() now.\nI think it not necessary but it can help. Do you think we should remove it?","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # compute_client.backup_server("},{"line_number":136,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":137,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":138,"context_line":"            servers[0].id,"},{"line_number":139,"context_line":"            servers[0].name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"2ebcba6f_c034fa09","line":136,"in_reply_to":"960cb3a5_e6d32e59","updated":"2021-10-26 14:51:04.000000000","message":"noted, will remove it.","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13a28d245050a2b2117f17f000777e01cbef45c2","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # compute_client.backup_server("},{"line_number":136,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":137,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":138,"context_line":"            servers[0].id,"},{"line_number":139,"context_line":"            servers[0].name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"960cb3a5_e6d32e59","line":136,"in_reply_to":"ea10d982_58d8c6f5","updated":"2021-10-26 11:06:37.000000000","message":"Yes, you can remove this. If someone wants to see the change, they can use a combination of \u0027git log\u0027 and \u0027git blame\u0027.","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # compute_client.backup_server("},{"line_number":171,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":172,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":173,"context_line":"            servers[0].id,"},{"line_number":174,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"10dbe53f_31530242","line":171,"updated":"2021-10-21 17:06:46.000000000","message":"Ditto","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # compute_client.backup_server("},{"line_number":171,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":172,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":173,"context_line":"            servers[0].id,"},{"line_number":174,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bea88e59_2cf77e21","line":171,"in_reply_to":"10dbe53f_31530242","updated":"2021-10-26 14:51:04.000000000","message":"Done","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        )"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # compute_client.backup_server("},{"line_number":220,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":221,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":222,"context_line":"            servers[0].id,"},{"line_number":223,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc4ef4b_fcd50fa1","line":220,"updated":"2021-10-21 17:06:46.000000000","message":"ditto","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        )"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # compute_client.backup_server("},{"line_number":220,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":221,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":222,"context_line":"            servers[0].id,"},{"line_number":223,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7daf72ca_ba976bda","line":220,"in_reply_to":"5fc4ef4b_fcd50fa1","updated":"2021-10-26 14:51:04.000000000","message":"Done","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bff680e124678d889d130b7b3d3a559121d96fd","unresolved":true,"context_lines":[{"line_number":260,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # compute_client.backup_server("},{"line_number":263,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":264,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":265,"context_line":"            servers[0].id,"},{"line_number":266,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"71820369_800823bf","line":263,"updated":"2021-10-21 17:06:46.000000000","message":"ditto","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # compute_client.backup_server("},{"line_number":263,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":264,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":265,"context_line":"            servers[0].id,"},{"line_number":266,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"4c56009e_878ba827","line":263,"in_reply_to":"71820369_800823bf","updated":"2021-10-26 14:51:04.000000000","message":"Done","commit_id":"68ff960d3c2430c84f282f8d8ecc9715d43ed147"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b360a4abf79a9099d5516d2353474ae43a277401","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        )"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # compute_client.backup_server("},{"line_number":219,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":220,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":221,"context_line":"            servers[0].id,"},{"line_number":222,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"b6e1f62b_f8dda029","line":219,"updated":"2021-10-26 11:14:45.000000000","message":"nit: still needs to be removed","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        )"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # compute_client.backup_server("},{"line_number":219,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":220,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":221,"context_line":"            servers[0].id,"},{"line_number":222,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"da339881_160db80f","line":219,"in_reply_to":"b6e1f62b_f8dda029","updated":"2021-10-26 14:51:04.000000000","message":"Done","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b360a4abf79a9099d5516d2353474ae43a277401","unresolved":true,"context_lines":[{"line_number":259,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # compute_client.backup_server("},{"line_number":262,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":263,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":264,"context_line":"            servers[0].id,"},{"line_number":265,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"15108ade_424eba8e","line":262,"updated":"2021-10-26 11:14:45.000000000","message":"ditto","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"},{"author":{"_account_id":34041,"name":"Diwei Zhu","email":"zhu.diw@northeastern.edu","username":"DiweiZhu"},"change_message_id":"6053c5699925ea43e1500cd24dd8343aa7bcdccb","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # compute_client.backup_server("},{"line_number":262,"context_line":"        #     server, backup_name, backup_type, rotation)"},{"line_number":263,"context_line":"        self.sdk_client.backup_server.assert_called_with("},{"line_number":264,"context_line":"            servers[0].id,"},{"line_number":265,"context_line":"            \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"0a89b962_d33fb329","line":262,"in_reply_to":"15108ade_424eba8e","updated":"2021-10-26 14:51:04.000000000","message":"Done","commit_id":"2f7b80b28d0a4e4416aa63a750c93340c082274b"}],"releasenotes/notes/migrate-server-backup-to-sdk-0f170baf38e98b40.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cb68107516cb3aa3d9bf1048d343af531eff1744","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Migrate openstack server backup from novaclient to sdk."},{"line_number":5,"context_line":"    Temporary utility methods are added in tests/unit/compute/v2/fakes.py"},{"line_number":6,"context_line":"    to support fake resources for migrated method. These methods will"},{"line_number":7,"context_line":"    replace the olde ones once all server commands are migrated"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"63a8b40f_8bed7167","line":5,"updated":"2021-10-27 09:11:16.000000000","message":"IMO you can remove this and below. Release notes should be relevant to the target user. Information about project \"internals\" like tests or other tooling does not belong in a release note.","commit_id":"4b5849e2c44a088bba7330147eb20df2d5711af3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3dd2bb94dd719231e120450adb791ea3a4736910","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Migrate openstack server backup from novaclient to sdk."},{"line_number":5,"context_line":"    Temporary utility methods are added in tests/unit/compute/v2/fakes.py"},{"line_number":6,"context_line":"    to support fake resources for migrated method. These methods will"},{"line_number":7,"context_line":"    replace the olde ones once all server commands are migrated"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3171f33e_a9b617e4","line":5,"in_reply_to":"63a8b40f_8bed7167","updated":"2021-10-27 09:11:53.000000000","message":"Done","commit_id":"4b5849e2c44a088bba7330147eb20df2d5711af3"}]}