)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33aa90d5d44e55590c15691d62508ebc7c5618cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa18fd02_fec619cf","updated":"2021-11-25 17:07:49.000000000","message":"Can you add a release note? I\u0027m +2 once that\u0027s there. -1 is for the missing release note: everything else is at best a nit ","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89e423f0bf49a9f94b4cbf969afe0b89eb77f4db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8c6e024_3994790e","updated":"2021-11-25 14:34:58.000000000","message":"Hi fellow reviewers, if you have some time, please check this patch.","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44b1905b99d46d3fa7660526684ccf979ed6c972","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ccc32e6_2383317c","in_reply_to":"aa18fd02_fec619cf","updated":"2021-11-26 11:13:18.000000000","message":"Done","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96138959d41b303bd6580ddd204501888c7be2ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a73d096c_221c227f","updated":"2021-11-26 16:10:30.000000000","message":"One further nit inline","commit_id":"6e355d027f47eb57d0f0ff0e25a79b1a364a697a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"75158dbf585fa6e670e39c5b376afd597d4afd12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f444f94e_b92c3c31","updated":"2021-11-29 10:11:03.000000000","message":"Lovely!","commit_id":"b4efb3d5af782bd17340107b58349c1dcf066763"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b2f32931a00e2ff21743867cc7022fac24a68343","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"15ab7f51_37a124ac","updated":"2021-12-06 10:47:13.000000000","message":"recheck","commit_id":"c8c4f76498de3380c7cbf80c5dc800a588bed649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c4f8bcf765509b9ff49d001a148fb228d619120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1dbb3d92_a8c7a481","updated":"2021-12-09 17:21:34.000000000","message":"recheck","commit_id":"c8c4f76498de3380c7cbf80c5dc800a588bed649"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33aa90d5d44e55590c15691d62508ebc7c5618cb","unresolved":true,"context_lines":[{"line_number":613,"context_line":"        parser.add_argument("},{"line_number":614,"context_line":"            \u0027--security-group\u0027,"},{"line_number":615,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":616,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":617,"context_line":"        )"},{"line_number":618,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":619,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"d919dbdc_4cbb806a","line":616,"updated":"2021-11-25 17:07:49.000000000","message":"Do you want to allow users to specify this multiple times? You can use\n\n  action\u003d\u0027append\u0027,\n  dest\u003d\u0027security_groups\u0027,\n\nto allow this, if so","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3bb069b926e9f057c60bb6f843552429e4af12c8","unresolved":true,"context_lines":[{"line_number":613,"context_line":"        parser.add_argument("},{"line_number":614,"context_line":"            \u0027--security-group\u0027,"},{"line_number":615,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":616,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":617,"context_line":"        )"},{"line_number":618,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":619,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"ea340531_c10bbdc7","line":616,"range":{"start_line":616,"start_character":47,"end_line":616,"end_character":49},"updated":"2021-10-26 23:45:56.000000000","message":"nit: don\u0027t know if \u0027with\u0027 is better here","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33aa90d5d44e55590c15691d62508ebc7c5618cb","unresolved":true,"context_lines":[{"line_number":613,"context_line":"        parser.add_argument("},{"line_number":614,"context_line":"            \u0027--security-group\u0027,"},{"line_number":615,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":616,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":617,"context_line":"        )"},{"line_number":618,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":619,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"c024e6da_e336aa20","line":616,"range":{"start_line":616,"start_character":47,"end_line":616,"end_character":49},"in_reply_to":"1583b479_f4a2c66b","updated":"2021-11-25 17:07:49.000000000","message":"Yeah, \u0027with\u0027 would be nicer","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44b1905b99d46d3fa7660526684ccf979ed6c972","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        parser.add_argument("},{"line_number":614,"context_line":"            \u0027--security-group\u0027,"},{"line_number":615,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":616,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":617,"context_line":"        )"},{"line_number":618,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":619,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"f2e86703_2fff8622","line":616,"range":{"start_line":616,"start_character":47,"end_line":616,"end_character":49},"in_reply_to":"c024e6da_e336aa20","updated":"2021-11-26 11:13:18.000000000","message":"Done","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44b1905b99d46d3fa7660526684ccf979ed6c972","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        parser.add_argument("},{"line_number":614,"context_line":"            \u0027--security-group\u0027,"},{"line_number":615,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":616,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":617,"context_line":"        )"},{"line_number":618,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":619,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"4ef4603e_962038b7","line":616,"in_reply_to":"d919dbdc_4cbb806a","updated":"2021-11-26 11:13:18.000000000","message":"Done","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4472bd4ff5c76c79aaabe43d39d94a0befc59b21","unresolved":true,"context_lines":[{"line_number":613,"context_line":"        parser.add_argument("},{"line_number":614,"context_line":"            \u0027--security-group\u0027,"},{"line_number":615,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":616,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":617,"context_line":"        )"},{"line_number":618,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":619,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"1583b479_f4a2c66b","line":616,"range":{"start_line":616,"start_character":47,"end_line":616,"end_character":49},"in_reply_to":"ea340531_c10bbdc7","updated":"2021-10-28 09:46:51.000000000","message":"If I need to respin the patch, I\u0027ll change it.","commit_id":"7e028412d60017bc7e701cc9617ecb6a42223ef1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96138959d41b303bd6580ddd204501888c7be2ba","unresolved":true,"context_lines":[{"line_number":612,"context_line":"        )"},{"line_number":613,"context_line":"        parser.add_argument("},{"line_number":614,"context_line":"            \u0027--security-group\u0027,"},{"line_number":615,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":616,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":617,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":618,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"3e533085_01141192","line":615,"updated":"2021-11-26 16:10:30.000000000","message":"nit: If you add\n\n  dest\u003d\u0027security_groups\u0027\n\nthen you\u0027ll access \u0027parsed_args.security_groups\u0027 below, which seems a bit more sensible for a plural option","commit_id":"6e355d027f47eb57d0f0ff0e25a79b1a364a697a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a77a9a08475e74c97743801bec92330f81ebc512","unresolved":false,"context_lines":[{"line_number":612,"context_line":"        )"},{"line_number":613,"context_line":"        parser.add_argument("},{"line_number":614,"context_line":"            \u0027--security-group\u0027,"},{"line_number":615,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":616,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":617,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":618,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"3923529f_bf9c3c61","line":615,"in_reply_to":"3e533085_01141192","updated":"2021-11-26 18:07:40.000000000","message":"Done","commit_id":"6e355d027f47eb57d0f0ff0e25a79b1a364a697a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96138959d41b303bd6580ddd204501888c7be2ba","unresolved":true,"context_lines":[{"line_number":689,"context_line":"            filters[\u0027fixed_ips\u0027] \u003d _prepare_filter_fixed_ips("},{"line_number":690,"context_line":"                self.app.client_manager, parsed_args)"},{"line_number":691,"context_line":"        if parsed_args.security_group:"},{"line_number":692,"context_line":"            filters[\u0027security_groups\u0027] \u003d [parsed_args.security_group]"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        _tag.get_tag_filtering_args(parsed_args, filters)"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"31c0850b_cd5c248e","line":692,"range":{"start_line":692,"start_character":41,"end_line":692,"end_character":69},"updated":"2021-11-26 16:10:30.000000000","message":"If you\u0027re using \u0027append\u0027, then this will be either None or a list. You don\u0027t need to wrap it in another list","commit_id":"6e355d027f47eb57d0f0ff0e25a79b1a364a697a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a77a9a08475e74c97743801bec92330f81ebc512","unresolved":false,"context_lines":[{"line_number":689,"context_line":"            filters[\u0027fixed_ips\u0027] \u003d _prepare_filter_fixed_ips("},{"line_number":690,"context_line":"                self.app.client_manager, parsed_args)"},{"line_number":691,"context_line":"        if parsed_args.security_group:"},{"line_number":692,"context_line":"            filters[\u0027security_groups\u0027] \u003d [parsed_args.security_group]"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        _tag.get_tag_filtering_args(parsed_args, filters)"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"192aeabd_3bc5e23c","line":692,"range":{"start_line":692,"start_character":41,"end_line":692,"end_character":69},"in_reply_to":"31c0850b_cd5c248e","updated":"2021-11-26 18:07:40.000000000","message":"right!","commit_id":"6e355d027f47eb57d0f0ff0e25a79b1a364a697a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"78049bde367aef80dba96334c9cd8ba154a0a436","unresolved":true,"context_lines":[{"line_number":615,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":616,"context_line":"            dest\u003d\u0027security_groups\u0027,"},{"line_number":617,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":618,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":619,"context_line":"        )"},{"line_number":620,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":621,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"7e1b3372_51153fa2","line":618,"range":{"start_line":618,"start_character":47,"end_line":618,"end_character":49},"updated":"2021-11-29 15:49:01.000000000","message":"nit: didn\u0027t change to \u0027with\u0027 :(","commit_id":"b4efb3d5af782bd17340107b58349c1dcf066763"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f75e40bf4023452d877fd906463861a1e75d20c5","unresolved":false,"context_lines":[{"line_number":615,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":616,"context_line":"            dest\u003d\u0027security_groups\u0027,"},{"line_number":617,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":618,"context_line":"            help\u003d_(\"List only ports associated to this security group\")"},{"line_number":619,"context_line":"        )"},{"line_number":620,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":621,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"65d267ce_ea6e9703","line":618,"range":{"start_line":618,"start_character":47,"end_line":618,"end_character":49},"in_reply_to":"7e1b3372_51153fa2","updated":"2021-12-02 11:12:29.000000000","message":"Done","commit_id":"b4efb3d5af782bd17340107b58349c1dcf066763"}],"openstackclient/tests/unit/network/v2/test_port.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96138959d41b303bd6580ddd204501888c7be2ba","unresolved":true,"context_lines":[{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":1310,"context_line":"        filters \u003d {"},{"line_number":1311,"context_line":"            \u0027security_groups\u0027: [[\u0027sg-id1\u0027, \u0027sg-id2\u0027]],"},{"line_number":1312,"context_line":"            \u0027fields\u0027: LIST_FIELDS_TO_RETRIEVE,"},{"line_number":1313,"context_line":"        }"},{"line_number":1314,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"95d9f013_2f8b9070","line":1311,"updated":"2021-11-26 16:10:30.000000000","message":"Per comment in previous file, this shouldn\u0027t be doubly nested, right?","commit_id":"6e355d027f47eb57d0f0ff0e25a79b1a364a697a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a77a9a08475e74c97743801bec92330f81ebc512","unresolved":false,"context_lines":[{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":1310,"context_line":"        filters \u003d {"},{"line_number":1311,"context_line":"            \u0027security_groups\u0027: [[\u0027sg-id1\u0027, \u0027sg-id2\u0027]],"},{"line_number":1312,"context_line":"            \u0027fields\u0027: LIST_FIELDS_TO_RETRIEVE,"},{"line_number":1313,"context_line":"        }"},{"line_number":1314,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fb13571f_04939b14","line":1311,"in_reply_to":"95d9f013_2f8b9070","updated":"2021-11-26 18:07:40.000000000","message":"Exactly and I didn\u0027t know why that was happening.","commit_id":"6e355d027f47eb57d0f0ff0e25a79b1a364a697a"}]}