)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"08afabb938bf2e92728366c09aab688a83430ab7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"500f7a28_54a05bb0","updated":"2021-11-04 00:23:44.000000000","message":"Change itself makes sense.","commit_id":"442838ed158cd8fb4168877744a60de5cfca29cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a4a858b06d7fca290a9c74e7be6815e0c55f1142","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"254548d3_96a47210","updated":"2022-03-09 11:34:28.000000000","message":"This has been around for ages and is clearly correct. Let\u0027s get it in","commit_id":"442838ed158cd8fb4168877744a60de5cfca29cc"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"08afabb938bf2e92728366c09aab688a83430ab7","unresolved":true,"context_lines":[{"line_number":2973,"context_line":"    Note that it is not possible to show cold migrations or completed"},{"line_number":2974,"context_line":"    live-migrations. Use \u0027openstack server migration list\u0027 to get details for"},{"line_number":2975,"context_line":"    these."},{"line_number":2976,"context_line":"    \"\"\""},{"line_number":2977,"context_line":""},{"line_number":2978,"context_line":"    def get_parser(self, prog_name):"},{"line_number":2979,"context_line":"        parser \u003d super().get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d70b26c9_b10fc6f9","line":2976,"updated":"2021-11-04 00:23:44.000000000","message":"Feels weird to not test for this at all, though after looking at the cliff docs for Command and ShowOne, I can see why you haven\u0027t added anything for testing. It doesn\u0027t look like we have any established unit/local functional testing for commands\u0027 shell usage and it would be a lot of work to add it.\n\nWith that in mind, would it be worthwhile to at least do like:\n\n self.assertIsInstance(self.cmd, command.ShowOne)\n\nin TestServerMigrationShow [1] to verify the intention that this command needs to be a ShowOne command?\n\n[1] https://github.com/openstack/python-openstackclient/blob/f824e13bc5754d3de108d39d62de3d6cfae2670c/openstackclient/tests/unit/compute/v2/test_server.py#L5679","commit_id":"442838ed158cd8fb4168877744a60de5cfca29cc"}]}