)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dea14abef047b922df1d49fde532bad0836daa11","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ritvik Vinodkumar \u003cvinodkumar.r@northeastern.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-14 23:35:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch list server volume to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As far as I understand, VolumeAttachments is missing the field for \u0027BlockDeviceMapping UUID\u0027 in the SDK. As a result, one test case is failing. Would appreciate some feedback on how to resolve this!"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"4a170a16_f49dae4c","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":33},"updated":"2021-11-15 13:14:49.000000000","message":"nit: We don\u0027t tend to use trailing periods in commit message summaries","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":34060,"name":"Ritvik Vinodkumar","email":"vinodkumar.r@northeastern.edu","username":"ritvikvinod"},"change_message_id":"42f761cdf622c9060a2e4b32bbf8544b3c1ef804","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ritvik Vinodkumar \u003cvinodkumar.r@northeastern.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-14 23:35:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch list server volume to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As far as I understand, VolumeAttachments is missing the field for \u0027BlockDeviceMapping UUID\u0027 in the SDK. As a result, one test case is failing. Would appreciate some feedback on how to resolve this!"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"b885900d_d7ab6333","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":33},"in_reply_to":"4a170a16_f49dae4c","updated":"2021-11-24 01:43:22.000000000","message":"Done","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dea14abef047b922df1d49fde532bad0836daa11","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch list server volume to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As far as I understand, VolumeAttachments is missing the field for \u0027BlockDeviceMapping UUID\u0027 in the SDK. As a result, one test case is failing. Would appreciate some feedback on how to resolve this!"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Switch the server volume list command from novaclient to SDK. Use the SDK versions of test fakes to support fake Server resources"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"425e2731_41aa10db","line":9,"updated":"2021-11-15 13:14:49.000000000","message":"Yeah, you\u0027re missing [1]. This on the feature/r1 branch but that has not been merged into the master branch (we\u0027ll do that when we release openstacksdk 1.0).\n\nI don\u0027t know if there\u0027s much you can do to resolve this right now. We can either (a) wait for openstacksdk 1.0 to be released, or (b) keep calling novaclient if using 2.89, but add a TODO to remove that call once openstacksdk 1.0 is released. The former is far less complicated but means you need to wait a few weeks/months to merge this patch.\n\nLet\u0027s discuss this today.\n\n[1] https://github.com/openstack/openstacksdk/commit/ef587c9a021331f6407320b606a741719c90fafa","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63139c8f4edc760e691b9b8f8294a4d201662022","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch list server volume to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As far as I understand, VolumeAttachments is missing the field for \u0027BlockDeviceMapping UUID\u0027 in the SDK. As a result, one test case is failing. Would appreciate some feedback on how to resolve this!"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Switch the server volume list command from novaclient to SDK. Use the SDK versions of test fakes to support fake Server resources"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"d8982a24_51643d4c","line":9,"in_reply_to":"3bd45afb_a573ad78","updated":"2022-12-15 18:22:18.000000000","message":"Ack","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":34060,"name":"Ritvik Vinodkumar","email":"vinodkumar.r@northeastern.edu","username":"ritvikvinod"},"change_message_id":"42f761cdf622c9060a2e4b32bbf8544b3c1ef804","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch list server volume to sdk."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As far as I understand, VolumeAttachments is missing the field for \u0027BlockDeviceMapping UUID\u0027 in the SDK. As a result, one test case is failing. Would appreciate some feedback on how to resolve this!"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Switch the server volume list command from novaclient to SDK. Use the SDK versions of test fakes to support fake Server resources"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3bd45afb_a573ad78","line":9,"in_reply_to":"425e2731_41aa10db","updated":"2021-11-24 01:43:22.000000000","message":"I have made the change based on https://review.opendev.org/c/openstack/openstacksdk/+/817997. And added the Depends-On tag in the commit message","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dea14abef047b922df1d49fde532bad0836daa11","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As far as I understand, VolumeAttachments is missing the field for \u0027BlockDeviceMapping UUID\u0027 in the SDK. As a result, one test case is failing. Would appreciate some feedback on how to resolve this!"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Switch the server volume list command from novaclient to SDK. Use the SDK versions of test fakes to support fake Server resources"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5b4ab7d0275aec2e02451c5371319ac350af6a5f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fce606fd_155f7db4","line":11,"updated":"2021-11-15 13:14:49.000000000","message":"nit: wrap commit message bodies at \u003c\u003d 72 characters","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":34060,"name":"Ritvik Vinodkumar","email":"vinodkumar.r@northeastern.edu","username":"ritvikvinod"},"change_message_id":"42f761cdf622c9060a2e4b32bbf8544b3c1ef804","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As far as I understand, VolumeAttachments is missing the field for \u0027BlockDeviceMapping UUID\u0027 in the SDK. As a result, one test case is failing. Would appreciate some feedback on how to resolve this!"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Switch the server volume list command from novaclient to SDK. Use the SDK versions of test fakes to support fake Server resources"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5b4ab7d0275aec2e02451c5371319ac350af6a5f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"236d7ba2_9a426182","line":11,"in_reply_to":"fce606fd_155f7db4","updated":"2021-11-24 01:43:22.000000000","message":"Done","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dea14abef047b922df1d49fde532bad0836daa11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"96dfa6a0_c3848ad4","updated":"2021-11-15 13:14:49.000000000","message":"This is a very good effort, but I\u0027m afraid you might be running into limitations of openstacksdk here. I\u0027ve left a few comments but the summary is that openstacksdk is not complete here. You could invest some effort in fixing bugs in openstacksdk, but ultimately we\u0027ll need to get those changes included in a release for them to actually be usable.\n\nLet\u0027s discuss this during todays meeting to see if there\u0027s any way we could work around this.","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8803f28a4e3227aede85f0ef81f3b9c2a7335540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7c4c61ca_612f6173","updated":"2021-11-29 10:43:16.000000000","message":"I need to test this manually again. In any case, we can\u0027t merge this until [1] is merged and a new release of SDK has been cut\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/817997","commit_id":"f84e5115c02ed42d2642833e0acc1a65ab011f47"},{"author":{"_account_id":34060,"name":"Ritvik Vinodkumar","email":"vinodkumar.r@northeastern.edu","username":"ritvikvinod"},"change_message_id":"3c8f32232ab893e79a242bf97c4fc33905866356","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"4fe1af7e_75143e5d","updated":"2021-12-03 23:27:47.000000000","message":"recheck","commit_id":"f84e5115c02ed42d2642833e0acc1a65ab011f47"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5e49d673652c8d862ba520b186e60ce8221862b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2048863f_26e8de0a","updated":"2021-12-09 17:21:42.000000000","message":"recheck","commit_id":"9a6f6330f32a0052e962d0b8c55b418588860229"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e08e9213158f5d4c12cca122274f4c8e30c70e33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d6ff66ea_fe57619b","updated":"2021-12-09 17:21:39.000000000","message":"recheck","commit_id":"9a6f6330f32a0052e962d0b8c55b418588860229"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30eec1ed51d51c6f9f64336cd38820590c26875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"ded03715_6d6e76e8","updated":"2021-12-14 16:45:03.000000000","message":"I split the server volume update changes out to a separate patch to unblock this one. This looks good to me","commit_id":"629496c41737a217a3be9a2216ea6f89074a7e8f"}],"openstackclient/compute/v2/server_volume.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dea14abef047b922df1d49fde532bad0836daa11","unresolved":true,"context_lines":[{"line_number":74,"context_line":"            column_headers,"},{"line_number":75,"context_line":"            ("},{"line_number":76,"context_line":"                utils.get_item_properties("},{"line_number":77,"context_line":"                    s, columns, mixed_case_fields\u003d(\u0027server_id\u0027, \u0027volume_id\u0027)"},{"line_number":78,"context_line":"                ) for s in volumes"},{"line_number":79,"context_line":"            ),"},{"line_number":80,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"74141f1d_b3009273","line":77,"range":{"start_line":77,"start_character":31,"end_line":77,"end_character":76},"updated":"2021-11-15 13:14:49.000000000","message":"You don\u0027t need this anymore. Can you drop it? This option is needed because the \u0027get_item_properties\u0027 function does so normalization of the column names provided via column. This allows us to do e.g.\n\n    utils.get_item_properties(s, [\u0027Name\u0027, \u0027Updated At\u0027])\n\nwhere \u0027Name\u0027 and \u0027Updated At\u0027 are the human readable versions of the field names. The \u0027get_item_properties\u0027 function will automatically convert these to \u0027name\u0027 and \u0027updated_at\u0027. However, some clients (like novaclient here) return fields in camelCase rather than snake_case, and we need to avoid normalizing the camelCase field names (i.e. we should actually retrieve the \u0027serverId\u0027 field, rather than converting this to \u0027server_id\u0027). Since openstacksdk does the normalization for us, we shouldn\u0027t need this.","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":34060,"name":"Ritvik Vinodkumar","email":"vinodkumar.r@northeastern.edu","username":"ritvikvinod"},"change_message_id":"42f761cdf622c9060a2e4b32bbf8544b3c1ef804","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            column_headers,"},{"line_number":75,"context_line":"            ("},{"line_number":76,"context_line":"                utils.get_item_properties("},{"line_number":77,"context_line":"                    s, columns, mixed_case_fields\u003d(\u0027server_id\u0027, \u0027volume_id\u0027)"},{"line_number":78,"context_line":"                ) for s in volumes"},{"line_number":79,"context_line":"            ),"},{"line_number":80,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"7c4686d8_608768e8","line":77,"range":{"start_line":77,"start_character":31,"end_line":77,"end_character":76},"in_reply_to":"74141f1d_b3009273","updated":"2021-11-24 01:43:22.000000000","message":"Done","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dea14abef047b922df1d49fde532bad0836daa11","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                ignore_missing\u003dFalse"},{"line_number":133,"context_line":"            )"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            # NOTE(stephenfin): This may look silly, and that\u0027s because it is."},{"line_number":136,"context_line":"            # This API was originally used only for the swapping volumes, which"},{"line_number":137,"context_line":"            # is an internal operation that should only be done by"},{"line_number":138,"context_line":"            # orchestration software rather than a human. We\u0027re not going to"},{"line_number":139,"context_line":"            # expose that, but we are going to expose the ability to change the"},{"line_number":140,"context_line":"            # delete on termination behavior."},{"line_number":141,"context_line":"            # compute_client.volumes.update_server_volume("},{"line_number":142,"context_line":"            #    server.id,"},{"line_number":143,"context_line":"            #    parsed_args.volume,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1357dac2_c38bd98b","line":140,"range":{"start_line":135,"start_character":0,"end_line":140,"end_character":45},"updated":"2021-11-15 13:14:49.000000000","message":"This is not relevant for the openstacksdk implementation of this method and can be deleted. It was referring to the fact that we provided \u0027parsed_args.volume\u0027 twice to the \u0027update_server_volume\u0027 method below. That was required due to how it was implemented, as you can see here [1]\n\nLater: actually, per my comment below, I think the openstacksdk implementation is wrong here so perhaps it will eventually be called like this.\n\n[1] https://github.com/openstack/python-novaclient/blob/d3b4c01ea/novaclient/v2/volumes.py#L131-L133","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":34060,"name":"Ritvik Vinodkumar","email":"vinodkumar.r@northeastern.edu","username":"ritvikvinod"},"change_message_id":"42f761cdf622c9060a2e4b32bbf8544b3c1ef804","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                ignore_missing\u003dFalse"},{"line_number":133,"context_line":"            )"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            # NOTE(stephenfin): This may look silly, and that\u0027s because it is."},{"line_number":136,"context_line":"            # This API was originally used only for the swapping volumes, which"},{"line_number":137,"context_line":"            # is an internal operation that should only be done by"},{"line_number":138,"context_line":"            # orchestration software rather than a human. We\u0027re not going to"},{"line_number":139,"context_line":"            # expose that, but we are going to expose the ability to change the"},{"line_number":140,"context_line":"            # delete on termination behavior."},{"line_number":141,"context_line":"            # compute_client.volumes.update_server_volume("},{"line_number":142,"context_line":"            #    server.id,"},{"line_number":143,"context_line":"            #    parsed_args.volume,"}],"source_content_type":"text/x-python","patch_set":11,"id":"6dc0dcd1_a69eff90","line":140,"range":{"start_line":135,"start_character":0,"end_line":140,"end_character":45},"in_reply_to":"1357dac2_c38bd98b","updated":"2021-11-24 01:43:22.000000000","message":"Done","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dea14abef047b922df1d49fde532bad0836daa11","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            # orchestration software rather than a human. We\u0027re not going to"},{"line_number":139,"context_line":"            # expose that, but we are going to expose the ability to change the"},{"line_number":140,"context_line":"            # delete on termination behavior."},{"line_number":141,"context_line":"            # compute_client.volumes.update_server_volume("},{"line_number":142,"context_line":"            #    server.id,"},{"line_number":143,"context_line":"            #    parsed_args.volume,"},{"line_number":144,"context_line":"            #    parsed_args.volume,"},{"line_number":145,"context_line":"            #    delete_on_termination\u003dparsed_args.delete_on_termination,"},{"line_number":146,"context_line":"            # )"},{"line_number":147,"context_line":"            compute_client.update_volume_attachment("},{"line_number":148,"context_line":"                parsed_args.volume,"},{"line_number":149,"context_line":"                server.id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"c7fcfc0f_ec495093","line":146,"range":{"start_line":141,"start_character":0,"end_line":146,"end_character":15},"updated":"2021-11-15 13:14:49.000000000","message":"Drop this. It\u0027s in git history if we ever need it back","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":34060,"name":"Ritvik Vinodkumar","email":"vinodkumar.r@northeastern.edu","username":"ritvikvinod"},"change_message_id":"42f761cdf622c9060a2e4b32bbf8544b3c1ef804","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            # orchestration software rather than a human. We\u0027re not going to"},{"line_number":139,"context_line":"            # expose that, but we are going to expose the ability to change the"},{"line_number":140,"context_line":"            # delete on termination behavior."},{"line_number":141,"context_line":"            # compute_client.volumes.update_server_volume("},{"line_number":142,"context_line":"            #    server.id,"},{"line_number":143,"context_line":"            #    parsed_args.volume,"},{"line_number":144,"context_line":"            #    parsed_args.volume,"},{"line_number":145,"context_line":"            #    delete_on_termination\u003dparsed_args.delete_on_termination,"},{"line_number":146,"context_line":"            # )"},{"line_number":147,"context_line":"            compute_client.update_volume_attachment("},{"line_number":148,"context_line":"                parsed_args.volume,"},{"line_number":149,"context_line":"                server.id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"a57509dc_ec1190e3","line":146,"range":{"start_line":141,"start_character":0,"end_line":146,"end_character":15},"in_reply_to":"c7fcfc0f_ec495093","updated":"2021-11-24 01:43:22.000000000","message":"Done","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dea14abef047b922df1d49fde532bad0836daa11","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            #    parsed_args.volume,"},{"line_number":145,"context_line":"            #    delete_on_termination\u003dparsed_args.delete_on_termination,"},{"line_number":146,"context_line":"            # )"},{"line_number":147,"context_line":"            compute_client.update_volume_attachment("},{"line_number":148,"context_line":"                parsed_args.volume,"},{"line_number":149,"context_line":"                server.id,"},{"line_number":150,"context_line":"                delete_on_termination\u003dparsed_args.delete_on_termination"}],"source_content_type":"text/x-python","patch_set":11,"id":"88ad48d1_57539b3a","line":147,"updated":"2021-11-15 13:14:49.000000000","message":"I don\u0027t think this will work currently. Looking at [1], we can see that we aren\u0027t actually using the \u0027attr\u0027 variable passed in (this would be the \u0027delete_on_termination\u0027 flag). I suspect that method is broken and will need fixes. You\u0027ll figure that out very quickly if you play around with this on a real devstack deployment.\n\n[1] https://github.com/openstack/openstacksdk/blob/0948ee52dd/openstack/compute/v2/_proxy.py#L1613-L1615","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63139c8f4edc760e691b9b8f8294a4d201662022","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            #    parsed_args.volume,"},{"line_number":145,"context_line":"            #    delete_on_termination\u003dparsed_args.delete_on_termination,"},{"line_number":146,"context_line":"            # )"},{"line_number":147,"context_line":"            compute_client.update_volume_attachment("},{"line_number":148,"context_line":"                parsed_args.volume,"},{"line_number":149,"context_line":"                server.id,"},{"line_number":150,"context_line":"                delete_on_termination\u003dparsed_args.delete_on_termination"}],"source_content_type":"text/x-python","patch_set":11,"id":"d561e5d1_fbe453cd","line":147,"in_reply_to":"3832267e_cc183a75","updated":"2022-12-15 18:22:18.000000000","message":"Fixed","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":34060,"name":"Ritvik Vinodkumar","email":"vinodkumar.r@northeastern.edu","username":"ritvikvinod"},"change_message_id":"42f761cdf622c9060a2e4b32bbf8544b3c1ef804","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            #    parsed_args.volume,"},{"line_number":145,"context_line":"            #    delete_on_termination\u003dparsed_args.delete_on_termination,"},{"line_number":146,"context_line":"            # )"},{"line_number":147,"context_line":"            compute_client.update_volume_attachment("},{"line_number":148,"context_line":"                parsed_args.volume,"},{"line_number":149,"context_line":"                server.id,"},{"line_number":150,"context_line":"                delete_on_termination\u003dparsed_args.delete_on_termination"}],"source_content_type":"text/x-python","patch_set":11,"id":"3832267e_cc183a75","line":147,"in_reply_to":"88ad48d1_57539b3a","updated":"2021-11-24 01:43:22.000000000","message":"As far I understood, in the nova implementation of updating server volume, we were swapping a volume attachment with another volume attachment. And the update command allowed us to only update the \u0027delete_on_termination\u0027 field. Not sure if what I understood is wrong here. I found this from the note in [2]\n\nIt looks like passing **attrs as an additional parameter in [1] should work for achieving the delete_on_termination update in the nova implementation. However, this also exposes the ability for the user to update other fields in the volume attachment (like attachment_id, tag etc.). I am not sure if this is the desired functionality for this command. \n\n[1] https://github.com/openstack/openstacksdk/blob/0948ee52dd/openstack/compute/v2/_proxy.py#L1613-L1615\n[2] https://docs.openstack.org/api-ref/compute/?expanded\u003dcreate-server-back-up-createbackup-action-detail,update-a-volume-attachment-detail#update-a-volume-attachment","commit_id":"1437d29a81a4cb6dc28a26492e82e44e5e383a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"565dd77996e0c4b4f6f700b9e8de9deb8a3fea90","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    s, columns"},{"line_number":78,"context_line":"                ) for s in volumes"},{"line_number":79,"context_line":"            ),"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class UpdateServerVolume(command.Command):"}],"source_content_type":"text/x-python","patch_set":18,"id":"460878c9_3f87abb9","line":80,"updated":"2021-12-14 16:44:33.000000000","message":"This works for me with various microversions 👍","commit_id":"9a6f6330f32a0052e962d0b8c55b418588860229"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"565dd77996e0c4b4f6f700b9e8de9deb8a3fea90","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                parsed_args.volume,"},{"line_number":137,"context_line":"                server.id,"},{"line_number":138,"context_line":"                delete_on_termination\u003dparsed_args.delete_on_termination"},{"line_number":139,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":18,"id":"ac117266_3850acb5","line":139,"updated":"2021-12-14 16:44:33.000000000","message":"This is failing for me with the following error:\n\n  The commit method is not supported for openstack.compute.v2.volume_attachment.VolumeAttachment\n\nOn the face of it, this is because we need to set \u0027allow_commit \u003d True\u0027 on this resource, but I suspect there\u0027s more to this than just that. We should split this change in two to avoid blocking the above.","commit_id":"9a6f6330f32a0052e962d0b8c55b418588860229"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41be9d32a9d64c3b1f9f447c3149aaf4256e4113","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                parsed_args.volume,"},{"line_number":137,"context_line":"                server.id,"},{"line_number":138,"context_line":"                delete_on_termination\u003dparsed_args.delete_on_termination"},{"line_number":139,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":18,"id":"5bcf3aaf_57119735","line":139,"in_reply_to":"ac117266_3850acb5","updated":"2022-12-15 18:22:30.000000000","message":"Done","commit_id":"9a6f6330f32a0052e962d0b8c55b418588860229"}]}