)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"61492d52d6a8a41c8b32b6ac59f0bebd2a5b85d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a50dd138_f9e22c20","updated":"2021-11-13 17:32:18.000000000","message":"I noticed there are quite a few merge conflicts from unrelated patchsets and I\u0027m not sure what the best way to resolve all of them is.","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"38a233738d1dbd72b6e7661ea975d7514d21bdd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"28d3326d_08578546","updated":"2021-11-15 12:44:19.000000000","message":"Very soft -1. This is basically good to go but some of the test logic is a bit weird. If you can address that, I\u0027m +2","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40445b106ab1ca3c7e68a90418db1910999047a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87b420fa_cca0a42a","in_reply_to":"a50dd138_f9e22c20","updated":"2021-11-15 12:35:09.000000000","message":"That\u0027s not your issue. Those changes are potential merge conflicts. They\u0027ll only become an issue once changes merge. You could stack some changes if you wanted them to go in in a particular order or wanted to collaborate on a larger feature with someone (i.e. you agree that \"Joe\" can land his series before yours), but that\u0027s rare and in general it\u0027s a case of first come, first served: the first patch in wins and everyone else has to resolve the merge conflicts and resubmit","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"88e64dfe4d6bed9946203c8593fe5309a36bd572","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15092e7e_8bafa5ec","updated":"2021-11-17 09:48:19.000000000","message":"I have a nit in the release note but nothing worth blocking on. Nice work here 👍","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d880d7bce9af09cbd45f0ca2df13cec019c9119a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afff4241_4fd1c35c","updated":"2021-11-19 16:38:11.000000000","message":"Ignore my suggestion to use \u0027Server.(un)pause\u0027 - if you can add \u0027ignore_missing\u003dFalse\u0027 then I\u0027m +2","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cb425a5f99b7a8566530b6616c075ba291c799f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3b6bdfd3_21fdb7f6","updated":"2021-11-17 09:55:41.000000000","message":"Let\u0027s add the missing \u0027ignore_missing\u0027 parameter and maybe address the nit on the release note while we\u0027re at it. The other comment about using Server methods rather than proxy methods can be ignored if you like since it\u0027s at best a nice-to-have.","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"701789c8f386563062d62032e96d9327d661b92f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57e86920_94edf452","updated":"2021-11-17 00:09:58.000000000","message":"Ready for review.","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"ce0f6008c4e70fa049b2f03429dc8d1112f79022","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f1311a2a_79edc9a9","updated":"2021-11-17 19:09:06.000000000","message":"Seemed simpler to use `pause_server(server/id)`.\nOr do you reckon I ought to get a session object and use pause()? I\u0027m not sure how to do that.","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"1ce4ef13068587f2d8b217e4a1a5b940c3ba182f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f6641d5_3e94baed","in_reply_to":"169710f5_8ecfc265","updated":"2021-11-20 06:21:50.000000000","message":"Done.","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"1ce4ef13068587f2d8b217e4a1a5b940c3ba182f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba705fad_981597ee","in_reply_to":"afff4241_4fd1c35c","updated":"2021-11-20 06:21:50.000000000","message":"Done. Also wrapped the release note at 79 char.","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d880d7bce9af09cbd45f0ca2df13cec019c9119a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"169710f5_8ecfc265","in_reply_to":"f1311a2a_79edc9a9","updated":"2021-11-19 16:38:11.000000000","message":"Actually, that\u0027s a good point. We can get that info but let\u0027s continue using the proxy method as you\u0027ve done","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"1ce4ef13068587f2d8b217e4a1a5b940c3ba182f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c8235ccc_4be00645","updated":"2021-11-20 06:21:50.000000000","message":"Done and done.","commit_id":"285258576d5e19a51dd1eb3c29b57d679ae395dc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a1e23670a80f04597fb36bed1743bd94b13afff7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3514c8cc_ef7774c4","updated":"2021-11-29 10:12:29.000000000","message":"Thanks, I\u0027m happy with this now. Nice work here!","commit_id":"c59edd928f7f391857ea2e60edd1e8af446c9be3"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"3efba74fcebe09d68f3370a76049e6fb5003829d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bd1caf6f_d2d29312","updated":"2021-11-29 16:52:34.000000000","message":"Looking for reviews after adding trailing commas.","commit_id":"b515fe61b27408e78639da8abb3acaa485ebca4e"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cb425a5f99b7a8566530b6616c075ba291c799f2","unresolved":true,"context_lines":[{"line_number":3138,"context_line":"        compute_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":3139,"context_line":"        for server in parsed_args.server:"},{"line_number":3140,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":3141,"context_line":"                server"},{"line_number":3142,"context_line":"            ).id"},{"line_number":3143,"context_line":"            compute_client.pause_server(server_id)"},{"line_number":3144,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6e147907_64164999","line":3141,"updated":"2021-11-17 09:55:41.000000000","message":"Oh, wait, you need to pass \u0027ignore_missing\u003dFalse\u0027 otherwise there\u0027s a chance this will fail /o\\","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a1e23670a80f04597fb36bed1743bd94b13afff7","unresolved":false,"context_lines":[{"line_number":3138,"context_line":"        compute_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":3139,"context_line":"        for server in parsed_args.server:"},{"line_number":3140,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":3141,"context_line":"                server"},{"line_number":3142,"context_line":"            ).id"},{"line_number":3143,"context_line":"            compute_client.pause_server(server_id)"},{"line_number":3144,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"41a21a87_986fe2ca","line":3141,"in_reply_to":"6e147907_64164999","updated":"2021-11-29 10:12:29.000000000","message":"This is done in PS3","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"88e64dfe4d6bed9946203c8593fe5309a36bd572","unresolved":true,"context_lines":[{"line_number":3140,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":3141,"context_line":"                server"},{"line_number":3142,"context_line":"            ).id"},{"line_number":3143,"context_line":"            compute_client.pause_server(server_id)"},{"line_number":3144,"context_line":""},{"line_number":3145,"context_line":""},{"line_number":3146,"context_line":"class RebootServer(command.Command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"835dc172_83c0c5ad","line":3143,"updated":"2021-11-17 09:48:19.000000000","message":"FYI, I think you can do this without invoking the proxy layer. The individual \u0027server\u0027 objects have a \u0027pause\u0027 method you could call:\n\n  compute_client.find_server(server).pause()\n\nThis might have actually made your mocking in tests a little easier, so apologies for not thinking of it sooner.","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"ce0f6008c4e70fa049b2f03429dc8d1112f79022","unresolved":true,"context_lines":[{"line_number":3140,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":3141,"context_line":"                server"},{"line_number":3142,"context_line":"            ).id"},{"line_number":3143,"context_line":"            compute_client.pause_server(server_id)"},{"line_number":3144,"context_line":""},{"line_number":3145,"context_line":""},{"line_number":3146,"context_line":"class RebootServer(command.Command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"d0249f9b_3d8c0caa","line":3143,"in_reply_to":"835dc172_83c0c5ad","updated":"2021-11-17 19:09:06.000000000","message":"This seems to require the session.\n`pause() missing 1 required positional argument: \u0027session\u0027`\n\n[1] https://docs.openstack.org/openstacksdk/latest/user/proxies/compute.html","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d880d7bce9af09cbd45f0ca2df13cec019c9119a","unresolved":false,"context_lines":[{"line_number":3140,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":3141,"context_line":"                server"},{"line_number":3142,"context_line":"            ).id"},{"line_number":3143,"context_line":"            compute_client.pause_server(server_id)"},{"line_number":3144,"context_line":""},{"line_number":3145,"context_line":""},{"line_number":3146,"context_line":"class RebootServer(command.Command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2840d535_5a6e164c","line":3143,"in_reply_to":"d0249f9b_3d8c0caa","updated":"2021-11-19 16:38:11.000000000","message":"Yup, fair point. Let\u0027s keep using the proxy layer","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"}],"openstackclient/tests/unit/compute/v2/test_server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"38a233738d1dbd72b6e7661ea975d7514d21bdd7","unresolved":false,"context_lines":[{"line_number":8231,"context_line":"        }"},{"line_number":8232,"context_line":""},{"line_number":8233,"context_line":"    def test_server_unpause_one_server(self):"},{"line_number":8234,"context_line":"        self.run_method_with_servers(\u0027unpause\u0027, 1)"},{"line_number":8235,"context_line":""},{"line_number":8236,"context_line":"    def test_server_unpause_multi_servers(self):"},{"line_number":8237,"context_line":"        self.run_method_with_servers(\u0027unpause\u0027, 3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3758ebed_c84b92cf","side":"PARENT","line":8234,"updated":"2021-11-15 12:44:19.000000000","message":"nit: it would probably have been better to reimplement this method to support the SDK (i.e. \u0027run_method_with_sdk_servers\u0027) since it\u0027s intended to minimize duplication among these otherwise very similar tests. What you\u0027ve done does work though","commit_id":"163cb01e46fc3f906154a7045fdbe9342cd446c7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"38a233738d1dbd72b6e7661ea975d7514d21bdd7","unresolved":true,"context_lines":[{"line_number":6006,"context_line":"    def test_server_pause_one_server(self):"},{"line_number":6007,"context_line":"        servers \u003d self.setup_sdk_servers_mock(count\u003d1)"},{"line_number":6008,"context_line":""},{"line_number":6009,"context_line":"        arglist \u003d []"},{"line_number":6010,"context_line":"        verifylist \u003d []"},{"line_number":6011,"context_line":""},{"line_number":6012,"context_line":"        arglist.append(servers[0].id)"},{"line_number":6013,"context_line":"        verifylist \u003d ["},{"line_number":6014,"context_line":"            (\u0027server\u0027, arglist),"},{"line_number":6015,"context_line":"        ]"},{"line_number":6016,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":6017,"context_line":""},{"line_number":6018,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f2c4a955_e8152d2d","line":6015,"range":{"start_line":6009,"start_character":0,"end_line":6015,"end_character":9},"updated":"2021-11-15 12:44:19.000000000","message":"This is weird. Why do this? You can simply do:\n\n  arglist \u003d [\n    servers[0].id,\n  ]\n  verifylist \u003d [\n      (\u0027server\u0027, arglist),\n  ]","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"701789c8f386563062d62032e96d9327d661b92f","unresolved":false,"context_lines":[{"line_number":6006,"context_line":"    def test_server_pause_one_server(self):"},{"line_number":6007,"context_line":"        servers \u003d self.setup_sdk_servers_mock(count\u003d1)"},{"line_number":6008,"context_line":""},{"line_number":6009,"context_line":"        arglist \u003d []"},{"line_number":6010,"context_line":"        verifylist \u003d []"},{"line_number":6011,"context_line":""},{"line_number":6012,"context_line":"        arglist.append(servers[0].id)"},{"line_number":6013,"context_line":"        verifylist \u003d ["},{"line_number":6014,"context_line":"            (\u0027server\u0027, arglist),"},{"line_number":6015,"context_line":"        ]"},{"line_number":6016,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":6017,"context_line":""},{"line_number":6018,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"62fb71df_66772814","line":6015,"range":{"start_line":6009,"start_character":0,"end_line":6015,"end_character":9},"in_reply_to":"f2c4a955_e8152d2d","updated":"2021-11-17 00:09:58.000000000","message":"Consolidated this test within `run_method_with_sdk_servers()`.","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"38a233738d1dbd72b6e7661ea975d7514d21bdd7","unresolved":true,"context_lines":[{"line_number":6023,"context_line":"    def test_server_pause_multi_servers(self):"},{"line_number":6024,"context_line":"        servers \u003d self.setup_sdk_servers_mock(count\u003d3)"},{"line_number":6025,"context_line":""},{"line_number":6026,"context_line":"        arglist \u003d []"},{"line_number":6027,"context_line":"        verifylist \u003d []"},{"line_number":6028,"context_line":""},{"line_number":6029,"context_line":"        for s in servers:"},{"line_number":6030,"context_line":"            arglist.append(s.id)"},{"line_number":6031,"context_line":"        verifylist \u003d ["},{"line_number":6032,"context_line":"            (\u0027server\u0027, arglist),"},{"line_number":6033,"context_line":"        ]"},{"line_number":6034,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":6035,"context_line":""},{"line_number":6036,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b02024cb_4f25818d","line":6033,"range":{"start_line":6026,"start_character":0,"end_line":6033,"end_character":9},"updated":"2021-11-15 12:44:19.000000000","message":"ditto. Just do:\n\n  arglist \u003d [s.id for s in servers]\n  verifylist \u003d [\n      (\u0027server\u0027, arglist),\n  ]\n\nor, if you wanted to be explicit for some reason\n\n  arglist \u003d [\n      servers[0].id,\n      servers[1].id,\n      servers[2].id,\n  ]\n  verifylist \u003d [\n      (\u0027server\u0027, arglist),\n  ]","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"701789c8f386563062d62032e96d9327d661b92f","unresolved":false,"context_lines":[{"line_number":6023,"context_line":"    def test_server_pause_multi_servers(self):"},{"line_number":6024,"context_line":"        servers \u003d self.setup_sdk_servers_mock(count\u003d3)"},{"line_number":6025,"context_line":""},{"line_number":6026,"context_line":"        arglist \u003d []"},{"line_number":6027,"context_line":"        verifylist \u003d []"},{"line_number":6028,"context_line":""},{"line_number":6029,"context_line":"        for s in servers:"},{"line_number":6030,"context_line":"            arglist.append(s.id)"},{"line_number":6031,"context_line":"        verifylist \u003d ["},{"line_number":6032,"context_line":"            (\u0027server\u0027, arglist),"},{"line_number":6033,"context_line":"        ]"},{"line_number":6034,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":6035,"context_line":""},{"line_number":6036,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d449cba0_74a5215d","line":6033,"range":{"start_line":6026,"start_character":0,"end_line":6033,"end_character":9},"in_reply_to":"b02024cb_4f25818d","updated":"2021-11-17 00:09:58.000000000","message":"Done within `run_method_with_sdk_servers()`.","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"38a233738d1dbd72b6e7661ea975d7514d21bdd7","unresolved":true,"context_lines":[{"line_number":6035,"context_line":""},{"line_number":6036,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":6037,"context_line":""},{"line_number":6038,"context_line":"        calls \u003d []"},{"line_number":6039,"context_line":"        for s in servers:"},{"line_number":6040,"context_line":"            calls.append(call(s.id))"},{"line_number":6041,"context_line":"        self.sdk_client.pause_server.assert_has_calls(calls)"},{"line_number":6042,"context_line":"        self.assertIsNone(result)"},{"line_number":6043,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6e5f5f11_17d236fc","line":6040,"range":{"start_line":6038,"start_character":0,"end_line":6040,"end_character":36},"updated":"2021-11-15 12:44:19.000000000","message":"nit:\n\n  calls \u003d [call(s.id) for s in servers]","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"701789c8f386563062d62032e96d9327d661b92f","unresolved":false,"context_lines":[{"line_number":6035,"context_line":""},{"line_number":6036,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":6037,"context_line":""},{"line_number":6038,"context_line":"        calls \u003d []"},{"line_number":6039,"context_line":"        for s in servers:"},{"line_number":6040,"context_line":"            calls.append(call(s.id))"},{"line_number":6041,"context_line":"        self.sdk_client.pause_server.assert_has_calls(calls)"},{"line_number":6042,"context_line":"        self.assertIsNone(result)"},{"line_number":6043,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ba0e691_e13bc764","line":6040,"range":{"start_line":6038,"start_character":0,"end_line":6040,"end_character":36},"in_reply_to":"6e5f5f11_17d236fc","updated":"2021-11-17 00:09:58.000000000","message":"Done within `run_method_with_sdk_servers()`.","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"38a233738d1dbd72b6e7661ea975d7514d21bdd7","unresolved":true,"context_lines":[{"line_number":8284,"context_line":"    def test_server_unpause_one_server(self):"},{"line_number":8285,"context_line":"        servers \u003d self.setup_sdk_servers_mock(count\u003d1)"},{"line_number":8286,"context_line":""},{"line_number":8287,"context_line":"        arglist \u003d []"},{"line_number":8288,"context_line":"        verifylist \u003d []"},{"line_number":8289,"context_line":""},{"line_number":8290,"context_line":"        arglist.append(servers[0].id)"},{"line_number":8291,"context_line":"        verifylist \u003d ["},{"line_number":8292,"context_line":"            (\u0027server\u0027, arglist),"},{"line_number":8293,"context_line":"        ]"},{"line_number":8294,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":8295,"context_line":""},{"line_number":8296,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d41adb1a_f3df998a","line":8293,"range":{"start_line":8287,"start_character":0,"end_line":8293,"end_character":9},"updated":"2021-11-15 12:44:19.000000000","message":"Ditto","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"701789c8f386563062d62032e96d9327d661b92f","unresolved":false,"context_lines":[{"line_number":8284,"context_line":"    def test_server_unpause_one_server(self):"},{"line_number":8285,"context_line":"        servers \u003d self.setup_sdk_servers_mock(count\u003d1)"},{"line_number":8286,"context_line":""},{"line_number":8287,"context_line":"        arglist \u003d []"},{"line_number":8288,"context_line":"        verifylist \u003d []"},{"line_number":8289,"context_line":""},{"line_number":8290,"context_line":"        arglist.append(servers[0].id)"},{"line_number":8291,"context_line":"        verifylist \u003d ["},{"line_number":8292,"context_line":"            (\u0027server\u0027, arglist),"},{"line_number":8293,"context_line":"        ]"},{"line_number":8294,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":8295,"context_line":""},{"line_number":8296,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f9af119_e5818e6e","line":8293,"range":{"start_line":8287,"start_character":0,"end_line":8293,"end_character":9},"in_reply_to":"d41adb1a_f3df998a","updated":"2021-11-17 00:09:58.000000000","message":"Done within `run_method_with_sdk_servers()`.","commit_id":"83843eb289ef993945582925728c79987e0b8a26"}],"releasenotes/notes/migrate-server-pause-unpause-to-sdk-d74ec8536b764af6.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"38a233738d1dbd72b6e7661ea975d7514d21bdd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Migrate ``server pause`` and ``server unpause`` commands from novaclient to sdk."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"19f5a048_6af48746","line":1,"updated":"2021-11-15 12:44:19.000000000","message":"Missing newline here. See my comments on [1]\n\n[1] https://review.opendev.org/c/openstack/python-openstackclient/+/815913/3/releasenotes/notes/migrate-create-server-image-to-sdk-e3d8077ffe05bb3d.yaml","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"701789c8f386563062d62032e96d9327d661b92f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Migrate ``server pause`` and ``server unpause`` commands from novaclient to sdk."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4101927e_dda42517","line":1,"in_reply_to":"19f5a048_6af48746","updated":"2021-11-17 00:09:58.000000000","message":"Looks like I missed this once again since I\u0027m not using vim. This time I\u0027ve applied the IDE equivalent setting from [1].\n\n[1] https://thoughtbot.com/blog/no-newline-at-end-of-file","commit_id":"83843eb289ef993945582925728c79987e0b8a26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"88e64dfe4d6bed9946203c8593fe5309a36bd572","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Migrate ``server pause`` and ``server unpause`` commands from novaclient to sdk."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8e2070e5_cf33f8f2","line":4,"updated":"2021-11-17 09:48:19.000000000","message":"nit: can you try to wrap these at \u003c\u003d 79 characters. If you\u0027re using vim, you can set this using \u0027:set textwidth\u003d79\u0027 in command (not insert) mode","commit_id":"73fa54daeff21f99ef16820c75e2e9f79b198985"}]}