)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a2ef20536032fb77a6abb09f25ac4bf2b1a4901","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ba24d7c_e02b0ce5","updated":"2021-11-15 12:42:24.000000000","message":"Another very soft -1","commit_id":"920e3554a4f14935bf17d0159a3a8298a37981c5"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"427d0f19083ff9becb173402011a46dbb6d53d66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1aa5b14b_ddc6b113","updated":"2021-11-13 23:32:21.000000000","message":"Stacked changes on top of 817853.\n(817853: Switch server pause and server unpause to SDK)","commit_id":"920e3554a4f14935bf17d0159a3a8298a37981c5"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"c765686f86219051ffa6dda01691f74066a3c986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c31c3e3_d3d3e863","updated":"2021-11-17 19:10:14.000000000","message":"How do I get the session object to pass to resume() and suspend()?","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67d1100dee59264f1f01b191ac89e7e1c108e9bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"da03680f_0eacb4cb","updated":"2021-11-19 16:40:52.000000000","message":"Just add that \u0027ignore_missing\u003dFalse\u0027 call and I\u0027m +2","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7ed928fd87f91467a3b94639fc24d2e60b19d15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c835d3a_1af1f5c7","updated":"2021-11-17 09:52:24.000000000","message":"Oh, whoops, there\u0027s a small issue here actually. Maybe fix the nit in the release note while you\u0027re at it?","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"b6a7793c89a1601221a3195af470b8b4b136344f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1fd9e7b1_0de95493","updated":"2021-11-17 01:26:47.000000000","message":"Ready for review.","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"55b8c83c3bdb38251adbb2ab06384c07243625f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f3d0aaf_1f3bdc3d","updated":"2021-11-17 09:49:37.000000000","message":"Wunderbar","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67d1100dee59264f1f01b191ac89e7e1c108e9bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e4bf44d9_4193ccaf","in_reply_to":"1c31c3e3_d3d3e863","updated":"2021-11-19 16:40:52.000000000","message":"See the README [1], which gives an example of using these Resource objects directly (scroll down to \"Finally, there is the low-level resource layer.\"). However, we shouldn\u0027t do that. I\u0027d forgotten you\u0027d need to do this and it makes things _more_ complicated. Let\u0027s keep using the proxy methods as you\u0027ve done 😊\n\n[1] https://github.com/openstack/openstacksdk/blob/master/README.rst","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"98c722d9f650bf1a6cf533fed65bea113ee16510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cd5d636a_1e638dbe","in_reply_to":"6f3d0aaf_1f3bdc3d","updated":"2021-11-20 06:18:36.000000000","message":"Yay. 🙌🏼","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9b5831434a4fe06cf1b1ecef3874c87bcb46c0ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d677d384_454004b4","updated":"2021-11-29 10:13:47.000000000","message":"👏","commit_id":"307c69227028ec4192aa129fe4ca31cd409623f8"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"cbc9d720432ac9a68e1b108ebd060a9f0abeb90d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b7619cb2_99855b1b","updated":"2021-11-29 16:52:12.000000000","message":"Looking for fresh reviews after adding trailing commas.","commit_id":"ff96fea0120ab43968a10230ce7899a3c6504e75"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7ed928fd87f91467a3b94639fc24d2e60b19d15","unresolved":true,"context_lines":[{"line_number":4081,"context_line":"        compute_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":4082,"context_line":"        for server in parsed_args.server:"},{"line_number":4083,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":4084,"context_line":"                server"},{"line_number":4085,"context_line":"            ).id"},{"line_number":4086,"context_line":"            compute_client.resume_server(server_id)"},{"line_number":4087,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"56e25e67_5dd0c2f8","line":4084,"updated":"2021-11-17 09:52:24.000000000","message":"Oh, wait, you need to pass \u0027ignore_missing\u003dFalse\u0027 otherwise there\u0027s a chance this will fail /o\\","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"55b8c83c3bdb38251adbb2ab06384c07243625f3","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":4084,"context_line":"                server"},{"line_number":4085,"context_line":"            ).id"},{"line_number":4086,"context_line":"            compute_client.resume_server(server_id)"},{"line_number":4087,"context_line":""},{"line_number":4088,"context_line":""},{"line_number":4089,"context_line":"class SetServer(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"42f33bc6_e5aa57fe","line":4086,"updated":"2021-11-17 09:49:37.000000000","message":"Same comment as the pause/unpause series:\n\n  compute_client.find_server(server).resume()","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7ed928fd87f91467a3b94639fc24d2e60b19d15","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":4084,"context_line":"                server"},{"line_number":4085,"context_line":"            ).id"},{"line_number":4086,"context_line":"            compute_client.resume_server(server_id)"},{"line_number":4087,"context_line":""},{"line_number":4088,"context_line":""},{"line_number":4089,"context_line":"class SetServer(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ab6b2f2f_262d6855","line":4086,"in_reply_to":"42f33bc6_e5aa57fe","updated":"2021-11-17 09:52:24.000000000","message":"Make that:\n\n  compute_client.find_server(server, ignore_missing\u003dFalse).resume()","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"c765686f86219051ffa6dda01691f74066a3c986","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":4084,"context_line":"                server"},{"line_number":4085,"context_line":"            ).id"},{"line_number":4086,"context_line":"            compute_client.resume_server(server_id)"},{"line_number":4087,"context_line":""},{"line_number":4088,"context_line":""},{"line_number":4089,"context_line":"class SetServer(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"b2a14a4d_3ddd2bf8","line":4086,"in_reply_to":"ab6b2f2f_262d6855","updated":"2021-11-17 19:10:14.000000000","message":"This seems to require the session. Same with suspend().\n\nresume() missing 1 required positional argument: \u0027session\u0027\n\n[1] https://docs.openstack.org/openstacksdk/latest/user/proxies/compute.html","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67d1100dee59264f1f01b191ac89e7e1c108e9bb","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":4084,"context_line":"                server"},{"line_number":4085,"context_line":"            ).id"},{"line_number":4086,"context_line":"            compute_client.resume_server(server_id)"},{"line_number":4087,"context_line":""},{"line_number":4088,"context_line":""},{"line_number":4089,"context_line":"class SetServer(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"8092b4d7_d2754b5f","line":4086,"in_reply_to":"b2a14a4d_3ddd2bf8","updated":"2021-11-19 16:40:52.000000000","message":"See top level comment. We can stick with what you\u0027ve done","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9b5831434a4fe06cf1b1ecef3874c87bcb46c0ec","unresolved":false,"context_lines":[{"line_number":4085,"context_line":"        for server in parsed_args.server:"},{"line_number":4086,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":4087,"context_line":"                server,"},{"line_number":4088,"context_line":"                ignore_missing\u003dFalse"},{"line_number":4089,"context_line":"            ).id"},{"line_number":4090,"context_line":"            compute_client.resume_server(server_id)"},{"line_number":4091,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"4be4d08b_a32e157d","line":4088,"updated":"2021-11-29 10:13:47.000000000","message":"nit: trailing comma would be good here (it\u0027s not necessary but it makes things easier if you ever need to add more arguments to this function call)","commit_id":"307c69227028ec4192aa129fe4ca31cd409623f8"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"cbc9d720432ac9a68e1b108ebd060a9f0abeb90d","unresolved":false,"context_lines":[{"line_number":4085,"context_line":"        for server in parsed_args.server:"},{"line_number":4086,"context_line":"            server_id \u003d compute_client.find_server("},{"line_number":4087,"context_line":"                server,"},{"line_number":4088,"context_line":"                ignore_missing\u003dFalse"},{"line_number":4089,"context_line":"            ).id"},{"line_number":4090,"context_line":"            compute_client.resume_server(server_id)"},{"line_number":4091,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1e086414_a8c63d93","line":4088,"in_reply_to":"4be4d08b_a32e157d","updated":"2021-11-29 16:52:12.000000000","message":"Done.","commit_id":"307c69227028ec4192aa129fe4ca31cd409623f8"}],"openstackclient/tests/unit/compute/v2/test_server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a2ef20536032fb77a6abb09f25ac4bf2b1a4901","unresolved":true,"context_lines":[{"line_number":7583,"context_line":"        arglist.append(servers[0].id)"},{"line_number":7584,"context_line":"        verifylist \u003d ["},{"line_number":7585,"context_line":"            (\u0027server\u0027, arglist),"},{"line_number":7586,"context_line":"        ]"},{"line_number":7587,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":7588,"context_line":""},{"line_number":7589,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a6d8d448_b2c1cc91","line":7586,"updated":"2021-11-15 12:42:24.000000000","message":"Same comment as the previous change RE: weirdness in how you build this up. Can you address this and the others below?","commit_id":"920e3554a4f14935bf17d0159a3a8298a37981c5"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"b6a7793c89a1601221a3195af470b8b4b136344f","unresolved":false,"context_lines":[{"line_number":7583,"context_line":"        arglist.append(servers[0].id)"},{"line_number":7584,"context_line":"        verifylist \u003d ["},{"line_number":7585,"context_line":"            (\u0027server\u0027, arglist),"},{"line_number":7586,"context_line":"        ]"},{"line_number":7587,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":7588,"context_line":""},{"line_number":7589,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f97d6e6_5541b921","line":7586,"in_reply_to":"a6d8d448_b2c1cc91","updated":"2021-11-17 01:26:47.000000000","message":"Done in parent patchset.","commit_id":"920e3554a4f14935bf17d0159a3a8298a37981c5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a2ef20536032fb77a6abb09f25ac4bf2b1a4901","unresolved":true,"context_lines":[{"line_number":7608,"context_line":""},{"line_number":7609,"context_line":"        calls \u003d []"},{"line_number":7610,"context_line":"        for s in servers:"},{"line_number":7611,"context_line":"            calls.append(call(s.id))"},{"line_number":7612,"context_line":"        self.sdk_client.resume_server.assert_has_calls(calls)"},{"line_number":7613,"context_line":"        self.assertIsNone(result)"},{"line_number":7614,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d61fa584_6514643c","line":7611,"updated":"2021-11-15 12:42:24.000000000","message":"nit:\n\n  calls \u003d [call(s.id) for s in servers]","commit_id":"920e3554a4f14935bf17d0159a3a8298a37981c5"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"b6a7793c89a1601221a3195af470b8b4b136344f","unresolved":false,"context_lines":[{"line_number":7608,"context_line":""},{"line_number":7609,"context_line":"        calls \u003d []"},{"line_number":7610,"context_line":"        for s in servers:"},{"line_number":7611,"context_line":"            calls.append(call(s.id))"},{"line_number":7612,"context_line":"        self.sdk_client.resume_server.assert_has_calls(calls)"},{"line_number":7613,"context_line":"        self.assertIsNone(result)"},{"line_number":7614,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f9ebf323_cffe53c0","line":7611,"in_reply_to":"d61fa584_6514643c","updated":"2021-11-17 01:26:47.000000000","message":"Done in parent patchset.","commit_id":"920e3554a4f14935bf17d0159a3a8298a37981c5"}],"releasenotes/notes/migrate-server-suspend-resume-to-sdk-fd1709336607b496.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"55b8c83c3bdb38251adbb2ab06384c07243625f3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Migrate ``server suspend`` and ``server resume`` commands from novaclient to sdk."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3b19018a_2d64c7d1","line":4,"updated":"2021-11-17 09:49:37.000000000","message":"nit: wrap at \u003c\u003d 79 characters, please","commit_id":"a1b205b21a937e81f3421de52f5499511bfb3d1e"}]}