)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"daae8168ca3b8f8c03d6b16b4b7f45b96114ae92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3b4b3d1b_b0ba920d","updated":"2021-12-09 18:40:08.000000000","message":"If you can update lower-constraints.txt to reflect the changed minimum version of openstacksdk, I think we\u0027re good. Nice work as always 👍","commit_id":"5fc1590bd2787e0210029e4c87eb698fa8ea838c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06e30d1a4e64f00ed88327ec6c5d5de30972a0c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6e22fd2a_ebd2483b","updated":"2021-12-09 17:21:50.000000000","message":"recheck","commit_id":"5fc1590bd2787e0210029e4c87eb698fa8ea838c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"332d3460425d1cf21e31171663a721ca61580b4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9bbce235_f7a5d918","updated":"2021-12-09 18:56:42.000000000","message":"Okay, this should pass CI now. Unfortunately there\u0027s a bug in openstacksdk. I left a note on PS7. We can\u0027t merge this until that\u0027s fixed, sadly 😞","commit_id":"a57141941107826f070b923c41afa091715e3ae0"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"daae8168ca3b8f8c03d6b16b4b7f45b96114ae92","unresolved":true,"context_lines":[{"line_number":2569,"context_line":"            ).id"},{"line_number":2570,"context_line":"            compute_client.lock_server("},{"line_number":2571,"context_line":"                server_id,"},{"line_number":2572,"context_line":"                locked_reason\u003dparsed_args.reason)"},{"line_number":2573,"context_line":""},{"line_number":2574,"context_line":""},{"line_number":2575,"context_line":"# FIXME(dtroyer): Here is what I want, how with argparse/cliff?"}],"source_content_type":"text/x-python","patch_set":7,"id":"52cc96ac_4058803e","line":2572,"updated":"2021-12-09 18:40:08.000000000","message":"so, funny thing, this doesn\u0027t actually do anything fwict. It\u0027s accepted by the server but I don\u0027t see it appearing in results. Not sure if it\u0027s an environment issue but I see the same thing with novaclient","commit_id":"5fc1590bd2787e0210029e4c87eb698fa8ea838c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"332d3460425d1cf21e31171663a721ca61580b4d","unresolved":true,"context_lines":[{"line_number":2569,"context_line":"            ).id"},{"line_number":2570,"context_line":"            compute_client.lock_server("},{"line_number":2571,"context_line":"                server_id,"},{"line_number":2572,"context_line":"                locked_reason\u003dparsed_args.reason)"},{"line_number":2573,"context_line":""},{"line_number":2574,"context_line":""},{"line_number":2575,"context_line":"# FIXME(dtroyer): Here is what I want, how with argparse/cliff?"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf90d18f_d27dd31d","line":2572,"in_reply_to":"52cc96ac_4058803e","updated":"2021-12-09 18:56:42.000000000","message":"Okay, this is a bug in openstacksdk. It\u0027s not providing a microversion so nova is silently ignoring this argument. Running this command with the \u0027--debug\u0027 flag on master yields:\n\n  REQ: curl -g -i -X POST http://10.0.108.84/compute/v2.1/servers/111bada5-569c-4681-a937-2892a4ef6d8a/action\n  -H \"Accept: application/json\"\n  -H \"Content-Type: application/json\"\n  -H \"OpenStack-API-Version: compute 2.88\"\n  -H \"User-Agent: python-novaclient\"\n  -H \"X-Auth-Token: {SHA256}a7b39ac71db0ccfe5b3108cca734a71ad300245c132d5d19ec41b34e15589d12\"\n  -H \"X-OpenStack-Nova-API-Version: 2.88\"\n  -d \u0027{\"lock\": {\"locked_reason\": \"foobar\"}}\u0027\n\nWhereas running it with openstacksdk (this patch) yields:\n\n  REQ: curl -g -i -X POST http://10.0.108.84/compute/v2.1/servers/111bada5-569c-4681-a937-2892a4ef6d8a/action\n  -H \"Accept: \"\n  -H \"Content-Type: application/json\"\n  -H \"User-Agent: openstacksdk/0.61.0 keystoneauth1/4.4.0 python-requests/2.26.0 CPython/3.8.12\"\n  -H \"X-Auth-Token: {SHA256}8ae338c3e44ea2e44ba5fa21b22d836583a44a78c15048cfb60a52fb70eab5ef\"\n  -d \u0027{\"lock\": {\"locked_reason\": \"foobar\"}}\u0027\n\nNotice this line is missing:\n\n  -H \"OpenStack-API-Version: compute 2.88\"\n\nWe\u0027ll need another release of openstacksdk, unfortunately 😞","commit_id":"5fc1590bd2787e0210029e4c87eb698fa8ea838c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"44f8a1172188ce93512a8f8e63e593f7624d37b2","unresolved":false,"context_lines":[{"line_number":2569,"context_line":"            ).id"},{"line_number":2570,"context_line":"            compute_client.lock_server("},{"line_number":2571,"context_line":"                server_id,"},{"line_number":2572,"context_line":"                locked_reason\u003dparsed_args.reason)"},{"line_number":2573,"context_line":""},{"line_number":2574,"context_line":""},{"line_number":2575,"context_line":"# FIXME(dtroyer): Here is what I want, how with argparse/cliff?"}],"source_content_type":"text/x-python","patch_set":7,"id":"b0e874c5_66220e3b","line":2572,"in_reply_to":"bf90d18f_d27dd31d","updated":"2022-12-15 19:05:14.000000000","message":"Done","commit_id":"5fc1590bd2787e0210029e4c87eb698fa8ea838c"}]}
