)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"51613dfa62b96e512beaad5c312ca50af7548e9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f51e445b_116d3267","updated":"2021-11-30 17:11:38.000000000","message":"Good start","commit_id":"561ae7cc8d12d3d69861977cfc2661a1128e935a"},{"author":{"_account_id":34045,"name":"Thrivikram Mudunuri","email":"mthrivikram+opendev@gmail.com","username":"tmudunuri"},"change_message_id":"686f9bb5a5cebe6e245320d3d1e50aa76cb9bcf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07daac1a_dc40c1bc","updated":"2021-11-30 06:01:15.000000000","message":"Hi I wanted to get this checked out before writing tests.","commit_id":"561ae7cc8d12d3d69861977cfc2661a1128e935a"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"51613dfa62b96e512beaad5c312ca50af7548e9b","unresolved":true,"context_lines":[{"line_number":4614,"context_line":"                msg \u003d (msg % server)"},{"line_number":4615,"context_line":"                raise exceptions.InvalidValue(msg)"},{"line_number":4616,"context_line":"            elif len(all_servers) \u003d\u003d 1:"},{"line_number":4617,"context_line":"                server_id \u003d s.id"},{"line_number":4618,"context_line":"            else:"},{"line_number":4619,"context_line":"                server_id \u003d compute_client.find_server("},{"line_number":4620,"context_line":"                    server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ef12afa_87b0675a","line":4617,"updated":"2021-11-30 17:11:38.000000000","message":"You\u0027re relying on a side-effect of Python where loop variables exist outside the scope of the loop. This is a quirk and it\u0027s probably better to explicitly look at \u0027all_servers\u0027","commit_id":"561ae7cc8d12d3d69861977cfc2661a1128e935a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"51613dfa62b96e512beaad5c312ca50af7548e9b","unresolved":true,"context_lines":[{"line_number":4619,"context_line":"                server_id \u003d compute_client.find_server("},{"line_number":4620,"context_line":"                    server,"},{"line_number":4621,"context_line":"                    ignore_missing\u003dFalse,"},{"line_number":4622,"context_line":"                ).id"},{"line_number":4623,"context_line":"            compute_client.start_server(server_id)"},{"line_number":4624,"context_line":""},{"line_number":4625,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ae5eca45_046ea968","line":4622,"updated":"2021-11-30 17:11:38.000000000","message":"Couple of points on this:\n\n1. You don\u0027t need the \u0027find_server\u0027 call at the end: you already have a mapping of server IDs and server names.\n2. You can shortcut this if the user provided the server ID rather than a server name.\n3. You can use \u0027find_server\u0027 directly if the user didn\u0027t provide \u0027--all-projects\u0027\n4. This code is similar to the below and therefore should belong in a helper","commit_id":"561ae7cc8d12d3d69861977cfc2661a1128e935a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4187b167abf66f3c751039a0f2c56c2b99516894","unresolved":true,"context_lines":[{"line_number":4605,"context_line":"        for server in parsed_args.server:"},{"line_number":4606,"context_line":"            try:"},{"line_number":4607,"context_line":"                server_id \u003d compute_client.find_server("},{"line_number":4608,"context_line":"                    name\u003dserver,"},{"line_number":4609,"context_line":"                    details\u003dFalse,"},{"line_number":4610,"context_line":"                    all_projects\u003dparsed_args.all_projects,"},{"line_number":4611,"context_line":"                    ignore_missing\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4f21324f_dda7d8df","line":4608,"range":{"start_line":4608,"start_character":20,"end_line":4608,"end_character":31},"updated":"2023-05-17 09:46:47.000000000","message":"this breaks the command, see https://storyboard.openstack.org/#!/story/2010750","commit_id":"9241514137cd8d45fa6f36808536c5d0f218cb97"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4187b167abf66f3c751039a0f2c56c2b99516894","unresolved":true,"context_lines":[{"line_number":4645,"context_line":"        for server in parsed_args.server:"},{"line_number":4646,"context_line":"            try:"},{"line_number":4647,"context_line":"                server_id \u003d compute_client.find_server("},{"line_number":4648,"context_line":"                    name\u003dserver,"},{"line_number":4649,"context_line":"                    details\u003dFalse,"},{"line_number":4650,"context_line":"                    all_projects\u003dparsed_args.all_projects,"},{"line_number":4651,"context_line":"                    ignore_missing\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c2b38dd6_75911e95","line":4648,"range":{"start_line":4648,"start_character":20,"end_line":4648,"end_character":32},"updated":"2023-05-17 09:46:47.000000000","message":"ditto","commit_id":"9241514137cd8d45fa6f36808536c5d0f218cb97"}]}