)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a78d8b7b_d6a12087","updated":"2021-12-02 14:29:29.000000000","message":"There\u0027s a lot of work left to do here still, but it\u0027s a start. Let me know if anything isn\u0027t clear. I\u0027m happy to keep reviewing this if you can rapidly iterate on this over the next few days.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3d958bf9_8bc10bf6","updated":"2021-12-08 18:18:39.000000000","message":"I fixed up the merge conflict and some formatting issues. This is much better, however, you\u0027re now emitting the metadata/properties field, which we shouldn\u0027t be doing since it\u0027s useless. Fixing this is pretty easy but there\u0027s some cleanup needed. I\u0027ve left a lot of comments to guide you. Let me know if anything is confusing.\n\nAlso, you need to add a release note. You want the \u0027reno\u0027 tool for this.","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"}],"openstackclient/compute/v2/server_group.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    \u0027policies\u0027: format_columns.ListColumn,"},{"line_number":36,"context_line":"    \u0027rules\u0027: format_columns.DictColumn,"},{"line_number":37,"context_line":"    \u0027metadata\u0027: format_columns.ListColumn,"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _get_group_columns(item):"}],"source_content_type":"text/x-python","patch_set":1,"id":"597de054_756a43af","line":38,"in_reply_to":"b3d17251_37e9b9cc","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: E123 closing bracket does not match indentation of opening bracket\u0027s line\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    return tuple(sorted(columns))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class CreateServerGroup(command.ShowOne):"},{"line_number":62,"context_line":"    _description \u003d _(\"Create a new server group.\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"26e3334e_59bc6567","line":61,"updated":"2021-12-02 14:29:29.000000000","message":"You need to update this command and the others here too. If you don\u0027t, then you can\u0027t change the return type of the \u0027create_one_server_group\u0027 helper since it will affect the unit tests for all of these commands. Consider either updating them all in one go, or instead of updating \u0027create_one_server_group\u0027, create a new \u0027create_one_sdk_server_group\u0027 that will create an SDK-based object instead","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":285,"context_line":"            parsed_args.server_group, ignore_missing\u003dFalse)"},{"line_number":286,"context_line":"        display_columns, columns \u003d _get_group_columns(group)"},{"line_number":287,"context_line":"        data \u003d utils.get_item_properties("},{"line_number":288,"context_line":"            group, columns,formatters\u003d_formatters)"},{"line_number":289,"context_line":"        return [display_columns, data]"}],"source_content_type":"text/x-python","patch_set":1,"id":"395b7c4a_03e640b5","line":288,"in_reply_to":"26457658_657eedb9","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: E231 missing whitespace after \u0027,\u0027\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    \u0027members\u0027: format_columns.ListColumn,"},{"line_number":35,"context_line":"    \u0027policies\u0027: format_columns.ListColumn,"},{"line_number":36,"context_line":"    \u0027rules\u0027: format_columns.DictColumn,"},{"line_number":37,"context_line":"    \u0027metadata\u0027: format_columns.ListColumn,"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b9f248a0_d4fd6463","line":37,"updated":"2021-12-08 18:18:39.000000000","message":"You shouldn\u0027t need to do this, because we shouldn\u0027t be emitting properties (see below)","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    # whatever OSC was using before"},{"line_number":44,"context_line":"    column_map \u003d {"},{"line_number":45,"context_line":"        \u0027metadata\u0027: \u0027properties\u0027,"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"    hidden_columns \u003d [\u0027links\u0027, \u0027location\u0027]"},{"line_number":48,"context_line":"    return utils.get_osc_show_columns_for_sdk_resource("},{"line_number":49,"context_line":"        item, column_map, hidden_columns)"}],"source_content_type":"text/x-python","patch_set":3,"id":"09ac6a41_75461853","line":46,"updated":"2021-12-08 18:18:39.000000000","message":"Ditto","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    columns \u003d list(info.keys())"},{"line_number":54,"context_line":"    if \u0027metadata\u0027 in columns:"},{"line_number":55,"context_line":"        # NOTE(RuiChen): The metadata of server group is always empty since API"},{"line_number":56,"context_line":"        #                compatible, so hide it in order to avoid confusion."},{"line_number":57,"context_line":"        columns.remove(\u0027metadata\u0027)"},{"line_number":58,"context_line":"    return tuple(sorted(columns))"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"01e601db_ff4bc2b8","line":56,"updated":"2021-12-08 18:18:39.000000000","message":"See this note: we don\u0027t emit metadata/properties for this command because it\u0027s meaningless and always empty. What you need to do is _hide_ this column. Hint: you\u0027re already hiding two other columns","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"}],"openstackclient/tests/unit/compute/v2/fakes.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":1249,"context_line":"            A FakeResource object, with id and other attributes"},{"line_number":1250,"context_line":"        \"\"\""},{"line_number":1251,"context_line":"        #if attrs is None:"},{"line_number":1252,"context_line":"        #    attrs \u003d {}"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"        # Set default attributes."},{"line_number":1255,"context_line":"        server_group_info \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"c784e20b_30b13915","line":1252,"updated":"2021-12-02 14:29:29.000000000","message":"Is there any reason to comment this out? This is here so you can overload certain attributes","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":1259,"context_line":"            \u0027name\u0027: \u0027server-group-name-\u0027 + uuid.uuid4().hex,"},{"line_number":1260,"context_line":"            \u0027project_id\u0027: \u0027server-group-project-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1261,"context_line":"            \u0027user_id\u0027: \u0027server-group-user-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1262,"context_line":"            \u0027rules\u0027: {\"max_server_per_host\":3},"},{"line_number":1263,"context_line":"        }"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"        # Overwrite default attributes."}],"source_content_type":"text/x-python","patch_set":1,"id":"62120087_c227509f","line":1262,"in_reply_to":"548b5335_7bb3d8dc","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: E231 missing whitespace after \u0027:\u0027\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":1265,"context_line":"        # Overwrite default attributes."},{"line_number":1266,"context_line":"        server_group_info.update(attrs)"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        server_group \u003d fakes.FakeResource("},{"line_number":1269,"context_line":"            info\u003dcopy.deepcopy(server_group_info),"},{"line_number":1270,"context_line":"            loaded\u003dTrue)"},{"line_number":1271,"context_line":"        return server_group"}],"source_content_type":"text/x-python","patch_set":1,"id":"38cdb4cf_5818f268","line":1268,"updated":"2021-12-02 14:29:29.000000000","message":"This is intended to mimic the kind of object that would be returned from novaclient, however, we\u0027re no longer using novaclient so we should return the thing that openstacksdk returns (hint: it\u0027s the same type of that object that \u0027find_server_group\u0027 returns [1]). Note that the objects in openstacksdk sometimes use different names than what the API and/or novaclient uses, so you might need to update some of the keys in the dictionary above too.\n\nLook at what some of the other patches have done if you\u0027re stuck here\n\n[1] https://github.com/openstack/openstacksdk/blob/26c9bc22e/openstack/compute/v2/_proxy.py#L1343-L1344","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":1311,"context_line":"        server_group_info \u003d {"},{"line_number":1312,"context_line":"            \u0027id\u0027: \u0027server-group-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1313,"context_line":"            \u0027members\u0027: [],"},{"line_number":1314,"context_line":"            \u0027metadata\u0027: [],"},{"line_number":1315,"context_line":"            \u0027name\u0027: \u0027server-group-name-\u0027 + uuid.uuid4().hex,"},{"line_number":1316,"context_line":"            \u0027project_id\u0027: \u0027server-group-project-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1317,"context_line":"            \u0027user_id\u0027: \u0027server-group-user-id-\u0027 + uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bafd67a2_6bc372c2","line":1314,"updated":"2021-12-08 18:18:39.000000000","message":"This change shouldn\u0027t be necessary since you\u0027re not working with legacy novaclient resource objects here","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":1315,"context_line":"            \u0027name\u0027: \u0027server-group-name-\u0027 + uuid.uuid4().hex,"},{"line_number":1316,"context_line":"            \u0027project_id\u0027: \u0027server-group-project-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1317,"context_line":"            \u0027user_id\u0027: \u0027server-group-user-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1318,"context_line":"            \u0027rules\u0027: {\"max_server_per_host\": 3},"},{"line_number":1319,"context_line":"        }"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        # Overwrite default attributes."}],"source_content_type":"text/x-python","patch_set":3,"id":"edfde5c1_4e982c0f","line":1318,"updated":"2021-12-08 18:18:39.000000000","message":"...and neither should this. It\u0027s no harm, but it\u0027s unrelated to what you\u0027re trying to achieve here.","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":1353,"context_line":"        server_group_info.update(attrs)"},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"        server_group \u003d _server_group.ServerGroup(**server_group_info)"},{"line_number":1356,"context_line":"        return server_group"},{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":"    @staticmethod"},{"line_number":1359,"context_line":"    def create_one_server_group(attrs\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3dfb2489_78c8a804","line":1356,"updated":"2021-12-08 18:18:39.000000000","message":"Can you move this _below_ \u0027create_one_server_group\u0027 so that \u0027create_one_server_group\u0027 and the \u0027_create_one_server_group\u0027 method that it wraps and grouped together.","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"}],"openstackclient/tests/unit/compute/v2/test_server_group.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from osc_lib.cli import format_columns"},{"line_number":20,"context_line":"from osc_lib import exceptions"},{"line_number":21,"context_line":"from osc_lib import utils"},{"line_number":22,"context_line":"from openstack import exceptions as sdk_exceptions"},{"line_number":23,"context_line":"from openstack import utils as sdk_utils"},{"line_number":24,"context_line":"from openstackclient.compute.v2 import server_group"},{"line_number":25,"context_line":"from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes"}],"source_content_type":"text/x-python","patch_set":1,"id":"40717187_c76c1eb2","line":22,"in_reply_to":"55970f2c_ed9891fa","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: F401 \u0027openstack.exceptions as sdk_exceptions\u0027 imported but unused\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from osc_lib.cli import format_columns"},{"line_number":20,"context_line":"from osc_lib import exceptions"},{"line_number":21,"context_line":"from osc_lib import utils"},{"line_number":22,"context_line":"from openstack import exceptions as sdk_exceptions"},{"line_number":23,"context_line":"from openstack import utils as sdk_utils"},{"line_number":24,"context_line":"from openstackclient.compute.v2 import server_group"},{"line_number":25,"context_line":"from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes"}],"source_content_type":"text/x-python","patch_set":1,"id":"7eee4193_31429468","line":22,"in_reply_to":"6ac4f23b_2830f8ff","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (osc_lib.utils, openstack.exceptions)\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from osc_lib import exceptions"},{"line_number":21,"context_line":"from osc_lib import utils"},{"line_number":22,"context_line":"from openstack import exceptions as sdk_exceptions"},{"line_number":23,"context_line":"from openstack import utils as sdk_utils"},{"line_number":24,"context_line":"from openstackclient.compute.v2 import server_group"},{"line_number":25,"context_line":"from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes"},{"line_number":26,"context_line":"from openstackclient.tests.unit import utils as tests_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0591003_aedcbb1b","line":23,"in_reply_to":"cd87e668_6aa26ea8","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: F401 \u0027openstack.utils as sdk_utils\u0027 imported but unused\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from osc_lib import utils"},{"line_number":22,"context_line":"from openstack import exceptions as sdk_exceptions"},{"line_number":23,"context_line":"from openstack import utils as sdk_utils"},{"line_number":24,"context_line":"from openstackclient.compute.v2 import server_group"},{"line_number":25,"context_line":"from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes"},{"line_number":26,"context_line":"from openstackclient.tests.unit import utils as tests_utils"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6f844c40_e7f4296c","line":24,"in_reply_to":"15a6bba2_15eedbab","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: I201 Missing newline between import groups. \u0027from openstackclient.compute.v2 import server_group\u0027 is identified as Application and \u0027from openstack import utils\u0027 is identified as Third Party.\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        self.server_groups_mock \u003d self.app.client_manager.compute.server_groups"},{"line_number":62,"context_line":"        self.server_groups_mock.reset_mock()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class TestServerGroupV264(TestServerGroup):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    fake_server_group \u003d \\"},{"line_number":67,"context_line":"        compute_fakes.FakeServerGroupV264.create_one_server_group()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c7aa28b_0a85ff1e","line":64,"in_reply_to":"f634ef97_0cfee121","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: E302 expected 2 blank lines, found 1\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def setUp(self):"},{"line_number":484,"context_line":"        super(TestServerGroupShow, self).setUp()"},{"line_number":485,"context_line":"        print(self) "},{"line_number":486,"context_line":"        self.sdk_client.find_server_group.return_value\u003dself.fake_server_group"},{"line_number":487,"context_line":"        self.cmd \u003d server_group.ShowServerGroup(self.app, None)"},{"line_number":488,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"b607c8e5_c1db3d72","line":485,"in_reply_to":"881d1e2e_0806b9da","updated":"2021-12-02 14:29:29.000000000","message":"You need to drop these print statements","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":483,"context_line":"    def setUp(self):"},{"line_number":484,"context_line":"        super(TestServerGroupShow, self).setUp()"},{"line_number":485,"context_line":"        print(self) "},{"line_number":486,"context_line":"        self.sdk_client.find_server_group.return_value\u003dself.fake_server_group"},{"line_number":487,"context_line":"        self.cmd \u003d server_group.ShowServerGroup(self.app, None)"},{"line_number":488,"context_line":"    "},{"line_number":489,"context_line":"    def test_server_group_show(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c57c84b8_08faa14e","line":486,"in_reply_to":"172bc60c_f4e013b9","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: E225 missing whitespace around operator\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        print(self) "},{"line_number":486,"context_line":"        self.sdk_client.find_server_group.return_value\u003dself.fake_server_group"},{"line_number":487,"context_line":"        self.cmd \u003d server_group.ShowServerGroup(self.app, None)"},{"line_number":488,"context_line":"    "},{"line_number":489,"context_line":"    def test_server_group_show(self):"},{"line_number":490,"context_line":"        arglist \u003d ["},{"line_number":491,"context_line":"            \u0027ag1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"922f14a0_f04506b7","line":488,"in_reply_to":"e9f3dcc4_9d134263","updated":"2021-12-02 14:29:29.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68da90208cae3f43ef177ea85bb503093c1b72df","unresolved":true,"context_lines":[{"line_number":491,"context_line":"            \u0027ag1\u0027,"},{"line_number":492,"context_line":"        ]"},{"line_number":493,"context_line":"        verifylist \u003d ["},{"line_number":494,"context_line":"            (\u0027server_group\u0027, \u0027ag1\u0027),"},{"line_number":495,"context_line":"        ]"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":1,"id":"72dfa1b5_c05421e6","line":494,"updated":"2021-12-02 14:29:29.000000000","message":"There shouldn\u0027t be any reason to rename these. Can you undo this?","commit_id":"11006ba874891a28e6b3ba4d8bdd9ce3465d8bda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":105,"context_line":"            name\u003dparsed_args.name,"},{"line_number":106,"context_line":"            policies\u003d[parsed_args.policy],"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":110,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"75bb8f27_3538012f","side":"PARENT","line":108,"updated":"2021-12-08 18:18:39.000000000","message":"Unrelated change. Can you add this line back in?","commit_id":"9eb42403d3aa4e0005c4914a20ce3e3dc53cbc22"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        \u0027name\u0027,"},{"line_number":36,"context_line":"        \u0027policies\u0027,"},{"line_number":37,"context_line":"        \u0027project_id\u0027,"},{"line_number":38,"context_line":"        \u0027rules\u0027,"},{"line_number":39,"context_line":"        \u0027user_id\u0027,"},{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4ae246b5_1d248734","line":38,"updated":"2021-12-08 18:18:39.000000000","message":"As noted in the first file, this shouldn\u0027t be necessary","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        fake_server_group.name,"},{"line_number":46,"context_line":"        format_columns.ListColumn(fake_server_group.policies),"},{"line_number":47,"context_line":"        fake_server_group.project_id,"},{"line_number":48,"context_line":"        format_columns.DictColumn(fake_server_group.rules),"},{"line_number":49,"context_line":"        fake_server_group.user_id,"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"31cdc5dc_7dc1213a","line":48,"updated":"2021-12-08 18:18:39.000000000","message":"Neither should this","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        m \u003d mock.Mock(return_value\u003d[\"mockVal\", 100, 200])"},{"line_number":56,"context_line":"        self.app.client_manager.sdk_connection \u003d m"},{"line_number":57,"context_line":"        self.app.client_manager.sdk_connection.compute \u003d m"},{"line_number":58,"context_line":"        self.sdk_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":59,"context_line":"        self.server_groups_mock \u003d self.app.client_manager.compute.server_groups"},{"line_number":60,"context_line":"        self.server_groups_mock.reset_mock()"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"aa6af11d_77664392","line":58,"updated":"2021-12-08 18:18:39.000000000","message":"Don\u0027t do this here. Do it in the \u0027setUp\u0027 of the test that you\u0027re modifying (\u0027TestServerGroupShow\u0027)","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":477,"context_line":"        \u0027policies\u0027,"},{"line_number":478,"context_line":"        \u0027policy\u0027,"},{"line_number":479,"context_line":"        \u0027project_id\u0027,"},{"line_number":480,"context_line":"        \u0027properties\u0027,"},{"line_number":481,"context_line":"        \u0027rules\u0027,"},{"line_number":482,"context_line":"        \u0027user_id\u0027,"},{"line_number":483,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":3,"id":"b8b339e5_81708303","line":480,"updated":"2021-12-08 18:18:39.000000000","message":"This shouldn\u0027t be here","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad1312b0111e686027aec391a8e6ffd84209814f","unresolved":true,"context_lines":[{"line_number":488,"context_line":"        format_columns.ListColumn(fake_server_group.policies),"},{"line_number":489,"context_line":"        fake_server_group.policy,"},{"line_number":490,"context_line":"        fake_server_group.project_id,"},{"line_number":491,"context_line":"        format_columns.ListColumn(fake_server_group.metadata),"},{"line_number":492,"context_line":"        format_columns.DictColumn(fake_server_group.rules),"},{"line_number":493,"context_line":"        fake_server_group.user_id,"},{"line_number":494,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":3,"id":"bde27dfc_9a246ad1","line":491,"updated":"2021-12-08 18:18:39.000000000","message":"Neither should this","commit_id":"3eb0de28b3123e20bb2812158f300e1a3da139a2"}]}