)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0380a73bc785f3d1bc252318262371e76c1fc885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f52fd651_aaca09c1","updated":"2022-09-30 11:15:24.000000000","message":"@ralonsoh: Are you happy with this now?","commit_id":"bced4852c7a92959f5457360dd91eb397af4d270"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"e2a666a02d446b26b5ce244e326805c6c1b1b7b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"555827d6_a3c540aa","updated":"2022-11-30 13:19:51.000000000","message":"Hi folks, is there anything else to improve here? or is there some suggestion that I am missing? Thanks 😊 ","commit_id":"bced4852c7a92959f5457360dd91eb397af4d270"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"43d1f844fb7012ef5b41d9a9a53cc15eae18a31c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93a42782_38c89f05","in_reply_to":"f52fd651_aaca09c1","updated":"2023-01-04 17:03:37.000000000","message":"Sorry, I didn\u0027t see this comment. Yes, thanks!","commit_id":"bced4852c7a92959f5457360dd91eb397af4d270"}],"openstackclient/tests/unit/network/v2/test_floating_ip_port_forwarding.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1473645feab1356ef875c2f49572e66852f7ca86","unresolved":true,"context_lines":[{"line_number":571,"context_line":"        arglist \u003d ["},{"line_number":572,"context_line":"            \u0027--port\u0027, self.port.id,"},{"line_number":573,"context_line":"            \u0027--internal-ip-address\u0027, \u0027new_internal_ip_address\u0027,"},{"line_number":574,"context_line":"            \u0027--internal-protocol-port\u0027, \u0027100\u0027,"},{"line_number":575,"context_line":"            \u0027--external-protocol-port\u0027, \u0027200\u0027,"},{"line_number":576,"context_line":"            \u0027--protocol\u0027, \u0027tcp\u0027,"},{"line_number":577,"context_line":"            \u0027--description\u0027, \u0027some description\u0027,"},{"line_number":578,"context_line":"            self._port_forwarding.floatingip_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"08589cd9_7aac88f8","line":575,"range":{"start_line":574,"start_character":12,"end_line":575,"end_character":46},"updated":"2022-07-13 13:09:01.000000000","message":"You should test:\n1) Setting a port range\n2) Setting a port range when you had before a single port. Is that allowed? I don\u0027t remember. If this is not allowed, this should fail. If it is, the CLI should remove the internal_port/external_port field.","commit_id":"92c35895ba05ae75d8170ced26d1db73993072c0"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"c15b6a0502d5023cdcb1e376e135e5c1138885f7","unresolved":true,"context_lines":[{"line_number":571,"context_line":"        arglist \u003d ["},{"line_number":572,"context_line":"            \u0027--port\u0027, self.port.id,"},{"line_number":573,"context_line":"            \u0027--internal-ip-address\u0027, \u0027new_internal_ip_address\u0027,"},{"line_number":574,"context_line":"            \u0027--internal-protocol-port\u0027, \u0027100\u0027,"},{"line_number":575,"context_line":"            \u0027--external-protocol-port\u0027, \u0027200\u0027,"},{"line_number":576,"context_line":"            \u0027--protocol\u0027, \u0027tcp\u0027,"},{"line_number":577,"context_line":"            \u0027--description\u0027, \u0027some description\u0027,"},{"line_number":578,"context_line":"            self._port_forwarding.floatingip_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1e625efa_b4546a2d","line":575,"range":{"start_line":574,"start_character":12,"end_line":575,"end_character":46},"in_reply_to":"08589cd9_7aac88f8","updated":"2022-07-13 21:49:11.000000000","message":"Thanks for reviewing it 😊, I created a new case where we set all using ranges. About switching a rule from single ports to ranges and vice versa, it should be allowed (of course, if there is no collisions with the new ports)","commit_id":"92c35895ba05ae75d8170ced26d1db73993072c0"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"9f9eabb4baa3087030dfe119a3ac3c50e29ef858","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        arglist \u003d ["},{"line_number":572,"context_line":"            \u0027--port\u0027, self.port.id,"},{"line_number":573,"context_line":"            \u0027--internal-ip-address\u0027, \u0027new_internal_ip_address\u0027,"},{"line_number":574,"context_line":"            \u0027--internal-protocol-port\u0027, \u0027100\u0027,"},{"line_number":575,"context_line":"            \u0027--external-protocol-port\u0027, \u0027200\u0027,"},{"line_number":576,"context_line":"            \u0027--protocol\u0027, \u0027tcp\u0027,"},{"line_number":577,"context_line":"            \u0027--description\u0027, \u0027some description\u0027,"},{"line_number":578,"context_line":"            self._port_forwarding.floatingip_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"49f2b0d2_e1739e25","line":575,"range":{"start_line":574,"start_character":12,"end_line":575,"end_character":46},"in_reply_to":"1e625efa_b4546a2d","updated":"2022-12-22 14:33:04.000000000","message":"Done","commit_id":"92c35895ba05ae75d8170ced26d1db73993072c0"}]}
