)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"970165ce96787812cbda26645a66e8432b6052c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3b5c4f5_901fb97a","updated":"2022-04-14 12:23:54.000000000","message":"Can we have functional test for this pls (if not too complex)? This functionality is not widely known and need special verification.","commit_id":"725b7de13cf00da386132a42b2738f4c57026184"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7c415c29f7203989b2aea7a795487b78d71bb096","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c7a059b_771f495f","updated":"2022-09-30 11:17:42.000000000","message":"This has been around a long time. I\u0027m pretty confident that this is doing what it\u0027s supposed to do. Let\u0027s try it out. We can revert if needed.","commit_id":"725b7de13cf00da386132a42b2738f4c57026184"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cc535aa83cb3494c3178788bfd5b13b18a546fe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2778fa30_6655e460","updated":"2022-04-19 15:58:38.000000000","message":"recheck unrelated failure","commit_id":"725b7de13cf00da386132a42b2738f4c57026184"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"001538a85f47f9e1879af4eb281c3713daae09ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ebd9eb06_f263339d","in_reply_to":"98460cd1_d3b1dec8","updated":"2022-04-15 15:33:24.000000000","message":"What I mean you now introduce pretty special \"in:ID1,ID2\" logic which is currently only tested in unit test and is not covered directly by func tests. And exactly since it is pretty special and (can\u0027t say how often) not often used logic we need to have some guarantee it works. I do not see any func test that would be covering explicitly this usecase. And we are not even having func tests in SDK for this type of query","commit_id":"725b7de13cf00da386132a42b2738f4c57026184"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"17ffea609805f369ec92749bf47b6f3e13d06653","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"081a300a_94daf54c","in_reply_to":"ebd9eb06_f263339d","updated":"2022-04-19 14:44:10.000000000","message":"I understand, but this special logic is actually used on the \"standard\" path and e.g. the `ServerTests.test_server_list` in `openstackclient.tests.functional.compute.v2.test_server` is testing this standard path. If I\u0027d broken something then that test would fail, right? The fact that it is passing suggests things are working as expected. Right?","commit_id":"725b7de13cf00da386132a42b2738f4c57026184"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c6d5f191603d9d970bd1bbc71e99c1e41db69934","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98460cd1_d3b1dec8","in_reply_to":"f3b5c4f5_901fb97a","updated":"2022-04-14 17:44:06.000000000","message":"This is already sort of testing via e.g. `ServerTests.test_server_list` in `openstackclient.tests.functional.compute.v2.test_server`, no? We don\u0027t appear to use mocks or check the actual request sent under the hood in any of our functional tests, at least from what I can tell","commit_id":"725b7de13cf00da386132a42b2738f4c57026184"}]}