)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"80074bfa3c343defbae5512c596be7608e21fc8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bef79cf0_677dbcaf","updated":"2022-06-02 03:45:46.000000000","message":"recheck","commit_id":"90bfc62959a52721d51b36daba4d914750385f3c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bb0644436940abd613333ddca705922b50da5bf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c284a3e_b4824297","updated":"2022-06-30 09:12:55.000000000","message":"Thanks Stephen and Gorka for the reviews.","commit_id":"1da9c841a1da1b9c0a4c7ad62bf9960d10271f93"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f669c9313ec96b7504f5b9d4c2d445fa995fdb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f0a2736f_580df9b7","updated":"2022-06-30 16:51:37.000000000","message":"recheck\n\nfailing for another test in same job\n\nopenstackclient.tests.functional.compute.v2.test_server.ServerTests.test_server_add_remove_network\ntempest.lib.exceptions.CommandFailed: Command \u0027openstack --os-cloud\u003ddevstack-admin server add network ac0a0cae07674bc588c91cedd8d7353a public\u0027 returned non-zero exit status 1.","commit_id":"9eea28ba59e44526b9d6f1ad9f80c3553d5853e2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c131969768c0a75c555c30441aa856ec0c8bca0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b28f00b6_e6deb47a","updated":"2022-06-30 14:41:46.000000000","message":"recheck\n\nunrelated failure\nopenstackclient.tests.functional.compute.v2.test_server.ServerTests.test_server_add_remove_volume\njson.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)","commit_id":"9eea28ba59e44526b9d6f1ad9f80c3553d5853e2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b162d854613bcba2221557f9e5083f64d3ec5164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b10abf5_09e87039","in_reply_to":"b28f00b6_e6deb47a","updated":"2022-06-30 15:04:18.000000000","message":"Yeah, the server failed to create. From the n-cpu logs [1]:\n\n    DEBUG nova.network.os_vif_util [None req-f9a5c6a8-ab26-4f1f-ab63-dd518edf32f3 admin admin] No conversion for VIF type unbound yet {{(pid\u003d97953) nova_to_osvif_vif /opt/stack/nova/nova/network/os_vif_util.py:530}}\n    ERROR nova.compute.manager [None req-f9a5c6a8-ab26-4f1f-ab63-dd518edf32f3 admin admin] [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f] Instance failed to spawn: nova.exception.InternalError: Unexpected vif_type\u003dunbound\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f] Traceback (most recent call last):\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]   File \"/opt/stack/nova/nova/compute/manager.py\", line 2728, in _build_resources\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]     yield resources\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]   File \"/opt/stack/nova/nova/compute/manager.py\", line 2487, in _build_and_run_instance\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]     self.driver.spawn(context, instance, image_meta,\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]   File \"/opt/stack/nova/nova/virt/libvirt/driver.py\", line 4340, in spawn\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]     xml \u003d self._get_guest_xml(context, instance, network_info,\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]   File \"/opt/stack/nova/nova/virt/libvirt/driver.py\", line 7311, in _get_guest_xml\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]     conf \u003d self._get_guest_config(instance, network_info, image_meta,\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]   File \"/opt/stack/nova/nova/virt/libvirt/driver.py\", line 6925, in _get_guest_config\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]     config \u003d self.vif_driver.get_config(\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]   File \"/opt/stack/nova/nova/virt/libvirt/vif.py\", line 600, in get_config\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f]     raise exception.InternalError(_(\u0027Unexpected vif_type\u003d%s\u0027) % vif_type)\n    ERROR nova.compute.manager [instance: db9ae2d6-b717-4bbc-932a-24f5f94dfd8f] nova.exception.InternalError: Unexpected vif_type\u003dunbound\n    \nand from the q-svc logs:\n\n  WARNING neutron.plugins.ml2.plugin [req-f9a5c6a8-ab26-4f1f-ab63-dd518edf32f3 req-c372ca6e-78a4-4f09-976b-c74d5f169c66 service neutron] Concurrent port binding operations failed on port a2fb8af2-d4df-4b29-bd3f-5591aa8819d2\n  \n[1] https://zuul.opendev.org/t/openstack/build/b5c09ce1dbdd42228f5f2928d9df6178/log/controller/logs/screen-n-cpu.txt#10060\n[2] https://zuul.opendev.org/t/openstack/build/b5c09ce1dbdd42228f5f2928d9df6178/log/controller/logs/screen-q-svc.txt#10891","commit_id":"9eea28ba59e44526b9d6f1ad9f80c3553d5853e2"}],"openstackclient/image/v2/image.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c50d1519002144eb5f1cba4876f00bd30c81261","unresolved":true,"context_lines":[{"line_number":483,"context_line":"            source_volume \u003d utils.find_resource("},{"line_number":484,"context_line":"                volume_client.volumes,"},{"line_number":485,"context_line":"                parsed_args.volume,"},{"line_number":486,"context_line":"            )"},{"line_number":487,"context_line":"            if volume_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.1\u0027):"},{"line_number":488,"context_line":"                response, body \u003d volume_client.volumes.upload_to_image("},{"line_number":489,"context_line":"                    source_volume.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f1be4b07_91f980a8","line":486,"updated":"2022-06-29 14:00:54.000000000","message":"Rather than silently ignoring this, can you add an error check here if either of these are specified and the volume API version \u003c 3.1? You\u0027ll find loads of examples of us doing this in the openstack.compute.v2 module.","commit_id":"90bfc62959a52721d51b36daba4d914750385f3c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bb0644436940abd613333ddca705922b50da5bf5","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            source_volume \u003d utils.find_resource("},{"line_number":484,"context_line":"                volume_client.volumes,"},{"line_number":485,"context_line":"                parsed_args.volume,"},{"line_number":486,"context_line":"            )"},{"line_number":487,"context_line":"            if volume_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.1\u0027):"},{"line_number":488,"context_line":"                response, body \u003d volume_client.volumes.upload_to_image("},{"line_number":489,"context_line":"                    source_volume.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a8a2580_127b740d","line":486,"in_reply_to":"f1be4b07_91f980a8","updated":"2022-06-30 09:12:55.000000000","message":"Done","commit_id":"90bfc62959a52721d51b36daba4d914750385f3c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e3ca7486e1582d4fbe8aa3f253e16e66743a98f2","unresolved":true,"context_lines":[{"line_number":484,"context_line":"                volume_client.volumes,"},{"line_number":485,"context_line":"                parsed_args.volume,"},{"line_number":486,"context_line":"            )"},{"line_number":487,"context_line":"            if volume_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.1\u0027):"},{"line_number":488,"context_line":"                response, body \u003d volume_client.volumes.upload_to_image("},{"line_number":489,"context_line":"                    source_volume.id,"},{"line_number":490,"context_line":"                    parsed_args.force,"},{"line_number":491,"context_line":"                    parsed_args.name,"},{"line_number":492,"context_line":"                    parsed_args.container_format,"},{"line_number":493,"context_line":"                    parsed_args.disk_format,"},{"line_number":494,"context_line":"                    visibility\u003dkwargs.get(\u0027visibility\u0027, \u0027private\u0027),"},{"line_number":495,"context_line":"                    protected\u003dTrue if parsed_args.protected else False"},{"line_number":496,"context_line":"                )"},{"line_number":497,"context_line":"            else:"},{"line_number":498,"context_line":"                response, body \u003d volume_client.volumes.upload_to_image("},{"line_number":499,"context_line":"                    source_volume.id,"},{"line_number":500,"context_line":"                    parsed_args.force,"},{"line_number":501,"context_line":"                    parsed_args.name,"},{"line_number":502,"context_line":"                    parsed_args.container_format,"},{"line_number":503,"context_line":"                    parsed_args.disk_format"},{"line_number":504,"context_line":"                )"},{"line_number":505,"context_line":"            info \u003d body[\u0027os-volume_upload_image\u0027]"},{"line_number":506,"context_line":"            try:"},{"line_number":507,"context_line":"                info[\u0027volume_type\u0027] \u003d info[\u0027volume_type\u0027][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"b23166df_45a7055c","line":504,"range":{"start_line":487,"start_character":0,"end_line":504,"end_character":17},"updated":"2022-06-29 15:02:09.000000000","message":"-1: Since it\u0027s the same call I think it would be best to make the call once, something like:\n\n            kwargs \u003d {}\n            if volume_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.1\u0027):\n                kwargs \u003d kwargs.update(\n                    visibility\u003dkwargs.get(\u0027visibility\u0027, \u0027private\u0027),\n                    protected\u003dbool(parsed_args.protected)\n                )\n\n            response, body \u003d volume_client.volumes.upload_to_image(\n                source_volume.id,\n                parsed_args.force,\n                parsed_args.name,\n                parsed_args.container_format,\n                parsed_args.disk_format,\n                **kwargs\n            )","commit_id":"90bfc62959a52721d51b36daba4d914750385f3c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bb0644436940abd613333ddca705922b50da5bf5","unresolved":false,"context_lines":[{"line_number":484,"context_line":"                volume_client.volumes,"},{"line_number":485,"context_line":"                parsed_args.volume,"},{"line_number":486,"context_line":"            )"},{"line_number":487,"context_line":"            if volume_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.1\u0027):"},{"line_number":488,"context_line":"                response, body \u003d volume_client.volumes.upload_to_image("},{"line_number":489,"context_line":"                    source_volume.id,"},{"line_number":490,"context_line":"                    parsed_args.force,"},{"line_number":491,"context_line":"                    parsed_args.name,"},{"line_number":492,"context_line":"                    parsed_args.container_format,"},{"line_number":493,"context_line":"                    parsed_args.disk_format,"},{"line_number":494,"context_line":"                    visibility\u003dkwargs.get(\u0027visibility\u0027, \u0027private\u0027),"},{"line_number":495,"context_line":"                    protected\u003dTrue if parsed_args.protected else False"},{"line_number":496,"context_line":"                )"},{"line_number":497,"context_line":"            else:"},{"line_number":498,"context_line":"                response, body \u003d volume_client.volumes.upload_to_image("},{"line_number":499,"context_line":"                    source_volume.id,"},{"line_number":500,"context_line":"                    parsed_args.force,"},{"line_number":501,"context_line":"                    parsed_args.name,"},{"line_number":502,"context_line":"                    parsed_args.container_format,"},{"line_number":503,"context_line":"                    parsed_args.disk_format"},{"line_number":504,"context_line":"                )"},{"line_number":505,"context_line":"            info \u003d body[\u0027os-volume_upload_image\u0027]"},{"line_number":506,"context_line":"            try:"},{"line_number":507,"context_line":"                info[\u0027volume_type\u0027] \u003d info[\u0027volume_type\u0027][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fc30f35_2213d584","line":504,"range":{"start_line":487,"start_character":0,"end_line":504,"end_character":17},"in_reply_to":"b23166df_45a7055c","updated":"2022-06-30 09:12:55.000000000","message":"Done","commit_id":"90bfc62959a52721d51b36daba4d914750385f3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f5dd38c78462d4c1d0819d13b35e2c69487e7bba","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            if volume_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.1\u0027):"},{"line_number":489,"context_line":"                mv_kwargs.update("},{"line_number":490,"context_line":"                    visibility\u003dkwargs.get(\u0027visibility\u0027, \u0027private\u0027),"},{"line_number":491,"context_line":"                    protected\u003dbool(parsed_args.protected)"},{"line_number":492,"context_line":"                )"},{"line_number":493,"context_line":"            else:"},{"line_number":494,"context_line":"                if kwargs.get(\u0027visibility\u0027) or parsed_args.protected:"}],"source_content_type":"text/x-python","patch_set":3,"id":"95615d0c_a480677a","line":491,"updated":"2022-06-30 10:12:48.000000000","message":"nit: you could avoid the \u0027bool\u0027 cast if you set default\u003dFalse for this option","commit_id":"1da9c841a1da1b9c0a4c7ad62bf9960d10271f93"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ae455ecb30d6b65cdfeadd164bc8722cf63fd1ef","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            if volume_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.1\u0027):"},{"line_number":489,"context_line":"                mv_kwargs.update("},{"line_number":490,"context_line":"                    visibility\u003dkwargs.get(\u0027visibility\u0027, \u0027private\u0027),"},{"line_number":491,"context_line":"                    protected\u003dbool(parsed_args.protected)"},{"line_number":492,"context_line":"                )"},{"line_number":493,"context_line":"            else:"},{"line_number":494,"context_line":"                if kwargs.get(\u0027visibility\u0027) or parsed_args.protected:"}],"source_content_type":"text/x-python","patch_set":3,"id":"c066ab8d_b6a01f83","line":491,"in_reply_to":"95615d0c_a480677a","updated":"2022-06-30 10:13:40.000000000","message":"Actually, nvm: this won\u0027t work because we want a tri-state for the other call (to glance)","commit_id":"1da9c841a1da1b9c0a4c7ad62bf9960d10271f93"}]}