)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e53ec01773e0c1b4b420dc5de8b1f24740d4a8c3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch add a check to be sure that the volume created is in a"},{"line_number":10,"context_line":"available state before trying to set bootable or readonly flag."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"resolves: rhbz#1685081"},{"line_number":13,"context_line":"Change-Id: I8db71fd8cf5bd14eb67880f76d2e9135edeb3ed2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d9dcf8d9_2266b5e3","line":12,"updated":"2022-06-16 00:06:21.000000000","message":"Can you create a story and link to that instead?","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"168f12588927623573e7755d8a45d717cac00b7c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch add a check to be sure that the volume created is in a"},{"line_number":10,"context_line":"available state before trying to set bootable or readonly flag."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"resolves: rhbz#1685081"},{"line_number":13,"context_line":"Change-Id: I8db71fd8cf5bd14eb67880f76d2e9135edeb3ed2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4d3a0541_3bd70075","line":12,"in_reply_to":"d9dcf8d9_2266b5e3","updated":"2022-06-16 07:56:27.000000000","message":"Done","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9360d305d02878d4a0e6ad1a056d8b56808b4b68","unresolved":true,"context_lines":[{"line_number":10,"context_line":"available state before trying to set bootable or readonly flag."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: 2002158"},{"line_number":13,"context_line":"resolves: rhbz#1685081"},{"line_number":14,"context_line":"Change-Id: I8db71fd8cf5bd14eb67880f76d2e9135edeb3ed2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3ddd263c_b13e21be","line":13,"updated":"2022-07-13 09:05:20.000000000","message":"This isn\u0027t relevant for upstream bugs. Can you drop it?","commit_id":"8bd7380edc24dbdef9c2dd89af3ff6d4ac3358cc"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"a88a703672ec550dfb1eb07297ae3f7cb8fa3c7b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"available state before trying to set bootable or readonly flag."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: 2002158"},{"line_number":13,"context_line":"resolves: rhbz#1685081"},{"line_number":14,"context_line":"Change-Id: I8db71fd8cf5bd14eb67880f76d2e9135edeb3ed2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"73ff17ed_499bcd0d","line":13,"in_reply_to":"3ddd263c_b13e21be","updated":"2022-07-13 15:41:30.000000000","message":"Done","commit_id":"8bd7380edc24dbdef9c2dd89af3ff6d4ac3358cc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b7ceb9705d244644a0f9480451219ac0616af07e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ce47712e_7548ebd1","updated":"2022-06-20 10:05:59.000000000","message":"I agree that the failures look unrelated, but I don\u0027t know what causes them. I\u0027ve asked the Neutron team for help.","commit_id":"5a17f95184ec979bc3f21ea53461f327c65867a3"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"cbbaf9ac185d906eb103567299e257b573fe95e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9d9fc20b_ac384bdd","updated":"2022-06-20 09:18:36.000000000","message":"The devstack functionnal test jobs are pretty unstable:\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dosc-functional-devstack-tips\u0026skip\u003d0 \n\n@Jens, do you know ?\nThe failure seems completely unrelated with my review.","commit_id":"5a17f95184ec979bc3f21ea53461f327c65867a3"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"d6090b5e70b2dcb05e888eab7103aaebe38a6479","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"14f92ab4_87e6b946","updated":"2022-06-16 20:50:10.000000000","message":"recheck","commit_id":"5a17f95184ec979bc3f21ea53461f327c65867a3"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"cb6821c20649c1d1fc3910c526db9a5adb489b40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d523e55f_db00e24c","updated":"2022-06-20 07:20:35.000000000","message":"recheck","commit_id":"5a17f95184ec979bc3f21ea53461f327c65867a3"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"9f7797d4f62411b5ba2e5f560b614818fe047b5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"55614774_dc389d43","updated":"2022-06-23 07:42:57.000000000","message":"recheck","commit_id":"3217dc12c724ccb5ea8d17ef9bc669c5242f7ffe"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"86384b347c93aee9a3603a619165e504944f74c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b92fdeb4_35aeb120","updated":"2022-06-27 08:33:47.000000000","message":"recheck","commit_id":"3217dc12c724ccb5ea8d17ef9bc669c5242f7ffe"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"71dab7b7a251dc530b6344de19bee6f5fd758be0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"250401d3_61d2db14","updated":"2022-06-30 08:22:46.000000000","message":"I\u0027m wondering if we should not pushed those two jobs as non-voting ?","commit_id":"46c0cb3dedc9f93691d2b56113822a638c7266fb"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"42a97d9ced4166b28e7a4dc280b6f4f139783aab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"80847042_a0b5651c","updated":"2022-06-30 08:22:26.000000000","message":"recheck","commit_id":"46c0cb3dedc9f93691d2b56113822a638c7266fb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9360d305d02878d4a0e6ad1a056d8b56808b4b68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cf17ad9a_1d10ef6c","updated":"2022-07-13 09:05:20.000000000","message":"Some nits but nothing blocking IMO","commit_id":"8bd7380edc24dbdef9c2dd89af3ff6d4ac3358cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0a59023c7c8067e6889b44621c18f285e6d0287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f85a92c1_9f225dfd","updated":"2022-12-20 12:30:22.000000000","message":"I missed that this has been reworked. Sorry!","commit_id":"82171f2276c099d8675e06f764d748b2f52d0817"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"025b13815b37fd8ab51e259a650f7d97ef734a3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ca7756dc_6f810c5a","updated":"2022-07-14 19:52:41.000000000","message":"recheck","commit_id":"82171f2276c099d8675e06f764d748b2f52d0817"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"be476ad3f62a3b5e3a0bfc877d60a4bd7c9e9722","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"50c878be_1aa7fb6a","updated":"2023-02-22 09:55:36.000000000","message":"Fixed minor test issue","commit_id":"5c9c1c77a0d534db475cc7d081283e4b0864b86d"}],"openstackclient/volume/v1/volume.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e53ec01773e0c1b4b420dc5de8b1f24740d4a8c3","unresolved":true,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if parsed_args.bootable or parsed_args.non_bootable:"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                if utils.wait_for_status(volume_client.volumes.get, volume.id,"},{"line_number":228,"context_line":"                                         success_status\u003d[\u0027available\u0027]):"},{"line_number":229,"context_line":"                    volume_client.volumes.set_bootable("},{"line_number":230,"context_line":"                        volume.id, parsed_args.bootable)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4dc5e525_7b52e394","line":227,"updated":"2022-06-16 00:06:21.000000000","message":"I\u0027m not sure that it is the client\u0027s job to wait for this, would like to hear other reviewer\u0027s opinions. \n\nIf at all, this should be configurable (cf. the --wait option on some server operations) and have a timeout. You\u0027d also want to add error_status\u003derror I think.","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"168f12588927623573e7755d8a45d717cac00b7c","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if parsed_args.bootable or parsed_args.non_bootable:"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                if utils.wait_for_status(volume_client.volumes.get, volume.id,"},{"line_number":228,"context_line":"                                         success_status\u003d[\u0027available\u0027]):"},{"line_number":229,"context_line":"                    volume_client.volumes.set_bootable("},{"line_number":230,"context_line":"                        volume.id, parsed_args.bootable)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f6041f7c_6f75f679","line":227,"in_reply_to":"4dc5e525_7b52e394","updated":"2022-06-16 07:56:27.000000000","message":"Done","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e53ec01773e0c1b4b420dc5de8b1f24740d4a8c3","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        if parsed_args.bootable or parsed_args.non_bootable:"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                if utils.wait_for_status(volume_client.volumes.get, volume.id,"},{"line_number":228,"context_line":"                                         success_status\u003d[\u0027available\u0027]):"},{"line_number":229,"context_line":"                    volume_client.volumes.set_bootable("},{"line_number":230,"context_line":"                        volume.id, parsed_args.bootable)"},{"line_number":231,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"295463e7_f559293d","line":228,"updated":"2022-06-16 00:06:21.000000000","message":"Are you sure that \"available\" is the only state the cinder API allows for this to happen? The api-ref doesn\u0027t seem to mention this.","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"168f12588927623573e7755d8a45d717cac00b7c","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        if parsed_args.bootable or parsed_args.non_bootable:"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                if utils.wait_for_status(volume_client.volumes.get, volume.id,"},{"line_number":228,"context_line":"                                         success_status\u003d[\u0027available\u0027]):"},{"line_number":229,"context_line":"                    volume_client.volumes.set_bootable("},{"line_number":230,"context_line":"                        volume.id, parsed_args.bootable)"},{"line_number":231,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba9a8cdc_f46659d2","line":228,"in_reply_to":"295463e7_f559293d","updated":"2022-06-16 07:56:27.000000000","message":"afaik, available is the only state where we can set flags, there other states can not accept this operation.","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"8444175ad06a1a7a9bde2a24559b9356ec6821b9","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        if parsed_args.bootable or parsed_args.non_bootable:"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                if utils.wait_for_status(volume_client.volumes.get, volume.id,"},{"line_number":228,"context_line":"                                         success_status\u003d[\u0027available\u0027]):"},{"line_number":229,"context_line":"                    volume_client.volumes.set_bootable("},{"line_number":230,"context_line":"                        volume.id, parsed_args.bootable)"},{"line_number":231,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fdafddbe_00906c06","line":228,"in_reply_to":"ba9a8cdc_f46659d2","updated":"2022-07-06 08:25:21.000000000","message":"Done","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e53ec01773e0c1b4b420dc5de8b1f24740d4a8c3","unresolved":true,"context_lines":[{"line_number":230,"context_line":"                        volume.id, parsed_args.bootable)"},{"line_number":231,"context_line":"                else:"},{"line_number":232,"context_line":"                    msg \u003d (\"Volume status is not available for setting \""},{"line_number":233,"context_line":"                           \"it bootable.\")"},{"line_number":234,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":235,"context_line":"            except Exception as e:"},{"line_number":236,"context_line":"                LOG.error(_(\"Failed to set volume bootable property: %s\"), e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e21b8ade_ac19e184","line":233,"updated":"2022-06-16 00:06:21.000000000","message":"This message is confusing for the non_bootable option, might need a more generic wording.","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"168f12588927623573e7755d8a45d717cac00b7c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                        volume.id, parsed_args.bootable)"},{"line_number":231,"context_line":"                else:"},{"line_number":232,"context_line":"                    msg \u003d (\"Volume status is not available for setting \""},{"line_number":233,"context_line":"                           \"it bootable.\")"},{"line_number":234,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":235,"context_line":"            except Exception as e:"},{"line_number":236,"context_line":"                LOG.error(_(\"Failed to set volume bootable property: %s\"), e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"83958ac8_e3a2bb35","line":233,"in_reply_to":"e21b8ade_ac19e184","updated":"2022-06-16 07:56:27.000000000","message":"Done","commit_id":"00122984e86f90157d922568e6cd99c60cc7a949"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9360d305d02878d4a0e6ad1a056d8b56808b4b68","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                else:"},{"line_number":235,"context_line":"                    msg \u003d (\"Volume status is not available for setting \""},{"line_number":236,"context_line":"                           \"boot state.\")"},{"line_number":237,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":238,"context_line":"            except Exception as e:"},{"line_number":239,"context_line":"                LOG.error(_(\"Failed to set volume bootable property: %s\"), e)"},{"line_number":240,"context_line":"        if parsed_args.read_only or parsed_args.read_write:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7d9a264d_dfec736a","line":237,"updated":"2022-07-13 09:05:20.000000000","message":"style nit:\n\n  if utils.wait_for_status(\n      volume_client.volumes.get,\n      volume.id,\n      success_status\u003d[\u0027available\u0027],\n      error_status\u003d[\u0027error\u0027],\n      sleep_time\u003d1,\n  ):\n      volume_client.volumes.set_bootable(\n          volume.id,\n          parsed_args.bootable,\n      )\n  else:\n      msg \u003d _(\n          \"Volume status is not available for setting boot \"\n          \"state\"\n      )\n      raise exceptions.CommandError(msg)","commit_id":"8bd7380edc24dbdef9c2dd89af3ff6d4ac3358cc"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"a88a703672ec550dfb1eb07297ae3f7cb8fa3c7b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                else:"},{"line_number":235,"context_line":"                    msg \u003d (\"Volume status is not available for setting \""},{"line_number":236,"context_line":"                           \"boot state.\")"},{"line_number":237,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":238,"context_line":"            except Exception as e:"},{"line_number":239,"context_line":"                LOG.error(_(\"Failed to set volume bootable property: %s\"), e)"},{"line_number":240,"context_line":"        if parsed_args.read_only or parsed_args.read_write:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fe0caa4_1ea71254","line":237,"in_reply_to":"7d9a264d_dfec736a","updated":"2022-07-13 15:41:30.000000000","message":"Ack done","commit_id":"8bd7380edc24dbdef9c2dd89af3ff6d4ac3358cc"}]}