)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"d5569d3620c9cce8640c14266594ee8de5a67c0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63225a56_346b71cf","updated":"2022-06-27 15:13:16.000000000","message":"got stale in Nova for quite a while. Anyway, as a user I would want in the help message to at least see which \u003cDATA\u003e this actually can be. Should it be json, a sting, whatever? Otherwise change is quite straight forward","commit_id":"d2d9d21b375c0acaca2db277b5a05a90be86baf2"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"c6f6c7be744b460df811e57fdc908e4b419df983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ef38ce9_226fd3ed","in_reply_to":"63225a56_346b71cf","updated":"2022-07-04 13:00:42.000000000","message":"Yeah it needed some time to get the spec refined and merged.\nI think it should be clear now for the user that \u003cDATA\u003e should be a base64-encoded string containing the updated user data.","commit_id":"d2d9d21b375c0acaca2db277b5a05a90be86baf2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1fd5393ced8d206dcc84ffef219173208399ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99137a37_5d4d7de0","updated":"2022-09-30 10:45:16.000000000","message":"This is a pretty thorough patch. Nice work! Just have a couple of suggestions inline. Please let me know what you think","commit_id":"8c4bf3e3f0a3f2f14de312877a132a15c60e9722"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"05dc8c711ba8451babb6c5951acbe43e8fe61aef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ef4202c_464e52f4","in_reply_to":"99137a37_5d4d7de0","updated":"2022-10-11 12:07:50.000000000","message":"Hey Stephen, thanks for reviewing this patch!\n\nUnfortunately, the Nova patch did not make it into Zed because of some problems caught last-minute (see Nova patch comments for details). A new spec is needed to push this feature forward.\n\nI will continue working on the python-openstackclient implementation once we know which direction the spec is going, taking your review into account.","commit_id":"8c4bf3e3f0a3f2f14de312877a132a15c60e9722"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1fd5393ced8d206dcc84ffef219173208399ec","unresolved":true,"context_lines":[{"line_number":2921,"context_line":"                \u0027as base64-encoded string \u0027"},{"line_number":2922,"context_line":"                \u0027(supported by --os-compute-api-version 2.93 or above)\u0027"},{"line_number":2923,"context_line":"            ),"},{"line_number":2924,"context_line":"        )"},{"line_number":2925,"context_line":"        return parser"},{"line_number":2926,"context_line":""},{"line_number":2927,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"02637827_fd5b2fec","line":2924,"updated":"2022-09-30 10:45:16.000000000","message":"Can one *unset* user data? Perhaps we need a \u0027--no-user-data\u0027 option to do this?","commit_id":"8c4bf3e3f0a3f2f14de312877a132a15c60e9722"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1fd5393ced8d206dcc84ffef219173208399ec","unresolved":true,"context_lines":[{"line_number":2935,"context_line":"        server \u003d utils.find_resource("},{"line_number":2936,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":2937,"context_line":""},{"line_number":2938,"context_line":"        if parsed_args.user_data is not None:"},{"line_number":2939,"context_line":"            if parsed_args.reboot_type \u003d\u003d servers.REBOOT_HARD:"},{"line_number":2940,"context_line":"                if server.api_version \u003c api_versions.APIVersion(\u00272.93\u0027):"},{"line_number":2941,"context_line":"                    msg \u003d _("}],"source_content_type":"text/x-python","patch_set":4,"id":"f195a45a_2a0a8867","line":2938,"updated":"2022-09-30 10:45:16.000000000","message":"Instead of having two separate calls to \u0027server.reboot\u0027, can we build a kwarg dict that we can use later (like we\u0027ve done below)\n\n  kwargs \u003d {}\n  if parsed_args.user_data is not None:\n      ...\n      \n  server.reboot(parsed_args.reboot_type, **kwargs)","commit_id":"8c4bf3e3f0a3f2f14de312877a132a15c60e9722"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1fd5393ced8d206dcc84ffef219173208399ec","unresolved":true,"context_lines":[{"line_number":2942,"context_line":"                        \u0027--os-compute-api-version 2.93 or greater is \u0027"},{"line_number":2943,"context_line":"                        \u0027required to support the --user-data option\u0027"},{"line_number":2944,"context_line":"                    )"},{"line_number":2945,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":2946,"context_line":"                else:"},{"line_number":2947,"context_line":"                    server.reboot(parsed_args.reboot_type,"},{"line_number":2948,"context_line":"                                  parsed_args.user_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"40359112_a6bacbc8","line":2945,"updated":"2022-09-30 10:45:16.000000000","message":"I don\u0027t see any reason to nest this inside the if-block. This is probably the first thing users should be told if they call this incorrectly (ahead of the reboot type)\n\n  if server.api_version \u003c api_versions.APIVersion(\u00272.93\u0027):\n      msg \u003d _(...)\n      raise exceptions.CommandError(msg)\n      \n  if parsed_args.reboot_type !\u003d servers.REBOOT_HARD:\n      msg \u003d _(...)\n      raise exceptions.CommandError(msg)\n      \n  kwargs[\u0027user_data\u0027] \u003d parsed_args.user_data","commit_id":"8c4bf3e3f0a3f2f14de312877a132a15c60e9722"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1fd5393ced8d206dcc84ffef219173208399ec","unresolved":true,"context_lines":[{"line_number":3957,"context_line":"                \u0027as base64-encoded string \u0027"},{"line_number":3958,"context_line":"                \u0027(supported by --os-compute-api-version 2.93 or above)\u0027"},{"line_number":3959,"context_line":"            ),"},{"line_number":3960,"context_line":"        )"},{"line_number":3961,"context_line":"        return parser"},{"line_number":3962,"context_line":""},{"line_number":3963,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ad9c6a1_3d161d13","line":3960,"updated":"2022-09-30 10:45:16.000000000","message":"As above, do we need a \u0027--no-user-data\u0027 option to unset all user data?","commit_id":"8c4bf3e3f0a3f2f14de312877a132a15c60e9722"}],"openstackclient/tests/unit/compute/v2/test_server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1fd5393ced8d206dcc84ffef219173208399ec","unresolved":false,"context_lines":[{"line_number":8310,"context_line":"class TestServerReboot(TestServer):"},{"line_number":8311,"context_line":""},{"line_number":8312,"context_line":"    def setUp(self):"},{"line_number":8313,"context_line":"        super(TestServerReboot, self).setUp()"},{"line_number":8314,"context_line":""},{"line_number":8315,"context_line":"        self.methods \u003d {"},{"line_number":8316,"context_line":"            \u0027reboot\u0027: None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e2635ad0_4ff9fa4d","line":8313,"range":{"start_line":8313,"start_character":14,"end_line":8313,"end_character":36},"updated":"2022-09-30 10:45:16.000000000","message":"nit: don\u0027t need this in py3","commit_id":"8c4bf3e3f0a3f2f14de312877a132a15c60e9722"}]}