)]}'
{"id":"openstack%2Fpython-openstackclient~848446","triplet_id":"openstack%2Fpython-openstackclient~stable%2Fyoga~I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc","project":"openstack/python-openstackclient","branch":"stable/yoga","topic":"yoga","attention_set":{},"removed_from_attention_set":{"8122":{"account":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"last_update":"2022-07-04 13:32:13.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc","subject":"Fix: create image from volume command","status":"MERGED","created":"2022-07-01 13:27:10.000000000","updated":"2022-07-04 13:34:44.000000000","submitted":"2022-07-04 13:32:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"848446-yoga","meta_rev_id":"866eb019eb5728213d013b406aa7f4fdb6003b6b","_number":848446,"virtual_id_number":848446,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-04 13:32:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-07-04 10:28:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2022-07-04 11:28:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":1,"date":"2022-07-04 11:28:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-01 13:27:10.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"CC"},{"updated":"2022-07-01 14:15:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-01 15:34:07.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2022-07-04 10:28:11.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"fd6dd0f95106b3e0fdc62be6f7ccf3e22aaa9565","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2022-07-01 13:27:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e886111bc9b94c05675d16ae80b3d2567fd7fdc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-01 14:15:34.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bfcde3a4bfee4de1900c07fd9485d651 : SUCCESS in 6m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c7ce3be1f272409d88576b00dc41be30 : SUCCESS in 5m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8b48aac9af5a4a5598dfe5fd4ac9a24d : FAILURE in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/92ef4c78543e41f786dfd0a481d0b683 : SUCCESS in 3m 45s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/961de7f114134e7381064222874c88c6 : SUCCESS in 4m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0c81d27bd72647e1ad5d066290326be7 : SUCCESS in 5m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bda872a31b0849cbb2b8314e887c1e07 : SUCCESS in 3m 59s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/ef1f87110f5d460faad37cd4bc6ece0f : SUCCESS in 7m 09s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/03a78e60917c41088f155dbc3a76d579 : SUCCESS in 44m 39s","accounts_in_message":[],"_revision_number":1},{"id":"26f040d8704ad05c9c21669f6aaa774b97dbac71","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-01 15:34:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"73c24839e569117bcff715526bdb82bb57d2fe43","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2022-07-01 16:05:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"350d68a3a3ac6000ed95cc35b8c84f232cf139d6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-01 17:15:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ccb067e81b4e49ca8d0a4946eb15761a : SUCCESS in 4m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5801567157e24db8be843c7b3c2ba3cf : SUCCESS in 6m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/09a771c7bf6149729eb2eedf23732a60 : SUCCESS in 3m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/486308d0d4194e9dab8cc5d8437248e8 : SUCCESS in 3m 53s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9b2a93bd1a584a7fbcb57cc678e3b39e : SUCCESS in 3m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/862c6cc590af42d3971112b9c24ed7ab : SUCCESS in 6m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/94594a2a36404028ae7db43f78aaf6b0 : SUCCESS in 4m 15s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/5fc3f289263f4f1e9d7236358f417844 : SUCCESS in 7m 23s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/6e98d75ba9a14fa7a94ffb76a54dc7cc : SUCCESS in 1h 03m 37s","accounts_in_message":[],"_revision_number":2},{"id":"c873603843c2777ec8d7c29dc1fdcf2efa5db221","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-07-04 10:28:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0b5f197890950d64087d07c3089b4a8b41c5c52a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-04 11:28:03.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"162d805fc0ff5c6654eed0c158b538215b50c6b6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 11:29:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"db747eda08b03d2da6fbb7e3477603dcbc86c9ce","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:32:13.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/78cfd9076aeb4375aad38797596609e7\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6faf26626c134c47b9749b88e8b3dee7 : SUCCESS in 5m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/155459bcd2f84ab8859b1ddee8292094 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/763fbe3d79d84c5eb691fa9015969f8c : SUCCESS in 4m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fe5787ce07614a54b15fb35cc36122d2 : SUCCESS in 4m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1c143bdfef1a4a4d8bd8ceeecb4daac0 : SUCCESS in 7m 16s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0a9b1cf88e2545659da8ce7b5ca7efa5 : SUCCESS in 4m 11s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/4202da1ae257496c9a668876f3b77aad : SUCCESS in 6m 09s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/0f48ad7213834d61bf79b5365b624d93 : SUCCESS in 1h 05m 50s","accounts_in_message":[],"_revision_number":2},{"id":"5bf07215e2dc5d03d8c122445f0a3e2b9c9944a8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:32:13.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"866eb019eb5728213d013b406aa7f4fdb6003b6b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:34:44.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9ec59213ec2d47e6a8a8875fc0f2c8c5\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/800687feaa074b1ea88ff1d4ff45b5c1 : SUCCESS in 48s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/801bd4adc1154cb88cb07e896629d92f : SUCCESS in 46s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/565abfdc84ba4c43b343d5b0788fe9b7 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"849e7e93f83a220265d11af71e2edc009c3f7bea","revisions":{"933cff7cb189dc6a2e3eb141b40aca74693c87f9":{"kind":"REWORK","_number":1,"created":"2022-07-01 13:27:10.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/46/848446/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/46/848446/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/848446/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/848446/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/848446/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/46/848446/1"}}},"commit":{"parents":[{"commit":"97c81cf61f6ab32c93e3de02b91b1e69acada396","subject":"Update TOX_CONSTRAINTS_FILE for stable/yoga","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/97c81cf61f6ab32c93e3de02b91b1e69acada396"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-06-01 09:21:29.000000000","tz":330},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2022-07-01 13:26:36.000000000","tz":120},"subject":"Fix: create image from volume command","message":"Fix: create image from volume command\n\nCurrently the command ``openstack image create --volume`` calls cinderclient\nto upload the volume to image service (glance) but OSC passes ``visibility``\nand ``protected`` fields which are only available in microversion 3.1 or\ngreater. This generates an error if the user is using volume microversion\n\u003c 3.1 and wants to create an image from volume.\nThis patch fixes that by only passing ``visibility`` and ``protected`` fields\nwhen the volume microversion is 3.1 or greater and fail otherwise i.e. the\nfollowing 3 cases:\n1) visibility/protected argument + mv \u003e\u003d 3.1 \u003d pass\n2) visibility/protected argument + mv \u003c 3.1 \u003d fail\n3) not visibility/protected argument + any mv \u003d pass\n\nStory: 2010060\nTask: 45511\nChange-Id: I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc\n(cherry picked from commit 9eea28ba59e44526b9d6f1ad9f80c3553d5853e2)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/933cff7cb189dc6a2e3eb141b40aca74693c87f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/933cff7cb189dc6a2e3eb141b40aca74693c87f9"}]},"branch":"refs/heads/stable/yoga"},"849e7e93f83a220265d11af71e2edc009c3f7bea":{"kind":"REWORK","_number":2,"created":"2022-07-01 16:05:47.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/46/848446/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/46/848446/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/848446/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/848446/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/848446/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/46/848446/2"}}},"commit":{"parents":[{"commit":"97c81cf61f6ab32c93e3de02b91b1e69acada396","subject":"Update TOX_CONSTRAINTS_FILE for stable/yoga","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/97c81cf61f6ab32c93e3de02b91b1e69acada396"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-06-01 09:21:29.000000000","tz":330},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2022-07-01 16:05:41.000000000","tz":120},"subject":"Fix: create image from volume command","message":"Fix: create image from volume command\n\nCurrently the command ``openstack image create --volume`` calls cinderclient\nto upload the volume to image service (glance) but OSC passes ``visibility``\nand ``protected`` fields which are only available in microversion 3.1 or\ngreater. This generates an error if the user is using volume microversion\n\u003c 3.1 and wants to create an image from volume.\nThis patch fixes that by only passing ``visibility`` and ``protected`` fields\nwhen the volume microversion is 3.1 or greater and fail otherwise i.e. the\nfollowing 3 cases:\n1) visibility/protected argument + mv \u003e\u003d 3.1 \u003d pass\n2) visibility/protected argument + mv \u003c 3.1 \u003d fail\n3) not visibility/protected argument + any mv \u003d pass\n\nStory: 2010060\nTask: 45511\nChange-Id: I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc\n(cherry picked from commit 9eea28ba59e44526b9d6f1ad9f80c3553d5853e2)\nConflicts:\n\topenstackclient/image/v2/image.py\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/849e7e93f83a220265d11af71e2edc009c3f7bea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/849e7e93f83a220265d11af71e2edc009c3f7bea"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[]}
