)]}'
{"id":"openstack%2Fpython-openstackclient~848449","triplet_id":"openstack%2Fpython-openstackclient~stable%2Fwallaby~I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc","project":"openstack/python-openstackclient","branch":"stable/wallaby","topic":"wallaby","attention_set":{},"removed_from_attention_set":{"8122":{"account":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"last_update":"2022-07-04 13:38:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc","subject":"Fix: create image from volume command","status":"MERGED","created":"2022-07-01 13:35:09.000000000","updated":"2022-07-04 13:39:49.000000000","submitted":"2022-07-04 13:38:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"848449-wallaby","meta_rev_id":"0516b766947bcfce8203f5e9ad88f76bf98dd4ed","_number":848449,"virtual_id_number":848449,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-04 13:38:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2022-07-04 11:36:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":1,"date":"2022-07-04 11:36:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-01 13:35:09.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"CC"},{"updated":"2022-07-01 14:41:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-01 15:45:32.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2022-07-04 10:27:42.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"03e384c4f7b86a5b8dba43d3ce8596338b71f72e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2022-07-01 13:35:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"feb2d1c1bcaf6cc58dee6586c959f9d7bfbf7de8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-01 14:41:46.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1a76507da5b94fd18697289749506ef5 : FAILURE in 4m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4c3329012a09449d970d8f8ace98d92c : FAILURE in 5m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/13153388a3b240cab037f08acad52671 : FAILURE in 3m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ef93d6c271d2408db8adad1bcf852da2 : FAILURE in 3m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d2c8d9f7a7984dabbcb1b2ec7d00c125 : FAILURE in 3m 26s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/544546be860343bdb2c685a616656638 : FAILURE in 4m 48s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0133795889e746c099a0eafe6ce9277e : SUCCESS in 6m 02s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e4ba202b4b61480eb6c1fc6fafdcb08c : SUCCESS in 4m 52s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/d761c920a8a34764aa7d96576965a636 : SUCCESS in 7m 50s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/6509517a157d4228868132b579e119a7 : SUCCESS in 1h 01m 48s","accounts_in_message":[],"_revision_number":1},{"id":"9e76477bf69e0fc4a41bd3450415c6d343b103cb","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-01 15:45:32.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1a14fbcc2675cfb012cbe789ad3929b1ff8a933c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2022-07-01 16:23:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ff8968e3eb6d4a1a774385987a3d802c00d4fee5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-01 17:21:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e05d3f49359f457c9ae08e3710e8e284 : SUCCESS in 4m 22s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/798c6450302b4a3daf1598fff0df63b2 : SUCCESS in 5m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5c7f3301f0964003b936b8e6fbe43617 : SUCCESS in 4m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2873e1a2b81b43b3beadc9163cc45c05 : SUCCESS in 3m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e7ca43414c114435b6755ccbd034fa75 : SUCCESS in 3m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/96c664286a144c3986a74f58560f5639 : SUCCESS in 3m 52s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/126266fd9b544792aa8be5a93c906f43 : SUCCESS in 6m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/76815cb384ce49fc9e5179845e0b0666 : SUCCESS in 3m 33s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/855438b4ac794f4f832dd5ad2a095f60 : SUCCESS in 5m 25s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/e95c4d29331546ec877a1cba16d98fdc : SUCCESS in 56m 43s","accounts_in_message":[],"_revision_number":2},{"id":"f2029ca557b97268a444218a09b61acc4f4e27b2","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-07-04 10:27:42.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7eeaab1b48c3c8a3b9d9f7d42ef50ffbd22c85c2","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-04 11:00:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"26047fa0789217ecaf9ce6b31ffa699e1b1b38c8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 11:01:28.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9a4715c481b5f8ab30ce38c682a83d257b94b94f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-04 11:28:37.000000000","message":"Patch Set 2: -Workflow\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b348b0dcc4d2df413837a0df78c2c593572a8a87","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 11:28:53.000000000","message":"Patch Set 2: Verified-2\n\nThis change is unable to merge due to a missing merge requirement.","accounts_in_message":[],"_revision_number":2},{"id":"4a53139601651e172b711cd9b3a633d71cd4f9fc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-04 11:35:48.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"bb72820a2ee6c34e95596d06aa5d23db20debc3a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-04 11:36:14.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"71f5e810d298044356d4323ab896bceb0ba28c96","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 12:26:46.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/44a914b929f34c97b43704c7dee1c6a8\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6d38fdb721fb4940b0b2f6abc9d50bf0 : SUCCESS in 5m 25s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/74867886130c43f385e60a80ee23dd4b : SUCCESS in 5m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/298586df269b4484958d3ea8955614c9 : SUCCESS in 3m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1374af17441c4900b5613c6fda4edc3e : SUCCESS in 3m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0f8c735e4b984a12aac4e7667d9cd701 : SUCCESS in 3m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b96be5947f19403fbff279102af5c285 : SUCCESS in 3m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5b6d16b80a9d4efe8c25da38bc4e0fca : SUCCESS in 6m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/588015bb2bc84397af82baad0f988b7b : SUCCESS in 3m 35s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/40e7f31de22f40f3a0188d3d6500b075 : SUCCESS in 5m 59s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/1b3748bc09a6481a88fc3c751d48f655 : SUCCESS in 49m 34s","accounts_in_message":[],"_revision_number":3},{"id":"80a09fbe18c767165fd2307a2a03ede501609dd4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 12:27:36.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"8166f040750e5ab3f02139bc0462f567013f4550","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:38:29.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/834cb3b9f05442f5b8c30ea992f3238b\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/873e40001b8a4578aeb5c7f918dd0db4 : SUCCESS in 3m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/91f56b8787aa4283b43242786a1427ec : SUCCESS in 3m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e5f34d737caa4ef8b70916aa5862e559 : SUCCESS in 3m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b57f41285454485687b16e7a51f7eed1 : SUCCESS in 7m 13s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bf71d67e022b4eb1a30716f3326dcc4a : SUCCESS in 4m 28s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/3e391267e4ef4e4c8453e782728459ea : SUCCESS in 6m 42s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/c6c80c46446f47fc8b317d184dbc1629 : SUCCESS in 1h 05m 09s","accounts_in_message":[],"_revision_number":3},{"id":"c379fa487280c570f89ff5bb83a9367f4a25141b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:38:29.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"0516b766947bcfce8203f5e9ad88f76bf98dd4ed","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:39:49.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a43244e5aaee4489a66f4d53ca78fc35\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4334b0b050d048bf8edcf00d2bd6b91e : SUCCESS in 59s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/98abad3654fe4ae0bd08be25f99e2a0d : SUCCESS in 49s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/f98a132fb2174869aea56e23528d9886 : SUCCESS in 48s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9425e6fcb6b907fbae7e1eb6b01ad293199cee75","revisions":{"4431611ccf705195d28af20ab2f297027dd0d7fd":{"kind":"REWORK","_number":1,"created":"2022-07-01 13:35:09.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/49/848449/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/49/848449/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/1"}}},"commit":{"parents":[{"commit":"b39fe0b46380686e33b737633deff753d35691d9","subject":"openstack image create: honor protection/visibility flags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b39fe0b46380686e33b737633deff753d35691d9"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-06-01 09:21:29.000000000","tz":330},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2022-07-01 13:34:20.000000000","tz":120},"subject":"Fix: create image from volume command","message":"Fix: create image from volume command\n\nCurrently the command ``openstack image create --volume`` calls cinderclient\nto upload the volume to image service (glance) but OSC passes ``visibility``\nand ``protected`` fields which are only available in microversion 3.1 or\ngreater. This generates an error if the user is using volume microversion\n\u003c 3.1 and wants to create an image from volume.\nThis patch fixes that by only passing ``visibility`` and ``protected`` fields\nwhen the volume microversion is 3.1 or greater and fail otherwise i.e. the\nfollowing 3 cases:\n1) visibility/protected argument + mv \u003e\u003d 3.1 \u003d pass\n2) visibility/protected argument + mv \u003c 3.1 \u003d fail\n3) not visibility/protected argument + any mv \u003d pass\n\nStory: 2010060\nTask: 45511\nChange-Id: I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc\n(cherry picked from commit 9eea28ba59e44526b9d6f1ad9f80c3553d5853e2)\n(cherry picked from commit 933cff7cb189dc6a2e3eb141b40aca74693c87f9)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4431611ccf705195d28af20ab2f297027dd0d7fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4431611ccf705195d28af20ab2f297027dd0d7fd"}]},"branch":"refs/heads/stable/wallaby"},"ab6560973cda3cac026c66c5a1ed263cc0af5137":{"kind":"REWORK","_number":2,"created":"2022-07-01 16:23:11.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/49/848449/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/49/848449/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/2"}}},"commit":{"parents":[{"commit":"b39fe0b46380686e33b737633deff753d35691d9","subject":"openstack image create: honor protection/visibility flags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b39fe0b46380686e33b737633deff753d35691d9"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-06-01 09:21:29.000000000","tz":330},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2022-07-01 16:22:50.000000000","tz":120},"subject":"Fix: create image from volume command","message":"Fix: create image from volume command\n\nCurrently the command ``openstack image create --volume`` calls cinderclient\nto upload the volume to image service (glance) but OSC passes ``visibility``\nand ``protected`` fields which are only available in microversion 3.1 or\ngreater. This generates an error if the user is using volume microversion\n\u003c 3.1 and wants to create an image from volume.\nThis patch fixes that by only passing ``visibility`` and ``protected`` fields\nwhen the volume microversion is 3.1 or greater and fail otherwise i.e. the\nfollowing 3 cases:\n1) visibility/protected argument + mv \u003e\u003d 3.1 \u003d pass\n2) visibility/protected argument + mv \u003c 3.1 \u003d fail\n3) not visibility/protected argument + any mv \u003d pass\n\nStory: 2010060\nTask: 45511\n(cherry picked from commit 9eea28ba59e44526b9d6f1ad9f80c3553d5853e2)\nConflicts:\n\topenstackclient/image/v2/image.py\nChanges:\nImported openstackclient/tests/unit/volume/v3/fakes.py from the Yoga\nbranch.\nUsed FakeType instead of FakeVolumeType for compatibility with older\nclass names.\n\n(cherry picked from commit 849e7e93f83a220265d11af71e2edc009c3f7bea)\nChange-Id: I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab6560973cda3cac026c66c5a1ed263cc0af5137"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab6560973cda3cac026c66c5a1ed263cc0af5137"}]},"branch":"refs/heads/stable/wallaby"},"9425e6fcb6b907fbae7e1eb6b01ad293199cee75":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-07-04 11:35:48.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/49/848449/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/49/848449/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/49/848449/3"}}},"commit":{"parents":[{"commit":"b39fe0b46380686e33b737633deff753d35691d9","subject":"openstack image create: honor protection/visibility flags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b39fe0b46380686e33b737633deff753d35691d9"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-06-01 09:21:29.000000000","tz":330},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2022-07-04 11:35:48.000000000","tz":0},"subject":"Fix: create image from volume command","message":"Fix: create image from volume command\n\nCurrently the command ``openstack image create --volume`` calls cinderclient\nto upload the volume to image service (glance) but OSC passes ``visibility``\nand ``protected`` fields which are only available in microversion 3.1 or\ngreater. This generates an error if the user is using volume microversion\n\u003c 3.1 and wants to create an image from volume.\nThis patch fixes that by only passing ``visibility`` and ``protected`` fields\nwhen the volume microversion is 3.1 or greater and fail otherwise i.e. the\nfollowing 3 cases:\n1) visibility/protected argument + mv \u003e\u003d 3.1 \u003d pass\n2) visibility/protected argument + mv \u003c 3.1 \u003d fail\n3) not visibility/protected argument + any mv \u003d pass\n\nChanges:\n  openstackclient/tests/unit/volume/v3/fakes.py\n  \nNOTE(croelandt): Imported openstackclient/tests/unit/volume/v3/fakes.py from\nthe Yoga branch. Used FakeType instead of FakeVolumeType for compatibility with\nolder class names.\n\nStory: 2010060\nTask: 45511\nChange-Id: I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc\n(cherry picked from commit 9eea28ba59e44526b9d6f1ad9f80c3553d5853e2)\n(cherry picked from commit 849e7e93f83a220265d11af71e2edc009c3f7bea)\n(cherry picked from commit 665d93ff0721801896bf08c3cc4f189a55daae80)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9425e6fcb6b907fbae7e1eb6b01ad293199cee75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9425e6fcb6b907fbae7e1eb6b01ad293199cee75"}]},"branch":"refs/heads/stable/wallaby","description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[]}