)]}'
{"id":"openstack%2Fpython-openstackclient~848618","triplet_id":"openstack%2Fpython-openstackclient~stable%2Fxena~I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc","project":"openstack/python-openstackclient","branch":"stable/xena","topic":"story/2010060","hashtags":[],"change_id":"I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc","subject":"Fix: create image from volume command","status":"MERGED","created":"2022-07-04 11:33:21.000000000","updated":"2022-07-04 13:35:54.000000000","submitted":"2022-07-04 13:32:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"848618-story/2010060","meta_rev_id":"c3a6fa33bd053a7edc84847d4764b319a064533b","_number":848618,"virtual_id_number":848618,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-04 13:32:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-07-04 11:43:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-07-04 11:43:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-04 11:33:21.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"CC"},{"updated":"2022-07-04 12:25:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8653aaeab484e4e8a5f77a98991244659de5d3ea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-04 11:33:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2be7f4df2955ef36d7a6b857346a0ff630c5216c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-04 11:43:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"305aa2566b6b168d7f12b59b963aba704238da6d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 12:25:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a0147d0b11f44df4a5dd0b09ee605c73\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c04b296d07b3461287a8c1d6f94465f2 : SUCCESS in 4m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b78be27afbe740caa398f1ceb3995db3 : SUCCESS in 6m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c7a9adba4f2f4a5987cefaffda806788 : SUCCESS in 3m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4d0cab0f155f4c5f9276a371fc52c7cd : SUCCESS in 3m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/313ec043adc34285a91f835dbc5161e9 : SUCCESS in 3m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/75bd8cac536b4b64a07452b13f24fa49 : SUCCESS in 4m 03s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/03d6e42a1aba436d9c7a494c077dfd5b : SUCCESS in 7m 14s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/75959e0ab8a84b3f99d91c90154a930a : SUCCESS in 4m 32s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/a5e007fea4f04ac6987015c0abc0bca2 : SUCCESS in 6m 08s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/548e4917a30a434a9a741ff80f404456 : SUCCESS in 50m 52s","accounts_in_message":[],"_revision_number":1},{"id":"7b07fe3d1e4fe4de5598bf960596b9622d0e6377","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 12:26:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2c57bcfe9fcf46eb31125fa69d5173e31799c2df","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:32:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ce87c44a0c57468a9d60b852926891cd\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eed131b841994aaa87932aa632116ed8 : SUCCESS in 4m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dbac9ace8c744fdb91fbe94c64321495 : SUCCESS in 5m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bdc6d08d6f5a40a09f259482a99a48a8 : SUCCESS in 4m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/00ab7d256ca9455c80e2ca8c74d3320d : SUCCESS in 7m 29s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e5d645a7af874ab88d5f3cd106b53abf : SUCCESS in 4m 53s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/048f59a2e21348598652f819344f87f6 : SUCCESS in 7m 55s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/c571ee0908954042b48240e2b7e5e68a : SUCCESS in 48m 26s","accounts_in_message":[],"_revision_number":1},{"id":"b506b0561529f70308b612d9cc85410d934bbfbb","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:32:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"c3a6fa33bd053a7edc84847d4764b319a064533b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-04 13:35:54.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8899516584064c438682a421499bd7c3\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ecdda9209e7b466ba557f13ff6b6cce4 : SUCCESS in 49s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/793c045bef5c45a480c7240538220e4c : SUCCESS in 1m 25s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/46416fda23674796972536df223226e3 : SUCCESS in 44s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"665d93ff0721801896bf08c3cc4f189a55daae80","revisions":{"665d93ff0721801896bf08c3cc4f189a55daae80":{"kind":"REWORK","_number":1,"created":"2022-07-04 11:33:21.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/18/848618/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/18/848618/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/848618/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/848618/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/848618/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/18/848618/1"}}},"commit":{"parents":[{"commit":"cbc64f9469600624e74631f42ca214487e800155","subject":"compute: Fix filtering servers by tags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cbc64f9469600624e74631f42ca214487e800155"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-06-01 09:21:29.000000000","tz":330},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2022-07-04 11:30:08.000000000","tz":60},"subject":"Fix: create image from volume command","message":"Fix: create image from volume command\n\nCurrently the command ``openstack image create --volume`` calls cinderclient\nto upload the volume to image service (glance) but OSC passes ``visibility``\nand ``protected`` fields which are only available in microversion 3.1 or\ngreater. This generates an error if the user is using volume microversion\n\u003c 3.1 and wants to create an image from volume.\nThis patch fixes that by only passing ``visibility`` and ``protected`` fields\nwhen the volume microversion is 3.1 or greater and fail otherwise i.e. the\nfollowing 3 cases:\n1) visibility/protected argument + mv \u003e\u003d 3.1 \u003d pass\n2) visibility/protected argument + mv \u003c 3.1 \u003d fail\n3) not visibility/protected argument + any mv \u003d pass\n\nStory: 2010060\nTask: 45511\nChange-Id: I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc\n(cherry picked from commit 9eea28ba59e44526b9d6f1ad9f80c3553d5853e2)\n(cherry picked from commit 849e7e93f83a220265d11af71e2edc009c3f7bea)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/665d93ff0721801896bf08c3cc4f189a55daae80"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/665d93ff0721801896bf08c3cc4f189a55daae80"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[]}