)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"39232de4cefabc9147fbfde946b8cba0e9900269","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f978397_5b6ee5fd","updated":"2022-07-13 13:44:56.000000000","message":"Good start. Obviously needs tests and some style fixes to keep CI happy","commit_id":"78cb24d40852841df3b459df11de23401752698a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6045c7ab4ab40ffac186ec1d8c418a54a1286fcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ac9c3ea_e77a2d79","in_reply_to":"0f978397_5b6ee5fd","updated":"2022-07-13 18:14:10.000000000","message":"yes, pep8 fixes and unit tests are coming in the next patch-set","commit_id":"78cb24d40852841df3b459df11de23401752698a"}],"openstackclient/identity/v3/identity_provider.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bc0526ebe3111afd41a8c6dd931c99c3533035dc","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                   \u0027authenticating via this identity provider. \u0027"},{"line_number":72,"context_line":"                   \u0027When not provided, global default configured in the \u0027"},{"line_number":73,"context_line":"                   \u0027Identity service will be used. \u0027"},{"line_number":74,"context_line":"                   \u0027Available since Identity API version 3.14 (Ussuri).\u0027),"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        enable_identity_provider \u003d parser.add_mutually_exclusive_group()"},{"line_number":77,"context_line":"        enable_identity_provider.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"7609b8bb_d18ea9f1","line":74,"updated":"2022-07-13 13:44:40.000000000","message":"Can we add an API version check for this so?","commit_id":"78cb24d40852841df3b459df11de23401752698a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6045c7ab4ab40ffac186ec1d8c418a54a1286fcc","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                   \u0027authenticating via this identity provider. \u0027"},{"line_number":72,"context_line":"                   \u0027When not provided, global default configured in the \u0027"},{"line_number":73,"context_line":"                   \u0027Identity service will be used. \u0027"},{"line_number":74,"context_line":"                   \u0027Available since Identity API version 3.14 (Ussuri).\u0027),"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        enable_identity_provider \u003d parser.add_mutually_exclusive_group()"},{"line_number":77,"context_line":"        enable_identity_provider.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc08357_5fe0f129","line":74,"in_reply_to":"7609b8bb_d18ea9f1","updated":"2022-07-13 18:14:10.000000000","message":"Having quickly looked around keystoneclient, I did not immediately find any such fine-grained machinery for api microversions as in e.g. novaclient or cinderclient. May be need to look more thorughly though..","commit_id":"78cb24d40852841df3b459df11de23401752698a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"d118bce756f074109dc77d8d3b4f793083ffb6f7","unresolved":true,"context_lines":[{"line_number":281,"context_line":"        # TODO(pas-ha) actually check for 3.14 microversion"},{"line_number":282,"context_line":"        auth_ttl \u003d parsed_args.authorization_ttl"},{"line_number":283,"context_line":"        if parsed_args.default_authorization_ttl:"},{"line_number":284,"context_line":"            kwargs[\u0027authorization_ttl\u0027] \u003d None"},{"line_number":285,"context_line":"        elif auth_ttl is not None:"},{"line_number":286,"context_line":"            if auth_ttl \u003c 0:"},{"line_number":287,"context_line":"                msg \u003d (_(\"%(param)s must be positive integer or zero.\""}],"source_content_type":"text/x-python","patch_set":3,"id":"2bcdad59_929063f4","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":46},"updated":"2022-07-13 18:58:46.000000000","message":"Actually tried this and it does not seem to work... The fields with None value are removed from the final request :-/\nNeed to check if it would be possible at all with keystoneclient as is, or would need some patch there too.\nIf patch will be needed, I\u0027d rather first remove this \u0027reset to default\u0027 functionality for now to let everything else be available already, and implement this later.\n\nDefinitely works with curl though, as in:\n\n  -X PATCH \u003cidentity-endpoint\u003e/v3/OS-FEDERATION/identity_providers/\u003cidp\u003e -d \u0027{\"identity_provider\": {\"authorization_ttl\": null}}\u0027","commit_id":"df1c8f74a9361b6ae707952e7a65ee87e65f702b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"bdfb6f0557f1f7c388d498db9dffc21d4198669b","unresolved":true,"context_lines":[{"line_number":281,"context_line":"        # TODO(pas-ha) actually check for 3.14 microversion"},{"line_number":282,"context_line":"        auth_ttl \u003d parsed_args.authorization_ttl"},{"line_number":283,"context_line":"        if parsed_args.default_authorization_ttl:"},{"line_number":284,"context_line":"            kwargs[\u0027authorization_ttl\u0027] \u003d None"},{"line_number":285,"context_line":"        elif auth_ttl is not None:"},{"line_number":286,"context_line":"            if auth_ttl \u003c 0:"},{"line_number":287,"context_line":"                msg \u003d (_(\"%(param)s must be positive integer or zero.\""}],"source_content_type":"text/x-python","patch_set":3,"id":"150cc48d_dd812d29","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":46},"in_reply_to":"2bcdad59_929063f4","updated":"2022-07-13 19:29:46.000000000","message":"unfortunately it is not possible ATM to pass None/null value in a patch in keystoneclient, these are specifically filtered out\n\nhttps://opendev.org/openstack/python-keystoneclient/src/branch/master/keystoneclient/base.py#L75\n\nso I will just remove this functionality for now in this patch with some notes/comments/TODOs for later","commit_id":"df1c8f74a9361b6ae707952e7a65ee87e65f702b"}]}