)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"063999a4ddee47606c9d3dc28e54fd924ff03104","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Added \"openstack image namespace list\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibc064566478818bd70e7e6550095d24a05e1bb0e"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/854612"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c8f1abc0_adf99802","line":10,"updated":"2022-08-29 10:12:07.000000000","message":"Depends-On: Ibb86d74419faf066edca1a43d2d4da005db780ea","commit_id":"b9c40954a4bff9043e40581fe230b82d54b14668"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"7991a16cd8aa65b478091dbbe4946faee94fcfa3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added \"openstack image namespace list\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibc064566478818bd70e7e6550095d24a05e1bb0e"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/854612"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa6c4ee_b237f29f","line":10,"in_reply_to":"067d6ac5_b8f8ff80","updated":"2022-09-01 08:28:37.000000000","message":"The latest patch set has the original version for the dependency again.","commit_id":"b9c40954a4bff9043e40581fe230b82d54b14668"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"556884b088eb6dc194cb7c0b834f9928ea3adae5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Added \"openstack image namespace list\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibc064566478818bd70e7e6550095d24a05e1bb0e"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/854612"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"067d6ac5_b8f8ff80","line":10,"in_reply_to":"c8f1abc0_adf99802","updated":"2022-08-30 15:59:55.000000000","message":"No, what you\u0027ve done here is fine. In fact, I think it might even be preferred now.","commit_id":"b9c40954a4bff9043e40581fe230b82d54b14668"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35203,"name":"Areg Grigoryan","email":"argrigor@cern.ch","username":"argrigor"},"change_message_id":"63d4381f4a6a288d68db469cfd583bf0941bc73e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26f8de76_fd8eaf81","updated":"2022-08-25 08:22:02.000000000","message":"This command does the same thing as \"glance md-namespace-list\". \nWhen working on this command we found a bug in the openstacksdk files, and proposed a fix: https://review.opendev.org/c/openstack/openstacksdk/+/853656/6\nThis patch will not work without the bugfix.\n","commit_id":"a14915ef9f82e4565fe8b303674ca5fdde73c0d5"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"063999a4ddee47606c9d3dc28e54fd924ff03104","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8551e0d_8947aa67","updated":"2022-08-29 10:12:07.000000000","message":"Try updating the commit message (see inline).","commit_id":"b9c40954a4bff9043e40581fe230b82d54b14668"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"556884b088eb6dc194cb7c0b834f9928ea3adae5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9d69a8d9_949f78d0","updated":"2022-08-30 15:59:55.000000000","message":"Great start. I\u0027d like to see us implement the other commands here, but if you\u0027d like to do those separately then that\u0027s okay, we can do that. However, there are a leftover print statements here that you have to remove and we could also do with a release note. You can generate a release note using reno:\n\n  $ sudo dnf install python-reno  # or Ubuntu/pip equivalent\n  $ reno new add-image-metadef-namespace-support  # or your own filename\n  # edit the file created\n\nFinally, we should think about the naming of this. I\u0027ve comments inline about this.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"7991a16cd8aa65b478091dbbe4946faee94fcfa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"359e399f_e64dae95","updated":"2022-09-01 08:28:37.000000000","message":"Many thanks for the comments. Since Areg left I\u0027m taking over from here. For additional commands, I think the best is to have dedicated merge requests to keep the individual changes small.","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"465a68ba_fc5ac824","updated":"2022-09-01 15:23:09.000000000","message":"Still a couple of changes needed here. This is looking better already though 😊","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"5bad40f9425b06e7ab2850c07708dccbd475ca8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"796e155c_c51e15b6","updated":"2022-09-01 15:01:55.000000000","message":"Thanks a lot for the quick review! \nThe new patch set should fix those. I also changed back to the original dependency on the openstacksdk repository. It seems that this is the reason for the failure of the test.\n\n","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3da8552e_5bedbd02","updated":"2022-09-06 06:51:58.000000000","message":"This is still work in progress. Patchset7 adapts to the recent updates in openstacksdk, mainly renaming of things.\n\nIssues still being looked into are:\n- add command line options (at least the visibility one)\n- review of tests (locally they do not seem to be executed for some reason)\n","commit_id":"2293ce60532a9b9a7653c69e124d45af615c8b83"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"143625e6ab229a958c57d497f7fe13d40f9e045e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"33016556_18238912","updated":"2022-09-06 11:06:19.000000000","message":"The two command line options are implemented as well now.\n","commit_id":"9da1fdcfd7b188fe9d1fff4a348fd9f654be3fec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7a594065_c28dd81f","updated":"2022-09-14 10:35:53.000000000","message":"Very close. I\u0027ve a few nits inline. If you can fix these, I\u0027m +2 😊","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cf73e4dd_1368e0b3","updated":"2022-09-19 08:26:47.000000000","message":"Hi, all! Sorry for the delay in processing this, I got busy with something else and had to postpone this for a bit. \nThanks a lot for the review! In addition to addressing the comments, I have reviewed the tests as I think the original version was sub-optimal (actually, I found it was not discovered thus not executed by tox, at least locally). The new patch set fixes this. Please take a look if it makes sense to you this way.\n","commit_id":"e95e35e52968966e12ac2a66a45a44bc9fca4a8d"},{"author":{"_account_id":33859,"name":"Yoon Soo Lim","display_name":"yoonsoolim","email":"msdbtjd123@naver.com","username":"yoonsoolim"},"change_message_id":"add9117fb7a86ce70def023f99cba6f77a8f841d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"dbeceebc_31c97f5c","updated":"2022-09-30 00:40:16.000000000","message":"RECHECK","commit_id":"3dd5643af84023d655dc7d9e72ce2ea8dd96f3a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4657c74153795897fd6133d0e4614c0980e2d13f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"517b4294_9be983c0","updated":"2022-09-28 10:47:31.000000000","message":"We need to cut a new release of openstacksdk before we can merge this. I\u0027ll talk to gtema about what\u0027s involved here.","commit_id":"3dd5643af84023d655dc7d9e72ce2ea8dd96f3a9"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"81df84aebe8e8ac96095f809893a0465e4927fd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"a051e0b5_89260f7b","updated":"2022-10-17 21:09:31.000000000","message":"RECHECK","commit_id":"0858b5cc1656d410620dd7d986a27f83af24ab13"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"59038c20840bb8eba5ea63bebca181114fa91f46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"1f4cea2b_d063bd31","updated":"2022-10-26 09:24:53.000000000","message":"Actually, we can do that in a follow-up","commit_id":"d6584dce08efe37da12807829d4bdd386b8caf7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fbf8f2332d59db7b5b33888b69e895602e4b0e57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b9f8416d_5881e450","updated":"2022-10-26 09:23:56.000000000","message":"The fixes have been released in openstacksdk 0.102.0. Can you bump the version in requirements.txt and we can merge this?","commit_id":"d6584dce08efe37da12807829d4bdd386b8caf7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e8b9a8daf792bfab096cec5b3e5621d110cb0f0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"42e2c64f_21bc597e","updated":"2022-10-26 09:26:35.000000000","message":"Never mind, I squeezed it in here.","commit_id":"a726d84f4b7cec761d3d82824997969dffbd4249"}],"openstackclient/image/v2/image.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"556884b088eb6dc194cb7c0b834f9928ea3adae5","unresolved":true,"context_lines":[{"line_number":1471,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"class ListNamespace(command.Lister):"},{"line_number":1475,"context_line":"    _description \u003d _(\"List namespace\")"},{"line_number":1476,"context_line":""},{"line_number":1477,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"4cc8df4b_2188c8e6","line":1474,"updated":"2022-08-30 15:59:55.000000000","message":"We\u0027re no longer talking about images here so this shouldn\u0027t go into the \u0027image\u0027 module. Can you create a new \u0027metadef_namespace.py\u0027 file, please?","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"7991a16cd8aa65b478091dbbe4946faee94fcfa3","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"class ListNamespace(command.Lister):"},{"line_number":1475,"context_line":"    _description \u003d _(\"List namespace\")"},{"line_number":1476,"context_line":""},{"line_number":1477,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a0e17843_eed98047","line":1474,"in_reply_to":"4cc8df4b_2188c8e6","updated":"2022-09-01 08:28:37.000000000","message":"Fixed in patchset6. New file named metadefs_namespace.py.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"556884b088eb6dc194cb7c0b834f9928ea3adae5","unresolved":true,"context_lines":[{"line_number":1475,"context_line":"    _description \u003d _(\"List namespace\")"},{"line_number":1476,"context_line":""},{"line_number":1477,"context_line":"    def get_parser(self, prog_name):"},{"line_number":1478,"context_line":"        parser \u003d super(ListNamespace, self).get_parser(prog_name)"},{"line_number":1479,"context_line":"        common.add_project_domain_option_to_parser(parser)"},{"line_number":1480,"context_line":"        return parser"},{"line_number":1481,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c0b78229_6a2385d1","line":1478,"range":{"start_line":1478,"start_character":23,"end_line":1478,"end_character":42},"updated":"2022-08-30 15:59:55.000000000","message":"nit: not necessary in Python 3","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"7991a16cd8aa65b478091dbbe4946faee94fcfa3","unresolved":false,"context_lines":[{"line_number":1475,"context_line":"    _description \u003d _(\"List namespace\")"},{"line_number":1476,"context_line":""},{"line_number":1477,"context_line":"    def get_parser(self, prog_name):"},{"line_number":1478,"context_line":"        parser \u003d super(ListNamespace, self).get_parser(prog_name)"},{"line_number":1479,"context_line":"        common.add_project_domain_option_to_parser(parser)"},{"line_number":1480,"context_line":"        return parser"},{"line_number":1481,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e5c7dac8_265f8567","line":1478,"range":{"start_line":1478,"start_character":23,"end_line":1478,"end_character":42},"in_reply_to":"c0b78229_6a2385d1","updated":"2022-09-01 08:28:37.000000000","message":"Ack. Fixed in patchset6.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"5bad40f9425b06e7ab2850c07708dccbd475ca8f","unresolved":false,"context_lines":[{"line_number":1475,"context_line":"    _description \u003d _(\"List namespace\")"},{"line_number":1476,"context_line":""},{"line_number":1477,"context_line":"    def get_parser(self, prog_name):"},{"line_number":1478,"context_line":"        parser \u003d super(ListNamespace, self).get_parser(prog_name)"},{"line_number":1479,"context_line":"        common.add_project_domain_option_to_parser(parser)"},{"line_number":1480,"context_line":"        return parser"},{"line_number":1481,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7fc836f5_537a2381","line":1478,"range":{"start_line":1478,"start_character":23,"end_line":1478,"end_character":42},"in_reply_to":"c0b78229_6a2385d1","updated":"2022-09-01 15:01:55.000000000","message":"Ack. This is fixed in patchset6.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"}],"openstackclient/image/v2/metadef_namespaces.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":true,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ListNameSpaces(command.Lister):"},{"line_number":31,"context_line":"    \"\"\"return list of metadef namespaces\"\"\""},{"line_number":32,"context_line":"    _description \u003d _(\"List namespaces\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"e3ef68c0_9011e8d3","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":20},"updated":"2022-09-14 10:35:53.000000000","message":"ListMetadefNamespaces","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ListNameSpaces(command.Lister):"},{"line_number":31,"context_line":"    \"\"\"return list of metadef namespaces\"\"\""},{"line_number":32,"context_line":"    _description \u003d _(\"List namespaces\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ee7f00ad_808a8ddd","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":20},"in_reply_to":"e3ef68c0_9011e8d3","updated":"2022-09-19 08:26:47.000000000","message":"renamed all of them. Thanks.","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ListNameSpaces(command.Lister):"},{"line_number":31,"context_line":"    \"\"\"return list of metadef namespaces\"\"\""},{"line_number":32,"context_line":"    _description \u003d _(\"List namespaces\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fd25dc8_b8125618","line":31,"updated":"2022-09-14 10:35:53.000000000","message":"You don\u0027t need a docstring once you have the _description attribute below. Can you drop this?","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ListNameSpaces(command.Lister):"},{"line_number":31,"context_line":"    \"\"\"return list of metadef namespaces\"\"\""},{"line_number":32,"context_line":"    _description \u003d _(\"List namespaces\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"0edfdf56_f50f7b74","line":31,"in_reply_to":"9fd25dc8_b8125618","updated":"2022-09-19 08:26:47.000000000","message":"Done","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ListNameSpaces(command.Lister):"},{"line_number":31,"context_line":"    \"\"\"return list of metadef namespaces\"\"\""},{"line_number":32,"context_line":"    _description \u003d _(\"List namespaces\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"},{"line_number":35,"context_line":"        parser \u003d super().get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ac00d1d1_74c10242","line":32,"range":{"start_line":32,"start_character":22,"end_line":32,"end_character":37},"updated":"2022-09-14 10:35:53.000000000","message":"List metadef namespaces","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ListNameSpaces(command.Lister):"},{"line_number":31,"context_line":"    \"\"\"return list of metadef namespaces\"\"\""},{"line_number":32,"context_line":"    _description \u003d _(\"List namespaces\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"},{"line_number":35,"context_line":"        parser \u003d super().get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa09b61_2a69dd98","line":32,"range":{"start_line":32,"start_character":22,"end_line":32,"end_character":37},"in_reply_to":"ac00d1d1_74c10242","updated":"2022-09-19 08:26:47.000000000","message":"Done","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":true,"context_lines":[{"line_number":43,"context_line":"            metavar\u003d\"\u003cvisibility\u003e\","},{"line_number":44,"context_line":"            help\u003d_(\"filter on visibility\"),"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        common.add_project_domain_option_to_parser(parser)"},{"line_number":47,"context_line":"        return parser"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":12,"id":"da17e26f_11de480f","line":46,"updated":"2022-09-14 10:35:53.000000000","message":"Is this relevant? Can you list namespaces for another project?","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            metavar\u003d\"\u003cvisibility\u003e\","},{"line_number":44,"context_line":"            help\u003d_(\"filter on visibility\"),"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        common.add_project_domain_option_to_parser(parser)"},{"line_number":47,"context_line":"        return parser"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":12,"id":"75026f36_a74073ec","line":46,"in_reply_to":"da17e26f_11de480f","updated":"2022-09-19 08:26:47.000000000","message":"I guess not. Let\u0027s drop this.","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"}],"openstackclient/image/v2/metadefs_namespaces.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":23,"context_line":"from openstackclient.identity import common"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_formatters \u003d {"},{"line_number":26,"context_line":"    \u0027tags\u0027: format_columns.ListColumn,"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"690fa8fa_cbecf8c6","line":26,"updated":"2022-09-01 15:23:09.000000000","message":"Do you need this, given you\u0027re not even showing these?","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from openstackclient.identity import common"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_formatters \u003d {"},{"line_number":26,"context_line":"    \u0027tags\u0027: format_columns.ListColumn,"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c42b1199_9c2c41a2","line":26,"in_reply_to":"690fa8fa_cbecf8c6","updated":"2022-09-06 06:51:58.000000000","message":"These are used in the response, line 51, to format the output. So I think this one should be kept.","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"},{"line_number":35,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":36,"context_line":"        common.add_project_domain_option_to_parser(parser)"},{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"cee8ee93_3abbea69","line":36,"updated":"2022-09-01 15:23:09.000000000","message":"Do you want to add the options from glanceclient to ensure we\u0027re preserving functionality?\n\n  usage: glance md-namespace-list [--resource-types \u003cRESOURCE_TYPES\u003e] [--visibility \u003cVISIBILITY\u003e] [--page-size \u003cSIZE\u003e]\n\n  List metadata definitions namespaces.\n\n  Options:\n    --resource-types \u003cRESOURCE_TYPES\u003e\n                          Resource type to filter namespaces.\n    --visibility \u003cVISIBILITY\u003e\n                          Visibility parameter to filter namespaces.\n    --page-size \u003cSIZE\u003e    Number of namespaces to request in each paginated request.\n\nNote that we probably do *not* want to include \u0027--page-size\u0027 since openstacksdk does auto-pagination.","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"143625e6ab229a958c57d497f7fe13d40f9e045e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"},{"line_number":35,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":36,"context_line":"        common.add_project_domain_option_to_parser(parser)"},{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d8411c0b_cf81fd98","line":36,"in_reply_to":"cee8ee93_3abbea69","updated":"2022-09-06 11:06:19.000000000","message":"Done","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        image_client \u003d self.app.client_manager.image"},{"line_number":41,"context_line":"        kwargs \u003d {}"},{"line_number":42,"context_line":"        # List of namespace data received"},{"line_number":43,"context_line":"        data \u003d image_client.metadefs_namespaces(**kwargs)"},{"line_number":44,"context_line":"        columns \u003d [\u0027namespace\u0027]"},{"line_number":45,"context_line":"        column_headers \u003d columns"},{"line_number":46,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":6,"id":"d9543d55_40a3cd6e","line":43,"range":{"start_line":43,"start_character":48,"end_line":43,"end_character":56},"updated":"2022-09-01 15:23:09.000000000","message":"Feels unnecessary unless you add support for --resource-types and --visibility filters, which I think you should. If you don\u0027t add these, this should be dropped.","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"143625e6ab229a958c57d497f7fe13d40f9e045e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        image_client \u003d self.app.client_manager.image"},{"line_number":41,"context_line":"        kwargs \u003d {}"},{"line_number":42,"context_line":"        # List of namespace data received"},{"line_number":43,"context_line":"        data \u003d image_client.metadefs_namespaces(**kwargs)"},{"line_number":44,"context_line":"        columns \u003d [\u0027namespace\u0027]"},{"line_number":45,"context_line":"        column_headers \u003d columns"},{"line_number":46,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":6,"id":"23850e65_f824853c","line":43,"range":{"start_line":43,"start_character":48,"end_line":43,"end_character":56},"in_reply_to":"d9543d55_40a3cd6e","updated":"2022-09-06 11:06:19.000000000","message":"Both implemented in patchset 8","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"}],"openstackclient/tests/unit/image/v2/fakes.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":132,"context_line":"    return member.Member(**image_member_info)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def create_one_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake image member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of image member"}],"source_content_type":"text/x-python","patch_set":6,"id":"652333bd_38d2c776","line":135,"range":{"start_line":135,"start_character":15,"end_line":135,"end_character":24},"updated":"2022-09-01 15:23:09.000000000","message":"metadef_namespace","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    return member.Member(**image_member_info)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def create_one_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake image member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of image member"}],"source_content_type":"text/x-python","patch_set":6,"id":"186ea461_7f720bbf","line":135,"range":{"start_line":135,"start_character":15,"end_line":135,"end_character":24},"in_reply_to":"652333bd_38d2c776","updated":"2022-09-06 06:51:58.000000000","message":"Done","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def create_one_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake image member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of image member"},{"line_number":139,"context_line":"    :type attrs: dict"}],"source_content_type":"text/x-python","patch_set":6,"id":"f83bf80d_87856a94","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":33},"updated":"2022-09-01 15:23:09.000000000","message":"metadef namespace","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def create_one_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake image member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of image member"},{"line_number":139,"context_line":"    :type attrs: dict"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fcf3340_cb428cff","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":33},"in_reply_to":"f83bf80d_87856a94","updated":"2022-09-06 06:51:58.000000000","message":"Ack","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":135,"context_line":"def create_one_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake image member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of image member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"}],"source_content_type":"text/x-python","patch_set":6,"id":"8a0258bc_98993f49","line":138,"range":{"start_line":138,"start_character":54,"end_line":138,"end_character":66},"updated":"2022-09-01 15:23:09.000000000","message":"metadef namespace","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":false,"context_lines":[{"line_number":135,"context_line":"def create_one_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake image member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of image member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"}],"source_content_type":"text/x-python","patch_set":6,"id":"8e49e83c_9ea57414","line":138,"range":{"start_line":138,"start_character":54,"end_line":138,"end_character":66},"in_reply_to":"8a0258bc_98993f49","updated":"2022-09-06 06:51:58.000000000","message":"Done","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of image member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    attrs \u003d attrs or {}"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"e9518cf0_2f7d38e7","line":141,"range":{"start_line":141,"start_character":32,"end_line":141,"end_character":45},"updated":"2022-09-01 15:23:09.000000000","message":"metadef_namespace.MetadefNamespace","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of image member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    attrs \u003d attrs or {}"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d2907d85_8041e0e4","line":141,"range":{"start_line":141,"start_character":32,"end_line":141,"end_character":45},"in_reply_to":"e9518cf0_2f7d38e7","updated":"2022-09-06 06:51:58.000000000","message":"Done","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":143,"context_line":"    attrs \u003d attrs or {}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    image_namespace_list \u003d {"},{"line_number":146,"context_line":"        \u0027namespace\u0027: \u0027OS::Cinder::Volumetype\u0027"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    # Overwrite default attributes if there are some attributes set"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a0a7ca9_cfa5c9c1","line":146,"updated":"2022-09-01 15:23:09.000000000","message":"Can you populate the other attributes from a real-world example? It would be useful as we add the other metadef namespace-related commands later","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"143625e6ab229a958c57d497f7fe13d40f9e045e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    attrs \u003d attrs or {}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    image_namespace_list \u003d {"},{"line_number":146,"context_line":"        \u0027namespace\u0027: \u0027OS::Cinder::Volumetype\u0027"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    # Overwrite default attributes if there are some attributes set"}],"source_content_type":"text/x-python","patch_set":6,"id":"905e403a_128565f8","line":146,"in_reply_to":"3a0a7ca9_cfa5c9c1","updated":"2022-09-06 11:06:19.000000000","message":"Done","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def create_one_metadef_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake metadef_namespace member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of metadef_namespace member"},{"line_number":139,"context_line":"    :type attrs: dict"}],"source_content_type":"text/x-python","patch_set":12,"id":"e935c12b_3b539c22","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":38},"updated":"2022-09-14 10:35:53.000000000","message":"nit: can you drop the underscore?","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def create_one_metadef_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake metadef_namespace member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of metadef_namespace member"},{"line_number":139,"context_line":"    :type attrs: dict"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a4a0111_18339d9f","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":38},"in_reply_to":"e935c12b_3b539c22","updated":"2022-09-19 08:26:47.000000000","message":"Done","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":true,"context_lines":[{"line_number":135,"context_line":"def create_one_metadef_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake metadef_namespace member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of metadef_namespace member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"}],"source_content_type":"text/x-python","patch_set":12,"id":"10c6c2a0_92402f8f","line":138,"range":{"start_line":138,"start_character":54,"end_line":138,"end_character":71},"updated":"2022-09-14 10:35:53.000000000","message":"ditto","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":135,"context_line":"def create_one_metadef_namespace(attrs\u003dNone):"},{"line_number":136,"context_line":"    \"\"\"Create a fake metadef_namespace member."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of metadef_namespace member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"}],"source_content_type":"text/x-python","patch_set":12,"id":"0551decf_c2424f38","line":138,"range":{"start_line":138,"start_character":54,"end_line":138,"end_character":71},"in_reply_to":"10c6c2a0_92402f8f","updated":"2022-09-19 08:26:47.000000000","message":"Ack","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":true,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of metadef_namespace member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    attrs \u003d attrs or {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"1cd75bc5_2c3fdaaf","line":140,"range":{"start_line":140,"start_character":20,"end_line":140,"end_character":26},"updated":"2022-09-14 10:35:53.000000000","message":"MetadefNamespace","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of metadef_namespace member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    attrs \u003d attrs or {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"74469648_626c06e5","line":140,"range":{"start_line":140,"start_character":20,"end_line":140,"end_character":26},"in_reply_to":"1cd75bc5_2c3fdaaf","updated":"2022-09-19 08:26:47.000000000","message":"Ack","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32a79389b6f0d8e3daf6bfbf9445f5faeed7aa41","unresolved":true,"context_lines":[{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of metadef_namespace member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    attrs \u003d attrs or {}"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a1fcb82_828ae5e2","line":141,"range":{"start_line":141,"start_character":32,"end_line":141,"end_character":45},"updated":"2022-09-14 10:35:53.000000000","message":"metadef_namespace.MetadefNamespace","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    :param attrs: A dictionary with all attributes of metadef_namespace member"},{"line_number":139,"context_line":"    :type attrs: dict"},{"line_number":140,"context_line":"    :return: A fake Member object."},{"line_number":141,"context_line":"    :rtype: `openstack.image.v2.member.Member`"},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":"    attrs \u003d attrs or {}"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4958ee_6ea24be3","line":141,"range":{"start_line":141,"start_character":32,"end_line":141,"end_character":45},"in_reply_to":"5a1fcb82_828ae5e2","updated":"2022-09-19 08:26:47.000000000","message":"Ack","commit_id":"0f0dbbfc1717d0f4608ee83155c9103429ad4913"}],"openstackclient/tests/unit/image/v2/test_image.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"556884b088eb6dc194cb7c0b834f9928ea3adae5","unresolved":true,"context_lines":[{"line_number":1862,"context_line":"        print(\u0027columns\u0027)"},{"line_number":1863,"context_line":"        print(columns)"},{"line_number":1864,"context_line":"        print(\u0027data\u0027)"},{"line_number":1865,"context_line":"        print(data)"},{"line_number":1866,"context_line":"        self.client.images.assert_called_with("},{"line_number":1867,"context_line":"            # marker\u003dself._image.id,"},{"line_number":1868,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"110246a4_d1770b23","line":1865,"updated":"2022-08-30 15:59:55.000000000","message":"Whoops","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"7991a16cd8aa65b478091dbbe4946faee94fcfa3","unresolved":false,"context_lines":[{"line_number":1862,"context_line":"        print(\u0027columns\u0027)"},{"line_number":1863,"context_line":"        print(columns)"},{"line_number":1864,"context_line":"        print(\u0027data\u0027)"},{"line_number":1865,"context_line":"        print(data)"},{"line_number":1866,"context_line":"        self.client.images.assert_called_with("},{"line_number":1867,"context_line":"            # marker\u003dself._image.id,"},{"line_number":1868,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"be5cf66f_75fd5ff0","line":1865,"in_reply_to":"110246a4_d1770b23","updated":"2022-09-01 08:28:37.000000000","message":"Ack. Sorry about that! Fixed in patchset6.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"556884b088eb6dc194cb7c0b834f9928ea3adae5","unresolved":true,"context_lines":[{"line_number":1864,"context_line":"        print(\u0027data\u0027)"},{"line_number":1865,"context_line":"        print(data)"},{"line_number":1866,"context_line":"        self.client.images.assert_called_with("},{"line_number":1867,"context_line":"            # marker\u003dself._image.id,"},{"line_number":1868,"context_line":"        )"},{"line_number":1869,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":1870,"context_line":"        print(self.columns)"}],"source_content_type":"text/x-python","patch_set":5,"id":"23159fa4_80fdfc27","line":1867,"updated":"2022-08-30 15:59:55.000000000","message":"If this isn\u0027t relevant, please drop it","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"7991a16cd8aa65b478091dbbe4946faee94fcfa3","unresolved":false,"context_lines":[{"line_number":1864,"context_line":"        print(\u0027data\u0027)"},{"line_number":1865,"context_line":"        print(data)"},{"line_number":1866,"context_line":"        self.client.images.assert_called_with("},{"line_number":1867,"context_line":"            # marker\u003dself._image.id,"},{"line_number":1868,"context_line":"        )"},{"line_number":1869,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":1870,"context_line":"        print(self.columns)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a298e519_07df3867","line":1867,"in_reply_to":"23159fa4_80fdfc27","updated":"2022-09-01 08:28:37.000000000","message":"Ack. Sorry about that! Fixed in patchset6.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"556884b088eb6dc194cb7c0b834f9928ea3adae5","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"            # marker\u003dself._image.id,"},{"line_number":1868,"context_line":"        )"},{"line_number":1869,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":1870,"context_line":"        print(self.columns)"},{"line_number":1871,"context_line":"        print(self.datalist)"},{"line_number":1872,"context_line":"        print(tuple(data))"},{"line_number":1873,"context_line":"        self.assertCountEqual(self.datalist, tuple(data))"}],"source_content_type":"text/x-python","patch_set":5,"id":"af38c02d_30496c7d","line":1870,"updated":"2022-08-30 15:59:55.000000000","message":"whoops","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"7991a16cd8aa65b478091dbbe4946faee94fcfa3","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"            # marker\u003dself._image.id,"},{"line_number":1868,"context_line":"        )"},{"line_number":1869,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":1870,"context_line":"        print(self.columns)"},{"line_number":1871,"context_line":"        print(self.datalist)"},{"line_number":1872,"context_line":"        print(tuple(data))"},{"line_number":1873,"context_line":"        self.assertCountEqual(self.datalist, tuple(data))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7c4fb848_bbb94eb2","line":1870,"in_reply_to":"af38c02d_30496c7d","updated":"2022-09-01 08:28:37.000000000","message":"Ack.Sorry about this again. Fixed in patchset6.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":1830,"context_line":"            self.assertIsNone(test_fname)"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"class TestNamespaceList(TestImage):"},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"    _image \u003d image_fakes.create_one_namespace()"},{"line_number":1836,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"abfaf92b_7650d4d6","line":1833,"range":{"start_line":1833,"start_character":6,"end_line":1833,"end_character":23},"updated":"2022-09-01 15:23:09.000000000","message":"TestMetadefNamespaceList","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"            self.assertIsNone(test_fname)"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"class TestNamespaceList(TestImage):"},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"    _image \u003d image_fakes.create_one_namespace()"},{"line_number":1836,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2e712897_14c63372","line":1833,"range":{"start_line":1833,"start_character":6,"end_line":1833,"end_character":23},"in_reply_to":"abfaf92b_7650d4d6","updated":"2022-09-06 06:51:58.000000000","message":"Done","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"class TestNamespaceList(TestImage):"},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"    _image \u003d image_fakes.create_one_namespace()"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"    columns \u003d ("},{"line_number":1838,"context_line":"        \u0027Namespace\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a1f51a1a_931a7b93","line":1835,"range":{"start_line":1835,"start_character":4,"end_line":1835,"end_character":10},"updated":"2022-09-01 15:23:09.000000000","message":"_metadef_namespace","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":false,"context_lines":[{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"class TestNamespaceList(TestImage):"},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"    _image \u003d image_fakes.create_one_namespace()"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"    columns \u003d ("},{"line_number":1838,"context_line":"        \u0027Namespace\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f0bcd8a_bcb6280c","line":1835,"range":{"start_line":1835,"start_character":4,"end_line":1835,"end_character":10},"in_reply_to":"a1f51a1a_931a7b93","updated":"2022-09-06 06:51:58.000000000","message":"Done","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6b314769447f2b9009f632a21846ba7e9601fb9","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"    def setUp(self):"},{"line_number":1846,"context_line":"        super().setUp()"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"        self.client.images.side_effect \u003d [[self._image], []]"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"        # Get the command object to test"},{"line_number":1851,"context_line":"        self.cmd \u003d image.ListNamespace(self.app, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e169acd8_ef4c8741","line":1848,"updated":"2022-09-01 15:23:09.000000000","message":"This can\u0027t be right. This is mocking the \u0027images\u0027 proxy API. We should be calling the \u0027metadef_namespaces\u0027 proxy API.\n\nLater: Ah, this is probably the reason for the failing tests.","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"40a7c368d9affa1efec11b28f90088748ab39a98","unresolved":false,"context_lines":[{"line_number":1845,"context_line":"    def setUp(self):"},{"line_number":1846,"context_line":"        super().setUp()"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"        self.client.images.side_effect \u003d [[self._image], []]"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"        # Get the command object to test"},{"line_number":1851,"context_line":"        self.cmd \u003d image.ListNamespace(self.app, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"291acc24_925eecc0","line":1848,"in_reply_to":"6e03bc54_9c284784","updated":"2022-09-19 08:26:47.000000000","message":"Indeed, this wasn\u0027t correct. I\u0027ve redone the tests entirely, as it turned out that the original version of the test was not discovered.\nPlease take a look at the new version. Hopefully it\u0027s better.","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"04a0840dbb05369dab585da27e1940c8e35f8844","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"    def setUp(self):"},{"line_number":1846,"context_line":"        super().setUp()"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"        self.client.images.side_effect \u003d [[self._image], []]"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"        # Get the command object to test"},{"line_number":1851,"context_line":"        self.cmd \u003d image.ListNamespace(self.app, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e03bc54_9c284784","line":1848,"in_reply_to":"e169acd8_ef4c8741","updated":"2022-09-06 06:51:58.000000000","message":"Checking this. Thanks!","commit_id":"e229cc56989d8952d4ed8730b074452e674646d3"}],"setup.cfg":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"556884b088eb6dc194cb7c0b834f9928ea3adae5","unresolved":true,"context_lines":[{"line_number":382,"context_line":"    image_show \u003d openstackclient.image.v2.image:ShowImage"},{"line_number":383,"context_line":"    image_set \u003d openstackclient.image.v2.image:SetImage"},{"line_number":384,"context_line":"    image_unset \u003d openstackclient.image.v2.image:UnsetImage"},{"line_number":385,"context_line":"    image_namespace_list \u003d openstackclient.image.v2.image:ListNamespace"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"openstack.network.v2 \u003d"},{"line_number":388,"context_line":"    address_group_create \u003d openstackclient.network.v2.address_group:CreateAddressGroup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"793f6816_09561083","line":385,"updated":"2022-08-30 15:59:55.000000000","message":"It\u0027s not an image namespace though, is it? It\u0027s an image metadef namespace so this should read:\n\n  image_metadef_namespace_list \u003d ...\n\nThat\u0027s a bit of a mouthful but I don\u0027t see how we can meaningfully shorten it without confusing matters. The glanceclient terminology (md) isn\u0027t helpful IMO and OSC avoid abbreviations like this.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"},{"author":{"_account_id":7953,"name":"Ulrich Schwickerath","email":"Ulrich.Schwickerath@cern.ch","username":"schwicke"},"change_message_id":"7991a16cd8aa65b478091dbbe4946faee94fcfa3","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    image_show \u003d openstackclient.image.v2.image:ShowImage"},{"line_number":383,"context_line":"    image_set \u003d openstackclient.image.v2.image:SetImage"},{"line_number":384,"context_line":"    image_unset \u003d openstackclient.image.v2.image:UnsetImage"},{"line_number":385,"context_line":"    image_namespace_list \u003d openstackclient.image.v2.image:ListNamespace"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"openstack.network.v2 \u003d"},{"line_number":388,"context_line":"    address_group_create \u003d openstackclient.network.v2.address_group:CreateAddressGroup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"197db7fa_0cae1d32","line":385,"in_reply_to":"793f6816_09561083","updated":"2022-09-01 08:28:37.000000000","message":"Yes, fully agree. For consistency, I think it should read\nimage_metadefs_namespace_list\nChanged in patchset6.","commit_id":"361dcb46e80613c8a76cf0a7348ed81abff114b4"}]}