)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0083135f5adb88e41eb654286f8c04feb751d0f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"043f973a_abe7486c","updated":"2022-10-26 09:21:12.000000000","message":"Brian is happy. Let\u0027s get this in.","commit_id":"3fc585332f79358489285eabc298e01007599128"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b74aefcf48987637d60501ad93060227494a398","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a93c282_78c8696f","updated":"2022-11-11 09:04:50.000000000","message":"This is still not correct, the command line still shows an error since it\u0027s a positional argument. We need to make it optional and size as positional argument.\n\nopenstack volume create: error: the following arguments are required: \u003cname\u003e\n","commit_id":"3fc585332f79358489285eabc298e01007599128"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"24236757085c518487768f5ce20282b92f6e6714","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a1046b40_b5b71472","updated":"2022-10-25 15:23:17.000000000","message":"Volume names have always been optional in the Block Storage API (even version 1).  I was surprised to see that the Compute API requires a server name.  Just goes to show half the world doesn\u0027t know how the other half lives.\n\nThanks for fixing this!  ","commit_id":"3fc585332f79358489285eabc298e01007599128"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"badba6d1e77e1cf66a1a67983688a384ab097d06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"636655bf_5a3d431b","in_reply_to":"0a93c282_78c8696f","updated":"2022-11-14 18:09:59.000000000","message":"Are you using the correct version? This works fine for me locally.\n\n    ❯ openstack volume create\n    --size is a required option if snapshot or source volume is not specified.\n\n    ❯ openstack volume create --size 1\n    +---------------------+--------------------------------------+\n    | Field               | Value                                |\n    +---------------------+--------------------------------------+\n    | attachments         | []                                   |\n    | availability_zone   | nova                                 |\n    | bootable            | false                                |\n    | consistencygroup_id | None                                 |\n    | created_at          | 2022-11-14T18:08:04.797745           |\n    | description         | None                                 |\n    | encrypted           | False                                |\n    | id                  | 13cf0888-8ff8-4471-8e39-702c9c8b80ed |\n    | migration_status    | None                                 |\n    | multiattach         | False                                |\n    | name                | None                                 |\n    | properties          |                                      |\n    | replication_status  | None                                 |\n    | size                | 1                                    |\n    | snapshot_id         | None                                 |\n    | source_volid        | None                                 |\n    | status              | creating                             |\n    | type                | lvmdriver-1                          |\n    | updated_at          | None                                 |\n    | user_id             | e81a2d7a033642beae9932ba28f176b8     |\n    +---------------------+--------------------------------------+\n\n    ❯ openstack volume list\n    +--------------------------------------+------+-----------+------+-------------+\n    | ID                                   | Name | Status    | Size | Attached to |\n    +--------------------------------------+------+-----------+------+-------------+\n    | 13cf0888-8ff8-4471-8e39-702c9c8b80ed | None | available |    1 |             |\n    +--------------------------------------+------+-----------+------+-------------+","commit_id":"3fc585332f79358489285eabc298e01007599128"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a082762d584a957654195d7ae467f449abdcb2c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa6de386_79bd8400","in_reply_to":"636655bf_5a3d431b","updated":"2022-11-14 18:16:18.000000000","message":"We\u0027re not going to make \u0027size\u0027 a positional argument though since this is not required if you\u0027re create a volume based on an existing volume or snapshot (we\u0027ll copy the volume from those if you don\u0027t provide it). We also have no requirement to match cinderclient\u0027s layout identically","commit_id":"3fc585332f79358489285eabc298e01007599128"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"984039b4c4e6dc4a6e9342d65f324c8817a77cf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10ec7176_0335874a","in_reply_to":"fa6de386_79bd8400","updated":"2022-11-15 08:27:26.000000000","message":"You\u0027re right, changing the OSC version does solve the issue of name being a mandatory argument.\n\nAlthough i don\u0027t agree on the notion that we\u0027re keeping name as a positional argument whereas size as an optional one.\n\"name\" is always optional so rather than changing it\u0027s nargs value to optional, I would prefer to make it optional altogether (--name)\n\"size\" is optional incase of creating from snapshot, volume, backup etc but if the source is not provided and we\u0027re creating a normal volume then size is indeed a mandatory argument and would be better suited as positional. We\u0027ve done it\u0027s handling in cinderclient and similar could be done here as well.\nI will discuss this with the cinder team this week and update with the discussion.","commit_id":"3fc585332f79358489285eabc298e01007599128"}]}