)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35355,"name":"Daniel Wilson","email":"danielcw@bu.edu","username":"dannosliwcd"},"change_message_id":"36de9e7174840b0359cb53e31f846d598c0f931d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bf806a8_3ae8153f","updated":"2022-10-18 02:28:25.000000000","message":"recheck","commit_id":"b6d75a6e64add42a3fa498436b9d5386df39d570"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b87b6e1_4824a1bd","updated":"2022-11-21 17:08:00.000000000","message":"I can\u0027t find anything wrong with this. Bravo 👏 I have one small nit in there but it\u0027s not overly important. If you can fix that and add a release note indicating that we\u0027ve switched this, I think we can other merge pretty much as-is.\n\n-1 is purely for the release note.","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2338,"context_line":"            if flavor is None:"},{"line_number":2339,"context_line":"                msg \u003d _(\u0027Unable to find flavor: %s\u0027) % parsed_args.flavor"},{"line_number":2340,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":2341,"context_line":"            flavor_id \u003d flavor.id"},{"line_number":2342,"context_line":""},{"line_number":2343,"context_line":"        # Nova only supports list servers searching by image ID. So if a"},{"line_number":2344,"context_line":"        # image name is given, map it to ID."}],"source_content_type":"text/x-python","patch_set":5,"id":"bc8750ec_32456120","line":2341,"updated":"2022-11-21 17:08:00.000000000","message":"This works 👍","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2347,"context_line":"            image_id \u003d image_client.find_image("},{"line_number":2348,"context_line":"                parsed_args.image,"},{"line_number":2349,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":2350,"context_line":"            ).id"},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"        search_opts \u003d {"},{"line_number":2353,"context_line":"            \u0027reservation_id\u0027: parsed_args.reservation_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"660e4b16_46325b6f","line":2350,"updated":"2022-11-21 17:08:00.000000000","message":"This works 👍","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2352,"context_line":"        search_opts \u003d {"},{"line_number":2353,"context_line":"            \u0027reservation_id\u0027: parsed_args.reservation_id,"},{"line_number":2354,"context_line":"            \u0027ip\u0027: parsed_args.ip,"},{"line_number":2355,"context_line":"            \u0027ip6\u0027: parsed_args.ip6,"},{"line_number":2356,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":2357,"context_line":"            \u0027status\u0027: parsed_args.status,"},{"line_number":2358,"context_line":"            \u0027flavor\u0027: flavor_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c87bb24d_a001bfb7","line":2355,"updated":"2022-11-21 17:08:00.000000000","message":"Wasn\u0027t able to validate these first three but there\u0027s an entry for each in Server._query_mapping [1] so I assume it\u0027s okay.\n\n[1] https://github.com/openstack/openstacksdk/blob/374f647/openstack/compute/v2/server.py#L43-L66","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2358,"context_line":"            \u0027flavor\u0027: flavor_id,"},{"line_number":2359,"context_line":"            \u0027image\u0027: image_id,"},{"line_number":2360,"context_line":"            \u0027host\u0027: parsed_args.host,"},{"line_number":2361,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":2362,"context_line":"            \u0027all_tenants\u0027: parsed_args.all_projects,"},{"line_number":2363,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":2364,"context_line":"            \u0027deleted\u0027: parsed_args.deleted,"}],"source_content_type":"text/x-python","patch_set":5,"id":"52661a91_9117de7c","line":2361,"updated":"2022-11-21 17:08:00.000000000","message":"The 6 above all work 👍","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":true,"context_lines":[{"line_number":2359,"context_line":"            \u0027image\u0027: image_id,"},{"line_number":2360,"context_line":"            \u0027host\u0027: parsed_args.host,"},{"line_number":2361,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":2362,"context_line":"            \u0027all_tenants\u0027: parsed_args.all_projects,"},{"line_number":2363,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":2364,"context_line":"            \u0027deleted\u0027: parsed_args.deleted,"},{"line_number":2365,"context_line":"            \u0027changes-before\u0027: parsed_args.changes_before,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aa930d6_c0e66df7","line":2362,"range":{"start_line":2362,"start_character":13,"end_line":2362,"end_character":24},"updated":"2022-11-21 17:08:00.000000000","message":"This should be updated to \u0027all_projects\u0027. Due to a quirk in how openstacksdk works this is accepted but the \"official\" query argument is \u0027all_projects\u0027 [1]\n\n[1] https://github.com/openstack/openstacksdk/blob/374f647/openstack/compute/v2/server.py#L64","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"23f89ff7beb94a80e5b750f99faaffea704fa566","unresolved":false,"context_lines":[{"line_number":2359,"context_line":"            \u0027image\u0027: image_id,"},{"line_number":2360,"context_line":"            \u0027host\u0027: parsed_args.host,"},{"line_number":2361,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":2362,"context_line":"            \u0027all_tenants\u0027: parsed_args.all_projects,"},{"line_number":2363,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":2364,"context_line":"            \u0027deleted\u0027: parsed_args.deleted,"},{"line_number":2365,"context_line":"            \u0027changes-before\u0027: parsed_args.changes_before,"}],"source_content_type":"text/x-python","patch_set":5,"id":"6738c40d_c453681a","line":2362,"range":{"start_line":2362,"start_character":13,"end_line":2362,"end_character":24},"in_reply_to":"5aa930d6_c0e66df7","updated":"2022-11-30 12:09:55.000000000","message":"Done","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2360,"context_line":"            \u0027host\u0027: parsed_args.host,"},{"line_number":2361,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":2362,"context_line":"            \u0027all_tenants\u0027: parsed_args.all_projects,"},{"line_number":2363,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":2364,"context_line":"            \u0027deleted\u0027: parsed_args.deleted,"},{"line_number":2365,"context_line":"            \u0027changes-before\u0027: parsed_args.changes_before,"},{"line_number":2366,"context_line":"            \u0027changes-since\u0027: parsed_args.changes_since,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a43647b2_139adb8f","line":2363,"updated":"2022-11-21 17:08:00.000000000","message":"This works 👍","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2361,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":2362,"context_line":"            \u0027all_tenants\u0027: parsed_args.all_projects,"},{"line_number":2363,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":2364,"context_line":"            \u0027deleted\u0027: parsed_args.deleted,"},{"line_number":2365,"context_line":"            \u0027changes-before\u0027: parsed_args.changes_before,"},{"line_number":2366,"context_line":"            \u0027changes-since\u0027: parsed_args.changes_since,"},{"line_number":2367,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"f5ea3d52_8f48b27d","line":2364,"updated":"2022-11-21 17:08:00.000000000","message":"Didn\u0027t bother testing this but the logic is in SDK","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2363,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":2364,"context_line":"            \u0027deleted\u0027: parsed_args.deleted,"},{"line_number":2365,"context_line":"            \u0027changes-before\u0027: parsed_args.changes_before,"},{"line_number":2366,"context_line":"            \u0027changes-since\u0027: parsed_args.changes_since,"},{"line_number":2367,"context_line":"        }"},{"line_number":2368,"context_line":""},{"line_number":2369,"context_line":"        if parsed_args.instance_name is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bbcef161_05b8768e","line":2366,"updated":"2022-11-21 17:08:00.000000000","message":"Both of these work 👍","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2405,"context_line":"                    \u0027--os-compute-api-version 2.26 or greater is required to \u0027"},{"line_number":2406,"context_line":"                    \u0027support the --tag option\u0027"},{"line_number":2407,"context_line":"                )"},{"line_number":2408,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":2409,"context_line":""},{"line_number":2410,"context_line":"            search_opts[\u0027tags\u0027] \u003d \u0027,\u0027.join(parsed_args.tags)"},{"line_number":2411,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c4b60253_6878ad91","line":2408,"updated":"2022-11-21 17:08:00.000000000","message":"Correctly errors out 👍 Ditto for the rest below.","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"227b6a16f3183030a0b4918b8a109d6f8cd9ec98","unresolved":false,"context_lines":[{"line_number":2440,"context_line":""},{"line_number":2441,"context_line":"        if parsed_args.limit is not None:"},{"line_number":2442,"context_line":"            search_opts[\u0027limit\u0027] \u003d parsed_args.limit"},{"line_number":2443,"context_line":"            search_opts[\u0027paginated\u0027] \u003d False"},{"line_number":2444,"context_line":""},{"line_number":2445,"context_line":"        LOG.debug(\u0027search options: %s\u0027, search_opts)"},{"line_number":2446,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"0e8eed90_e3835c9b","line":2443,"updated":"2022-11-21 17:08:00.000000000","message":"Works 👍","commit_id":"adfeddc5562e5c7340338963f4c0087c5de464c1"}]}