)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f1be384be164eecbefcad4dec891411848c720fb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Huda Irshad \u003chudai@bu.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-06 17:22:07 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"added in kwargs options, added in pagniate argument, modified test_server_event in unit test to add paginated input and ignore_missing input, modified expections to sdk version in server_event.py and added in dependencies for commit message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/866383/7"},{"line_number":10,"context_line":"Change-Id: I3d24851303222af9efcee8d7e1565278b1018efd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"efee9039_fc0dd5dc","line":7,"updated":"2022-12-09 16:23:10.000000000","message":"This needs to be rewritten to have a clear subject line and body with correct line lengths. See [1] for an idea of what\u0027s expected.\n\n[1] https://cbea.ms/git-commit/#seven-rules","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2acd4e06c2c421daf76b97cefccebd92e6021e0c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Huda Irshad \u003chudai@bu.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-06 17:22:07 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"added in kwargs options, added in pagniate argument, modified test_server_event in unit test to add paginated input and ignore_missing input, modified expections to sdk version in server_event.py and added in dependencies for commit message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/866383/7"},{"line_number":10,"context_line":"Change-Id: I3d24851303222af9efcee8d7e1565278b1018efd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"d494a79d_b732c696","line":7,"in_reply_to":"efee9039_fc0dd5dc","updated":"2022-12-20 12:03:52.000000000","message":"Done","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f1be384be164eecbefcad4dec891411848c720fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7240794a_c4b75e48","updated":"2022-12-09 16:23:10.000000000","message":"This looks pretty good. Nice work. I\u0027d like to see some changes in how we generate the output for the \u0027server event show\u0027 command. That commit message also needs some work and we could do with a release note [1]. Let me know if anything isn\u0027t clear.\n\n[1] Just run \u0027pip install -u reno\u0027 followed by e.g. \u0027reno new switch-server-events-to-sdk\u0027","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1e47c39894330c308ae890124d331a9cb400a2e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9306c2de_25fc3f40","updated":"2023-04-20 13:37:49.000000000","message":"recheck","commit_id":"737540cca0b820ceaf53fc74e81f4fdafbc8f518"}],"openstackclient/compute/v2/server_event.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f1be384be164eecbefcad4dec891411848c720fb","unresolved":true,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        try:"},{"line_number":150,"context_line":"            server_id \u003d compute_client.find_server(parsed_args.server,"},{"line_number":151,"context_line":"                                                   ignore_missing\u003dFalse).id"},{"line_number":152,"context_line":"        except sdk_exceptions.ResourceNotFound:"},{"line_number":153,"context_line":"            # If we fail to find the resource, it is possible the server is"},{"line_number":154,"context_line":"            # deleted. Try once more using the \u003cserver\u003e arg directly if it is a"}],"source_content_type":"text/x-python","patch_set":11,"id":"dbb5a976_927ee50c","line":151,"updated":"2022-12-09 16:23:10.000000000","message":"Can you avoid rewrapping this, please?\n\n  server_id \u003d compute_client.find_server(\n      compute_client.servers, parsed_args.server,\n  ).id","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2acd4e06c2c421daf76b97cefccebd92e6021e0c","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        try:"},{"line_number":150,"context_line":"            server_id \u003d compute_client.find_server(parsed_args.server,"},{"line_number":151,"context_line":"                                                   ignore_missing\u003dFalse).id"},{"line_number":152,"context_line":"        except sdk_exceptions.ResourceNotFound:"},{"line_number":153,"context_line":"            # If we fail to find the resource, it is possible the server is"},{"line_number":154,"context_line":"            # deleted. Try once more using the \u003cserver\u003e arg directly if it is a"}],"source_content_type":"text/x-python","patch_set":11,"id":"cfc1bbb8_5bbbf6d1","line":151,"in_reply_to":"dbb5a976_927ee50c","updated":"2022-12-20 12:03:52.000000000","message":"Done","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f1be384be164eecbefcad4dec891411848c720fb","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        try:"},{"line_number":221,"context_line":"            server_id \u003d compute_client.find_server(parsed_args.server,"},{"line_number":222,"context_line":"                                                   ignore_missing\u003dFalse).id"},{"line_number":223,"context_line":"        except sdk_exceptions.ResourceNotFound:"},{"line_number":224,"context_line":"            # If we fail to find the resource, it is possible the server is"},{"line_number":225,"context_line":"            # deleted. Try once more using the \u003cserver\u003e arg directly if it is a"}],"source_content_type":"text/x-python","patch_set":11,"id":"3951c066_8e514219","line":222,"updated":"2022-12-09 16:23:10.000000000","message":"Ditto","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2acd4e06c2c421daf76b97cefccebd92e6021e0c","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        try:"},{"line_number":221,"context_line":"            server_id \u003d compute_client.find_server(parsed_args.server,"},{"line_number":222,"context_line":"                                                   ignore_missing\u003dFalse).id"},{"line_number":223,"context_line":"        except sdk_exceptions.ResourceNotFound:"},{"line_number":224,"context_line":"            # If we fail to find the resource, it is possible the server is"},{"line_number":225,"context_line":"            # deleted. Try once more using the \u003cserver\u003e arg directly if it is a"}],"source_content_type":"text/x-python","patch_set":11,"id":"eaea00fa_89308f02","line":222,"in_reply_to":"3951c066_8e514219","updated":"2022-12-20 12:03:52.000000000","message":"Done","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f1be384be164eecbefcad4dec891411848c720fb","unresolved":true,"context_lines":[{"line_number":233,"context_line":"            parsed_args.request_id, server_id)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        action_detail_dict \u003d action_detail.to_dict()"},{"line_number":236,"context_line":"        return zip(*sorted(action_detail_dict.items()))"}],"source_content_type":"text/x-python","patch_set":11,"id":"ddae795e_5e0e5336","line":236,"updated":"2022-12-09 16:23:10.000000000","message":"I commented on the SDK patch but in short, instead of doing this we could specifically list the columns we want to show and avoid calling \u0027to_dict\u0027. To do this, I\u0027d suggest looking at the \u0027get_osc_show_columns_for_sdk_resource\u0027 util method. grep for a few other examples. This also provides a mechanism to hide the \u0027location\u0027 field\n\nWe also probably want to specify a formatter for the \u0027events\u0027 field. Specifically, we want the ListFormatter.\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/866383","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2acd4e06c2c421daf76b97cefccebd92e6021e0c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            parsed_args.request_id, server_id)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        action_detail_dict \u003d action_detail.to_dict()"},{"line_number":236,"context_line":"        return zip(*sorted(action_detail_dict.items()))"}],"source_content_type":"text/x-python","patch_set":11,"id":"22b7cefb_43adc7ee","line":236,"in_reply_to":"ddae795e_5e0e5336","updated":"2022-12-20 12:03:52.000000000","message":"Done","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"}],"openstackclient/tests/unit/compute/v2/test_server_event.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f1be384be164eecbefcad4dec891411848c720fb","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        \u0027start_time\u0027,"},{"line_number":372,"context_line":"        \u0027user_id\u0027,"},{"line_number":373,"context_line":"    )"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    data \u003d ("},{"line_number":376,"context_line":"        fake_event.action,"},{"line_number":377,"context_line":"        fake_event.events,"}],"source_content_type":"text/x-python","patch_set":11,"id":"94170803_16fb2533","line":374,"updated":"2022-12-09 16:23:10.000000000","message":"nit: unnecessary change","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2acd4e06c2c421daf76b97cefccebd92e6021e0c","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        \u0027start_time\u0027,"},{"line_number":372,"context_line":"        \u0027user_id\u0027,"},{"line_number":373,"context_line":"    )"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    data \u003d ("},{"line_number":376,"context_line":"        fake_event.action,"},{"line_number":377,"context_line":"        fake_event.events,"}],"source_content_type":"text/x-python","patch_set":11,"id":"492b30e0_3b06f241","line":374,"in_reply_to":"94170803_16fb2533","updated":"2022-12-20 12:03:52.000000000","message":"Done","commit_id":"fba336ec07b740bb31361c535f45dde75ad1e24c"}]}