)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"34e5120bad9645981c8bcc330fb70f0ca7bc4288","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add option to create volume from backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support for creating a volume from backup was added in"},{"line_number":10,"context_line":"microversio 3.47. This patch adds a --backup option"},{"line_number":11,"context_line":"to the volume create command to add that support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib26d2d335475d9aacbf77c0fd7b7cda2ba743943"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a5227dff_465314da","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":11},"updated":"2022-11-21 15:54:14.000000000","message":"microversion","commit_id":"bd0727c4f897289722ba639930c9e979cfee534a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6250288d33400398c0f1763abeddd89e21320f04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15ee5300_bbc43c4e","updated":"2022-11-17 18:02:30.000000000","message":"I know this is WIP but I spotted a few things. It would be good to get this in. Obviously we need a release note but a functional test would be cool if you could add one. Hint: I wrote a guide on running functional tests a while back [1] which could be helpful.\n\n[1] https://that.guru/blog/reproducing-devstack-gate-jobs-locally/","commit_id":"8e9b34f631e7e604f7625db7b7385cbd573ad8d8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f93526aa003c9fcc7a25703f5e5b7f1b9edd4d05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"795f82ae_d3a4b837","updated":"2022-11-21 08:01:53.000000000","message":"Thanks Stephen for the review.","commit_id":"23d363fed0acdc31fcf2f89286fbe2c7aac94539"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b003d7f85645149df10fe13f9c26e4612e5d706e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c170916_adca20f5","updated":"2022-11-21 12:23:52.000000000","message":"Small nit in the help text. If you can fix that, I\u0027m +2","commit_id":"5b86f15d4916904193f013e96b255b2e0fdc9fbf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"34e5120bad9645981c8bcc330fb70f0ca7bc4288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6cfc7b19_4d98104c","updated":"2022-11-21 15:54:14.000000000","message":"Thank you 🙏","commit_id":"bd0727c4f897289722ba639930c9e979cfee534a"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6250288d33400398c0f1763abeddd89e21320f04","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    if ((args.snapshot or args.source or args.backup)"},{"line_number":75,"context_line":"            is None and args.size is None):"},{"line_number":76,"context_line":"        msg \u003d _(\"--size is a required option if snapshot \""},{"line_number":77,"context_line":"                \"or source volume is not specified.\")"},{"line_number":78,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2374bf3b_306942d6","line":77,"range":{"start_line":76,"start_character":56,"end_line":77,"end_character":20},"updated":"2022-11-17 18:02:30.000000000","message":"nit:\n\n  --size is a required option if snapshot,\n  backup or source volume are not specified","commit_id":"8e9b34f631e7e604f7625db7b7385cbd573ad8d8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f93526aa003c9fcc7a25703f5e5b7f1b9edd4d05","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    if ((args.snapshot or args.source or args.backup)"},{"line_number":75,"context_line":"            is None and args.size is None):"},{"line_number":76,"context_line":"        msg \u003d _(\"--size is a required option if snapshot \""},{"line_number":77,"context_line":"                \"or source volume is not specified.\")"},{"line_number":78,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"926ef313_1a6dd830","line":77,"range":{"start_line":76,"start_character":56,"end_line":77,"end_character":20},"in_reply_to":"2374bf3b_306942d6","updated":"2022-11-21 08:01:53.000000000","message":"Done","commit_id":"8e9b34f631e7e604f7625db7b7385cbd573ad8d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6250288d33400398c0f1763abeddd89e21320f04","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if parsed_args.backup and not ("},{"line_number":190,"context_line":"                volume_client.api_version.matches(\u00273.47\u0027)):"},{"line_number":191,"context_line":"            msg \u003d (_(\"--os-volume-api-version 3.47 or greater is required \""},{"line_number":192,"context_line":"                     \"to create a volume from backup.\"))"},{"line_number":193,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        source_volume \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"d8f8e77c_5099d4d3","line":192,"updated":"2022-11-17 18:02:30.000000000","message":"nit: You don\u0027t need the extra brackets\n\n  msg \u003d _(\n      \"--os-volume-api-version 3.47 ...\"\n  )","commit_id":"8e9b34f631e7e604f7625db7b7385cbd573ad8d8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f93526aa003c9fcc7a25703f5e5b7f1b9edd4d05","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if parsed_args.backup and not ("},{"line_number":190,"context_line":"                volume_client.api_version.matches(\u00273.47\u0027)):"},{"line_number":191,"context_line":"            msg \u003d (_(\"--os-volume-api-version 3.47 or greater is required \""},{"line_number":192,"context_line":"                     \"to create a volume from backup.\"))"},{"line_number":193,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        source_volume \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfbfaa22_792939b7","line":192,"in_reply_to":"d8f8e77c_5099d4d3","updated":"2022-11-21 08:01:53.000000000","message":"Done","commit_id":"8e9b34f631e7e604f7625db7b7385cbd573ad8d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6250288d33400398c0f1763abeddd89e21320f04","unresolved":true,"context_lines":[{"line_number":231,"context_line":"                volume_client.backups,"},{"line_number":232,"context_line":"                parsed_args.backup)"},{"line_number":233,"context_line":"            backup \u003d backup_obj.id"},{"line_number":234,"context_line":"            size \u003d max(size or 0, backup_obj.size)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        volume \u003d volume_client.volumes.create("},{"line_number":237,"context_line":"            size\u003dsize,"}],"source_content_type":"text/x-python","patch_set":2,"id":"61c92ded_1e136475","line":234,"updated":"2022-11-17 18:02:30.000000000","message":"Can you add a comment explaining this, even it\u0027s simply referring to the above? Simply\n\n  # As above\n\nwould do the trick","commit_id":"8e9b34f631e7e604f7625db7b7385cbd573ad8d8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f93526aa003c9fcc7a25703f5e5b7f1b9edd4d05","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                volume_client.backups,"},{"line_number":232,"context_line":"                parsed_args.backup)"},{"line_number":233,"context_line":"            backup \u003d backup_obj.id"},{"line_number":234,"context_line":"            size \u003d max(size or 0, backup_obj.size)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        volume \u003d volume_client.volumes.create("},{"line_number":237,"context_line":"            size\u003dsize,"}],"source_content_type":"text/x-python","patch_set":2,"id":"88501f6c_2a4ef574","line":234,"in_reply_to":"61c92ded_1e136475","updated":"2022-11-21 08:01:53.000000000","message":"Done","commit_id":"8e9b34f631e7e604f7625db7b7385cbd573ad8d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6250288d33400398c0f1763abeddd89e21320f04","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            source_volid\u003dsource_volume,"},{"line_number":246,"context_line":"            consistencygroup_id\u003dconsistency_group,"},{"line_number":247,"context_line":"            scheduler_hints\u003dparsed_args.hint,"},{"line_number":248,"context_line":"            backup_id\u003dbackup,"},{"line_number":249,"context_line":"        )"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if parsed_args.bootable or parsed_args.non_bootable:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe1fa66f_35430f39","line":248,"updated":"2022-11-17 18:02:30.000000000","message":"This is supported by the current minimum version of cinderclient, 3.3.0 👌","commit_id":"8e9b34f631e7e604f7625db7b7385cbd573ad8d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b003d7f85645149df10fe13f9c26e4612e5d706e","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            metavar\u003d\"\u003cbackup\u003e\","},{"line_number":123,"context_line":"            help\u003d_(\"Restore backup to a volume (name or ID). \""},{"line_number":124,"context_line":"                   \"Note that this option is available from \""},{"line_number":125,"context_line":"                   \"volume microversion 3.47 and onwards.\"),"},{"line_number":126,"context_line":"        )"},{"line_number":127,"context_line":"        source_group.add_argument("},{"line_number":128,"context_line":"            \"--source-replicated\","}],"source_content_type":"text/x-python","patch_set":4,"id":"cb4dcddb_adb7f35e","line":125,"updated":"2022-11-21 12:23:52.000000000","message":"We generally give this in option form to be more explicit.\n\n  help\u003d_(\n      \"Restore backup to a volume (name or ID) \"\n      \"(supported by --os-volume-api-version 3.47 or later)\"\n  ),\n\n(You\u0027ll find loads of examples of this wording if you grep for it)","commit_id":"5b86f15d4916904193f013e96b255b2e0fdc9fbf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"07c4dd4a28fe6c1a9d3854166dd170711b7cfb76","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            metavar\u003d\"\u003cbackup\u003e\","},{"line_number":123,"context_line":"            help\u003d_(\"Restore backup to a volume (name or ID). \""},{"line_number":124,"context_line":"                   \"Note that this option is available from \""},{"line_number":125,"context_line":"                   \"volume microversion 3.47 and onwards.\"),"},{"line_number":126,"context_line":"        )"},{"line_number":127,"context_line":"        source_group.add_argument("},{"line_number":128,"context_line":"            \"--source-replicated\","}],"source_content_type":"text/x-python","patch_set":4,"id":"8ab90e23_84851060","line":125,"in_reply_to":"cb4dcddb_adb7f35e","updated":"2022-11-21 15:01:00.000000000","message":"Done","commit_id":"5b86f15d4916904193f013e96b255b2e0fdc9fbf"}]}