)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"979581630db14fbbee4d3de769726fcd4cf3854c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"710bce2f_d5101b45","updated":"2022-11-22 14:55:18.000000000","message":"Some suggestions for follow-ups but nothing we need to block on. I\u0027ll review a follow-up if you get to one","commit_id":"d8cac265f2053fa320096ed9073c77996617a20a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abc489d71d8be069b59c8e9fbb6bc0df19621583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d78b066d_5b7d317c","updated":"2022-11-22 15:31:47.000000000","message":"Thanks Stephen","commit_id":"ebf614b84a32fda56fa27eff7f15788dc1d52509"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"979581630db14fbbee4d3de769726fcd4cf3854c","unresolved":true,"context_lines":[{"line_number":94,"context_line":"            metavar\u003d\"\u003csize\u003e\","},{"line_number":95,"context_line":"            type\u003dint,"},{"line_number":96,"context_line":"            help\u003d_(\"Volume size in GB (Required unless --snapshot or \""},{"line_number":97,"context_line":"                   \"--source is specified)\"),"},{"line_number":98,"context_line":"        )"},{"line_number":99,"context_line":"        parser.add_argument("},{"line_number":100,"context_line":"            \"--type\","}],"source_content_type":"text/x-python","patch_set":1,"id":"0e9cfa26_f7b7daa6","line":97,"updated":"2022-11-22 14:55:18.000000000","message":"Oh, we missed this when adding the --backup option. Could you update this (a follow-up is fine) to add --backup is provided?\n\n  help \u003d _(\n      \"Volume size in GB \"\n      \"(required unless --snapshot, --backup or --source are \"\n      \"specified)\"\n  ),","commit_id":"d8cac265f2053fa320096ed9073c77996617a20a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abc489d71d8be069b59c8e9fbb6bc0df19621583","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            metavar\u003d\"\u003csize\u003e\","},{"line_number":95,"context_line":"            type\u003dint,"},{"line_number":96,"context_line":"            help\u003d_(\"Volume size in GB (Required unless --snapshot or \""},{"line_number":97,"context_line":"                   \"--source is specified)\"),"},{"line_number":98,"context_line":"        )"},{"line_number":99,"context_line":"        parser.add_argument("},{"line_number":100,"context_line":"            \"--type\","}],"source_content_type":"text/x-python","patch_set":1,"id":"b42a5c3b_6859475e","line":97,"in_reply_to":"0e9cfa26_f7b7daa6","updated":"2022-11-22 15:31:47.000000000","message":"Since this was unrelated to this patch, done in https://review.opendev.org/c/openstack/python-openstackclient/+/865296","commit_id":"d8cac265f2053fa320096ed9073c77996617a20a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"979581630db14fbbee4d3de769726fcd4cf3854c","unresolved":true,"context_lines":[{"line_number":193,"context_line":"                    \"to create a volume from backup.\")"},{"line_number":194,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        size \u003d parsed_args.size"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        source_volume \u003d None"},{"line_number":199,"context_line":"        if parsed_args.source:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c73decd0_cb73de24","line":196,"updated":"2022-11-22 14:55:18.000000000","message":"A note here that \u0027size\u0027 has already been validated would be helpful. That or we move this up under the \u0027_check_size_arg\u0027 call (or inline that call)","commit_id":"d8cac265f2053fa320096ed9073c77996617a20a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"abc489d71d8be069b59c8e9fbb6bc0df19621583","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                    \"to create a volume from backup.\")"},{"line_number":194,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        size \u003d parsed_args.size"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        source_volume \u003d None"},{"line_number":199,"context_line":"        if parsed_args.source:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b90c8dac_172fadb4","line":196,"in_reply_to":"c73decd0_cb73de24","updated":"2022-11-22 15:31:47.000000000","message":"Done","commit_id":"d8cac265f2053fa320096ed9073c77996617a20a"}]}