)]}'
{"id":"openstack%2Fpython-openstackclient~865377","triplet_id":"openstack%2Fpython-openstackclient~master~I9219eecc65f0382c74c97cd13abd8f1bd258c3c1","project":"openstack/python-openstackclient","branch":"master","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2022-11-23 16:48:44.000000000","reason":"Change was abandoned"},"27615":{"account":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"last_update":"2022-11-23 16:48:38.000000000","reason":"\u003cGERRIT_ACCOUNT_27615\u003e replied on the change","reason_account":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}}},"hashtags":[],"change_id":"I9219eecc65f0382c74c97cd13abd8f1bd258c3c1","subject":"Update size and name parameters in volume create","status":"ABANDONED","created":"2022-11-23 08:52:21.000000000","updated":"2022-11-24 12:52:21.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9b88262b06c4f472fbea2b63b35ffe5ba0bc4c2f","_number":865377,"virtual_id_number":865377,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-11-23 09:50:08.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":-2,"date":"2022-11-23 13:33:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-23 09:50:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-23 13:33:33.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2022-11-23 14:50:49.000000000","updated_by":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"reviewer":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"state":"CC"}],"messages":[{"id":"19a9a79e01fc6ca1b30661cb117e625b9f3954df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2022-11-23 08:52:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"82584ca54d328d24a8948d85083f40341aa579f7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2022-11-23 08:55:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9e7704fb5ea507f27b137455e910a28149012d7e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-23 09:50:08.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/30e7b2b69eee4760b7343b5c116c1015\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/6aafc4fa761e4dcd86a417fb651d9572 : SUCCESS in 4m 42s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/863a28d53e8d463e848ff1579191e7a2 : FAILURE in 5m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2c7bf787ac7e4586840e405921f5180c : FAILURE in 3m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9346d848b8fd4a35b44b7efe852f4542 : SUCCESS in 3m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/789a01efa8da446a89a3ec678a1a5086 : FAILURE in 4m 06s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/9fe25a6d9ef24ac290990baae5f8ec47 : FAILURE in 3m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/56df646d797f47218d86b6e33d4ca8ff : SUCCESS in 5m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5a1f5790ab9742ef9a1e93dd17ee1720 : SUCCESS in 4m 14s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/d9686fea1fec4478a3bddbdb917f13ef : SUCCESS in 6m 13s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/18493cea4748416fa1b7075f7adee64b : FAILURE in 46m 11s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/60d12ec8a3014e02bc5345d19cfd2d46 : FAILURE in 53m 11s","accounts_in_message":[],"_revision_number":2},{"id":"d52937289e28af641c6b218c9043b3c1043c0404","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-11-23 13:33:33.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"aea7f9c846cc5215b8ec323d6dcfb322a5727074","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2022-11-23 16:48:38.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"f1eab388d0c303a021e72f81c5211ecef2ad4260","tag":"autogenerated:gerrit:abandon","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2022-11-23 16:48:44.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2},{"id":"9b88262b06c4f472fbea2b63b35ffe5ba0bc4c2f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-11-24 12:52:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bd741b96367aade8ae3509d06b229b28e6714eb4","revisions":{"51fda22bbf944db6e03c1cbbfa5878e33fd57f90":{"kind":"REWORK","_number":1,"created":"2022-11-23 08:52:21.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/77/865377/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/77/865377/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/865377/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/865377/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/865377/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/77/865377/1"}}},"commit":{"parents":[{"commit":"4710cbeca6638cc78880f2c4fc22d74aa7bb7c41","subject":"Add test for creating volume from source","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4710cbeca6638cc78880f2c4fc22d74aa7bb7c41"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-11-23 08:35:42.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-11-23 08:51:50.000000000","tz":330},"subject":"Update size and name parameters in volume create","message":"Update size and name parameters in volume create\n\nWhile migrating from cinderclient to OpenStack client, there is\nexpected to be a smooth transition and that means we want to try\nto keep the syntax as similar as possible.\nOne such case where this isn\u0027t satisfied is the name and size\narguments in the volume create command.\nThe name argument is positional (although it was made optional) and\nsize is an optional argument (although it is mandatory when not\ncreating volume from another resource), this is a gap that could\ncause the following behavior for end users:\n\nWhen we are creating a volume from snapshot (or source volume or\nbackup), we execute the following command in cinderclient:\n\ncinder create --snapshot \u003csnapshot-uuid\u003e \u003csize\u003e\n\nThis will create a volume from snapshot with the given size.\n\nEg: cinder create --snapshot \u003csome-snapshot-uuid\u003e 2\nwill create a volume of size 2 from given snapshot.\n\nIf we execute the same command in OSC,\n\nopenstack volume create --snapshot \u003csome-snapshot-uuid\u003e 2\nThis will create a volume of size same as snapshot but with name as 2.\n\nThis is because the syntax in OSC is following:\nopenstack volume create --snapshot \u003csnapshot-uuid\u003e \u003cname\u003e\nand we need to specify --size to provide the size for the resource.\nThis example is executed in [1] for reference.\n\nThis patch modifies the behavior to make size as positional argument\nand name as optional (--name).\n\n[1] https://paste.opendev.org/show/bBUk8ul0v2qpQJRS1hwt/\n\nChange-Id: I9219eecc65f0382c74c97cd13abd8f1bd258c3c1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/51fda22bbf944db6e03c1cbbfa5878e33fd57f90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/51fda22bbf944db6e03c1cbbfa5878e33fd57f90"}]},"branch":"refs/heads/master"},"bd741b96367aade8ae3509d06b229b28e6714eb4":{"kind":"REWORK","_number":2,"created":"2022-11-23 08:55:04.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/77/865377/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/77/865377/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/865377/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/865377/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/865377/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/77/865377/2"}}},"commit":{"parents":[{"commit":"4710cbeca6638cc78880f2c4fc22d74aa7bb7c41","subject":"Add test for creating volume from source","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4710cbeca6638cc78880f2c4fc22d74aa7bb7c41"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-11-23 08:35:42.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2022-11-23 08:54:43.000000000","tz":330},"subject":"Update size and name parameters in volume create","message":"Update size and name parameters in volume create\n\nWhile migrating from cinderclient to OpenStack client, there is\nexpected to be a smooth transition and that means we want to try\nto keep the syntax as similar as possible.\nOne such case where this isn\u0027t satisfied is the name and size\narguments in the volume create command.\nThe name argument is positional (although it was made optional) and\nsize is an optional argument (although it is mandatory when not\ncreating volume from another resource), this is a gap that could\ncause the following behavior for end users:\n\nWhen we are creating a volume from snapshot (or source volume or\nbackup), we execute the following command in cinderclient:\n\ncinder create --snapshot \u003csnapshot-uuid\u003e \u003csize\u003e\n\nThis will create a volume from snapshot with the given size.\n\nEg: cinder create --snapshot \u003csome-snapshot-uuid\u003e 2\nwill create a volume of size 2 from given snapshot.\n\nIf we execute the same command in OSC,\n\nopenstack volume create --snapshot \u003csome-snapshot-uuid\u003e 2\nThis will create a volume of size same as snapshot but with name as 2.\n\nThis is because the syntax in OSC is following:\nopenstack volume create --snapshot \u003csnapshot-uuid\u003e \u003cname\u003e\nand we need to specify --size to provide the size for the resource.\nThis example is executed in [1] for reference.\n\nThis patch modifies the behavior to make size as positional argument\nand name as optional (--name).\n\n[1] https://paste.opendev.org/show/bBUk8ul0v2qpQJRS1hwt/\n\nChange-Id: I9219eecc65f0382c74c97cd13abd8f1bd258c3c1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bd741b96367aade8ae3509d06b229b28e6714eb4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bd741b96367aade8ae3509d06b229b28e6714eb4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}