)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9900f8ac6bbb6b5eb1a625780b8edc26636019e2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ariel-Berkowicz \u003carielmb@bu.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-27 20:23:26 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Compared review #858366 with #763414 to create a stable build based off of master"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43b2071f5108c28f6881c8e99d4b06e87c83ddfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"76b2b906_b9026a86","line":7,"updated":"2022-11-29 15:25:47.000000000","message":"This is useful context but it doesn\u0027t belong in a commit message. Can you indicate what the commit itself is doing? Something like:\n\n  compute: Migrate hypervisor stats commands to SDK\n\n  We migrate these commands. We also add some new functional tests to validate\n  behavior of the hypervisor commands.\n\nAs an aside, I suspect the functional tests are the things that will fail so it might make sense to split those out into another separate change?","commit_id":"c26b65f1e2b8f0ea7f64f6d57651c72b2420ec3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cfab6e37a8b7c84890d788255644d5a0b65ecbc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ariel-Berkowicz \u003carielmb@bu.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-27 20:23:26 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Compared review #858366 with #763414 to create a stable build based off of master"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43b2071f5108c28f6881c8e99d4b06e87c83ddfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a064abbe_ba7b5202","line":7,"in_reply_to":"2cfbeb0a_9493cd3c","updated":"2022-12-08 11:39:23.000000000","message":"Turned out we needed this but for other reasons 😄","commit_id":"c26b65f1e2b8f0ea7f64f6d57651c72b2420ec3c"},{"author":{"_account_id":35430,"name":"Ariel Berkowicz","email":"arielmb@bu.edu","username":"arielmb"},"change_message_id":"db87b6bfa2f8aef76beaa035f9319158a69ed94c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ariel-Berkowicz \u003carielmb@bu.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-27 20:23:26 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Compared review #858366 with #763414 to create a stable build based off of master"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43b2071f5108c28f6881c8e99d4b06e87c83ddfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2cfbeb0a_9493cd3c","line":7,"in_reply_to":"76b2b906_b9026a86","updated":"2022-12-01 00:33:33.000000000","message":"Zuul passed the functional test cases, so do you think I should still do so?","commit_id":"c26b65f1e2b8f0ea7f64f6d57651c72b2420ec3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cfab6e37a8b7c84890d788255644d5a0b65ecbc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute: Migrate hypervisor stats commands to SDK"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We migrate these commands. We also add some new functional tests to validate behavior of the hypervisor commands."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I43b2071f5108c28f6881c8e99d4b06e87c83ddfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4c35caed_1d401b84","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":113},"updated":"2022-12-08 11:39:23.000000000","message":"This is no longer true.","commit_id":"7faa05e6dfccc26086bed43e4498c2eaa6bdffc3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e8b6dc373e7b90573f522f78f2f703f6bbff65a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute: Migrate hypervisor stats commands to SDK"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We migrate these commands. We also add some new functional tests to validate behavior of the hypervisor commands."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I43b2071f5108c28f6881c8e99d4b06e87c83ddfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bd847a15_2b051b49","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":113},"in_reply_to":"4c35caed_1d401b84","updated":"2022-12-12 10:15:24.000000000","message":"Done","commit_id":"7faa05e6dfccc26086bed43e4498c2eaa6bdffc3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"216d45036b2e7b63702c7f5899b5d6a58898d8cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"954c1250_bd3a9908","updated":"2022-12-02 12:51:36.000000000","message":"you describe your change as migrating of hypervisor stats, but you also touch tests for hypervisor without mentioning it. Those changes should (if necessary) go to a separate change.\nOtherwise change is good","commit_id":"93bfab208eea4170ce8d72c3703a9a234ec0d23c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cfab6e37a8b7c84890d788255644d5a0b65ecbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"70e50424_a7511c8e","updated":"2022-12-08 11:39:23.000000000","message":"Your commit message now needs an update post split-out of the functional tests. I also spotted another issue with the fakes. Should be relatively easy to address but let me know if anything isn\u0027t clear!","commit_id":"7faa05e6dfccc26086bed43e4498c2eaa6bdffc3"}],"openstackclient/tests/unit/compute/v2/fakes.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cfab6e37a8b7c84890d788255644d5a0b65ecbc","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        :param dict attrs:"},{"line_number":352,"context_line":"            A dictionary with all attributes"},{"line_number":353,"context_line":"        :return:"},{"line_number":354,"context_line":"            A FakeResource object, with count, current_workload, and so on"},{"line_number":355,"context_line":"        \"\"\""},{"line_number":356,"context_line":"        attrs \u003d attrs or {}"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"73817051_fda69ac7","side":"PARENT","line":354,"updated":"2022-12-08 11:39:23.000000000","message":"This isn\u0027t true. It now returns a dict.\n\nTo be honest, I\u0027d probably get rid of this method and move creation of the \u0027hypervisor_stats\u0027 dict into the unit test. Every other class here returns (or will return, once migration to SDK is complete) a subclass of \u0027openstack.resource.Resource\u0027 _except_ this one. This returns a dict because the hypervisor stats API is deprecated and openstacksdk has chosen not to provide an implementation.","commit_id":"29129a7715feb750b7738a5884f9d2f49491a511"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cfab6e37a8b7c84890d788255644d5a0b65ecbc","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        :param int count:"},{"line_number":393,"context_line":"            The number of hypervisors to fake"},{"line_number":394,"context_line":"        :return:"},{"line_number":395,"context_line":"            A list of FakeResource objects faking the hypervisors"},{"line_number":396,"context_line":"        \"\"\""},{"line_number":397,"context_line":"        hypervisors \u003d []"},{"line_number":398,"context_line":"        for i in range(0, count):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ec2405b4_f3e987e0","side":"PARENT","line":395,"updated":"2022-12-08 11:39:23.000000000","message":"This isn\u0027t true either, but this method has no callers and should really just be removed.","commit_id":"29129a7715feb750b7738a5884f9d2f49491a511"}],"openstackclient/tests/unit/compute/v2/test_hypervisor_stats.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e8b6dc373e7b90573f522f78f2f703f6bbff65a4","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    \"\"\"Fake one or more hypervisor stats.\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @staticmethod"},{"line_number":39,"context_line":"    def create_one_hypervisor_stats(attrs\u003dNone):"},{"line_number":40,"context_line":"        \"\"\"Create a fake hypervisor stats."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :param dict attrs:"}],"source_content_type":"text/x-python","patch_set":7,"id":"938a587f_a9907c52","line":39,"updated":"2022-12-12 10:15:24.000000000","message":"nit: you can flatten this. Instead of\n\n  class FakeHypervisorStats(object):\n      \"\"\"Fake one or more hypervisor stats.\"\"\"\n\n      @staticmethod\n      def create_one_hypervisor_stats(attrs\u003dNone):\n          ...\n\nYou could simply do:\n\n  def create_one_hypervisor_stats(attrs\u003dNone):\n      ...","commit_id":"80743f1f1a5472a94b2b31a0cfdb4a7968377a96"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5b4507e6423a613102ddd74f98ebdbcce4af51e1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \"\"\"Fake one or more hypervisor stats.\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @staticmethod"},{"line_number":39,"context_line":"    def create_one_hypervisor_stats(attrs\u003dNone):"},{"line_number":40,"context_line":"        \"\"\"Create a fake hypervisor stats."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :param dict attrs:"}],"source_content_type":"text/x-python","patch_set":7,"id":"99b8afbd_f31c4c64","line":39,"in_reply_to":"938a587f_a9907c52","updated":"2022-12-14 10:28:39.000000000","message":"Done","commit_id":"80743f1f1a5472a94b2b31a0cfdb4a7968377a96"}]}