)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"805bc4d10ca0bb3b4a05781e2d1e4868b7a8cf13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0bbd3625_e124fc36","updated":"2022-12-01 15:39:11.000000000","message":"I guess it\u0027s a problem that we require --image (that needs to be None when doing BFV) when doing block-device-mapping with boot_index\u003d0","commit_id":"5326beee56713470e5539e889bf08be67c0aaf50"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa6ca7ce301d1161ab1b4dbc56a9b1185a9cd9fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d8ded18_b5a6e797","updated":"2022-12-01 13:36:45.000000000","message":"Patch itself is fine. I just have a question on the necessity of it","commit_id":"5326beee56713470e5539e889bf08be67c0aaf50"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"215450ec7fae5031f29e21be02ccfbada89309a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa3ea3df_76d1e185","updated":"2022-12-01 15:41:39.000000000","message":"ah now I see, answered before reading your comment, https://review.opendev.org/c/openstack/python-openstackclient/+/862176 should solve it then.\n\nThen I guess I could just revert to using --block-device as expected when above is released, no need to implement anything as that is already supported there.","commit_id":"5326beee56713470e5539e889bf08be67c0aaf50"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4ed8594e03ce40a28de199043bf2284b10c4dab","unresolved":true,"context_lines":[{"line_number":961,"context_line":"                \u0027volume type used in the block device mapping. \u0027"},{"line_number":962,"context_line":"                \u0027(supported by --os-compute-api-version 2.67 or above)\u0027"},{"line_number":963,"context_line":"            )"},{"line_number":964,"context_line":"        )"},{"line_number":965,"context_line":"        # TODO(stephenfin): Remove this in the v7.0"},{"line_number":966,"context_line":"        parser.add_argument("},{"line_number":967,"context_line":"            \u0027--block-device-mapping\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"80a58c29_143ccc4c","line":964,"updated":"2022-12-01 13:36:22.000000000","message":"Is this something you\u0027d consider a regular occurrence? The \u0027--boot-from-volume\u0027 option is a shortcut for the following:\n\n  --block-device id\u003d$image,boot_index\u003d0,source_type\u003dimage,destination_type\u003dvolume,volume_size\u003d$size\n\nThere are various other properties we can configure as part of a BDM including \u0027device_type\u0027, \u0027disk_bus\u0027 and \u0027tag\u0027 and we don\u0027t want to expose a \u0027--boot-from-volume-foo\u0027 opt for each of these. If this is a common enough operation then we can do this but if not I\u0027d expect people to create their block devices the longer way.","commit_id":"5326beee56713470e5539e889bf08be67c0aaf50"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"8da7ab0c1a32b6b1698e54cbff41358e63d80503","unresolved":true,"context_lines":[{"line_number":961,"context_line":"                \u0027volume type used in the block device mapping. \u0027"},{"line_number":962,"context_line":"                \u0027(supported by --os-compute-api-version 2.67 or above)\u0027"},{"line_number":963,"context_line":"            )"},{"line_number":964,"context_line":"        )"},{"line_number":965,"context_line":"        # TODO(stephenfin): Remove this in the v7.0"},{"line_number":966,"context_line":"        parser.add_argument("},{"line_number":967,"context_line":"            \u0027--block-device-mapping\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffc343db_98e25fa9","line":964,"in_reply_to":"80a58c29_143ccc4c","updated":"2022-12-01 15:04:17.000000000","message":"$ openstack --version\n5.7.0\n\nJust with --block-device like this I have to specify --image\n\n$ openstack server create --flavor gp.1x2 --availability-zone europe-se-1a --block-device uuid\u003df74c2365-94fa-4a0d-924d-053074c4c57c,source_type\u003dimage,destination_type\u003dvolume,volume_size\u003d52,boot_index\u003d0,delete_on_termination\u003dtrue --network europe-se-1-1a-net0 --security-group default --key-name tobias-urdin-macbook mytest\n\nopenstack server create: error: one of the arguments --image --image-property --volume --snapshot is required\n\nIf I add image I get an error I cannot have boot_index\u003d0\n\n$ openstack server create --flavor gp.1x2 --availability-zone europe-se-1a --image ubuntu-jammy-22-x86_64 --block-device uuid\u003df74c2365-94fa-4a0d-924d-053074c4c57c,source_type\u003dimage,destination_type\u003dvolume,volume_size\u003d52,boot_index\u003d0,delete_on_termination\u003dtrue --network europe-se-1-1a-net0 --security-group default --key-name tobias-urdin-macbook mytest\n\nBlock Device Mapping is Invalid: Boot sequence for the instance and image/block device mapping combination is not valid. (HTTP 400)\n\nIf I change to boot_index\u003d1 I get a server but with 1 local disk and 1 volume attached so not a boot from volume server.\n\nIf I use --boot-from-volume I get a server booted from a volume but I cannot specify either delete_on_termination or volume_type (from microversion 2.67) both of which I want.\n\nI think it was possible with --block-device-mapping but that\u0027s deprecated, hence I added --boot-from-volume-type here but would like to do the same for delete_on_termination.\n\nPerhaps I should either:\n\n1) propose --boot-from-volume-opts delete_on_termination\u003d1,volume_type\u003dhdd\n\nor\n\n2) change --boot-from-volume to support an int for size and keep current default and also support \"--boot-from-volume size\u003d10, delete_on_termination\u003dtrue,volume_type\u003dhdd\"\n\nWhat do you think?","commit_id":"5326beee56713470e5539e889bf08be67c0aaf50"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"99081b99a7f60e0948db116bd2dd144e094c480e","unresolved":true,"context_lines":[{"line_number":961,"context_line":"                \u0027volume type used in the block device mapping. \u0027"},{"line_number":962,"context_line":"                \u0027(supported by --os-compute-api-version 2.67 or above)\u0027"},{"line_number":963,"context_line":"            )"},{"line_number":964,"context_line":"        )"},{"line_number":965,"context_line":"        # TODO(stephenfin): Remove this in the v7.0"},{"line_number":966,"context_line":"        parser.add_argument("},{"line_number":967,"context_line":"            \u0027--block-device-mapping\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9bab04fb_501d1fd6","line":964,"in_reply_to":"ffc343db_98e25fa9","updated":"2022-12-01 15:38:52.000000000","message":"\u003e $ openstack --version\n\u003e 5.7.0\n\u003e \n\u003e Just with --block-device like this I have to specify --image\n\u003e \n\u003e $ openstack server create --flavor gp.1x2 --availability-zone europe-se-1a --block-device uuid\u003df74c2365-94fa-4a0d-924d-053074c4c57c,source_type\u003dimage,destination_type\u003dvolume,volume_size\u003d52,boot_index\u003d0,delete_on_termination\u003dtrue --network europe-se-1-1a-net0 --security-group default --key-name tobias-urdin-macbook mytest\n\u003e \n\u003e openstack server create: error: one of the arguments --image --image-property --volume --snapshot is required\n\u003e \n\u003e If I add image I get an error I cannot have boot_index\u003d0\n\u003e \n\u003e $ openstack server create --flavor gp.1x2 --availability-zone europe-se-1a --image ubuntu-jammy-22-x86_64 --block-device uuid\u003df74c2365-94fa-4a0d-924d-053074c4c57c,source_type\u003dimage,destination_type\u003dvolume,volume_size\u003d52,boot_index\u003d0,delete_on_termination\u003dtrue --network europe-se-1-1a-net0 --security-group default --key-name tobias-urdin-macbook mytest\n\u003e \n\u003e Block Device Mapping is Invalid: Boot sequence for the instance and image/block device mapping combination is not valid. (HTTP 400)\n\u003e \n\u003e If I change to boot_index\u003d1 I get a server but with 1 local disk and 1 volume attached so not a boot from volume server.\n\nAh, yes, that\u0027s a bug. I thought we\u0027d already fixed it but I see now the patch hadn\u0027t merged yet. That will work as soon as [1] merges and is released.\n\n[1] https://review.opendev.org/c/openstack/python-openstackclient/+/862176\n\n\u003e If I use --boot-from-volume I get a server booted from a volume but I cannot specify either delete_on_termination or volume_type (from microversion 2.67) both of which I want.\n\u003e \n\u003e I think it was possible with --block-device-mapping but that\u0027s deprecated, hence I added --boot-from-volume-type here but would like to do the same for delete_on_termination.\n\u003e \n\u003e Perhaps I should either:\n\u003e \n\u003e 1) propose --boot-from-volume-opts delete_on_termination\u003d1,volume_type\u003dhdd\n\u003e \n\u003e or\n\u003e \n\u003e 2) change --boot-from-volume to support an int for size and keep current default and also support \"--boot-from-volume size\u003d10, delete_on_termination\u003dtrue,volume_type\u003dhdd\"\n\u003e \n\u003e What do you think?\n\nAssuming a version of \u0027--block-device\u0027 with that fix isn\u0027t good enough (is it), we could also 3) undeprecate \u0027--block-device-mapping\u0027 and simply indicate that it\u0027s less powerful than \u0027--block-device\u0027? Both of the above options seem to give options that are similarly icky to type but less powerful than \u0027--block-device\u0027.\n\nIt\u0027s also worth noting that \u0027--volume\u0027 and \u0027--snapshot\u0027 have the same issue, in that they provide a shortcut version of \u0027--block-device\u0027 but without any knobs. That\u0027s perfectly okay though, IMO: if you want all the power, use the longer \u0027--block-device\u0027 option.","commit_id":"5326beee56713470e5539e889bf08be67c0aaf50"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4ed8594e03ce40a28de199043bf2284b10c4dab","unresolved":false,"context_lines":[{"line_number":1484,"context_line":"            # If we get a boot from volume type add it to BDM"},{"line_number":1485,"context_line":"            if parsed_args.boot_from_volume_type:"},{"line_number":1486,"context_line":"                if (compute_client.api_version \u003c api_versions.APIVersion("},{"line_number":1487,"context_line":"                        \"2.67\")):"},{"line_number":1488,"context_line":"                    msg \u003d _(\"--boot-from-volume-type is not supported for \""},{"line_number":1489,"context_line":"                            \"--os-compute-api-version less than 2.67\")"},{"line_number":1490,"context_line":"                    raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f6b29fa_ca89481b","line":1487,"updated":"2022-12-01 13:36:22.000000000","message":"nit: can this fit on one line?","commit_id":"5326beee56713470e5539e889bf08be67c0aaf50"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"8da7ab0c1a32b6b1698e54cbff41358e63d80503","unresolved":false,"context_lines":[{"line_number":1484,"context_line":"            # If we get a boot from volume type add it to BDM"},{"line_number":1485,"context_line":"            if parsed_args.boot_from_volume_type:"},{"line_number":1486,"context_line":"                if (compute_client.api_version \u003c api_versions.APIVersion("},{"line_number":1487,"context_line":"                        \"2.67\")):"},{"line_number":1488,"context_line":"                    msg \u003d _(\"--boot-from-volume-type is not supported for \""},{"line_number":1489,"context_line":"                            \"--os-compute-api-version less than 2.67\")"},{"line_number":1490,"context_line":"                    raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5807d88e_dfd2fa70","line":1487,"in_reply_to":"3f6b29fa_ca89481b","updated":"2022-12-01 15:04:17.000000000","message":"I will check on next PS","commit_id":"5326beee56713470e5539e889bf08be67c0aaf50"}]}