)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2752a01c3bd5c51a2f6e888ea413271d17745192","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d799285_27e38e64","updated":"2022-12-15 16:06:21.000000000","message":"Also, don\u0027t know if you\u0027ll have time, but it would be nice to work on a follow-up to move the remaining server migration commands across so we can dump all that legacy stuff. It should be relatively easy now that you\u0027ve all that hardwork done","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cbb7b735deb4db2da75a5a76e62c9314a6fd497a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f1a79d4_353a40a9","updated":"2022-12-15 16:05:30.000000000","message":"Two nits in the tests. This otherwise LGTM","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"},{"author":{"_account_id":34327,"name":"Violet Kurtz","email":"vikurtz@osuosl.org","username":"OniLink"},"change_message_id":"87d78583522e5fe1982ceb573c9dce741dd1057a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e581f9cc_881c8036","in_reply_to":"1d799285_27e38e64","updated":"2022-12-16 04:20:01.000000000","message":"Yeah, I can absolutely look into it. I will probably wait until this and the other server migration patch are merged, then it shouldn\u0027t take too long since the framework is all there at this point.","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"},{"author":{"_account_id":34327,"name":"Violet Kurtz","email":"vikurtz@osuosl.org","username":"OniLink"},"change_message_id":"c930679e6a7db7647871c6832aff5be8e59d4d8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"94070bad_b8ee27f1","updated":"2022-12-31 02:05:07.000000000","message":"Rebased on the other work for server migration, then finished migrating everything for it to the SDK","commit_id":"525a70d5c66c04c85f3eabc0e954f74ed1ebab27"}],"openstackclient/tests/unit/compute/v2/fakes.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cbb7b735deb4db2da75a5a76e62c9314a6fd497a","unresolved":false,"context_lines":[{"line_number":1847,"context_line":"    return _server_interface.ServerInterface(**server_interface_info)"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"def create_one_server_migration(attrs\u003dNone, methods\u003dNone):"},{"line_number":1851,"context_line":"    \"\"\"Create a fake server migration."},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    :param dict attrs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"20509cf2_6b0d933a","line":1850,"updated":"2022-12-15 16:05:30.000000000","message":"Okay, so this is a duplicate but it exists because we haven\u0027t migrated the final few commands across. We can dump the other one when that happens.","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"}],"openstackclient/tests/unit/compute/v2/test_server_migration.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cbb7b735deb4db2da75a5a76e62c9314a6fd497a","unresolved":true,"context_lines":[{"line_number":606,"context_line":"    def setUp(self):"},{"line_number":607,"context_line":"        super().setUp()"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        self.server \u003d compute_fakes.FakeServer.create_one_server()"},{"line_number":610,"context_line":"        self.sdk_client.find_server.return_value \u003d self.server"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        self.server_migration \u003d compute_fakes.create_one_server_migration()"}],"source_content_type":"text/x-python","patch_set":1,"id":"e96811d2_cbcaef57","line":609,"updated":"2022-12-15 16:05:30.000000000","message":"This is a novaclient fake server, not an SDK one. You want create_one_sdk_server (I think)","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"},{"author":{"_account_id":34327,"name":"Violet Kurtz","email":"vikurtz@osuosl.org","username":"OniLink"},"change_message_id":"43a37e94df4d5d9b5d7272c0e209ae7cf19d68ba","unresolved":false,"context_lines":[{"line_number":606,"context_line":"    def setUp(self):"},{"line_number":607,"context_line":"        super().setUp()"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        self.server \u003d compute_fakes.FakeServer.create_one_server()"},{"line_number":610,"context_line":"        self.sdk_client.find_server.return_value \u003d self.server"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        self.server_migration \u003d compute_fakes.create_one_server_migration()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d18c0141_eb1d268d","line":609,"in_reply_to":"e96811d2_cbcaef57","updated":"2022-12-16 04:06:26.000000000","message":"Done","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cbb7b735deb4db2da75a5a76e62c9314a6fd497a","unresolved":true,"context_lines":[{"line_number":612,"context_line":"        self.server_migration \u003d compute_fakes.create_one_server_migration()"},{"line_number":613,"context_line":"        self.sdk_client.get_server_migration.return_value \u003d\\"},{"line_number":614,"context_line":"            self.server_migration"},{"line_number":615,"context_line":"        self.sdk_client.server_migrations.return_value \u003d\\"},{"line_number":616,"context_line":"            [self.server_migration]"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        self.columns \u003d ("},{"line_number":619,"context_line":"            \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b296cef2_b0c8754e","line":616,"range":{"start_line":615,"start_character":1,"end_line":616,"end_character":35},"updated":"2022-12-15 16:05:30.000000000","message":"nit: this should be an iterator\n\n self.sdk_client.server_migrations.return_value \u003d iter(\n     [self.server_migration]\n )","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"},{"author":{"_account_id":34327,"name":"Violet Kurtz","email":"vikurtz@osuosl.org","username":"OniLink"},"change_message_id":"43a37e94df4d5d9b5d7272c0e209ae7cf19d68ba","unresolved":false,"context_lines":[{"line_number":612,"context_line":"        self.server_migration \u003d compute_fakes.create_one_server_migration()"},{"line_number":613,"context_line":"        self.sdk_client.get_server_migration.return_value \u003d\\"},{"line_number":614,"context_line":"            self.server_migration"},{"line_number":615,"context_line":"        self.sdk_client.server_migrations.return_value \u003d\\"},{"line_number":616,"context_line":"            [self.server_migration]"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        self.columns \u003d ("},{"line_number":619,"context_line":"            \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d50b7174_de2778d5","line":616,"range":{"start_line":615,"start_character":1,"end_line":616,"end_character":35},"in_reply_to":"b296cef2_b0c8754e","updated":"2022-12-16 04:06:26.000000000","message":"Done","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7fb7ccb8e7c1961a0dd9b804c8009319b7b09085","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    MIGRATION_FIELDS \u003d ["},{"line_number":66,"context_line":"        \u0027id\u0027, \u0027uuid\u0027, \u0027source_node\u0027, \u0027dest_node\u0027, \u0027source_compute\u0027,"},{"line_number":67,"context_line":"        \u0027dest_compute\u0027, \u0027dest_host\u0027, \u0027status\u0027, \u0027server_id\u0027, \u0027old_flavor_id\u0027,"},{"line_number":68,"context_line":"        \u0027new_flavor_id\u0027, \u0027migration_type\u0027, \u0027created_at\u0027, \u0027updated_at\u0027"},{"line_number":69,"context_line":"    ]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f9f474d_188a5250","line":68,"updated":"2023-01-04 13:31:13.000000000","message":"We need to change this because we haven\u0027t set the microversion. By setting that to 2.1, this change goes away.","commit_id":"525a70d5c66c04c85f3eabc0e954f74ed1ebab27"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7fb7ccb8e7c1961a0dd9b804c8009319b7b09085","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.server \u003d compute_fakes.FakeServer.create_one_sdk_server()"},{"line_number":75,"context_line":"        self.sdk_client.find_server.return_value \u003d self.server"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.migrations \u003d compute_fakes.create_server_migrations("},{"line_number":78,"context_line":"            count\u003d3)"},{"line_number":79,"context_line":"        self.sdk_client.migrations.return_value \u003d self.migrations"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"99f8b786_eea26012","line":77,"updated":"2023-01-04 13:31:13.000000000","message":"This isn\u0027t correct. Migration !\u003d ServerMigration. I\u0027ve split this out into a separate patch and fixed it up since it\u0027s tangential to this.","commit_id":"525a70d5c66c04c85f3eabc0e954f74ed1ebab27"}],"releasenotes/notes/switch-server-migration-show-to-sdk-4adb88a0f1f03f3b.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cbb7b735deb4db2da75a5a76e62c9314a6fd497a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Switch server migration show to the OpenStackSDK"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8f9dc0c4_6683121f","line":4,"updated":"2022-12-15 16:05:30.000000000","message":"nit: extra newline","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"},{"author":{"_account_id":34327,"name":"Violet Kurtz","email":"vikurtz@osuosl.org","username":"OniLink"},"change_message_id":"43a37e94df4d5d9b5d7272c0e209ae7cf19d68ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Switch server migration show to the OpenStackSDK"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1d2805cb_df906b97","line":4,"in_reply_to":"8f9dc0c4_6683121f","updated":"2022-12-16 04:06:26.000000000","message":"Done","commit_id":"add06c2cb34bb74879347f26eb78f05f3982f44a"}]}