)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"66335dc096ecbebe72e96496cb7c7bbb9543c4bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ea71d9f_d48d63ec","updated":"2023-01-11 12:45:25.000000000","message":"Another nice change. Again, one question around naming.","commit_id":"12e6fd8c2327510b4ae7d3aeebdb273df6baa096"}],"setup.cfg":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"66335dc096ecbebe72e96496cb7c7bbb9543c4bf","unresolved":true,"context_lines":[{"line_number":813,"context_line":"    volume_transfer_request_show \u003d openstackclient.volume.v2.volume_transfer_request:ShowTransferRequest"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    volume_summary \u003d openstackclient.volume.v3.volume:VolumeSummary"},{"line_number":816,"context_line":"    volume_revert_snapshot \u003d openstackclient.volume.v3.volume:VolumeRevertSnapshot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c152bae1_8ffc9361","line":816,"range":{"start_line":816,"start_character":4,"end_line":816,"end_character":26},"updated":"2023-01-11 12:45:25.000000000","message":"Do we need the \u0027snapshot\u0027 bit of this command? Wouldn\u0027t\n\n  volume revert [snapshot]\n\nbe self-explanatory enough?","commit_id":"12e6fd8c2327510b4ae7d3aeebdb273df6baa096"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"132f26939dd48a1ce45c037d42ab9877fea83ba6","unresolved":true,"context_lines":[{"line_number":813,"context_line":"    volume_transfer_request_show \u003d openstackclient.volume.v2.volume_transfer_request:ShowTransferRequest"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    volume_summary \u003d openstackclient.volume.v3.volume:VolumeSummary"},{"line_number":816,"context_line":"    volume_revert_snapshot \u003d openstackclient.volume.v3.volume:VolumeRevertSnapshot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"0f51a297_7f3fd64a","line":816,"range":{"start_line":816,"start_character":4,"end_line":816,"end_character":26},"in_reply_to":"2255941a_681822a7","updated":"2023-01-12 19:10:26.000000000","message":"FWIW, I like the \u0027volume revert \u003cid\u003e\u0027 better.","commit_id":"12e6fd8c2327510b4ae7d3aeebdb273df6baa096"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d867e658e1da3cb527c28067f17391360b8cc1c2","unresolved":true,"context_lines":[{"line_number":813,"context_line":"    volume_transfer_request_show \u003d openstackclient.volume.v2.volume_transfer_request:ShowTransferRequest"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    volume_summary \u003d openstackclient.volume.v3.volume:VolumeSummary"},{"line_number":816,"context_line":"    volume_revert_snapshot \u003d openstackclient.volume.v3.volume:VolumeRevertSnapshot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"2f2bbb9f_24e071c1","line":816,"range":{"start_line":816,"start_character":4,"end_line":816,"end_character":26},"in_reply_to":"2255941a_681822a7","updated":"2023-01-12 19:11:34.000000000","message":"I would vote for dropping the \"snapshot\" part of the command and using Stephen\u0027s proposal of\n    volume revert [snapshot]\n\nNaming it\n    volume revert snapshot [snapshot]\n\nimplies that the command is reverting the snapshot instead of the volume, which isn\u0027t accurate.","commit_id":"12e6fd8c2327510b4ae7d3aeebdb273df6baa096"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a0cd11ec5fd2bf89f347c27ebe22455723f0783","unresolved":false,"context_lines":[{"line_number":813,"context_line":"    volume_transfer_request_show \u003d openstackclient.volume.v2.volume_transfer_request:ShowTransferRequest"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    volume_summary \u003d openstackclient.volume.v3.volume:VolumeSummary"},{"line_number":816,"context_line":"    volume_revert_snapshot \u003d openstackclient.volume.v3.volume:VolumeRevertSnapshot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"4fd1d01a_2e6afb7b","line":816,"range":{"start_line":816,"start_character":4,"end_line":816,"end_character":26},"in_reply_to":"2f2bbb9f_24e071c1","updated":"2023-01-13 07:15:55.000000000","message":"Based on the feedback, updated the command. Thanks everyone!","commit_id":"12e6fd8c2327510b4ae7d3aeebdb273df6baa096"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c4246b609913c9c39b179a250bcb42ca69e5ea8c","unresolved":true,"context_lines":[{"line_number":813,"context_line":"    volume_transfer_request_show \u003d openstackclient.volume.v2.volume_transfer_request:ShowTransferRequest"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    volume_summary \u003d openstackclient.volume.v3.volume:VolumeSummary"},{"line_number":816,"context_line":"    volume_revert_snapshot \u003d openstackclient.volume.v3.volume:VolumeRevertSnapshot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"2255941a_681822a7","line":816,"range":{"start_line":816,"start_character":4,"end_line":816,"end_character":26},"in_reply_to":"c152bae1_8ffc9361","updated":"2023-01-12 18:19:08.000000000","message":"actually yes but (I might be talking too much about keeping the migration as minimal as possible) we use revert-to-snapshot in cinderclient so it kind of adds a keyword stating we\u0027re actually reverting to a snapshot of this volume (if someone is not looking at the help text).\nopenstack volume revert snapshot \u003cid\u003e\nopenstack volume revert \u003cid\u003e\n\nIn the second example, I don\u0027t see it very trivial for users to understand we\u0027ve to put snap ID there. Let me ask other cores what they think about this.","commit_id":"12e6fd8c2327510b4ae7d3aeebdb273df6baa096"}]}