)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10300434c5d0a3cf9c69d2257429f31f84545d6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"873f9379_9d08631f","updated":"2023-02-17 09:55:15.000000000","message":"Well, we need pypi to have 18.3.0 which isn\u0027t released yet.\nhttps://review.opendev.org/c/openstack/releases/+/873537\n\n\n2023-02-15 18:18:57.188616 | controller | Collecting python-novaclient\u003e\u003d17.2.1\n2023-02-15 18:18:57.192845 | controller |   Downloading https://mirror-int.iad.rax.opendev.org/wheel/ubuntu-22.04-x86_64/python-novaclient/python_novaclient-18.2.0-py3-none-any.whl (335 kB)\n\n","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46519cb26bdbde48ceb00c6467b13769768085be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73859967_8a34c713","updated":"2023-05-18 10:11:15.000000000","message":"You\u0027re going to need to pull this down, rebase it and run black (pre-commit run black -a) before we can merge it.","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"bb559b1abc88ad2cf1163291b38b93ee0ee01611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4f7424d_1d1317cf","updated":"2023-04-15 01:13:27.000000000","message":"recheck","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a9e9e6792e4f2fb5dd52331ca3691c3bec9a6759","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81ed3287_7b9cd43a","updated":"2023-02-20 08:37:02.000000000","message":"recheck https://pypi.org/project/python-novaclient/18.3.0/ is now delivered","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1fe5d83fb9cceb5c0b48984b53e988c59fc1386e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fee9ee02_f58692ca","updated":"2023-02-14 16:24:52.000000000","message":"recheck novaclient patch merged","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"53d0d69df5c9780a4b95afd583ebc1713bff5632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7d373c6_7185d692","updated":"2023-02-15 17:22:53.000000000","message":"recheck test_server_create_with_fqdn_hostname failed beasue it did not have 2.94 microversion however i think this was related to pypi package verions?\n\nhttps://pypi.org/project/python-novaclient/ seams to be out of date","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63d980c6e5d14bf42bec9fd665f8c5df194125f9","unresolved":true,"context_lines":[{"line_number":1353,"context_line":"                \u0027Up to and incuding --os-compute-api-version 2.93, \u0027"},{"line_number":1354,"context_line":"                \u0027this can only be a short name. \u0027"},{"line_number":1355,"context_line":"                \u0027With --os-compute-api-version 2.94 and above, \u0027"},{"line_number":1356,"context_line":"                \u0027this can be a Fully Qualified Domain Name (FQDN).\u0027"},{"line_number":1357,"context_line":"            ),"},{"line_number":1358,"context_line":"        )"},{"line_number":1359,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"e769ba2a_c876d28a","line":1356,"updated":"2023-05-18 10:10:44.000000000","message":"We tend to keep these side notes in brackets. How about something like:\n\n    (short names supported by --os-compute-api-version 2.90 or above,\n    FQDNs supported by --os-compute-api-version 2.94 or above)\n\nMaybe too terse though?","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c530f37a90bb207ba03dcfcf44212d6f3fd4392b","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"                \u0027Up to and incuding --os-compute-api-version 2.93, \u0027"},{"line_number":1354,"context_line":"                \u0027this can only be a short name. \u0027"},{"line_number":1355,"context_line":"                \u0027With --os-compute-api-version 2.94 and above, \u0027"},{"line_number":1356,"context_line":"                \u0027this can be a Fully Qualified Domain Name (FQDN).\u0027"},{"line_number":1357,"context_line":"            ),"},{"line_number":1358,"context_line":"        )"},{"line_number":1359,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"9192de06_76363f0a","line":1356,"in_reply_to":"a9fe0713_fd1b1c2d","updated":"2023-10-17 16:52:39.000000000","message":"Done","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"23903600b5ae66e76ecc7dc374253245ff7200fe","unresolved":true,"context_lines":[{"line_number":1353,"context_line":"                \u0027Up to and incuding --os-compute-api-version 2.93, \u0027"},{"line_number":1354,"context_line":"                \u0027this can only be a short name. \u0027"},{"line_number":1355,"context_line":"                \u0027With --os-compute-api-version 2.94 and above, \u0027"},{"line_number":1356,"context_line":"                \u0027this can be a Fully Qualified Domain Name (FQDN).\u0027"},{"line_number":1357,"context_line":"            ),"},{"line_number":1358,"context_line":"        )"},{"line_number":1359,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"a9fe0713_fd1b1c2d","line":1356,"in_reply_to":"e769ba2a_c876d28a","updated":"2023-05-18 10:16:03.000000000","message":"as an aside short names shoudl be \"hostnames\"\n\nshort name is not a inducstry standard thing that i would expect user to understand.\n\ni personally dislike the use of the \"short name\" terminolgy and woudl prefer not to have it in any docs or help text. i wont block on this but it its updated for stephens comment i woudl prefer if this was changed","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7f76a3a47a95236a79ad8f7268fd104598f5575","unresolved":true,"context_lines":[{"line_number":1403,"context_line":"                \u0027A utility such as cloud-init is required to propagate the \u0027"},{"line_number":1404,"context_line":"                \u0027hostname in the metadata service to the guest OS itself. \u0027"},{"line_number":1405,"context_line":"                \u0027Supported by --os-compute-api-version 2.90 or above. \u0027"},{"line_number":1406,"context_line":"                \u0027(hostnames aka \"short names\" supported by \u0027"},{"line_number":1407,"context_line":"                \u0027--os-compute-api-version 2.90 or above, FQDNs supported by \u0027"},{"line_number":1408,"context_line":"                \u0027--os-compute-api-version 2.94 or above)\u0027"},{"line_number":1409,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":4,"id":"06b95dd8_27c7cc35","line":1406,"range":{"start_line":1406,"start_character":32,"end_line":1406,"end_character":45},"updated":"2023-10-17 17:43:24.000000000","message":"you didnt remove teh use of shortnames everywhere by the way just where i commeted\n\ni would prefer if you removed it here","commit_id":"d2ed99ba0c02dc60a8559d65cd4643fe44820b0e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7f76a3a47a95236a79ad8f7268fd104598f5575","unresolved":true,"context_lines":[{"line_number":4322,"context_line":"                \u0027propagate changes to this value to the guest OS itself. \u0027"},{"line_number":4323,"context_line":"                \u0027Supported by --os-compute-api-version 2.90 or above. \u0027"},{"line_number":4324,"context_line":"                \u0027Up to and incuding --os-compute-api-version 2.93, \u0027"},{"line_number":4325,"context_line":"                \u0027this can only be a short name. \u0027"},{"line_number":4326,"context_line":"                \u0027With --os-compute-api-version 2.94 and above, \u0027"},{"line_number":4327,"context_line":"                \u0027this can be a Fully Qualified Domain Name (FQDN).\u0027"},{"line_number":4328,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":4,"id":"10ff43ce_5314718b","line":4325,"range":{"start_line":4325,"start_character":35,"end_line":4325,"end_character":46},"updated":"2023-10-17 17:43:24.000000000","message":"and here","commit_id":"d2ed99ba0c02dc60a8559d65cd4643fe44820b0e"}],"openstackclient/tests/functional/compute/v2/test_server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63d980c6e5d14bf42bec9fd665f8c5df194125f9","unresolved":true,"context_lines":[{"line_number":1066,"context_line":"        self.addCleanup(self.openstack, \u0027server delete --wait \u0027 + server_name)"},{"line_number":1067,"context_line":"        self.wait_for_status(server_name, \"ACTIVE\")"},{"line_number":1068,"context_line":"        self.assertEqual(\u0027test.example.com\u0027,"},{"line_number":1069,"context_line":"                         server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    def test_server_create_with_none_network(self):"},{"line_number":1072,"context_line":"        \"\"\"Test server create with none network option.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"a471fa37_519ed47c","line":1069,"updated":"2023-05-18 10:10:44.000000000","message":"This is failing because the microversion is too new. I\u0027d probably drop this as it\u0027s not really testing an OSC-specific thing (as you note in the commit message, there aren\u0027t really any changes needed in OSC)","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c530f37a90bb207ba03dcfcf44212d6f3fd4392b","unresolved":true,"context_lines":[{"line_number":1066,"context_line":"        self.addCleanup(self.openstack, \u0027server delete --wait \u0027 + server_name)"},{"line_number":1067,"context_line":"        self.wait_for_status(server_name, \"ACTIVE\")"},{"line_number":1068,"context_line":"        self.assertEqual(\u0027test.example.com\u0027,"},{"line_number":1069,"context_line":"                         server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    def test_server_create_with_none_network(self):"},{"line_number":1072,"context_line":"        \"\"\"Test server create with none network option.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"cd6c519b_1a60de6d","line":1069,"in_reply_to":"a471fa37_519ed47c","updated":"2023-10-17 16:52:39.000000000","message":"So with https://review.opendev.org/c/openstack/python-novaclient/+/872418 merged, the new microversion should work, no? I think there\u0027s still (admitedly very small) value in the test in that it makes sure osc can _pass_ an FQDN in the hostname field.","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7f76a3a47a95236a79ad8f7268fd104598f5575","unresolved":true,"context_lines":[{"line_number":1066,"context_line":"        self.addCleanup(self.openstack, \u0027server delete --wait \u0027 + server_name)"},{"line_number":1067,"context_line":"        self.wait_for_status(server_name, \"ACTIVE\")"},{"line_number":1068,"context_line":"        self.assertEqual(\u0027test.example.com\u0027,"},{"line_number":1069,"context_line":"                         server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    def test_server_create_with_none_network(self):"},{"line_number":1072,"context_line":"        \"\"\"Test server create with none network option.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"cf02c864_8fb08e34","line":1069,"in_reply_to":"cd6c519b_1a60de6d","updated":"2023-10-17 17:43:24.000000000","message":"since this was propsoed i think osc nolonger uses nova client for server show so its actully the sdk that need to supprot that microverion","commit_id":"a9c821289c140d514b59ec1cfed5e6154c086fe5"}]}