)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"514f2f65_87be7644","updated":"2023-02-14 15:45:35.000000000","message":"This isn\u0027t far off. Lots of comments around command structure but not too much \"structural\" with the inner workings, per se","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8325a516_8acab656","updated":"2023-02-16 09:03:09.000000000","message":"Thanks Stephen for the review.","commit_id":"c6efa05403a0c5820da007a4161a950d7814f7a8"}],"openstackclient/volume/v3/volume_group.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":true,"context_lines":[{"line_number":87,"context_line":"            metavar\u003d\u0027\u003cvolume_group_type\u003e\u0027,"},{"line_number":88,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":89,"context_line":"            help\u003d_(\u0027Name or ID of volume group type to use.\u0027),"},{"line_number":90,"context_line":"        )"},{"line_number":91,"context_line":"        parser.add_argument("},{"line_number":92,"context_line":"            \u0027volume_types\u0027,"},{"line_number":93,"context_line":"            metavar\u003d\u0027\u003cvolume_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca678089_4833738c","line":90,"updated":"2023-02-14 15:45:35.000000000","message":"This needs to be in the source_parser group, otherwise folks can do:\n\n  volume group create voume-group-type-foo --source-group source-group-bar\n\nIf you do this, you can mark the group as required and remove some logic below.\n\nAlso, can we migrating this from a positional arguments to option arguments? This is what we do for consistency groups [1]. We can/should maintain the positional argument for backwards compatibility but hide it using \u0027help\u003dargparse.SUPPRESS\u0027.\n\n[1] https://docs.openstack.org/python-openstackclient/zed/cli/command-objects/consistency-group.html#consistency-group-create","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            metavar\u003d\u0027\u003cvolume_group_type\u003e\u0027,"},{"line_number":88,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":89,"context_line":"            help\u003d_(\u0027Name or ID of volume group type to use.\u0027),"},{"line_number":90,"context_line":"        )"},{"line_number":91,"context_line":"        parser.add_argument("},{"line_number":92,"context_line":"            \u0027volume_types\u0027,"},{"line_number":93,"context_line":"            metavar\u003d\u0027\u003cvolume_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"37c8374f_2977e9f6","line":90,"in_reply_to":"c0276e7d_05ef67b8","updated":"2023-02-16 09:03:09.000000000","message":"Done","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8a75198b22ef318dba388aefcebab2548fb34d43","unresolved":true,"context_lines":[{"line_number":87,"context_line":"            metavar\u003d\u0027\u003cvolume_group_type\u003e\u0027,"},{"line_number":88,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":89,"context_line":"            help\u003d_(\u0027Name or ID of volume group type to use.\u0027),"},{"line_number":90,"context_line":"        )"},{"line_number":91,"context_line":"        parser.add_argument("},{"line_number":92,"context_line":"            \u0027volume_types\u0027,"},{"line_number":93,"context_line":"            metavar\u003d\u0027\u003cvolume_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0276e7d_05ef67b8","line":90,"in_reply_to":"ca678089_4833738c","updated":"2023-02-14 16:43:54.000000000","message":"The alternative option could be achieved with [1]\n\n[1] https://review.opendev.org/c/openstack/python-openstackclient/+/873730","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        parser.add_argument("},{"line_number":109,"context_line":"            \u0027--availability-zone\u0027,"},{"line_number":110,"context_line":"            metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":111,"context_line":"            help\u003d_(\u0027Availability zone for volume group.\u0027),"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        source_parser \u003d parser.add_mutually_exclusive_group()"},{"line_number":114,"context_line":"        source_parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"00ac59ff_ed33d585","line":111,"updated":"2023-02-14 15:45:35.000000000","message":"Is this applicable if creating from an existing group or snapshot? You should call it out if not.","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        parser.add_argument("},{"line_number":109,"context_line":"            \u0027--availability-zone\u0027,"},{"line_number":110,"context_line":"            metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":111,"context_line":"            help\u003d_(\u0027Availability zone for volume group.\u0027),"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        source_parser \u003d parser.add_mutually_exclusive_group()"},{"line_number":114,"context_line":"        source_parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"e8a3ad8e_d6a2d794","line":111,"in_reply_to":"00ac59ff_ed33d585","updated":"2023-02-16 09:03:09.000000000","message":"Good catch, modified the help text","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":true,"context_lines":[{"line_number":116,"context_line":"            metavar\u003d\u0027\u003csource-group\u003e\u0027,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Name or ID of a source group. \u0027"},{"line_number":118,"context_line":"                   \u0027(supported by --os-volume-api-version 3.14 or later)\u0027),"},{"line_number":119,"context_line":"        )"},{"line_number":120,"context_line":"        source_parser.add_argument("},{"line_number":121,"context_line":"            \u0027--group-snapshot\u0027,"},{"line_number":122,"context_line":"            metavar\u003d\u0027\u003cgroup-snapshot\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"01f51225_c297e2dc","line":119,"updated":"2023-02-14 15:45:35.000000000","message":"I know it\u0027s a bit redundant, but should we call this \u0027--volume-group-source\u0027 to align with \u0027consistency group create --consistency-group-source\u0027? Alternatively, should we remove the redundancy from the \u0027consistency group create\u0027 command options (retaining aliases ofc). We could do that in a follow-up?\n\nThe help text could also do with a little work.\n\n  _(\n      \u0027Existing volume group (name or ID) \u0027\n      \u0027(supported by --os-volume-api-version 3.14 or later)\u0027\n  )\n\nwould work (duplicating \u0027consistency group create\u0027 again)","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            metavar\u003d\u0027\u003csource-group\u003e\u0027,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Name or ID of a source group. \u0027"},{"line_number":118,"context_line":"                   \u0027(supported by --os-volume-api-version 3.14 or later)\u0027),"},{"line_number":119,"context_line":"        )"},{"line_number":120,"context_line":"        source_parser.add_argument("},{"line_number":121,"context_line":"            \u0027--group-snapshot\u0027,"},{"line_number":122,"context_line":"            metavar\u003d\u0027\u003cgroup-snapshot\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"218ba736_d584589d","line":119,"in_reply_to":"01f51225_c297e2dc","updated":"2023-02-16 09:03:09.000000000","message":"I see you\u0027ve already modified the consistency group code so will keep the args as it is here. updated the help text.","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            metavar\u003d\u0027\u003cgroup-snapshot\u003e\u0027,"},{"line_number":123,"context_line":"            help\u003d_(\u0027Name or ID of a group snapshot. \u0027"},{"line_number":124,"context_line":"                   \u0027(supported by --os-volume-api-version 3.14 or later)\u0027),"},{"line_number":125,"context_line":"        )"},{"line_number":126,"context_line":"        return parser"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"711f6a0b_7cc3d577","line":125,"updated":"2023-02-14 15:45:35.000000000","message":"Same comments as above","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            metavar\u003d\u0027\u003cgroup-snapshot\u003e\u0027,"},{"line_number":123,"context_line":"            help\u003d_(\u0027Name or ID of a group snapshot. \u0027"},{"line_number":124,"context_line":"                   \u0027(supported by --os-volume-api-version 3.14 or later)\u0027),"},{"line_number":125,"context_line":"        )"},{"line_number":126,"context_line":"        return parser"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d55769c0_96f8ae96","line":125,"in_reply_to":"711f6a0b_7cc3d577","updated":"2023-02-16 09:03:09.000000000","message":"Done","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":true,"context_lines":[{"line_number":142,"context_line":"            )"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"            volume_types \u003d []"},{"line_number":145,"context_line":"            for volume_type in parsed_args.volume_types:"},{"line_number":146,"context_line":"                volume_types.append("},{"line_number":147,"context_line":"                    utils.find_resource("},{"line_number":148,"context_line":"                        volume_client.volume_types,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c45f619_0aa7cca3","line":145,"updated":"2023-02-14 15:45:35.000000000","message":"You need a check in case this is empty and error out if so. That wasn\u0027t allowed previously.","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            )"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"            volume_types \u003d []"},{"line_number":145,"context_line":"            for volume_type in parsed_args.volume_types:"},{"line_number":146,"context_line":"                volume_types.append("},{"line_number":147,"context_line":"                    utils.find_resource("},{"line_number":148,"context_line":"                        volume_client.volume_types,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f2883e9b_7bcfaf90","line":145,"in_reply_to":"3c45f619_0aa7cca3","updated":"2023-02-16 09:03:09.000000000","message":"Done","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":true,"context_lines":[{"line_number":168,"context_line":"                    \"[--source-group|--group-snapshot]\u0027 command\""},{"line_number":169,"context_line":"                )"},{"line_number":170,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"            if (parsed_args.source_group is None and"},{"line_number":173,"context_line":"                    parsed_args.group_snapshot is None):"},{"line_number":174,"context_line":"                msg \u003d _("}],"source_content_type":"text/x-python","patch_set":1,"id":"4eac8881_dae6c049","line":171,"updated":"2023-02-14 15:45:35.000000000","message":"We need to warn if an AZ is set, like we do for CGs","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    \"[--source-group|--group-snapshot]\u0027 command\""},{"line_number":169,"context_line":"                )"},{"line_number":170,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"            if (parsed_args.source_group is None and"},{"line_number":173,"context_line":"                    parsed_args.group_snapshot is None):"},{"line_number":174,"context_line":"                msg \u003d _("}],"source_content_type":"text/x-python","patch_set":1,"id":"540d8bdd_981324a8","line":171,"in_reply_to":"4eac8881_dae6c049","updated":"2023-02-16 09:03:09.000000000","message":"Done","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                    \"provided to run the \u0027volume group create \""},{"line_number":178,"context_line":"                    \"[--source-group|--group-snapshot]\u0027 command\""},{"line_number":179,"context_line":"                )"},{"line_number":180,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":181,"context_line":"            source_group \u003d None"},{"line_number":182,"context_line":"            if parsed_args.source_group:"},{"line_number":183,"context_line":"                source_group \u003d utils.find_resource(volume_client.groups,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c4804a8_c622ff3e","line":180,"updated":"2023-02-14 15:45:35.000000000","message":"Won\u0027t need this if we make better use of the mutually exclusive group above.","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                    \"provided to run the \u0027volume group create \""},{"line_number":178,"context_line":"                    \"[--source-group|--group-snapshot]\u0027 command\""},{"line_number":179,"context_line":"                )"},{"line_number":180,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":181,"context_line":"            source_group \u003d None"},{"line_number":182,"context_line":"            if parsed_args.source_group:"},{"line_number":183,"context_line":"                source_group \u003d utils.find_resource(volume_client.groups,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e9a3686_1b47211d","line":180,"in_reply_to":"7c4804a8_c622ff3e","updated":"2023-02-16 09:03:09.000000000","message":"I\u0027m not sure how to do that exactly. If i don\u0027t supply both source group and group snapshot then it doesn\u0027t error out. can you help with that?","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c720ff7f54a93bc1caca4eb78ebf94162ffc0865","unresolved":true,"context_lines":[{"line_number":195,"context_line":"            column_headers \u003d ("},{"line_number":196,"context_line":"                \u0027ID\u0027,"},{"line_number":197,"context_line":"                \u0027Name\u0027,"},{"line_number":198,"context_line":"            )"},{"line_number":199,"context_line":"            data \u003d []"},{"line_number":200,"context_line":"            for attr in group:"},{"line_number":201,"context_line":"                data.append(group[attr])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bc08927d_8b7cb32f","line":198,"updated":"2023-02-14 15:45:35.000000000","message":"I assume we don\u0027t return any more information that this? Could we fetch it to provide a consistent output?","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9083122da3b503c9822ec8b04cc712cf295b8688","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            column_headers \u003d ("},{"line_number":196,"context_line":"                \u0027ID\u0027,"},{"line_number":197,"context_line":"                \u0027Name\u0027,"},{"line_number":198,"context_line":"            )"},{"line_number":199,"context_line":"            data \u003d []"},{"line_number":200,"context_line":"            for attr in group:"},{"line_number":201,"context_line":"                data.append(group[attr])"}],"source_content_type":"text/x-python","patch_set":1,"id":"cf9f7320_968d6dc8","line":198,"in_reply_to":"bc08927d_8b7cb32f","updated":"2023-02-16 09:03:09.000000000","message":"Even for a normal group create we only return ID and name. I see we do it already to fetch a group and return the info but not sure if it\u0027s the right thing since the client and API return values mismatch here.\nanyway we can address it later, i will do the requested change.\n\ncreate from group type: https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dcreate-a-consistency-group-from-source-detail,create-group-detail#id601\ncreate from source: https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dcreate-a-consistency-group-from-source-detail,create-group-detail,create-group-from-source-detail#id612","commit_id":"d8a36e3764ab1f51082774f95d31b751ea0ba2c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"88e6a0b8e1bb5e20c043108bb99dd6b62c63f474","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    def get_parser(self, prog_name):"},{"line_number":85,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":86,"context_line":"        source_parser \u003d parser.add_mutually_exclusive_group()"},{"line_number":87,"context_line":"        source_parser.add_argument("},{"line_number":88,"context_line":"            \u0027--volume-group-type\u0027,"},{"line_number":89,"context_line":"            metavar\u003d\u0027\u003cvolume_group_type\u003e\u0027,"},{"line_number":90,"context_line":"            help\u003d_(\u0027Name or ID of volume group type to use.\u0027),"},{"line_number":91,"context_line":"        )"},{"line_number":92,"context_line":"        source_parser.add_argument("},{"line_number":93,"context_line":"            \u0027volume_group_type\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"51a9ef5c_08ba1591","line":90,"range":{"start_line":87,"start_character":8,"end_line":90,"end_character":62},"updated":"2023-02-16 09:11:52.000000000","message":"The issue with specifying this is, the next positional argument will be taken as volume_group_type so we will need to either remove volume_group_type or make volume_types also optional.","commit_id":"c6efa05403a0c5820da007a4161a950d7814f7a8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"92e4adbb5cc28b3721d754495a475f459e51ce41","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    def get_parser(self, prog_name):"},{"line_number":85,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":86,"context_line":"        source_parser \u003d parser.add_mutually_exclusive_group()"},{"line_number":87,"context_line":"        source_parser.add_argument("},{"line_number":88,"context_line":"            \u0027--volume-group-type\u0027,"},{"line_number":89,"context_line":"            metavar\u003d\u0027\u003cvolume_group_type\u003e\u0027,"},{"line_number":90,"context_line":"            help\u003d_(\u0027Name or ID of volume group type to use.\u0027),"},{"line_number":91,"context_line":"        )"},{"line_number":92,"context_line":"        source_parser.add_argument("},{"line_number":93,"context_line":"            \u0027volume_group_type\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a7665ad_efcec48d","line":90,"range":{"start_line":87,"start_character":8,"end_line":90,"end_character":62},"in_reply_to":"51a9ef5c_08ba1591","updated":"2023-02-16 19:13:08.000000000","message":"Ah, sorry. You\u0027ll also need to create a new \u0027--volume-type\u0027 option to replace \u0027volume_types\u0027 and set help for the latter to \u0027argparse.SUPPRESS\u0027 also.\n\n  parser.add_argument(\n      \u0027--volume-type\u0027,\n      metavar\u003d\u0027\u003cvolume_type\u003e\u0027,\n      action\u003d\u0027append\u0027,\n      default\u003d[],\n      help\u003d_(\u0027Volume type(s) to use (name or ID)\u0027),\n  )\n\nSomething like https://review.opendev.org/c/openstack/python-openstackclient/+/874151 ought to do the trick","commit_id":"c6efa05403a0c5820da007a4161a950d7814f7a8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0c35915db6039a282d2712d648ac1c5b3448c57d","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    def get_parser(self, prog_name):"},{"line_number":85,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":86,"context_line":"        source_parser \u003d parser.add_mutually_exclusive_group()"},{"line_number":87,"context_line":"        source_parser.add_argument("},{"line_number":88,"context_line":"            \u0027--volume-group-type\u0027,"},{"line_number":89,"context_line":"            metavar\u003d\u0027\u003cvolume_group_type\u003e\u0027,"},{"line_number":90,"context_line":"            help\u003d_(\u0027Name or ID of volume group type to use.\u0027),"},{"line_number":91,"context_line":"        )"},{"line_number":92,"context_line":"        source_parser.add_argument("},{"line_number":93,"context_line":"            \u0027volume_group_type\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"73dd90be_7fb1e805","line":90,"range":{"start_line":87,"start_character":8,"end_line":90,"end_character":62},"in_reply_to":"6a7665ad_efcec48d","updated":"2023-02-17 12:22:45.000000000","message":"I\u0027ve removed the code that introduces new parameters since that seems better in a follow up patch (like the one you proposed). I\u0027m also facing issues juggling between the old and new parameters that is making the command more complicated and is also unrelated to the new options we are adding here. what do you think?","commit_id":"c6efa05403a0c5820da007a4161a950d7814f7a8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ff971e6551bc8da8ea387e8d92260db00033ed0","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    def get_parser(self, prog_name):"},{"line_number":85,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":86,"context_line":"        source_parser \u003d parser.add_mutually_exclusive_group()"},{"line_number":87,"context_line":"        source_parser.add_argument("},{"line_number":88,"context_line":"            \u0027--volume-group-type\u0027,"},{"line_number":89,"context_line":"            metavar\u003d\u0027\u003cvolume_group_type\u003e\u0027,"},{"line_number":90,"context_line":"            help\u003d_(\u0027Name or ID of volume group type to use.\u0027),"},{"line_number":91,"context_line":"        )"},{"line_number":92,"context_line":"        source_parser.add_argument("},{"line_number":93,"context_line":"            \u0027volume_group_type\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"915ba4c5_6ceeb4f4","line":90,"range":{"start_line":87,"start_character":8,"end_line":90,"end_character":62},"in_reply_to":"73dd90be_7fb1e805","updated":"2023-02-17 13:03:38.000000000","message":"Ack, let\u0027s tackle this separately.","commit_id":"c6efa05403a0c5820da007a4161a950d7814f7a8"}]}