)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ba108eb06a90f2667a19edd5cdb5636eaa2901ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f93b34b7_01f2dc57","updated":"2023-02-22 09:56:23.000000000","message":"Approving since Rajat has reviewed this and is happy with it.","commit_id":"0d57f3f367163dc4d3b57ae574a825563494f133"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"200b8b56d5515164282cf528bbed7423b9711878","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f6a5e2c_bdd51bc3","updated":"2023-02-20 12:59:22.000000000","message":"I tested 4 different cases\n\n1)\nvolume group type: positional\nvolume type: positional\nResult: creates the group but gives out expected warning\n\n$ openstack --os-volume-api-version 3.13 volume group create new_type lvmdriver-1\nPassing volume group type and volume types as positional arguments is deprecated. Use the --volume-group-type and --volume-type option arguments instead.\n+-------------------+------------------------------------------+\n| Field             | Value                                    |\n+-------------------+------------------------------------------+\n| ID                | 6874de49-4861-4ae0-bcee-b543aa03ca9d     |\n| Status            | creating                                 |\n| Name              | None                                     |\n| Description       | None                                     |\n| Group Type        | 178b1116-310c-453b-8c46-ada2e2995cc0     |\n| Volume Types      | [\u00273799a5b5-e03c-4f99-9976-f5eed4562ddf\u0027] |\n| Availability Zone | nova                                     |\n| Created At        | 2023-02-20T12:44:13.000000               |\n| Volumes           |                                          |\n| Group Snapshot ID |                                          |\n| Source Group ID   |                                          |\n+-------------------+------------------------------------------+\n\n2) \nvolume group type: optional\nvolume type: optional\nResult: creates the group as expected\n\n$ openstack --os-volume-api-version 3.13 volume group create --volume-group-type new_type --volume-type lvmdriver-1\n+-------------------+------------------------------------------+\n| Field             | Value                                    |\n+-------------------+------------------------------------------+\n| ID                | 8f0fe4fa-e094-44d0-83e1-ba2225309caf     |\n| Status            | creating                                 |\n| Name              | None                                     |\n| Description       | None                                     |\n| Group Type        | 178b1116-310c-453b-8c46-ada2e2995cc0     |\n| Volume Types      | [\u00273799a5b5-e03c-4f99-9976-f5eed4562ddf\u0027] |\n| Availability Zone | nova                                     |\n| Created At        | 2023-02-20T12:43:49.000000               |\n| Volumes           |                                          |\n| Group Snapshot ID |                                          |\n| Source Group ID   |                                          |\n+-------------------+------------------------------------------+\n\n3)\nvolume group type: positional\nvolume type: optional\nResult: creates the group but gives out warning about legacy positional parameters\n\n$ openstack --os-volume-api-version 3.13 volume group create new_type --volume-type lvmdriver-1\nPassing volume group type and volume types as positional arguments is deprecated. Use the --volume-group-type and --volume-type option arguments instead.\n+-------------------+------------------------------------------+\n| Field             | Value                                    |\n+-------------------+------------------------------------------+\n| ID                | 710276df-393f-445f-8258-88d7706e96b3     |\n| Status            | creating                                 |\n| Name              | None                                     |\n| Description       | None                                     |\n| Group Type        | 178b1116-310c-453b-8c46-ada2e2995cc0     |\n| Volume Types      | [\u00273799a5b5-e03c-4f99-9976-f5eed4562ddf\u0027] |\n| Availability Zone | nova                                     |\n| Created At        | 2023-02-20T12:45:21.000000               |\n| Volumes           |                                          |\n| Group Snapshot ID |                                          |\n| Source Group ID   |                                          |\n+-------------------+------------------------------------------+\n\n4)\nvolume group type: optional\nvolume type: positional\nResult: This is a strange case which users might not even try but it doesn\u0027t give out expected result. I\u0027m not sure what we can do about it.\n\n$ openstack --os-volume-api-version 3.13 volume group create --volume-group-type new_type lvmdriver-1\nusage: openstack volume group create [-h] [-f {json,shell,table,value,yaml}] [-c COLUMN] [--noindent] [--prefix PREFIX] [--max-width \u003cinteger\u003e] [--fit-width] [--print-empty]\n                                     [--volume-group-type \u003cvolume_group_type\u003e] [--volume-type \u003cvolume_type\u003e] [--source-group \u003csource-group\u003e] [--group-snapshot \u003cgroup-snapshot\u003e] [--name \u003cname\u003e]\n                                     [--description \u003cdescription\u003e] [--availability-zone \u003cavailability-zone\u003e]\nopenstack volume group create: error: argument \u003cvolume_group_type\u003e: not allowed with argument --volume-group-type\n\nEven flipping the positional argument, it treats the positional argument as volume group type\n\n$ openstack --os-volume-api-version 3.13 volume group create lvmdriver-1 --volume-group-type new_type\nusage: openstack volume group create [-h] [-f {json,shell,table,value,yaml}] [-c COLUMN] [--noindent] [--prefix PREFIX] [--max-width \u003cinteger\u003e] [--fit-width] [--print-empty]\n                                     [--volume-group-type \u003cvolume_group_type\u003e] [--volume-type \u003cvolume_type\u003e] [--source-group \u003csource-group\u003e] [--group-snapshot \u003cgroup-snapshot\u003e] [--name \u003cname\u003e]\n                                     [--description \u003cdescription\u003e] [--availability-zone \u003cavailability-zone\u003e]\nopenstack volume group create: error: argument --volume-group-type: not allowed with argument \u003cvolume_group_type\u003e\n","commit_id":"0d57f3f367163dc4d3b57ae574a825563494f133"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0a9cc478a92c8b58ba941d6ccea94f92db266d31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9589fbd7_d2c20a65","in_reply_to":"0f6a5e2c_bdd51bc3","updated":"2023-02-22 09:55:05.000000000","message":"\u003e I tested 4 different cases\n\u003e \n\u003e ...\n\u003e \n\u003e 4)\n\u003e volume group type: optional\n\u003e volume type: positional\n\u003e Result: This is a strange case which users might not even try but it doesn\u0027t give out expected result. I\u0027m not sure what we can do about it.\n\u003e \n\u003e $ openstack --os-volume-api-version 3.13 volume group create --volume-group-type new_type lvmdriver-1\n\u003e usage: openstack volume group create [-h] [-f {json,shell,table,value,yaml}] [-c COLUMN] [--noindent] [--prefix PREFIX] [--max-width \u003cinteger\u003e] [--fit-width] [--print-empty]\n\u003e                                      [--volume-group-type \u003cvolume_group_type\u003e] [--volume-type \u003cvolume_type\u003e] [--source-group \u003csource-group\u003e] [--group-snapshot \u003cgroup-snapshot\u003e] [--name \u003cname\u003e]\n\u003e                                      [--description \u003cdescription\u003e] [--availability-zone \u003cavailability-zone\u003e]\n\u003e openstack volume group create: error: argument \u003cvolume_group_type\u003e: not allowed with argument --volume-group-type\n\u003e \n\u003e Even flipping the positional argument, it treats the positional argument as volume group type\n\u003e \n\u003e $ openstack --os-volume-api-version 3.13 volume group create lvmdriver-1 --volume-group-type new_type\n\u003e usage: openstack volume group create [-h] [-f {json,shell,table,value,yaml}] [-c COLUMN] [--noindent] [--prefix PREFIX] [--max-width \u003cinteger\u003e] [--fit-width] [--print-empty]\n\u003e                                      [--volume-group-type \u003cvolume_group_type\u003e] [--volume-type \u003cvolume_type\u003e] [--source-group \u003csource-group\u003e] [--group-snapshot \u003cgroup-snapshot\u003e] [--name \u003cname\u003e]\n\u003e                                      [--description \u003cdescription\u003e] [--availability-zone \u003cavailability-zone\u003e]\n\u003e openstack volume group create: error: argument --volume-group-type: not allowed with argument \u003cvolume_group_type\u003e\n\nYeah, this is working as expected. Order matters for positional arguments so there\u0027s no way to provide volume type(s) as positional arguments without also providing volume group type, since the latter comes before the former.","commit_id":"0d57f3f367163dc4d3b57ae574a825563494f133"}]}