)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6156c44689123363b5a285e33e81b3747f2ac55","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{\u0027protected\u0027: True, \u0027name\u0027: \u0027mygcimg\u0027}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The Glance API is expecing \u0027protected\u0027, not \u0027is_protected\u0027."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This patch fixes this specific issue, but a lot of tests are failing."},{"line_number":43,"context_line":"Fixing them all would probably require renaming \"is_protected\" to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"05f561aa_d0154e5e","line":40,"updated":"2023-04-20 12:13:27.000000000","message":"Yeah, and we shouldn\u0027t be passing \u0027is_protected\u0027 to Glance. \u0027is_protected\u0027 is SDK\u0027s alias for this field [1], however, it should be translating this to the \"proper\" name when making requests. We\u0027re doing this for compute flavors [2]:\n\n    $ openstack flavor create --vcpu 8 --ram 32 --disk 80 --private --debug foo\n    ...\n    REQ: curl -g -i -X POST http://10.0.109.180/compute/v2.1/flavors ... -d \u0027{\"flavor\": {..., \"os-flavor-access:is_public\": false, ...}}\u0027\n    ...\n\nCompare this to the image request:\n\n    $ openstack image create --protected --debug test-image\n    ...\n    REQ: curl -g -i -X POST http://10.0.109.180/image/v2/images ... -d \u0027{..., \"is_protected\": true, ...}\u0027\n    ...\n\nI suspect this is something to do with the \"specialness\" of glance\u0027s properties, which are unpacked into the root request body rather than packed under a \u0027properties\u0027 or \u0027metadata\u0027 key. Need to investigate though...\n\n[1] https://github.com/openstack/openstacksdk/blob/1.0.1/openstack/image/v2/image.py#L89\n[2] https://github.com/openstack/openstacksdk/blob/1.0.1/openstack/compute/v2/flavor.py#L49-L50","commit_id":"428187cc202cffda4346a9fc3e3f8f9c0e7d8383"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ee63bfac14c7776a23a75354ea9b89113a59930","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{\u0027protected\u0027: True, \u0027name\u0027: \u0027mygcimg\u0027}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The Glance API is expecing \u0027protected\u0027, not \u0027is_protected\u0027."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This patch fixes this specific issue, but a lot of tests are failing."},{"line_number":43,"context_line":"Fixing them all would probably require renaming \"is_protected\" to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f7ef410b_e03a10b7","line":40,"in_reply_to":"05f561aa_d0154e5e","updated":"2023-04-20 18:02:51.000000000","message":"https://review.opendev.org/c/openstack/openstacksdk/+/881033/1","commit_id":"428187cc202cffda4346a9fc3e3f8f9c0e7d8383"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"47b308d853a28e01d496b79979058816a6606133","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93144e1b_5cc4d31a","updated":"2023-04-20 02:30:20.000000000","message":"Note to reviewers: of course this patch is not ready, but I\u0027d like to understand why we use \"is_protected\" rather than \"protected\". Is there a reason for this? This seems to be the root of the issue described in the commit message.","commit_id":"428187cc202cffda4346a9fc3e3f8f9c0e7d8383"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6156c44689123363b5a285e33e81b3747f2ac55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3418e869_451c53f0","updated":"2023-04-20 12:13:27.000000000","message":"This is an SDK issue, not an OSC issue","commit_id":"428187cc202cffda4346a9fc3e3f8f9c0e7d8383"}]}