)]}'
{"id":"openstack%2Fpython-openstackclient~880900","triplet_id":"openstack%2Fpython-openstackclient~master~I6618a0c933178d2109719b7f1468a1c04300142b","project":"openstack/python-openstackclient","branch":"master","topic":"protected","attention_set":{},"removed_from_attention_set":{"8122":{"account":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"last_update":"2023-04-21 18:31:08.000000000","reason":"Change was abandoned"},"33765":{"account":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"last_update":"2023-04-21 18:31:08.000000000","reason":"Change was abandoned"},"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-04-20 12:13:27.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}},"hashtags":[],"change_id":"I6618a0c933178d2109719b7f1468a1c04300142b","subject":"DNM: Fix failure when creating a protected image","status":"ABANDONED","created":"2023-04-20 02:29:09.000000000","updated":"2023-04-21 18:31:08.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6cced45ce33b9927e6d35bc4231250bd673e2104","_number":880900,"virtual_id_number":880900,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-04-20 03:27:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},{"value":-2,"date":"2023-04-20 12:13:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-20 02:30:20.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2023-04-20 02:30:20.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"state":"REVIEWER"},{"updated":"2023-04-20 03:27:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e7bc94538a39c2a0057c0a0fc3ac269192de1f78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2023-04-20 02:29:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"47b308d853a28e01d496b79979058816a6606133","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2023-04-20 02:30:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a2bc486cd22dd39f542ac67136ef177b5ec95309","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-20 03:27:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/6737791710244ddbb634cc28d458fc5d\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/2f8db3338f5c46fa996df45b0a43652c : SUCCESS in 4m 52s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/d0d4946ee37849c0805145775ab4490e : FAILURE in 4m 01s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/e334524802c644e0b3b2e289f8cfae90 : FAILURE in 4m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/36ba649d76754141861398ccbdf52147 : FAILURE in 3m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1c04c694f6414eea94523ca5d42f4b8b : FAILURE in 2m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5ed99d1a24c441dcb64b2a1effef196b : FAILURE in 3m 15s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/d6a6a5d56b604c358820e62057dd0cfc : FAILURE in 3m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/307aed210a8346e2be30cb3033091724 : SUCCESS in 6m 02s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/bc21ebb5de304b7ca292705b25c7244b : SUCCESS in 5m 42s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/20cee86eb77c49ab8528d6db4d9b841e : SUCCESS in 48m 01s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/5c9d08de9a054660b69779fa05f14cae : SUCCESS in 54m 40s\n\nWarning:\n  Comments left for invalid file openstackclient/network/v2/network_service_provider.py","accounts_in_message":[],"_revision_number":1},{"id":"b6156c44689123363b5a285e33e81b3747f2ac55","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-04-20 12:13:27.000000000","message":"Patch Set 1: Code-Review-2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"8ee63bfac14c7776a23a75354ea9b89113a59930","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-04-20 18:02:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6cced45ce33b9927e6d35bc4231250bd673e2104","tag":"autogenerated:gerrit:abandon","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2023-04-21 18:31:08.000000000","message":"Abandoned\n\nThanks for helping with this :)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"428187cc202cffda4346a9fc3e3f8f9c0e7d8383","revisions":{"428187cc202cffda4346a9fc3e3f8f9c0e7d8383":{"kind":"REWORK","_number":1,"created":"2023-04-20 02:29:09.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/00/880900/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/00/880900/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/880900/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/880900/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/880900/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/00/880900/1"}}},"commit":{"parents":[{"commit":"16c78fef15a5d8294d1ca555930085090616f87a","subject":"Adding ``image import`` command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/16c78fef15a5d8294d1ca555930085090616f87a"}]}],"author":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2023-04-19 18:02:14.000000000","tz":0},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2023-04-20 02:22:39.000000000","tz":0},"subject":"DNM: Fix failure when creating a protected image","message":"DNM: Fix failure when creating a protected image\n\nThe following command:\n\n$ openstack image create --protected imgname\n\nFails with the following error message, returned by glance-api:\n\nBadRequestException: 400: Client Error for url:\nhttp://192.168.121.187/image/v2/images, 400 Bad Request: Failed\nvalidating \u0026#x27;type\u0026#x27; in\nschema[\u0026#x27;additionalProperties\u0026#x27;]:: On\ninstance[\u0026#x27;is_protected\u0026#x27;]:: Provided object does not match\nschema \u0026#x27;image\u0026#x27;: True is not of type \u0026#x27;string\u0026#x27;:\n{\u0026#x27;type\u0026#x27;: \u0026#x27;string\u0026#x27;}: True\n\nThat is because the Schema.validate() method in glance/schema.py is\nworking on the following input:\n\n(Pdb) p obj\n{\u0027container_format\u0027: \u0027bare\u0027, \u0027name\u0027: \u0027imgname\u0027, \u0027disk_format\u0027: \u0027raw\u0027,\n\u0027is_protected\u0027: True, \u0027owner_specified.openstack.md5\u0027: \u0027\u0027,\n\u0027owner_specified.openstack.sha256\u0027: \u0027\u0027,\n\u0027owner_specified.openstack.object\u0027: \u0027images/imgname\u0027}\n\nWhereas, when using glanceclient with the following command:\n\n$ glance image-create --protected True --name mygcimg\n\nSchema.validate() is working on the following input:\n\n{\u0027protected\u0027: True, \u0027name\u0027: \u0027mygcimg\u0027}\n\nThe Glance API is expecing \u0027protected\u0027, not \u0027is_protected\u0027.\n\nThis patch fixes this specific issue, but a lot of tests are failing.\nFixing them all would probably require renaming \"is_protected\" to\n\"protected\" in the openstacksdk as well.\n\nChange-Id: I6618a0c933178d2109719b7f1468a1c04300142b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/428187cc202cffda4346a9fc3e3f8f9c0e7d8383"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/428187cc202cffda4346a9fc3e3f8f9c0e7d8383"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Code-Review\u003dMIN"],"failing_atoms":["label:Code-Review\u003dMAX"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}