)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"abb0acc11bf7cd87959c930424103d626107db30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5aac6d5d_996e8023","updated":"2023-05-10 16:07:27.000000000","message":"I imagine you\u0027ll probably end up abandoning this patch and creating a new one, but if you _wanted_ to resolve the merge conflicts here, you would do something like the following:\n\n1. Download the patch\n2. Apply black on the file\n3. Amend the commit to save the changes\n4. Rebase the patch onto master\n\nThat will probably look something like this:\n\n    git review -d 882091\n    black -S -l 79 openstackclient/image/v2/metadef_namespaces.py\n    git commit --amend -a\n    git rebase -i master\n\n\nJust an FYI","commit_id":"fa959a453ba930e83e37ddee7828217a0668660a"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"90e7f57db7f077f1d3a8883cf94263f31473d178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36bc0d65_735350cc","updated":"2023-05-03 08:56:42.000000000","message":"Well, difference of image to others in OSC is that for image the client is already an sdk image proxy (https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/client.py#L40) So the change in this form is not necessary. I guess this is even completed, since in SDK latest change to the NS is 8 month ago while OSC implementation is 5 month old. However metadef_resource_type and metadef_schema are missing completely","commit_id":"fa959a453ba930e83e37ddee7828217a0668660a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c2ddc2386e3a9c7c7376dc9e5fed3339a8bcea66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71aa80cf_ff756084","in_reply_to":"36bc0d65_735350cc","updated":"2023-05-03 10:15:16.000000000","message":"Yup, you shouldn\u0027t need to switch things from glanceclient to SDK because we don\u0027t use glanceclient here. This is different from the compute (nova), block storage (cinder) and identity (keystone) services. What you can do for the image service is to add the many missing commands. As Artem says, maybe look at metadef resource type and metadef schema since we already have these implemented in SDK.\n\nLet\u0027s take metadef resource type. The new OSC commands should be implemented in separate files. Something like \u0027openstackclient/image/v2/metadef_resource_type.py\u0027 for metadef resource type would work.\n\nWith regards to the commands to be implemented, looking at \u0027openstack/image/v2/metadef_resource_type.py\u0027 in the openstacksdk project you\u0027ll see that the MetadefResourceType resource allows resources to be created (allow_create \u003d True), deleted (allow_delete \u003d True) and listed (allow_list \u003d True). That would suggest you need three commands: \u0027metadef resource type create\u0027, \u0027metadef resource type delete\u0027, and \u0027metadef resource type list\u0027.\n\nBefore you start working on a command, you can make sure someone hasn\u0027t already done it by looking at open reviews [1]. That search finds all open reviews for the python-openstackclient project which modify the \u0027image\u0027 file or directory (directory, in this case).\n\n[1] https://review.opendev.org/q/project:openstack/python-openstackclient+is:open+file:image","commit_id":"fa959a453ba930e83e37ddee7828217a0668660a"}]}