)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e1c6dc93bc1ca42003fe9578952a45b3cdfedce4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"25036da2_fca09e5a","updated":"2023-05-17 15:39:57.000000000","message":"Can you make this depend-on the server change, please? This isn\u0027t valid until that merges.","commit_id":"cb55d0b82667e1d300dc688f31f2d44ba6e449ac"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"60661e1911f47ce56b3df9917eb5a70770d38a95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a0067c9_5df1e97c","in_reply_to":"25036da2_fca09e5a","updated":"2023-05-23 09:39:29.000000000","message":"Done. In the meanwhile the dependency got merged too.","commit_id":"cb55d0b82667e1d300dc688f31f2d44ba6e449ac"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"d92422a19e363930aa402f5e4a1b5ceb97ec41fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eaa3078c_37e9c8d6","updated":"2023-05-23 14:49:15.000000000","message":"Thanks for the quick review.","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"23e1522569e3f8395288745fb299069813ea4cf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd1f2c75_24f8d48b","updated":"2023-05-23 10:07:39.000000000","message":"Very soft -1","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0f1cddcf6e2771775f27ceab5d26cafa594f9c45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b379f41f_5f66288d","updated":"2023-05-23 15:54:40.000000000","message":"Nice work","commit_id":"d4df6295316fd1f07e2e01279ebf38135276cd33"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"274e0a9372b3d3630e00413eb4671d49c9b18292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0584cd73_eb11b196","updated":"2023-05-24 11:10:01.000000000","message":"Fixed the forgotten mocking of find_extension().","commit_id":"22d1a26d1dfd53a4337d541354544031ec6fdd17"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c6efae53afa101472d8d1d69b09f509989155ad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7b026178_5aae4279","updated":"2023-06-06 12:18:36.000000000","message":"\\o/ thanks, works as expected","commit_id":"22d1a26d1dfd53a4337d541354544031ec6fdd17"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"23e1522569e3f8395288745fb299069813ea4cf9","unresolved":true,"context_lines":[{"line_number":332,"context_line":"            \u0027Valid hint aliases/values: \u0027"},{"line_number":333,"context_line":"            \u0027ovs-tx-steering\u003dthread, ovs-tx-steering\u003dhash. \u0027"},{"line_number":334,"context_line":"            \u0027Valid JSON values are as specified by the Neutron API. \u0027"},{"line_number":335,"context_line":"            \u0027(repeat option to set multiple hints)\u0027"},{"line_number":336,"context_line":"        ),"},{"line_number":337,"context_line":"    )"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e09f6a9d_8f7f2af2","line":335,"updated":"2023-05-23 10:07:39.000000000","message":"Do we want to say what extension is required for this?\n\n    (requires Port Hints, Port hint: Open vSwitch Tx steering extensions)","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"d92422a19e363930aa402f5e4a1b5ceb97ec41fa","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            \u0027Valid hint aliases/values: \u0027"},{"line_number":333,"context_line":"            \u0027ovs-tx-steering\u003dthread, ovs-tx-steering\u003dhash. \u0027"},{"line_number":334,"context_line":"            \u0027Valid JSON values are as specified by the Neutron API. \u0027"},{"line_number":335,"context_line":"            \u0027(repeat option to set multiple hints)\u0027"},{"line_number":336,"context_line":"        ),"},{"line_number":337,"context_line":"    )"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"128c0a7c_84a77a0d","line":335,"in_reply_to":"e09f6a9d_8f7f2af2","updated":"2023-05-23 14:49:15.000000000","message":"Done","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"23e1522569e3f8395288745fb299069813ea4cf9","unresolved":true,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        if parsed_args.hint:"},{"line_number":572,"context_line":"            _validate_port_hints(parsed_args.hint)"},{"line_number":573,"context_line":"            attrs[\u0027hints\u0027] \u003d _expand_port_hint_aliases(parsed_args.hint)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        set_tags_in_post \u003d bool("},{"line_number":576,"context_line":"            client.find_extension(\u0027tag-ports-during-bulk-creation\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7c935835_ffa6fcff","line":573,"updated":"2023-05-23 10:07:39.000000000","message":"Do we need to add an extension check, like we do for tags below? We should probably hard-fail if it\u0027s missing","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"d92422a19e363930aa402f5e4a1b5ceb97ec41fa","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        if parsed_args.hint:"},{"line_number":572,"context_line":"            _validate_port_hints(parsed_args.hint)"},{"line_number":573,"context_line":"            attrs[\u0027hints\u0027] \u003d _expand_port_hint_aliases(parsed_args.hint)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        set_tags_in_post \u003d bool("},{"line_number":576,"context_line":"            client.find_extension(\u0027tag-ports-during-bulk-creation\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a39fa523_852ea607","line":573,"in_reply_to":"7c935835_ffa6fcff","updated":"2023-05-23 14:49:15.000000000","message":"Done","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"23e1522569e3f8395288745fb299069813ea4cf9","unresolved":true,"context_lines":[{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"        if parsed_args.hint:"},{"line_number":1021,"context_line":"            _validate_port_hints(parsed_args.hint)"},{"line_number":1022,"context_line":"            attrs[\u0027hints\u0027] \u003d _expand_port_hint_aliases(parsed_args.hint)"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        attrs.update("},{"line_number":1025,"context_line":"            self._parse_extra_properties(parsed_args.extra_properties)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec1a6154_b3417f8a","line":1022,"updated":"2023-05-23 10:07:39.000000000","message":"Ditto","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"d92422a19e363930aa402f5e4a1b5ceb97ec41fa","unresolved":false,"context_lines":[{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"        if parsed_args.hint:"},{"line_number":1021,"context_line":"            _validate_port_hints(parsed_args.hint)"},{"line_number":1022,"context_line":"            attrs[\u0027hints\u0027] \u003d _expand_port_hint_aliases(parsed_args.hint)"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        attrs.update("},{"line_number":1025,"context_line":"            self._parse_extra_properties(parsed_args.extra_properties)"}],"source_content_type":"text/x-python","patch_set":4,"id":"26b907cd_b914e8a7","line":1022,"in_reply_to":"ec1a6154_b3417f8a","updated":"2023-05-23 14:49:15.000000000","message":"Done","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"23e1522569e3f8395288745fb299069813ea4cf9","unresolved":true,"context_lines":[{"line_number":1133,"context_line":"            help\u003d_(\"Clear host binding for the port.\"),"},{"line_number":1134,"context_line":"        )"},{"line_number":1135,"context_line":"        parser.add_argument("},{"line_number":1136,"context_line":"            \u0027--hint\u0027,"},{"line_number":1137,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1138,"context_line":"            default\u003dFalse,"},{"line_number":1139,"context_line":"            help\u003d_(\"Clear hints for the port.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"c53d3cb9_7a7030e9","line":1136,"updated":"2023-05-23 10:07:39.000000000","message":"nit: This feels like it should be plural? The singular value makes sense above because you would repeat the parameter for multiple hints, but this will always clear all hints.","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"d92422a19e363930aa402f5e4a1b5ceb97ec41fa","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"            help\u003d_(\"Clear host binding for the port.\"),"},{"line_number":1134,"context_line":"        )"},{"line_number":1135,"context_line":"        parser.add_argument("},{"line_number":1136,"context_line":"            \u0027--hint\u0027,"},{"line_number":1137,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1138,"context_line":"            default\u003dFalse,"},{"line_number":1139,"context_line":"            help\u003d_(\"Clear hints for the port.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"b61d8aeb_c4adee3e","line":1136,"in_reply_to":"c53d3cb9_7a7030e9","updated":"2023-05-23 14:49:15.000000000","message":"I was vacillating between singular and plural too. Plural makes more sense here. On the other hand if we use the singular form then it\u0027s all the same across all verbs. I\u0027m okay with both.","commit_id":"70063500be76fbfe7d94afd0a6138a4372176ce8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c6efae53afa101472d8d1d69b09f509989155ad8","unresolved":true,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"# When we have multiple hints, we\u0027ll need to refactor this to expand aliases"},{"line_number":386,"context_line":"# without losing other hints. But until then let\u0027s have it as simple as"},{"line_number":387,"context_line":"# possible."},{"line_number":388,"context_line":"def _expand_port_hint_aliases(hints):"},{"line_number":389,"context_line":"    if hints \u003d\u003d {\u0027ovs-tx-steering\u0027: \u0027thread\u0027}:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1c70e0da_aadc7444","line":386,"updated":"2023-06-06 12:18:36.000000000","message":"thanks for the note, it can help future developers","commit_id":"22d1a26d1dfd53a4337d541354544031ec6fdd17"}]}