)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6c6fd95fe7c8ba28e33211552a4568858c26d91a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45e538dd_fd1b68dd","updated":"2024-05-02 14:33:08.000000000","message":"Continued here:\n    https://review.opendev.org/c/openstack/python-openstackclient/+/895214","commit_id":"1728af92bf95387addcd44e5be4516421c781ac2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6246ec5998a640e2a5927233a1f5fe3182bc729e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2350ea18_ec4cde16","updated":"2023-06-30 11:23:54.000000000","message":"Thanks Sofia for working on this.\n\nIdeally we add a new command to the setup.cfg file but we won\u0027t require that here since we are just adding a new parameter, --remote-source, to the existing volume create command.\n\nApart from inline comments, we also require unit tests releasenote.","commit_id":"1728af92bf95387addcd44e5be4516421c781ac2"}],"openstackclient/volume/v3/volume.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6246ec5998a640e2a5927233a1f5fe3182bc729e","unresolved":true,"context_lines":[{"line_number":118,"context_line":"        volume_client.revert_volume_to_snapshot(volume, snapshot)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class ManageVolume(command.ShowOne):"},{"line_number":122,"context_line":"    _description \u003d _(\"Manage an existing volume.\")"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e3ebe72_eb4b33bf","line":121,"updated":"2023-06-30 11:23:54.000000000","message":"I think what we want to do is replicate the behavior of snapshot manage command. We have a different syntax for that in OSC\n\nopenstack volume create --remote-source k\u003dv\n\nYou can refer to the snapshot command here\n\nhttps://github.com/openstack/python-openstackclient/blob/717837153be10e4c43009393760a422f2fb231e7/openstackclient/volume/v2/volume_snapshot.py#L103-L112","commit_id":"1728af92bf95387addcd44e5be4516421c781ac2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6246ec5998a640e2a5927233a1f5fe3182bc729e","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    def take_action(self, parsed_args):"},{"line_number":190,"context_line":"        volume_client \u003d self.app.client_manager.sdk_connection.volume"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if not sdk_utils.supports_microversion(volume_client, \u00273.44\u0027):"},{"line_number":193,"context_line":"            msg \u003d _("},{"line_number":194,"context_line":"                \"--os-volume-api-version 3.44 or greater is required to \""},{"line_number":195,"context_line":"                \"support the \u0027volume manage\u0027 command\""},{"line_number":196,"context_line":"            )"},{"line_number":197,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        volume \u003d volume_client.manage_volume("},{"line_number":200,"context_line":"            host\u003dparsed_args.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"79fcc2d0_4da0a1bf","line":197,"range":{"start_line":192,"start_character":0,"end_line":197,"end_character":46},"updated":"2023-06-30 11:23:54.000000000","message":"I don\u0027t think we require a microversion for the manage command","commit_id":"1728af92bf95387addcd44e5be4516421c781ac2"}]}
