)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f03b7685e32206cdee9097b3ed1964a40a015dce","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add the flavor-id option to router create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The --flavor-id option is added to the router create command. The"},{"line_number":10,"context_line":"router_id attribute has been supported by the Neutron API for router"},{"line_number":11,"context_line":"POST operations since a long time ago."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #2020823"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f5bf347_0ab55239","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2023-08-17 13:46:52.000000000","message":"flavor_id?","commit_id":"ba58a117ef3a31cbc1e6cec62d24af760e7a1d6d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"63e4302af7f608a3e99e45758d10b8b5ee42a71e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add the flavor-id option to router create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The --flavor-id option is added to the router create command. The"},{"line_number":10,"context_line":"router_id attribute has been supported by the Neutron API for router"},{"line_number":11,"context_line":"POST operations since a long time ago."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #2020823"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"639e6c2e_3362d63f","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"in_reply_to":"3f5bf347_0ab55239","updated":"2023-08-17 15:06:55.000000000","message":"Done","commit_id":"ba58a117ef3a31cbc1e6cec62d24af760e7a1d6d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f03b7685e32206cdee9097b3ed1964a40a015dce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d8670c4_5f38e005","updated":"2023-08-17 13:46:52.000000000","message":"What will be the behaviour for non-OVN routers when they get \"flavor-id\" on create?","commit_id":"ba58a117ef3a31cbc1e6cec62d24af760e7a1d6d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c16b5624a6c06c0eb1723ef5e477e12c5492c7bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d9128fa5_eb8134fd","in_reply_to":"2d8670c4_5f38e005","updated":"2023-08-17 15:06:34.000000000","message":"They get that flavor assigned to them. Here\u0027s an example from development environment, where I\u0027m testing the feature: https://paste.openstack.org/show/bp09AZwPaeOGi8dEAebO/","commit_id":"ba58a117ef3a31cbc1e6cec62d24af760e7a1d6d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f8e1bf6fe7320bc7b5f47e247606b8acd1af2684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bafeef28_2012e9d3","updated":"2023-08-18 06:06:50.000000000","message":"Thanks!","commit_id":"f8f174c458a8a33e1c7279cc3266ef0087378a86"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f06f6fca62a23b86df31dd275be33586824ce349","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0f03dff4_84186a65","updated":"2023-08-18 07:06:25.000000000","message":"thanks","commit_id":"f8f174c458a8a33e1c7279cc3266ef0087378a86"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8f674fd548630f870627dabcc29380e768ae4141","unresolved":true,"context_lines":[{"line_number":403,"context_line":"        )"},{"line_number":404,"context_line":"        parser.add_argument("},{"line_number":405,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":406,"context_line":"            metavar\u003d\u0027flavor-id\u0027,"},{"line_number":407,"context_line":"            help\u003d_(\"Associate the router to a flavor by ID\"),"},{"line_number":408,"context_line":"        )"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cfb9c29c_a4976fab","line":406,"range":{"start_line":406,"start_character":21,"end_line":406,"end_character":30},"updated":"2023-08-16 18:55:59.000000000","message":"Most of the other occurrences enclose this in \u003c\u003e, for example, \u003cflavor-id\u003e","commit_id":"54ac82929795585dc3ff935ebf8eff8aa48ea532"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e4199b46c6656daf9ef807fc5bbf1a4515c5a8f7","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        )"},{"line_number":404,"context_line":"        parser.add_argument("},{"line_number":405,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":406,"context_line":"            metavar\u003d\u0027flavor-id\u0027,"},{"line_number":407,"context_line":"            help\u003d_(\"Associate the router to a flavor by ID\"),"},{"line_number":408,"context_line":"        )"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bd8711a5_53cc5674","line":406,"range":{"start_line":406,"start_character":21,"end_line":406,"end_character":30},"in_reply_to":"cfb9c29c_a4976fab","updated":"2023-08-17 00:30:44.000000000","message":"Done","commit_id":"54ac82929795585dc3ff935ebf8eff8aa48ea532"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f03b7685e32206cdee9097b3ed1964a40a015dce","unresolved":true,"context_lines":[{"line_number":405,"context_line":"        parser.add_argument("},{"line_number":406,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":407,"context_line":"            metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"},{"line_number":408,"context_line":"            help\u003d_(\"Associate the router to a flavor by ID\"),"},{"line_number":409,"context_line":"        )"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":3,"id":"323f8a4f_1bad2a13","line":408,"updated":"2023-08-17 13:46:52.000000000","message":"should this mention that only OVN supports this?","commit_id":"ba58a117ef3a31cbc1e6cec62d24af760e7a1d6d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c16b5624a6c06c0eb1723ef5e477e12c5492c7bd","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        parser.add_argument("},{"line_number":406,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":407,"context_line":"            metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"},{"line_number":408,"context_line":"            help\u003d_(\"Associate the router to a flavor by ID\"),"},{"line_number":409,"context_line":"        )"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":3,"id":"e5afb3a3_7bc49d36","line":408,"in_reply_to":"323f8a4f_1bad2a13","updated":"2023-08-17 15:06:34.000000000","message":"No, flavors are supported in ML2 / OVS since many years ago. That was implemented by Kevin Benton. We are just catching up in the OVN case. Please see https://review.opendev.org/c/openstack/neutron/+/268941 and https://review.opendev.org/c/openstack/neutron-lib/+/494289","commit_id":"ba58a117ef3a31cbc1e6cec62d24af760e7a1d6d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2cbcde39d9f75f879ed0aa1c33070b43dc649d88","unresolved":true,"context_lines":[{"line_number":405,"context_line":"        parser.add_argument("},{"line_number":406,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":407,"context_line":"            metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"},{"line_number":408,"context_line":"            help\u003d_(\"Associate the router to a flavor by ID\"),"},{"line_number":409,"context_line":"        )"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":3,"id":"f0e98231_fabb5f5a","line":408,"in_reply_to":"323f8a4f_1bad2a13","updated":"2023-08-17 14:23:18.000000000","message":"Or is this better documented in the API ref or elsewhere?","commit_id":"ba58a117ef3a31cbc1e6cec62d24af760e7a1d6d"}],"openstackclient/tests/unit/network/v2/test_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8f674fd548630f870627dabcc29380e768ae4141","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        \u0027routes\u0027,"},{"line_number":146,"context_line":"        \u0027status\u0027,"},{"line_number":147,"context_line":"        \u0027tags\u0027,"},{"line_number":148,"context_line":"        \u0027flavor_id\u0027,"},{"line_number":149,"context_line":"    )"},{"line_number":150,"context_line":"    data \u003d ("},{"line_number":151,"context_line":"        router.AdminStateColumn(new_router.admin_state_up),"}],"source_content_type":"text/x-python","patch_set":1,"id":"abb531b9_171c728a","line":148,"updated":"2023-08-16 18:55:59.000000000","message":"Seems this needs to be alphabetical.","commit_id":"54ac82929795585dc3ff935ebf8eff8aa48ea532"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e4199b46c6656daf9ef807fc5bbf1a4515c5a8f7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        \u0027routes\u0027,"},{"line_number":146,"context_line":"        \u0027status\u0027,"},{"line_number":147,"context_line":"        \u0027tags\u0027,"},{"line_number":148,"context_line":"        \u0027flavor_id\u0027,"},{"line_number":149,"context_line":"    )"},{"line_number":150,"context_line":"    data \u003d ("},{"line_number":151,"context_line":"        router.AdminStateColumn(new_router.admin_state_up),"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bfadbe2_594c081e","line":148,"in_reply_to":"abb531b9_171c728a","updated":"2023-08-17 00:30:44.000000000","message":"Done","commit_id":"54ac82929795585dc3ff935ebf8eff8aa48ea532"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8f674fd548630f870627dabcc29380e768ae4141","unresolved":true,"context_lines":[{"line_number":385,"context_line":"        arglist \u003d ["},{"line_number":386,"context_line":"            self.new_router.name,"},{"line_number":387,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":388,"context_line":"            self.new_router.flavor_id"},{"line_number":389,"context_line":"        ]"},{"line_number":390,"context_line":"        verifylist \u003d ["},{"line_number":391,"context_line":"            (\u0027name\u0027, self.new_router.name),"}],"source_content_type":"text/x-python","patch_set":1,"id":"aacada36_d5806498","line":388,"updated":"2023-08-16 18:55:59.000000000","message":"The pep8 job didn\u0027t like the missing trailing \u0027,\u0027 here :(","commit_id":"54ac82929795585dc3ff935ebf8eff8aa48ea532"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e4199b46c6656daf9ef807fc5bbf1a4515c5a8f7","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        arglist \u003d ["},{"line_number":386,"context_line":"            self.new_router.name,"},{"line_number":387,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":388,"context_line":"            self.new_router.flavor_id"},{"line_number":389,"context_line":"        ]"},{"line_number":390,"context_line":"        verifylist \u003d ["},{"line_number":391,"context_line":"            (\u0027name\u0027, self.new_router.name),"}],"source_content_type":"text/x-python","patch_set":1,"id":"45be4fa9_40a541d4","line":388,"in_reply_to":"aacada36_d5806498","updated":"2023-08-17 00:30:44.000000000","message":"Done","commit_id":"54ac82929795585dc3ff935ebf8eff8aa48ea532"}]}