)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"05d333ba2d429f755816b7f22d240b96e56741a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d02a210_c9defd2e","updated":"2023-08-29 10:11:12.000000000","message":"Unit tests remaining","commit_id":"54390f75df02a3df54aae821cd51ae8f124055c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9799c240a57de37b751ecfc549803dc0c152cd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"49e55e88_79204262","updated":"2023-12-04 12:34:54.000000000","message":"two tests are failing in UTs, I have provided some inline reasons which you can try though i haven\u0027t run it manually myself.\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_bb9/893022/4/check/openstack-tox-py38/bb983bc/testr_results.html","commit_id":"e427cf436e67186201a9bdd005b33117cecc9db7"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bd7b8e1693f30b8fa10822e72efb04887cd2a7f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"db0dc90d_b61328df","updated":"2023-12-07 01:01:38.000000000","message":"Shouldn\u0027t we have release notes with this? And maybe one more entry in glance.csv (there is already one for image-create-via-import, but maybe we could have two?).","commit_id":"4c3c6e44f0e1fe32b75a49cce2ed7cc02d98a169"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"602025645b076e3068240483ebdf2d98b53bfa7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"71391897_e7ea40c6","updated":"2024-01-29 12:50:10.000000000","message":"Rather than adding a new command, let\u0027s fix `image create --import` so that it support other import-methods. We already expose this somewhat via the `image import` command. Now we need to expose it via the `image create` wrapper.","commit_id":"db49d86b4b4e450df0033a8b5b0961248566b2cb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2d8d61def9df6ad24a032e600eadf844800750bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d06b64f5_16b3830c","updated":"2023-12-22 05:30:17.000000000","message":"Still lot of duplication can be eliminated","commit_id":"db49d86b4b4e450df0033a8b5b0961248566b2cb"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"5684894291e269ab9d77a9be144db70bbf2b44e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b9380af7_845ceccd","in_reply_to":"71391897_e7ea40c6","updated":"2024-02-14 09:17:21.000000000","message":"We will then need to format the sdk","commit_id":"db49d86b4b4e450df0033a8b5b0961248566b2cb"}],"openstackclient/image/v2/image.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"12b2564f37c5c983353691fb5b9982224911ed2e","unresolved":true,"context_lines":[{"line_number":644,"context_line":""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"class CreateImageViaImport(command.ShowOne):"},{"line_number":647,"context_line":"    _description \u003d _(\"Create a new image via image import.\")"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def get_parser(self, prog_name):"},{"line_number":650,"context_line":"        parser \u003d super().get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b3154691_67832ba0","line":647,"range":{"start_line":647,"start_character":22,"end_line":647,"end_character":58},"updated":"2023-12-06 05:43:13.000000000","message":"nit: Create new image using import workflow.","commit_id":"4c3c6e44f0e1fe32b75a49cce2ed7cc02d98a169"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"29e21ba1edf0dc48fc41d5501ced6c612554672b","unresolved":false,"context_lines":[{"line_number":644,"context_line":""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"class CreateImageViaImport(command.ShowOne):"},{"line_number":647,"context_line":"    _description \u003d _(\"Create a new image via image import.\")"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def get_parser(self, prog_name):"},{"line_number":650,"context_line":"        parser \u003d super().get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab3a7b5_048cd5b8","line":647,"range":{"start_line":647,"start_character":22,"end_line":647,"end_character":58},"in_reply_to":"b3154691_67832ba0","updated":"2023-12-19 13:44:57.000000000","message":"Acknowledged","commit_id":"4c3c6e44f0e1fe32b75a49cce2ed7cc02d98a169"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"12b2564f37c5c983353691fb5b9982224911ed2e","unresolved":true,"context_lines":[{"line_number":963,"context_line":"            fp \u003d get_data_from_stdin()"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"        # validating stores:"},{"line_number":966,"context_line":"        if parsed_args.stores:"},{"line_number":967,"context_line":"            try:"},{"line_number":968,"context_line":"                enabled_backends \u003d list(image_client.stores())"},{"line_number":969,"context_line":"            except sdk_exceptions.ResourceNotFound:"}],"source_content_type":"text/x-python","patch_set":5,"id":"4027c547_9d58a3d0","line":966,"updated":"2023-12-06 05:43:13.000000000","message":"I can see lot of common code here and CreateImage, I think you can avoid duplication","commit_id":"4c3c6e44f0e1fe32b75a49cce2ed7cc02d98a169"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"29e21ba1edf0dc48fc41d5501ced6c612554672b","unresolved":false,"context_lines":[{"line_number":963,"context_line":"            fp \u003d get_data_from_stdin()"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"        # validating stores:"},{"line_number":966,"context_line":"        if parsed_args.stores:"},{"line_number":967,"context_line":"            try:"},{"line_number":968,"context_line":"                enabled_backends \u003d list(image_client.stores())"},{"line_number":969,"context_line":"            except sdk_exceptions.ResourceNotFound:"}],"source_content_type":"text/x-python","patch_set":5,"id":"8c035b62_5beb1feb","line":966,"in_reply_to":"4027c547_9d58a3d0","updated":"2023-12-19 13:44:57.000000000","message":"Acknowledged","commit_id":"4c3c6e44f0e1fe32b75a49cce2ed7cc02d98a169"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2d8d61def9df6ad24a032e600eadf844800750bc","unresolved":true,"context_lines":[{"line_number":349,"context_line":"            metavar\u003d\"\u003cid\u003e\","},{"line_number":350,"context_line":"            help\u003d_(\"Image ID to reserve\"),"},{"line_number":351,"context_line":"        )"},{"line_number":352,"context_line":"        parser.add_argument("},{"line_number":353,"context_line":"            \"--container-format\","},{"line_number":354,"context_line":"            default\u003dDEFAULT_CONTAINER_FORMAT,"},{"line_number":355,"context_line":"            choices\u003dCONTAINER_CHOICES,"},{"line_number":356,"context_line":"            metavar\u003d\"\u003ccontainer-format\u003e\","},{"line_number":357,"context_line":"            help\u003d("},{"line_number":358,"context_line":"                _("},{"line_number":359,"context_line":"                    \"Image container format. \""},{"line_number":360,"context_line":"                    \"The supported options are: %(option_list)s. \""},{"line_number":361,"context_line":"                    \"The default format is: %(default_opt)s\""},{"line_number":362,"context_line":"                )"},{"line_number":363,"context_line":"                % {"},{"line_number":364,"context_line":"                    \u0027option_list\u0027: \u0027, \u0027.join(CONTAINER_CHOICES),"},{"line_number":365,"context_line":"                    \u0027default_opt\u0027: DEFAULT_CONTAINER_FORMAT,"},{"line_number":366,"context_line":"                }"},{"line_number":367,"context_line":"            ),"},{"line_number":368,"context_line":"        )"},{"line_number":369,"context_line":"        parser.add_argument("},{"line_number":370,"context_line":"            \"--disk-format\","},{"line_number":371,"context_line":"            default\u003dDEFAULT_DISK_FORMAT,"}],"source_content_type":"text/x-python","patch_set":6,"id":"02e6a051_5bf15f54","line":368,"range":{"start_line":352,"start_character":8,"end_line":368,"end_character":9},"updated":"2023-12-22 05:30:17.000000000","message":"I still think code like this is duplicated in import command as well.","commit_id":"db49d86b4b4e450df0033a8b5b0961248566b2cb"}],"openstackclient/tests/unit/image/v2/test_image.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9799c240a57de37b751ecfc549803dc0c152cd2","unresolved":true,"context_lines":[{"line_number":720,"context_line":"        ]"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":723,"context_line":"        import pdb;pdb.set_trace()"},{"line_number":724,"context_line":"        self.assertRaises("},{"line_number":725,"context_line":"            exceptions.CommandError,"},{"line_number":726,"context_line":"            self.cmd.take_action,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8da78cc0_a924d96f","line":723,"range":{"start_line":723,"start_character":0,"end_line":723,"end_character":34},"updated":"2023-12-04 12:34:54.000000000","message":"this test is failing due to this import.\nyou might be trying to debug some other issue with pdb but the only failure visible in test run is because of pdb import.","commit_id":"e427cf436e67186201a9bdd005b33117cecc9db7"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"801369031c14b5fe6984ccd2249119f699e335ab","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        ]"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":723,"context_line":"        import pdb;pdb.set_trace()"},{"line_number":724,"context_line":"        self.assertRaises("},{"line_number":725,"context_line":"            exceptions.CommandError,"},{"line_number":726,"context_line":"            self.cmd.take_action,"}],"source_content_type":"text/x-python","patch_set":4,"id":"24a776b8_f8b393c8","line":723,"range":{"start_line":723,"start_character":0,"end_line":723,"end_character":34},"in_reply_to":"8da78cc0_a924d96f","updated":"2023-12-04 12:46:21.000000000","message":"Done","commit_id":"e427cf436e67186201a9bdd005b33117cecc9db7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9799c240a57de37b751ecfc549803dc0c152cd2","unresolved":true,"context_lines":[{"line_number":816,"context_line":"        ]"},{"line_number":817,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        self.assertRaises("},{"line_number":820,"context_line":"            exceptions.CommandError,"},{"line_number":821,"context_line":"            self.cmd.take_action,"},{"line_number":822,"context_line":"            parsed_args,"},{"line_number":823,"context_line":"        )"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def test_image_create_via_import_web_download_no_uri_with_store(self):"},{"line_number":826,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"14c1b56d_6af4ae3f","line":823,"range":{"start_line":819,"start_character":0,"end_line":823,"end_character":9},"updated":"2023-12-04 12:34:54.000000000","message":"we are expecting the failure to happen when we pass \u0027stores\u0027 arg but not the \u0027file\u0027[1] but we aren\u0027t mocking get_data_from_stdin to return None[2] which i think will be executed in this case.\n\n[1] https://review.opendev.org/c/openstack/python-openstackclient/+/893022/4/openstackclient/image/v2/image.py#1073\n[2] https://review.opendev.org/c/openstack/python-openstackclient/+/893022/4/openstackclient/image/v2/image.py#963","commit_id":"e427cf436e67186201a9bdd005b33117cecc9db7"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"801369031c14b5fe6984ccd2249119f699e335ab","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        ]"},{"line_number":817,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        self.assertRaises("},{"line_number":820,"context_line":"            exceptions.CommandError,"},{"line_number":821,"context_line":"            self.cmd.take_action,"},{"line_number":822,"context_line":"            parsed_args,"},{"line_number":823,"context_line":"        )"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def test_image_create_via_import_web_download_no_uri_with_store(self):"},{"line_number":826,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"fd549cdc_1087566d","line":823,"range":{"start_line":819,"start_character":0,"end_line":823,"end_character":9},"in_reply_to":"14c1b56d_6af4ae3f","updated":"2023-12-04 12:46:21.000000000","message":"Acknowledged","commit_id":"e427cf436e67186201a9bdd005b33117cecc9db7"}]}