)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"81d743ab07d518a2f793b039ef3e489cdebae431","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: Whitelist port fields"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Rather than blacklisting the fields we don\u0027t want, whitelist the ones we"},{"line_number":10,"context_line":"do."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is a problem for all tests that do the \"whitelisting\" in the tests,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a8d7f918_db35ad69","line":9,"updated":"2023-09-11 16:32:30.000000000","message":"Should use inclusive language like allow and ignore, etc.","commit_id":"6fa8b6289b1cdf4514cbc7412e8f20171507b938"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3c45ac4b293e854e7ad28bc188e420f11c933ffd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: Whitelist port fields"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Rather than blacklisting the fields we don\u0027t want, whitelist the ones we"},{"line_number":10,"context_line":"do."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is a problem for all tests that do the \"whitelisting\" in the tests,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"848fa694_ee6dbcdc","line":9,"in_reply_to":"a8d7f918_db35ad69","updated":"2023-09-12 08:30:55.000000000","message":"Ack","commit_id":"6fa8b6289b1cdf4514cbc7412e8f20171507b938"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"77b45310718a2251f1f76592d998591ef2eab0ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c517c2e7_85a88ceb","updated":"2023-09-14 09:54:19.000000000","message":"To avoid unnecessary comments, I\u0027ll point to the conversation had in the SDK patch that ended in this patch: https://review.opendev.org/c/openstack/openstacksdk/+/892771/comments/7daa0d26_f3a16987","commit_id":"fb2e0ced6e2413f5641e65bdc44ff1350a172a24"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"55cbcf6b77f56b72e5541c1330ce860117530072","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a4f7e0b_1e9c89c1","updated":"2023-09-19 11:01:12.000000000","message":"recheck FT error fixed","commit_id":"fb2e0ced6e2413f5641e65bdc44ff1350a172a24"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b2078d7a6a3a98a7903e4da291bc1d1d40644ef9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"708c2210_1517be93","updated":"2023-09-18 06:46:09.000000000","message":"recheck unrelated error","commit_id":"fb2e0ced6e2413f5641e65bdc44ff1350a172a24"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"81d743ab07d518a2f793b039ef3e489cdebae431","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        \u0027binding_profile\u0027: \u0027binding_profile\u0027,"},{"line_number":63,"context_line":"        \u0027binding_vif_details\u0027: \u0027binding_vif_details\u0027,"},{"line_number":64,"context_line":"        \u0027binding_vif_type\u0027: \u0027binding_vif_type\u0027,"},{"line_number":65,"context_line":"        \u0027binding_vnic_type\u0027: \u0027binding_vnic_type\u0027,"},{"line_number":66,"context_line":"        \u0027created_at\u0027: \u0027created_at\u0027,"},{"line_number":67,"context_line":"        \u0027data_plane_status\u0027: \u0027data_plane_status\u0027,"},{"line_number":68,"context_line":"        \u0027description\u0027: \u0027description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"044a0e97_ef51eab1","line":65,"updated":"2023-09-11 16:32:30.000000000","message":"So I guess we don\u0027t need to use \"binding:$thing\" here?","commit_id":"6fa8b6289b1cdf4514cbc7412e8f20171507b938"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3c45ac4b293e854e7ad28bc188e420f11c933ffd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        \u0027binding_profile\u0027: \u0027binding_profile\u0027,"},{"line_number":63,"context_line":"        \u0027binding_vif_details\u0027: \u0027binding_vif_details\u0027,"},{"line_number":64,"context_line":"        \u0027binding_vif_type\u0027: \u0027binding_vif_type\u0027,"},{"line_number":65,"context_line":"        \u0027binding_vnic_type\u0027: \u0027binding_vnic_type\u0027,"},{"line_number":66,"context_line":"        \u0027created_at\u0027: \u0027created_at\u0027,"},{"line_number":67,"context_line":"        \u0027data_plane_status\u0027: \u0027data_plane_status\u0027,"},{"line_number":68,"context_line":"        \u0027description\u0027: \u0027description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"90936b9a_3711f4b6","line":65,"in_reply_to":"044a0e97_ef51eab1","updated":"2023-09-12 08:30:55.000000000","message":"Yeah, that surprised me too. The short answer is no. The longer answer is the keys here refer to what we display in the output, while the values refer to the sdk names. The sdk uses the underscore variant (since a colon isn\u0027t valid in a Python identifier). If anything, we might want to use the original colon variant in output but we weren\u0027t doing that previously and I\u0027m not sure if that was intentional or not.","commit_id":"6fa8b6289b1cdf4514cbc7412e8f20171507b938"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"014acf2f7492a4c3fd4a2486025a43b5602291ce","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        \u0027binding_profile\u0027: \u0027binding_profile\u0027,"},{"line_number":63,"context_line":"        \u0027binding_vif_details\u0027: \u0027binding_vif_details\u0027,"},{"line_number":64,"context_line":"        \u0027binding_vif_type\u0027: \u0027binding_vif_type\u0027,"},{"line_number":65,"context_line":"        \u0027binding_vnic_type\u0027: \u0027binding_vnic_type\u0027,"},{"line_number":66,"context_line":"        \u0027created_at\u0027: \u0027created_at\u0027,"},{"line_number":67,"context_line":"        \u0027data_plane_status\u0027: \u0027data_plane_status\u0027,"},{"line_number":68,"context_line":"        \u0027description\u0027: \u0027description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d75162b8_8a658077","line":65,"in_reply_to":"90936b9a_3711f4b6","updated":"2023-09-12 17:00:56.000000000","message":"Ack, could have just done an \u0027openstack port show $port\u0027 I guess, just so used to the colon in the code I guess.","commit_id":"6fa8b6289b1cdf4514cbc7412e8f20171507b938"}]}
