)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"468be0611a837bc8d1fc727762568c27828c257e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2aedaa05_700fc449","updated":"2023-09-26 15:54:06.000000000","message":"Agree with both sides. What can be done is improving \"--hint\" help to explicitly mention `same_host` and `different_host` would become list while others are not. Understanding this without looking into the code is going to be quite hard","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"90a230522b760b96016469afdf49bdb3a4bd8eeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68679907_97a46487","updated":"2023-09-26 16:11:31.000000000","message":"FWIW, the openstack volume create --help says \"repeat option to set multiple hints).\n\nwithout this fix...it doesn\u0027t do that.\n\n\n  --hint \u003ckey\u003dvalue\u003e    Arbitrary scheduler hint key-value pairs to help boot an instance (repeat option to set multiple hints)","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8a7a3a1d9d0bde06699b59107f98db9e3c3be2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb3e76a2_48ab35f0","updated":"2023-09-26 15:06:16.000000000","message":"I think this is reasonable and I\u0027m not sure how else we could do this short of using special aliases for these two exception cases","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ae4fd4554cad121bac8b17441c33d44a509b29cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"475fc439_c60347a9","updated":"2023-09-26 14:01:54.000000000","message":"I\u0027m unsure about this, because I don\u0027t know whether this is understandable for a use. I think it would need some documentation at least.","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4025229144ac30c3a4cd3ad45ab9fe022f69acb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d5ef88a_438c8b8c","updated":"2023-09-26 12:57:04.000000000","message":"Thank you for fixing this.  LGTM","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"77f80c97e730e373ac6c0f3ce68b67f80b1a44b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53a9d842_7ce2958c","in_reply_to":"39c39e8e_1f14c195","updated":"2023-09-28 08:23:17.000000000","message":"Well the API ref doesn\u0027t say anything about hints that are not allowed to be a list, or did I miss something?","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"63cbda5c7206faa51bb5b3787ee262bcf639d088","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba8121ce_c9ae311e","in_reply_to":"3dd3ac43_33d6f760","updated":"2023-09-26 20:25:14.000000000","message":"this patch doesn\u0027t drop a command line option and it carefully makes sure that it only appends the values to the hint if and only if it\u0027s a scheduler hint for cinder\u0027s same_host and different_host.  This is absolutely correct.","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"09855478ad86f7c16c3bed26ae4ca09af6f7c95c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39c39e8e_1f14c195","in_reply_to":"475fc439_c60347a9","updated":"2023-09-26 14:22:06.000000000","message":"The documentation is in the cinder API.  This is a fix for a bug in the openstack client.  without this the osc is improperly formatting the post request to the cinder api and not including all of the hints in a single request.\n\nhttps://docs.openstack.org/api-ref/block-storage/v3/index.html#volumes-volumes\n\nThe example in the spec description shows multiple same_host volume UUIDS in a [], which is correct.   The OSC help for creating volume shows that you can specify multiple hints but it improperly doesn\u0027t all the volume uuids in the request.\n\nI don\u0027t think there needs to be any documentation change.  The code isn\u0027t working as documented.","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3abf22c5202085defa2eadbc5a4440f36a36f767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dd00ab2c_65c576ac","in_reply_to":"53a9d842_7ce2958c","updated":"2023-09-28 08:26:31.000000000","message":"nope, it doesn\u0027t. And therefore I recommended to improve at least help message here. Users of OSC right now do not really need to know all the API specialties to be able to use it. I think I will explicitly set -1 to underline that","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bc15e4e6376886fce62862f56fc3e2eb7a2ebb97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3dd3ac43_33d6f760","in_reply_to":"68679907_97a46487","updated":"2023-09-26 16:54:22.000000000","message":"Yes, I don\u0027t doubt that the current implementation needs fixing. But the alternative that I\u0027d like better in this situation instead of adding some complicated opaque action is to simply switch to KeyValueAppendAction and let the API tell the user about the error if they repeat the wrong type of hint. That seems more natural than to silently drop some command line options without any warning.","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"455785dd3ac19750392e43b6062ea9f1f20b3e15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6d52451_5d6d3ea0","in_reply_to":"ba8121ce_c9ae311e","updated":"2023-09-27 04:59:29.000000000","message":"from the commit message:\n\u003e An alternative already\n\u003e used in `CreateServer` would be `KeyValueAppendAction`, but only a subset of\n\u003e the scheduler hints accept lists, so we cannot use that in general.\n\nI\u0027d also like to just use the `KeyValueAppendAction`, but the API schema doesn\u0027t allow lists - only strings - for 2 of the 4 accepted hints.","commit_id":"99b43e41383d8e1b941a7dac3142fb05d30c9d55"}]}