)]}'
{"id":"openstack%2Fpython-openstackclient~901019","triplet_id":"openstack%2Fpython-openstackclient~master~I52246e183fb2cf0d855d92058dd305b48783589d","project":"openstack/python-openstackclient","branch":"master","topic":"argumenterror","hashtags":[],"change_id":"I52246e183fb2cf0d855d92058dd305b48783589d","subject":"compute: Address bug in shelve offload logic","status":"MERGED","created":"2023-11-15 11:33:49.000000000","updated":"2023-12-05 18:16:28.000000000","submitted":"2023-12-05 18:15:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"901019-argumenterror","meta_rev_id":"cdf8ddfa822c91c55837f32ce44031aa5af00153","_number":901019,"virtual_id_number":901019,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-12-05 18:15:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2023-12-05 17:20:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2023-12-05 17:20:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-15 12:45:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2a7dee374e223d686ea88a58b7650c3bf1ba135e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-11-15 11:33:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5dad6c65876728f71bec44e7e22efa2ef486824b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-15 12:45:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9a6107d914f74354af255feee2dc48b5\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/b1b56e2a696e4390bbb731fe643f2ace : SUCCESS in 4m 59s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/d97c8fa8a66d4f18be785062c42e6cc9 : SUCCESS in 5m 50s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/c1f9c1de7b814c8abab4724ec587289c : SUCCESS in 4m 49s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cdb6b470f2e24e31853c900c228d0c95 : SUCCESS in 4m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e1b77a50d5624a64b6f3e7316851093a : SUCCESS in 4m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2bbb3c4e0abe4324bab89bc31c95c960 : SUCCESS in 4m 30s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/d132e1bb44de4ad2834851415f8f7554 : SUCCESS in 3m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0507de0648a9476792a01940ed0a058a : SUCCESS in 6m 46s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/6480c880a8c54dd99ae28629d12541f2 : SUCCESS in 8m 59s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/2f23b0719dfc4fab81f839b81322135b : SUCCESS in 58m 43s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/752dcb5aaaf44623b433a5f5a40997cd : SUCCESS in 1h 06m 27s","accounts_in_message":[],"_revision_number":1},{"id":"8b123b0c5d23228cb548c81a9d1479546776da1c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-12-05 17:20:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3443b994cba2fd9b115576d7c9dfacdf3ef272ca","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-05 17:21:07.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"230d3cc4e7f2145a83d9493e5fcfb1176260f4d3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-05 18:15:08.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a24a0c807a3d4d359ea20a66725080b8\n\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/edbc23aeeee84b13b258343b8dbfcb3e : SUCCESS in 5m 23s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/e51c296fc345461291ed684fa7802854 : SUCCESS in 5m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba6b46ceedda4fada94f0ef1085785da : SUCCESS in 4m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e4ac8a347cc9490180cb1768b8c36720 : SUCCESS in 3m 25s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/38775688c13645d0b10b4afab0110530 : SUCCESS in 4m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d6d99c8b91e04dd193692dce342ec9cf : SUCCESS in 6m 05s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/502b510909074105a6c48b49ddcfa24f : SUCCESS in 6m 33s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/2a76a5a2d10b47268bc356c7b6b06152 : SUCCESS in 52m 51s","accounts_in_message":[],"_revision_number":1},{"id":"cfcc88ea7cfe4bf1f356a2f1645ff48436106a5d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-05 18:15:08.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"cdf8ddfa822c91c55837f32ce44031aa5af00153","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-05 18:16:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3e0506afcd944b03985476ffe6eff7f6\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/61472e2b25544fa4b84b85606068f112 : SUCCESS in 56s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/d7a4cd39aba04ceda807dfb95d29ff5b : SUCCESS in 35s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"885f5912eb531bc5594f98f834f2920a8e103c91","revisions":{"885f5912eb531bc5594f98f834f2920a8e103c91":{"kind":"REWORK","_number":1,"created":"2023-11-15 11:33:49.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/19/901019/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/19/901019/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/901019/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/901019/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/901019/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/19/901019/1"}}},"commit":{"parents":[{"commit":"1678f87d7ac72ad2064db1a3d34b66d506db76bd","subject":"tests: Handle missing extensions in network tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1678f87d7ac72ad2064db1a3d34b66d506db76bd"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-11-15 11:19:14.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-11-15 11:26:02.000000000","tz":0},"subject":"compute: Address bug in shelve offload logic","message":"compute: Address bug in shelve offload logic\n\nWe were reusing a variable from a previous loop, which meant this would\nnever work with multiple servers. Correct the mistake.\n\nChange-Id: I52246e183fb2cf0d855d92058dd305b48783589d\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/885f5912eb531bc5594f98f834f2920a8e103c91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/885f5912eb531bc5594f98f834f2920a8e103c91"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}